Re: [PATCH 4.19 009/118] scsi: ufs: Fix hynix ufs bug with quirk on hi36xx SoC

2018-12-17 Thread Kyuho Choi
Hi Greg, About Hinyx's "hB8aL1" ufs device. For support Kirin AP series, they are need to apply below VS_DebugSaveConfigTime expand patch. On 12/12/18, Greg Kroah-Hartman wrote: > 4.19-stable review patch. If anyone has any objections, please let me > know. > > -- > > [ Upstream

Re: [PATCH 4.19 009/118] scsi: ufs: Fix hynix ufs bug with quirk on hi36xx SoC

2018-12-17 Thread Greg Kroah-Hartman
On Mon, Dec 17, 2018 at 05:24:38PM +0900, Kyuho Choi wrote: > Hi Greg, > > About Hinyx's "hB8aL1" ufs device. For support Kirin AP series, they > are need to apply below VS_DebugSaveConfigTime expand patch. I am sorry, I do not understand at all. What needs to be done on the 4.19.y stable tree?

[PATCH 0/4] megaraid_sas: Fix HW errata in Aero controllers

2018-12-17 Thread Shivasharan S
Below patch series adds workaround for Aero controllers due to a HW errata that returns zero intermittently for read operations. Shivasharan S (4): megaraid_sas: Fix Ventura series based checks megaraid_sas: Introduce new Aero adapter type megaraid_sas: change function prototypes in megasas_

[PATCH 2/4] megaraid_sas: Introduce new Aero adapter type

2018-12-17 Thread Shivasharan S
Identify all Aero controller PCI IDs with new adapter type. Signed-off-by: Shivasharan S --- drivers/scsi/megaraid/megaraid_sas.h | 1 + drivers/scsi/megaraid/megaraid_sas_base.c | 18 -- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/megaraid/

[PATCH 4/4] megaraid_sas: add retry logic in megasas_readl

2018-12-17 Thread Shivasharan S
Problem statement: Due to hardware errata in Aero controllers, reads to certain fusion registers could intermittently return zero. This behavior is transient in nature and subsequent reads will return valid value. Fix: For Aero controllers, any calls to readl to read from certain registers, will b

[PATCH 1/4] megaraid_sas: Fix Ventura series based checks

2018-12-17 Thread Shivasharan S
In preparation for the new Aero series adapter type, all the places where we check adapter type for Ventura series needs to include any later adapter types. Signed-off-by: Shivasharan S --- drivers/scsi/megaraid/megaraid_sas_base.c | 10 +- drivers/scsi/megaraid/megaraid_sas_fp.c |

[PATCH 3/4] megaraid_sas: changes to function prototypes

2018-12-17 Thread Shivasharan S
Instead of the register address, pass the instance pointer to clear_intr and read_fw_status_reg functions. This is done in preparation for adding adapter type based checks in these functions in later patches of this series. Signed-off-by: Shivasharan S --- drivers/scsi/megaraid/megaraid_sas.h

Re: scsi: ufs: Problem at init on msm8998

2018-12-17 Thread Marc Gonzalez
Hello Kyuho, On 17/12/2018 08:14, Kyuho Choi wrote: > On Thursday, December 13, 2018, Marc Gonzalez wrote: > > Hello everyone, > > I'm having trouble getting UFS working on an APQ8098 MEDIABOX dev board. > (I'm running v4.20-rc4 with a few UFS patches taken off the MSM list.) > >

[PATCH -next] scsi: target/core: Use kmem_cache_free() instead of kfree()

2018-12-17 Thread Wei Yongjun
memory allocated by kmem_cache_alloc() should be freed using kmem_cache_free(), not kfree(). Fixes: ad669505c4e9 ("scsi: target/core: Make sure that target_wait_for_sess_cmds() waits long enough") Signed-off-by: Wei Yongjun --- drivers/target/target_core_transport.c | 2 +- 1 file changed, 1 in

[PATCH v5 0/2] hisi_sas: DIF support

2018-12-17 Thread John Garry
This patchset introduces support to the driver for DIF/DIX. We are making DIX support as RFC for now, based on issues discussed in the following: https://marc.info/?l=linux-scsi&m=154357719329297&w=4 and https://marc.info/?l=linux-scsi&m=154406987703456&w=2 We will only support PI in v3 hw at the

[RFC PATCH v5 2/2] scsi: hisi_sas: Add support for DIX feature for v3 hw as experimental

2018-12-17 Thread John Garry
From: Xiang Chen This patchset adds support for DIX to v3 hw driver. As discussed in the following thread, DIX seems to be in conflict with SCSI MQ, so this is why we mark the support for this driver as experimental: https://marc.info/?l=linux-scsi&m=154392687627603&w=2, As for DIX support itse

[PATCH v5 1/2] scsi: hisi_sas: Add support for DIF feature for v2 hw

2018-12-17 Thread John Garry
From: Xiang Chen For v3 hw, we support DIF operation for SAS, but not SATA. In addition, DIF CRC16 is supported. This patchset adds the SW support for the described features. The main components are as follows: - Get protection mask from module param - Fill PI fields - Fill related to DIF in DQ

Re: [PATCH v4 4/5] scsi: hisi_sas: Add support for DIF feature for v3 hw

2018-12-17 Thread John Garry
On 13/12/2018 13:35, John Garry wrote: to set your controller flags. +if (prot_op == SCSI_PROT_WRITE_INSERT) { +unsigned int interval = scsi_prot_interval(scsi_cmnd); +unsigned int ilog2_interval = ilog2(interval); + +len = (task->total_xfer_len >>

Re: [PATCH -next] scsi: target/core: Use kmem_cache_free() instead of kfree()

2018-12-17 Thread Bart Van Assche
On Mon, 2018-12-17 at 12:19 +, Wei Yongjun wrote: > memory allocated by kmem_cache_alloc() should be freed using > kmem_cache_free(), not kfree(). > > Fixes: ad669505c4e9 ("scsi: target/core: Make sure that > target_wait_for_sess_cmds() waits long enough") > Signed-off-by: Wei Yongjun > ---

RE: [PATCH 0/6] Add support of the HBA mode on HP Smart Array P410i controllers

2018-12-17 Thread Don.Brace
-Original Message- From: Ivan Mironov [mailto:mironov.i...@gmail.com] Sent: Friday, December 14, 2018 2:30 PM To: Don Brace - C33706 ; linux-scsi@vger.kernel.org Cc: linux-ker...@vger.kernel.org; don.br...@microsemi.com; j...@linux.vnet.ibm.com; martin.peter...@oracle.com; esc.storage...

Re: [PATCH v2] scsi/ata: Use unsigned int for cmd's type in ioctls in scsi_host_template

2018-12-17 Thread Nathan Chancellor
On Fri, Oct 19, 2018 at 10:01:44PM -0700, Nathan Chancellor wrote: > Clang warns several times in the scsi subsystem (trimmed for brevity): > > drivers/scsi/hpsa.c:6209:7: warning: overflow converting case value to > switch condition type (2147762695 to 18446744071562347015) [-Wswitch] > c

Re: SAS 2008 fault codes on 4.18 / array drops offline under load

2018-12-17 Thread tpearson
> Greetings, > > We're experiencing a serious issue with our SAS 2008-based LSI controllers > on our IBM POWER (ppc64le) machines. Under heavy 24/7 disk I/O, the > controller generates: > > mpt2sas_cm0: log_info(0x3112043d): originator(PL), code(0x12), > sub_code(0x043d) > mpt2sas_cm0: log_info(0x

Re: [PATCH 0/7] v4.19-stable randconfig fixes

2018-12-17 Thread Sasha Levin
On Fri, Dec 14, 2018 at 11:10:05PM +0100, Arnd Bergmann wrote: Hi Greg, I did some randconfig testing on linux-4.19 arm/arm64/x86. So far I needed 27 patches, most of which are also still needed in mainline Linux. I had submitted some before, and others were not submitted previously for some rea

Re: [PATCH v4 4/5] scsi: hisi_sas: Add support for DIF feature for v3 hw

2018-12-17 Thread Martin K. Petersen
John, > We have an issue with using scsi_transfer_length(). > > As I understand, for our controller we need to set the host structure > data transfer size to the size of data to write to the disk for WRITE > type command, and at size of info received to host memory for READ > type command. As su

Re: remove the "clustering" flag V2

2018-12-17 Thread Christoph Hellwig
Martin and others: can we get this reviewed and merge before the end of the merge window? That gets the clustering put of the way for the multipage-biovec work from Ming which we want to land in the block tree early in the next merge window.

[PATCH V2] blk-mq: Set request mapping to NULL in blk_mq_put_driver_tag

2018-12-17 Thread Kashyap Desai
V1 -> V2 Added fix in __blk_mq_finish_request around blk_mq_put_tag() for non-internal tags Problem statement : Whenever try to get outstanding request via scsi_host_find_tag, block layer will return stale entries instead of actual outstanding request. Kernel panic if stale entry is inaccessible o

Re: remove the "clustering" flag V2

2018-12-17 Thread Hannes Reinecke
On 12/18/18 8:08 AM, Christoph Hellwig wrote: Martin and others: can we get this reviewed and merge before the end of the merge window? That gets the clustering put of the way for the multipage-biovec work from Ming which we want to land in the block tree early in the next merge window. Have w

Re: [PATCH] hpsa: add module parameter to disable irq affinity

2018-12-17 Thread Hannes Reinecke
On 12/3/18 11:35 PM, Don Brace wrote: The PCI_IRQ_AFFINITY flag prevents customers from changing the smp_affinity and smp_affinity_list entries. - add a module parameter to allow this flag to be turned off. - to turn off PCI_IRQ_AFFINITY: flag hpsa_disable_irq_affinity=1 Reviewed-by: Dav