On 11/12/2018 12:58 AM, Martin Wilck wrote:
Since f44ac12f1dcc, BG enablement is tracked with the
LPFC_SLI3_BG_ENABLED bit, which is set in lpfc_get_cfgparam
before lpfc_sli_config_sli_port() is called. The bit
shouldn't be cleared before checking the feature.
Based on problem analysis by Davi
On Mon, Nov 26, 2018 at 08:46:39PM +1100, Finn Thain wrote:
> On Mon, 26 Nov 2018, Christoph Hellwig wrote:
>
> > On Thu, Nov 22, 2018 at 09:02:13AM +1100, Finn Thain wrote:
> > > > you in the To list maintain or wrote SCSI drivers that set the
> > > > DISABLE_CLUSTERING flag, which basically disa
Nesting in __qla2x00_abort_all_cmds() is way too deep. Reduce the nesting
level by introducing a helper function. This patch does not change any
functionality.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_os.c | 89 +--
1 file
This patch improves code readability but does not change any
functionality.
Cc: Himanshu Madhani
Signed-off-by: Bart Van Assche
---
drivers/scsi/qla2xxx/qla_target.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c
b/drivers/s
Hi Martin,
The two patches in this series make the qla2xxx driver source code easier
to read without changing the driver functionality. Please consider these
patches for kernel v4.21.
Thanks,
Bart.
Bart Van Assche (2):
qla2xxx: Introduce a switch/case statement in qlt_xmit_tm_rsp()
qla2xxx:
On Tue, 2018-11-27 at 15:04 -0800, Bart Van Assche wrote:
> Hi Martin,
>
> The two patches in this series make the qla2xxx driver source code
> easier
> to read without changing the driver functionality. Please consider
> these
> patches for kernel v4.21.
>
> Thanks,
>
> Bart.
>
> Bart Van Assc
PTR_ERR_OR_ZERO has implemented the same function, so use inlined function
instead of open coded equivalent.
Signed-off-by: Wen Yang
CC: "James E.J. Bottomley"
CC: "Martin K. Petersen"
CC: qla2xxx-upstr...@qlogic.com
CC: linux-scsi@vger.kernel.org
CC: Wen Yang
CC: linux-ker...@vger.kernel.org
Hi all,
There is a issue which may be related to CONFIG_SCSI_MQ_DEFAULT: before
we developed DIF/DIX feature on kernel 4.18 (disable
CONFIG_SCSI_MQ_DEFAULT default), and
it works well. But when we switch to kernel 4.19-rc1 and 4.20-rc1, Call
trace as follow occurs when running fio and if disab
On Tue, Nov 27, 2018 at 05:55:45PM +0800, chenxiang (M) wrote:
> Hi all,
>
> There is a issue which may be related to CONFIG_SCSI_MQ_DEFAULT: before we
> developed DIF/DIX feature on kernel 4.18 (disable CONFIG_SCSI_MQ_DEFAULT
> default), and
> it works well.
I guess you are testing hisi_sas_v3_h
Currently sas_task.c has no license specifier, so add SPDX license
identifier for GPL-2.0+.
As mentioned in commit b24413180f56 ("License cleanup: add SPDX GPL-2.0
license identifier to files with no license"), files with no license in
the kernel are under default kernel license.
While I'm at it,
On Tue, Nov 27, 2018 at 10:15:32PM +0800, John Garry wrote:
> Currently sas_task.c has no license specifier, so add SPDX license
> identifier for GPL-2.0+.
>
> As mentioned in commit b24413180f56 ("License cleanup: add SPDX GPL-2.0
> license identifier to files with no license"), files with no lic
On 27/11/2018 14:43, Greg KH wrote:
Hi Greg,
On Tue, Nov 27, 2018 at 10:15:32PM +0800, John Garry wrote:
Currently sas_task.c has no license specifier, so add SPDX license
identifier for GPL-2.0+.
As mentioned in commit b24413180f56 ("License cleanup: add SPDX GPL-2.0
license identifier to fi
Currently pvscsi_remove calls free_irq more than once as
pvscsi_release_resources and __pvscsi_shutdown both call
pvscsi_shutdown_intr. This results in a 'Trying to free
already-free IRQ' warning and stack trace. To solve the problem
pvscsi_shutdown_intr has been moved out of pvscsi_release_resourc
On Tue, Nov 27, 2018 at 02:28:53PM -0500, Cathy Avery wrote:
> Currently pvscsi_remove calls free_irq more than once as
> pvscsi_release_resources and __pvscsi_shutdown both call
> pvscsi_shutdown_intr. This results in a 'Trying to free
> already-free IRQ' warning and stack trace. To solve the prob
On Tue, 2018-11-27 at 17:55 +0800, chenxiang (M) wrote:
> [ 629.210506] Unable to handle kernel paging request at virtual address
> 8027e048
> [ 629.210506] Unable to handle kernel paging request at virtual address
> 8027e048
> ...
> [ 629.380218] pc : deadline_remove_request+0
Doug,
Response is inline below.
On 11/26/2018 08:41 PM, Douglas Gilbert wrote:
Lee,
See about 3/4 of the way down your patch.
Summary: how about generalizing the message logging to tracefs so the
whole SCSI subsystem can use it?
Doug Gilbert
On 2018-11-26 8:01 p.m., Lee Duncan wrote:
On 11
On Mon, Nov 26, 2018 at 10:33:32AM -0700, Jens Axboe wrote:
> On 11/26/18 9:54 AM, Keith Busch wrote:
> > The iterative update to the previous version taking into account review
> > comments.
> >
> > Background:
> >
> > The main objective is to remove the generic block layer's lock prefix
> > cur
Hi,
在 2018/11/28 4:22, Ewan D. Milne 写道:
On Tue, 2018-11-27 at 17:55 +0800, chenxiang (M) wrote:
[ 629.210506] Unable to handle kernel paging request at virtual address
8027e048
[ 629.210506] Unable to handle kernel paging request at virtual address
8027e048
...
[ 629.380218]
Hi Lei Ming,
在 2018/11/27 21:08, Ming Lei 写道:
On Tue, Nov 27, 2018 at 05:55:45PM +0800, chenxiang (M) wrote:
Hi all,
There is a issue which may be related to CONFIG_SCSI_MQ_DEFAULT: before we
developed DIF/DIX feature on kernel 4.18 (disable CONFIG_SCSI_MQ_DEFAULT
default), and
it works well.
On 11/26/18 8:25 PM, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20181126:
>
on i386:
ERROR: "__udivdi3" [drivers/scsi/aha1542.ko] undefined!
somewhere in aha1542_interrupt() according to objdump.
--
~Randy
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/be2iscsi/be_iscsi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/be2iscsi/be_iscsi.c b/drivers/scsi/be2iscsi/be_isc
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that, in this particular case, I replaced "!!! fall through !!!"
comment with "fall through" annotations, which is what GCC is expecting
to find.
Addresses-Coverity-ID: 146155 ("Mis
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that I replaced "!! fall through !!" and "!!! fall through !!!"
comments with "fall through" annotations, which is what GCC is
expecting to find.
Addresses-Coverity-ID: 744899 ("Mis
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 703127 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/isci/phy.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/i
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that, in this particular case, a dash is added as a token in
order to separate the "Fall through" annotations from the rest of
the comment on the same line, which is what GCC is expe
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/libfc/fc_rport.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c
inde
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that, in this particular case, I replaced "Drop thru" and
"Fall Thru" with "fall through" annotations, which is what GCC
is expecting to find.
Also, in some cases a dash is added as
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that, in this particular case, I replaced "Drop thru" with a
"fall through" annotation, which is what GCC is expecting to find.
Addresses-Coverity-ID: 114976 ("Missing break in swit
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1475400 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1465234 ("Missing break in switch")
Addresses-Coverity-ID: 1465238 ("Missing break in switch")
Addresses-Coverity-ID: 1465242 ("Missing break in switch")
Signed-off-b
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/megaraid/megaraid_sas_base.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
b/drivers/s
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that, in this particular case, I replaced "Fall thru" with a
"Fall through" annotation and added a dash as a token in order to
separate the "Fall through" annotation from the rest of
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/osd/osd_initiator.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/sc
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 114983 ("Missing break in switch")
Addresses-Coverity-ID: 114984 ("Missing break in switch")
Addresses-Coverity-ID: 114985 ("Missing break in switch")
Signed-off-by:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/sym53c8xx_2/sym_nvram.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/sym53c8xx_2/sym_nvram.c
b/drivers/scsi/sym53c
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that, in this particular case, I replaced "allow fall-through"
with a "fall through" annotation, which is what GCC is expecting to
find.
Signed-off-by: Gustavo A. R. Silva
---
dri
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 114994 ("Missing break in switch")
Addresses-Coverity-ID: 114995 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/st.c | 4
1 fi
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1087954 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/ufs/ufshcd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that, in this particular case, I replaced
"Missed the backend's Closing state -- fallthrough" with
"fall through - Missed the backend's Closing state", which
contains the "fall throu
Hi all,
On Tue, 27 Nov 2018 20:14:58 -0800 Randy Dunlap wrote:
>
> On 11/26/18 8:25 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20181126:
> >
>
> on i386:
>
> ERROR: "__udivdi3" [drivers/scsi/aha1542.ko] undefined!
>
> somewhere in aha1542_interrupt() according to objdump
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1056537 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/BusLogic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Also, a break statement is properly aligned.
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/aacraid/aachba.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that in this particular case, I replaced "Fall through to reject message"
with a "fall through" annotation at the bottom of the case, which is what GCC
is expecting to find.
Signed-
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that, in some cases, I replaced "FALLTHROUGH" with a "fall through"
annotation and then placed it at the bottom of the corresponding switch
case, which is what GCC is expecting to fi
In preparation to enabling -Wimplicit-fallthrough, this patchset aims
to mark switch cases where we are expecting to fall through.
I reviewed case by case and concluded that each of them is an
intentional fall-through. However, it doesn't hurt that the
maintainers and supporters of each driver tak
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that I replaced "Fall through !!!" with a "fall through"
annotation, which is what GCC is expecting to find.
Addresses-Coverity-ID: 114971 ("Missing break in switch")
Signed-off-by:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1357387 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/be2iscsi/be_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drive
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that, in this particular case, I replaced "!!! fall through !!!"
with a "fall through" annotation, which is what GCC is expecting to
find.
Signed-off-by: Gustavo A. R. Silva
---
d
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1195463 ("Missing break in switch")
Addresses-Coverity-ID: 1195464 ("Missing break in switch")
Addresses-Coverity-ID: 1195465 ("Missing break in switch")
Addresses-Co
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that, in some cases, I replaced "FALLTHROUGH" with a "fall through"
annotation and then placed it at the bottom of the corresponding switch
case, which is what GCC is expecting to fi
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/esas2r/esas2r_init.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/esas2r/esas2r_init.c
b/drivers
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that, in this particular case, a dash is added as a token in
order to separate the "fall through" annotations from the rest of
the comment on the same line, which is what GCC is expe
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/aacraid/linit.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index 2
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1056538 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/csiostor/csio_wr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drive
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 114978 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/lpfc/lpfc_els.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/s
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that, in this particular case, I placed all the "Phase N - ..."
comments on the same line as its corresponding switch case. The same
way in which similar comments appear in drivers/s
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that, in this particular case, a dash is added as a token in
order to separate the "Fall through" annotation from the rest of the
comment on the same line, which is what GCC is expec
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/lpfc/lpfc_nportdisc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c
b/drivers/scsi/lpfc/lpfc_
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 114996 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/sym53c8xx_2/sym_hipd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that, in this particular case, I replaced "Drop thru" with
"fall through" annotations, which is what GCC is expecting to find.
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 114988 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/ppa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/ppa.c
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/lpfc/lpfc_ct.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c
index 63
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/lpfc/lpfc_nvme.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c
inde
On Wed, 2018-11-28 at 15:38 +1100, Stephen Rothwell wrote:
> Hi all,
>
> On Tue, 27 Nov 2018 20:14:58 -0800 Randy Dunlap g> wrote:
> >
> > On 11/26/18 8:25 PM, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > Changes since 20181126:
> > >
> >
> > on i386:
> >
> > ERROR: "__udivdi3" [drive
On 28/11/2018 05:34, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that, in this particular case, I replaced
> "Missed the backend's Closing state -- fallthrough" with
> "fall through - Missed
Already submitted by Tomas:
https://www.spinics.net/lists/linux-scsi/msg125659.html
Thanks,
Avri
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org
> On Behalf Of Gustavo A. R. Silva
> Sent: Wednesday, November 28, 2018 6:34 AM
> To: Vinayak Holikatti
> Cc: James E.J. Bottoml
On Wed, Nov 28, 2018 at 10:02 AM Gustavo A. R. Silva
wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
Acked-by: Sumit Saxena
> ---
> drivers/scsi/megaraid/megaraid_sas_base.c | 1 +
>
On Wed, Nov 28, 2018 at 10:02 AM Gustavo A. R. Silva
wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that, in this particular case, I replaced "Fall thru" with a
> "Fall through" annotation and added a dash as a t
On Tue, Nov 27, 2018 at 09:41:24PM -0800, James Bottomley wrote:
> Yes, it's because dma_addr_t can be u64 on pae systems but
> isa_virt_to_bus only ever returns unsigned long (because an ISA
> physical address can only be 24 bits).
>
> I think this is the fix; there doesn't seem to be much point
On Wed, Nov 28, 2018 at 10:20:01AM +0800, Ming Lei wrote:
> On Mon, Nov 26, 2018 at 10:33:32AM -0700, Jens Axboe wrote:
> > On 11/26/18 9:54 AM, Keith Busch wrote:
> > > The iterative update to the previous version taking into account review
> > > comments.
> > >
> > > Background:
> > >
> > > The
On 11/27/18 9:41 PM, James Bottomley wrote:
> On Wed, 2018-11-28 at 15:38 +1100, Stephen Rothwell wrote:
>> Hi all,
>>
>> On Tue, 27 Nov 2018 20:14:58 -0800 Randy Dunlap > g> wrote:
>>>
>>> On 11/26/18 8:25 PM, Stephen Rothwell wrote:
Hi all,
Changes since 20181126:
>>>
>>> o
71 matches
Mail list logo
