Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Signed-off-by: YueHaibing
---
drivers/scsi/ufs/ufs-hisi.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/scsi/ufs/ufs-hisi.c b/drivers/scsi/ufs/ufs-hisi.c
index 452e19f..6fdf059 100644
--- a/drivers/scsi/u
On Tue, 2018-11-13 at 01:02 +, Madhani, Himanshu wrote:
> I see other drivers also use similar information populated for NVMe
> Connection at boot time.
Hi Himanshu,
Which other drivers are you referring to?
Thanks,
Bart.
> On Nov 13, 2018, at 6:23 AM, Bart Van Assche wrote:
>
> External Email
>
> On Tue, 2018-11-13 at 01:02 +, Madhani, Himanshu wrote:
>> I see other drivers also use similar information populated for NVMe
>> Connection at boot time.
>
> Hi Himanshu,
>
> Which other drivers are you referri
On Tue, 2018-11-13 at 17:38 +, Madhani, Himanshu wrote:
> On Nov 13, 2018, at 6:23 AM, Bart Van Assche wrote:
> > On Tue, 2018-11-13 at 01:02 +, Madhani, Himanshu wrote:
> > > I see other drivers also use similar information populated for NVMe
> > > Connection at boot time.
> >
> > Hi Him
On 12/11/2018 19:52, Joe Perches wrote:
On Mon, 2018-11-12 at 19:31 +, John Garry wrote:
On 12/11/2018 18:58, Joe Perches wrote:
+#define pr_fmt(fmt) "sas: " fmt
Some other subsystem may try to include this header, and gets its
message prefix overwritten. Just a consequence for doing somet
On Sun, Nov 11, 2018 at 02:32:08PM +0100, Christoph Hellwig wrote:
> Move all actual functionality into helpers, just leaving the dispatch
> in this function.
>
> Signed-off-by: Christoph Hellwig
> ---
> block/bsg.c | 158
> 1 file changed, 72
On Sun, Nov 11, 2018 at 02:32:09PM +0100, Christoph Hellwig wrote:
> We can just stash away the second request in struct bsg_job instead
> of using the block layer req->next_rq field, allowing for the eventual
> removal of the latter.
>
> Signed-off-by: Christoph Hellwig
> ---
> block/bsg-lib.c
Replaced vmalloc + memset with vzalloc
Signed-off-by: Sabyasachi Gupta
---
drivers/scsi/fnic/fnic_trace.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/fnic/fnic_trace.c b/drivers/scsi/fnic/fnic_trace.c
index 8271785..129ab27 100644
--- a/drivers/scsi/fnic/
On Tue, 2018-11-13 at 13:38 +, John Garry wrote:
> On 12/11/2018 19:52, Joe Perches wrote:
> > On Mon, 2018-11-12 at 19:31 +, John Garry wrote:
> > > On 12/11/2018 18:58, Joe Perches wrote:
> > > > > > +#define pr_fmt(fmt) "sas: " fmt
[]
> > > > It also might useful to use the common debugg
This is mostly a set of minor and obvious fixes (three in one of the
new drivers). The only substantial change is to move the ufs to the
blk-mq now that the merge window fixed the suspend/resume issues with
blk-mq.
The patch is available here:
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/s
On 13/11/2018 15:08, Sabyasachi Gupta wrote:
Replaced vmalloc + memset with vzalloc
Signed-off-by: Sabyasachi Gupta
---
drivers/scsi/fnic/fnic_trace.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/fnic/fnic_trace.c b/drivers/scsi/fnic/fnic_trace.c
index 8
On 13/11/2018 16:44, John Garry wrote:
> On 13/11/2018 15:08, Sabyasachi Gupta wrote:
>> Replaced vmalloc + memset with vzalloc
>>
>> Signed-off-by: Sabyasachi Gupta
>> ---
>> drivers/scsi/fnic/fnic_trace.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/sc
On Tue, Nov 13, 2018 at 9:23 PM Johannes Thumshirn wrote:
>
> On 13/11/2018 16:44, John Garry wrote:
> > On 13/11/2018 15:08, Sabyasachi Gupta wrote:
> >> Replaced vmalloc + memset with vzalloc
> >>
> >> Signed-off-by: Sabyasachi Gupta
> >> ---
> >> drivers/scsi/fnic/fnic_trace.c | 4 ++--
> >>
On Tue, 2018-11-13 at 16:53 +0100, Johannes Thumshirn wrote:
> On 13/11/2018 16:44, John Garry wrote:
> > On 13/11/2018 15:08, Sabyasachi Gupta wrote:
[...]
> > > -fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages *
> > > PAGE_SIZE));
> > > +fnic_trace_buf_p = (unsigned long)vzallo
On 13/11/2018 17:11, James Bottomley wrote:
> This is incorrect advice: there's no need to cast it to other *pointer*
> types, but if you cast it to a non-pointer type (which this is doing)
> the compiler will complain if there is no explicit cast.
Right, sorry for that and thanks for spotting it
On Tue, Nov 13, 2018 at 9:46 PM Johannes Thumshirn wrote:
>
> On 13/11/2018 17:11, James Bottomley wrote:
> > This is incorrect advice: there's no need to cast it to other *pointer*
> > types, but if you cast it to a non-pointer type (which this is doing)
> > the compiler will complain if there is
On 13/11/2018 17:22, Sabyasachi Gupta wrote:
> On Tue, Nov 13, 2018 at 9:46 PM Johannes Thumshirn wrote:
>>
>> On 13/11/2018 17:11, James Bottomley wrote:
>>> This is incorrect advice: there's no need to cast it to other *pointer*
>>> types, but if you cast it to a non-pointer type (which this is
There are no more users relying on blk-mq request states to prevent
double completions, so replace the relatively expensive cmpxchg operation
with WRITE_ONCE.
Signed-off-by: Keith Busch
---
block/blk-mq.c | 4 +---
include/linux/blk-mq.h | 14 --
2 files changed, 1 insertion
The scsi timeout error handling had been directly updating the request
state to prevent a natural completion and error handling from completing
the same request twice. Fix this layering violation by having scsi
control the fate of its commands with scsi owned flags rather than
use blk-mq's.
Signed
On 11/13/18 11:57 AM, Keith Busch wrote:
> The scsi timeout error handling had been directly updating the request
> state to prevent a natural completion and error handling from completing
> the same request twice. Fix this layering violation by having scsi
> control the fate of its commands with s
On Tue, Nov 13, 2018 at 12:20:46PM -0700, Jens Axboe wrote:
> On 11/13/18 11:57 AM, Keith Busch wrote:
> > static void scsi_mq_done(struct scsi_cmnd *cmd)
> > {
> > + if (test_and_set_bit(__SCMD_COMPLETE, &cmd->flags))
> > + return;
> > trace_scsi_dispatch_cmd_done(cmd);
> > b
Hi Alan:
>-Original Message-
>From: Alan Stern [mailto:st...@rowland.harvard.edu]
>Sent: Monday, November 12, 2018 11:33 PM
>To: Zengtao (B)
>Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com;
>gre...@linuxfoundation.org; linux-scsi@vger.kernel.org;
>linux-ker...@vger.kernel.org; li
c2856ae2f315d ("blk-mq: quiesce queue before freeing queue") has
already fixed this race, however the implied synchronize_rcu()
in blk_mq_quiesce_queue() can slow down LUN probe a lot, so caused
performance regression.
Then 1311326cf4755c7 ("blk-mq: avoid to synchronize rcu inside
blk_cleanup_que
On 11/13/18 12:45 PM, Keith Busch wrote:
> On Tue, Nov 13, 2018 at 12:20:46PM -0700, Jens Axboe wrote:
>> On 11/13/18 11:57 AM, Keith Busch wrote:
>>> static void scsi_mq_done(struct scsi_cmnd *cmd)
>>> {
>>> + if (test_and_set_bit(__SCMD_COMPLETE, &cmd->flags))
>>> + return;
>>>
On 11/14/18 12:35 PM, Ming Lei wrote:
> c2856ae2f315d ("blk-mq: quiesce queue before freeing queue") has
> already fixed this race, however the implied synchronize_rcu()
> in blk_mq_quiesce_queue() can slow down LUN probe a lot, so caused
> performance regression.
>
> Then 1311326cf4755c7 ("blk
On Wed, Nov 14, 2018 at 01:41:46PM +0800, jianchao.wang wrote:
>
>
> On 11/14/18 12:35 PM, Ming Lei wrote:
> > c2856ae2f315d ("blk-mq: quiesce queue before freeing queue") has
> > already fixed this race, however the implied synchronize_rcu()
> > in blk_mq_quiesce_queue() can slow down LUN probe
26 matches
Mail list logo
