Re: [PATCH 0/3] sd: Rely on the driver core for asynchronous probing

2018-10-28 Thread Laurence Oberman
On Tue, 2018-10-02 at 14:52 -0700, Bart Van Assche wrote: > Hello Martin, > > During the 2018 edition of LSF/MM there was a session about > increasing SCSI > disk probing concurrency. This patch series implements what has been > proposed > during that session, namely: > - Make sure that the driver

Re: [PATCH 0/3] sd: Rely on the driver core for asynchronous probing

2018-10-28 Thread Bart Van Assche
On 10/28/18 7:04 AM, Laurence Oberman wrote: I ran multiple tests for two days using the series from Bart's tree on the SRP test bed here. Multiple disconnects/reconnects during heavy IO activity on 32 SRP 64 LUNS/ 32 mpaths with no issues seen with probes and reconnects. For the series. Teste

Re: [PATCH v3 0/8] sg: major cleanup, remove max_queue limit

2018-10-28 Thread Douglas Gilbert
For anyone thinking of testing this patchset, it also applies clean to lk 4.19 release. Doug Gilbert On 2018-10-26 12:48 p.m., Douglas Gilbert wrote: The intention is to add two new ioctls as proposed by Linus Torvalds: SG_IOSUBMIT and SG_IORECEIVE to replace the write()/read() async interface.

Re: [PATCH] libosd: Remove ignored __weak attribute

2018-10-28 Thread Christoph Hellwig
On Sat, Oct 27, 2018 at 09:28:21AM -0400, Martin K. Petersen wrote: > The OSD protocol failed to get traction in the industry, adoption was > very limited. If the code just plugged straight into existing kernel > interfaces it would be easier to justify keeping it around. However, the > OSD support

Re: [PATCH 11/28] bsg: pass in desired timeout handler

2018-10-28 Thread Christoph Hellwig
On Thu, Oct 25, 2018 at 03:10:22PM -0600, Jens Axboe wrote: > This will ease in the conversion to blk-mq, where we can't set > a timeout handler after queue init. On thing I hoped to archive with the last round of bsg cleanups is to isolate the users of bsg from even knowing there is a struct requ

Re: [PATCH 12/28] bsg: provide bsg_remove_queue() helper

2018-10-28 Thread Christoph Hellwig
On Thu, Oct 25, 2018 at 03:10:23PM -0600, Jens Axboe wrote: > All drivers do unregister + cleanup, provide a helper for that. Nice cleanup, Reviewed-by: Christoph Hellwig

Re: [PATCH 13/28] bsg: convert to use blk-mq

2018-10-28 Thread Christoph Hellwig
> +static enum blk_eh_timer_return bsg_timeout(struct request *rq, bool > reserved) > +{ > + enum blk_eh_timer_return ret = BLK_EH_DONE; > + struct request_queue *q = rq->q; > + > + if (q->rq_timed_out_fn) > + ret = q->rq_timed_out_fn(rq); > + > + return ret; This is p

Re: [PATCH 11/28] bsg: pass in desired timeout handler

2018-10-28 Thread Jens Axboe
On 10/28/18 9:53 AM, Christoph Hellwig wrote: > On Thu, Oct 25, 2018 at 03:10:22PM -0600, Jens Axboe wrote: >> This will ease in the conversion to blk-mq, where we can't set >> a timeout handler after queue init. > > On thing I hoped to archive with the last round of bsg cleanups is > to isolate t

Re: [PATCH 13/28] bsg: convert to use blk-mq

2018-10-28 Thread Jens Axboe
On 10/28/18 10:07 AM, Christoph Hellwig wrote: >> +static enum blk_eh_timer_return bsg_timeout(struct request *rq, bool >> reserved) >> +{ >> +enum blk_eh_timer_return ret = BLK_EH_DONE; >> +struct request_queue *q = rq->q; >> + >> +if (q->rq_timed_out_fn) >> +ret = q->rq_t

Re: [PATCH 08/28] scsi: kill off the legacy IO path

2018-10-28 Thread Hannes Reinecke
On 10/25/18 11:10 PM, Jens Axboe wrote: Cc: linux-scsi@vger.kernel.org Signed-off-by: Jens Axboe --- Documentation/scsi/scsi-parameters.txt | 5 - drivers/scsi/Kconfig | 12 - drivers/scsi/cxlflash/main.c | 6 - drivers/scsi/hosts.c | 29 +

Re: [PATCH 09/28] dm: remove legacy IO path

2018-10-28 Thread Hannes Reinecke
On 10/25/18 11:10 PM, Jens Axboe wrote: dm supports both, and since we're killing off the legacy path in general, get rid of it in dm as well. Signed-off-by: Jens Axboe --- drivers/md/Kconfig| 11 -- drivers/md/dm-core.h | 10 -- drivers/md/dm-mpath.c | 14 +- drivers/md/dm-rq.c

Re: [PATCH 10/28] dasd: remove dead code

2018-10-28 Thread Hannes Reinecke
On 10/25/18 11:10 PM, Jens Axboe wrote: Since e443343e509a we haven't had a request_fn attached to this driver, hence any code inside an if (q->request_fn) is unreachable. Fixes: e443343e509a ("s390/dasd: blk-mq conversion") [sth: Keep and fix the dasd_info->chanq_len counter.] Reviewed-by: Jan

Re: [PATCH 11/28] bsg: pass in desired timeout handler

2018-10-28 Thread Hannes Reinecke
On 10/25/18 11:10 PM, Jens Axboe wrote: This will ease in the conversion to blk-mq, where we can't set a timeout handler after queue init. Cc: Johannes Thumshirn Cc: Benjamin Block Cc: linux-scsi@vger.kernel.org Signed-off-by: Jens Axboe --- block/bsg-lib.c | 3 ++- dri

Re: [PATCH 12/28] bsg: provide bsg_remove_queue() helper

2018-10-28 Thread Hannes Reinecke
On 10/25/18 11:10 PM, Jens Axboe wrote: All drivers do unregister + cleanup, provide a helper for that. Cc: Johannes Thumshirn Cc: Benjamin Block Cc: linux-scsi@vger.kernel.org Signed-off-by: Jens Axboe --- block/bsg-lib.c | 7 +++ drivers/scsi/scsi_transport_fc.c

Re: [PATCH 13/28] bsg: convert to use blk-mq

2018-10-28 Thread Hannes Reinecke
On 10/25/18 11:10 PM, Jens Axboe wrote: Requires a few changes to the FC transport class as well. Cc: Johannes Thumshirn Cc: Benjamin Block Cc: linux-scsi@vger.kernel.org Signed-off-by: Jens Axboe --- block/bsg-lib.c | 123 +++ drivers/scsi/scsi

Re: [PATCH 14/28] block: remove blk_complete_request()

2018-10-28 Thread Hannes Reinecke
On 10/25/18 11:10 PM, Jens Axboe wrote: It's now unused. Signed-off-by: Jens Axboe --- block/blk-softirq.c| 20 include/linux/blkdev.h | 1 - 2 files changed, 21 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes

Re: [PATCH 15/28] blk-wbt: kill check for legacy queue type

2018-10-28 Thread Hannes Reinecke
On 10/25/18 11:10 PM, Jens Axboe wrote: Everything is blk-mq at this point, so it doesn't make any sense to have this option available as it does nothing. Signed-off-by: Jens Axboe --- block/Kconfig | 6 -- block/blk-wbt.c | 3 +-- 2 files changed, 1 insertion(+), 8 deletions(-) Rev