On Mon, Oct 22, 2018 at 06:38:36AM -0600, Jens Axboe wrote:
> On 10/22/18 4:03 AM, Benjamin Block wrote:
> > On Fri, Oct 19, 2018 at 09:50:53AM -0600, Jens Axboe wrote:
> >
> > Ok so, that gets past the stage where we initialize the queues. Simple
> > SCSI-I/O also seems to work, that is for examp
This is still a bug in 4.20/scsi-queue. I am sending a new patch that applies
cleanly to
4.20/scsi-queue as it stands now. I have tested it successfully.
Regards
-Bill
-Original Message-
From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
Sent: Friday, October 19, 2018 6:24
When doing a surprise removal of an adapter, some in flight I/Os can get
stuck and take a while to complete (they actually timeout and are
retried). We are not handling an early error exit from
qla2xxx_eh_abort properly.
Fixes: 45235022da99 ("scsi: qla2xxx: Fix driver unload by shutting down ch
On 10/23/18 11:40 AM, Benjamin Block wrote:
> On Mon, Oct 22, 2018 at 06:38:36AM -0600, Jens Axboe wrote:
>> On 10/22/18 4:03 AM, Benjamin Block wrote:
>>> On Fri, Oct 19, 2018 at 09:50:53AM -0600, Jens Axboe wrote:
>>>
>>> Ok so, that gets past the stage where we initialize the queues. Simple
>>>
An error is an error - but not to the existing return value check.
Revise check to handle any failure, not just EIO.
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/lpf
Supported speeds is not updated when SFP is removed or replaced
Supported speed is obtained from lmt field in READ_CONFIG mailbox
response. Driver updates supported speeds only once from PCI probe
path. After that it is never updated. So, supported speeds remains
the same till reboot or driver rel
Update the driver version to 12.0.0.8
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_version.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h
index 5a0d512ff497..d0b2dd9b7
Testing a point-to-point topology and a case of re-FLOGI without
intervening link bouncing, showed an odd interaction with firmware
and a resulting scenario where the driver no longer probed after
accepting the new FLOGI.
Work around the firmware issue by issuing a link bounce if a FLOGI
is receiv
An address change for a remote port cause PRLI for the wrong
protocol to be sent. The node copy done in the discovery code
skipped copying the fc4 protocols supported as well.
Fix the copy logic for the address change.
Beefed up log messages in this area as well.
Signed-off-by: Dick Kennedy
Sig
Currently, PLOGI failures are infinitely delayed/retried.
There have been some fabric situations where the PLOGI's were to
the nameserver and it stopped responding. The retries would never
clear up. A better resolution in this situation is to retry a
couple of times, then drop the link and reinit.
After a LOGO in response to an ABTS timeout, a PLOGI wasn't issued
to re-establish the login. A nlp_type check in the LOGO completion
handler failed to restart discovery for NVME targets. Revised the
nlp_type check for NVME as well as SCSI.
While reviewing the LOGO handling a few other issues we
This patch corrects two issues:
- An oops would occur if reading based on a non-zero offset.
Offset calculation was incorrect.
- Updates to ras config (logging level) were ignored if change
was made while fw logging was enabled. Revise to dynamically
update.
Signed-off-by: Dick Kennedy
Sign
The switches seem to respond faster to GID_PT vs GID_FT NameServer
queries. Add support for GID_PT to be used over GID_FT to enable
faster storage failover detection. Includes addition of new module
parameter to select between GID_PT and GID_FT (GID_FT is default).
Signed-off-by: Dick Kennedy
Si
This patch contains lpfc bug fixes and 2 enhancements.
The patches were cut against Martin's 4.20/scsi-queue tree
James Smart (12):
lpfc: Correct speeds on SFP swap
lpfc: Fix lpfc_sli4_read_config return value check
lpfc: Fix LOGO/PLOGI handling when triggerd by ABTS Timeout event
lpfc:
On FCoE adapters, when running link bounce test in a loop,
initiator failed to login with switch switch and required driver
reload to recover. Switch reached a point where all subsequent
FLOGIs would be LS_RJT'd. Further testing showed the condition to
be related to not performing FCF discovery bet
Add trunking support to the driver. Trunking is found on more recent
asics. In general, trunking appears as a single "port" to the driver
and overall behavior doesn't differ. Link speed is reported as an
aggregate value, while link speed control is done on a per-physical
link basis with all links i
When LCB's are rejected, if beaconing was already in progress, the
Reason Code Explanation was not being set. Should have been set to
command in progress.
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_els.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
Hi Doug,
> I'll follow what the scsi mid-level and the other ULDs do. IOW, no
> change. The debug messages they produce are quite helpful (to me, I
> use them a lot, and Tony B. has asked for more precision) and
> well-tuned to the SCSI subsystem (e.g. telling us what sdp represents
> in useful
Bart,
> This is a series with mostly trivial patches for the qla2xxx
> driver. These patches address warnings reported by gcc and by the
> smatch and sparse static analyzers. Please consider these patches for
> kernel v4.20.
Applied to 4.20/scsi-queue. Thanks!
--
Martin K. Petersen Oracl
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/mvsas/mv_sas.c: In function 'mvs_work_queue':
> drivers/scsi/mvsas/mv_sas.c:1909:31: warning:
> variable 'id' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction in commit
> 20b09c2992fe
Dan,
>> +if (value < 0 || value > 2)
>> return -EINVAL;
>
> It's not actually clear to me why we allow 2. Shouldn't we just use
> kstrtobool()?
Hannes?
--
Martin K. Petersen Oracle Linux Engineering
On Mon, Oct 22, 2018 at 3:39 PM Dominik Brodowski
wrote:
>
> These are just a few odd fixes and improvements to the PCMCIA core
> and to a few PCMCIA device drivers.
Pulled,
Linus
This is to fix Sync cache and start stop command
failures with DID_NO_CONNECT during driver unload.
1) Release drives first from SML, then remove internally
in driver.
2) And allow sync cache and Start stop commands to firmware,
even when remove_host flag is set
Signed-off-by: Suganath Prabu
--
* If EEDPTagMode field in manufacturing page11 is set,
unset it. This is needed to fix a hardware bug
in SAS3/SAS2 cards, So, skipping EEDPTagMode changes
in Manufacturing page11 for SAS35 controllers.
* Fix driver modifying NVRAM/persistent data in
Manufacturing page11 along with current copy. Dr
v6 Change set:
Incorporated changes as suggested by Andy.
In Patch 1 converted while loop to do while in
function mpt3sas_wait_for_ioc_to_operational().
And in patch 3 removed parentheses.
V5 Change set:
V5 post has only defect fixes.
We are reworking and incorporating the suggestions from Bjorn.
Modify driver version to 27.100.00.00
(which is equivalent to PH8 OOB driver)
Signed-off-by: Suganath Prabu
---
drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h
b/drivers/scsi/mpt3sas/mpt3sas_base.h
i
No functional changes. This section of code
"wait for IOC to be operational" is used in many places
across the driver, and hence moved this code in to
a function "mpt3sas_wait_for_ioc_to_operational()"
Signed-off-by: Suganath Prabu
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 73 +++
On 10/12/18 4:08 AM, Damien Le Moal wrote:
> This series improves zoned block device support (reduce overhead) and
> introduces many simplifications to the code (overall, there are more deletions
> than insertions).
>
> In more details:
> * Patches 1 to 3 are SCSI side (sd driver) cleanups and imp
John,
Thanks for tweaking this.
> Not sure if this is the preferred way of scoping the quirk to
> the controller or not. Feedback would be greatly appreciated!
I think my preference would be to add:
UFS_FIX(UFS_VENDOR_SKHYNIX, "hB8aL1",
UFS_DEVICE_QUIRK_HOST_VS_DEBUG),
On Tue, Oct 23, 2018 at 7:47 PM, Martin K. Petersen
wrote:
>
> John,
>
> Thanks for tweaking this.
>
>> Not sure if this is the preferred way of scoping the quirk to
>> the controller or not. Feedback would be greatly appreciated!
>
> I think my preference would be to add:
>
>UFS_FIX(UFS_V
John,
> Ok. Yea, I saw something similar in the qcom code, but I wasn't sure
> if folks would want host specific quirks isolated to host code.
Yeah, that's why I thought it would be good for the UFS folks to chime
in.
--
Martin K. Petersen Oracle Linux Engineering
Sabyasachi,
> Replaced dma_pool_alloc + memset with dma_pool_zalloc
Applied to 4.20/scsi-queue, thank you.
--
Martin K. Petersen Oracle Linux Engineering
On Mon, Oct 8, 2018 at 9:58 PM Souptick Joarder wrote:
>
> On Tue, Oct 2, 2018 at 10:53 AM Souptick Joarder wrote:
> >
> > Replaced dma_pool_alloc + memset with dma_pool_zalloc.
> >
> > Signed-off-by: Sabyasachi Gupta
> > Signed-off-by: Souptick Joarder
>
> Any comment on this patch ?
Any comm
Nathan,
> Clang warns a few times:
>
> drivers/scsi/3w-sas.c:386:11: warning: implicit conversion from 'int' to
> 'char' changes value from 128 to -128 [-Wconstant-conversion]
> cdb[4] = TW_ALLOCATION_LENGTH; /* allocation length */
>~ ^~~~
>
> Update cdb'
Jens,
> 2) The ordering of the signed-off-by. Someone told me that this is
>patchwork, but I absolutely hate it. SOB should go last, not before
>the reviewed-by. I fixed that up too.
You keep mentioning this, but I don't recall ever seeing anything to
that effect. The rest of the kernel
35 matches
Mail list logo
