Re: [PATCH] Revert "genirq/affinity: assign vectors to all possible CPUs"

2018-10-08 Thread IT (Donald Buczek)
On 10/08/18 04:11, Ming Lei wrote: On Mon, Oct 01, 2018 at 02:33:07PM +0200, Paul Menzel wrote: Date: Wed, 29 Aug 2018 17:28:45 +0200 This reverts commit ef86f3a72adb8a7931f67335560740a7ad696d1d. See the discussion in the thread *aacraid: Regression in 4.14.56 with *genirq/affinity: assign vec

Re: [PATCH v1] scsi: ufs: add 2 lane support

2018-10-08 Thread cang
On 2018-10-04 02:34, Evan Green wrote: Hi, On Wed, Oct 3, 2018 at 11:19 AM Can Guo wrote: From: Venkat Gopalakrishnan Qcom ufs controller v3.1.0 supports 2 lanes, add support to configure 2 lanes during phy initialization. I'm reviving this old chestnut, sorry I missed it initially. This

Re: [PATCH v1] scsi: ufs: add 2 lane support

2018-10-08 Thread cang
Hi Evan, On 2018-10-04 02:34, Evan Green wrote: Hi, On Wed, Oct 3, 2018 at 11:19 AM Can Guo wrote: From: Venkat Gopalakrishnan Qcom ufs controller v3.1.0 supports 2 lanes, add support to configure 2 lanes during phy initialization. I'm reviving this old chestnut, sorry I missed it initia

Re: [PATCH] scsi/mpt3sas: Use dma_pool_zalloc

2018-10-08 Thread Souptick Joarder
On Tue, Oct 2, 2018 at 11:14 AM Souptick Joarder wrote: > > Replaced dma_pool_alloc + memset with dma_pool_zalloc. > > Signed-off-by: Brajeswar Ghosh > Signed-off-by: Souptick Joarder Any comment on this patch ? > --- > drivers/scsi/mpt3sas/mpt3sas_base.c | 6 ++ > 1 file changed, 2 insert

Re: [PATCH] scsi/pmcraid.c: Use dma_pool_zalloc

2018-10-08 Thread Souptick Joarder
On Tue, Oct 2, 2018 at 10:53 AM Souptick Joarder wrote: > > Replaced dma_pool_alloc + memset with dma_pool_zalloc. > > Signed-off-by: Sabyasachi Gupta > Signed-off-by: Souptick Joarder Any comment on this patch ? > --- > drivers/scsi/pmcraid.c | 4 +--- > 1 file changed, 1 insertion(+), 3 del

Re: -Wswitch Clang warnings in drivers/scsi

2018-10-08 Thread Nick Desaulniers
On Thu, Oct 4, 2018 at 11:57 PM Nathan Chancellor wrote: > > On Thu, Oct 04, 2018 at 02:16:49PM -0700, Nick Desaulniers wrote: > > On Thu, Oct 4, 2018 at 11:45 AM Nathan Chancellor > > wrote: > > > > > > On Thu, Oct 04, 2018 at 11:34:29AM -0700, Bart Van Assche wrote: > > > > On Thu, 2018-10-04 a

Re: -Wswitch Clang warnings in drivers/scsi

2018-10-08 Thread Bart Van Assche
On Thu, 2018-10-04 at 23:57 -0700, Nathan Chancellor wrote: > Regardless of how the overflow is handled within the switch statement, > the overflow is also happening when passing in these values to the ioctl, > right? I mean these case values are defined in the uapi files so that > userspace can ea

Re: [PATCH] scsi/mpt3sas: Use dma_pool_zalloc

2018-10-08 Thread Suganath Prabu Subramani
Looks good, Please consider this patch as Acked-by: Suganath Prabu Thanks On Tue, Oct 2, 2018 at 11:14 AM Souptick Joarder wrote: > > Replaced dma_pool_alloc + memset with dma_pool_zalloc. > > Signed-off-by: Brajeswar Ghosh > Signed-off-by: Souptick Joarder > --- > drivers/scsi/mpt3sas/mpt3s

Re: [PATCH 2/3] libfc: check fc_frame_payload_get() return value for null

2018-10-08 Thread Easi, Arun
On Sun, 7 Oct 2018, 1:35am, Hannes Reinecke wrote: > External Email > > From: Thomas Abraham > > We should not assume the payload of a PRLI or PLOGI > respons is always present. > > Signed-off-by: Thomas Abraham > Reviewed-by: Hannes Reinecke > --- > drivers/scsi/libfc/fc_rport.c | 14 +

Re: [PATCH 3/3] libfc: retry PRLI if we cannot analyse the payload

2018-10-08 Thread Easi, Arun
On Sun, 7 Oct 2018, 1:35am, Hannes Reinecke wrote: > External Email > > From: Hannes Reinecke > > When we fail to analyse the payload of a PRLI response we should > reset the state machine to retry the PRLI; eventually we will be > getting a proper frame. > Not doing so will result in a stuck s

Re: [PATCH 1/3] scsi: Allow state transitions from OFFLINE to BLOCKED

2018-10-08 Thread Ewan D. Milne
This change would permit a device that was OFFLINE (for any reason) to go back to RUNNING via: OFFLINE -> BLOCKED -> RUNNING Obviously that was your intention, but e.g. if a device was put OFFLINE due to exceeding max_medium_access_timeouts a fabric event and recovery would put it back online. S

Re: [PATCH 1/3] scsi: Allow state transitions from OFFLINE to BLOCKED

2018-10-08 Thread Hannes Reinecke
On 10/8/18 10:22 PM, Ewan D. Milne wrote: This change would permit a device that was OFFLINE (for any reason) to go back to RUNNING via: OFFLINE -> BLOCKED -> RUNNING Correct. Obviously that was your intention, but e.g. if a device was put OFFLINE due to exceeding max_medium_access_timeouts

[PATCH] lpfc: fixup crash in lpfc_els_unsol_buffer()

2018-10-08 Thread Hannes Reinecke
lpfc_nlp_get() in lpfc_els_unsol_buffer() is not running under a lock, so there is a chance that it might actually fail. But as we never check the return value we'll get a crash in lpfc_nlp_put() later on trying to free an invalid buffer. Signed-off-by: Hannes Reinecke --- drivers/scsi/lpfc/lpfc

Re: [PATCH] lpfc: fixup crash in lpfc_els_unsol_buffer()

2018-10-08 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG N