RE: [PATCH] driver core: device: add BUS_ATTR_WO macro

2018-10-02 Thread Ioana Ciornei
> > Add BUS_ATTR_WO macro to make it easier to add attributes without > > auditing the mode settings. Also, use the newly added macro where > > appropriate. > > > > Signed-off-by: Ioana Ciornei > > --- > > arch/powerpc/platforms/pseries/ibmebus.c | 12 > > drivers/block/rbd.c

Re: [PATCH] scsi: mptfusion: Remove unnecessary parentheses and simplify null checks

2018-10-02 Thread Arnd Bergmann
On Sat, Sep 15, 2018 at 8:38 AM Nathan Chancellor wrote: > Reported-by: Nick Desaulniers > Signed-off-by: Nathan Chancellor > --- > drivers/message/fusion/mptbase.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/message/fusion/mptbase.c > b/drivers/messag

Re: [PATCH v4 1/6] mpt3sas: Introduce mpt3sas_base_pci_device_is_available

2018-10-02 Thread Bjorn Helgaas
On Mon, Oct 01, 2018 at 03:40:51PM -0500, Bjorn Helgaas wrote: > I think the names "pci_device_is_present()" and > "mpt3sas_base_pci_device_is_available()" contribute to the problem > because they make promises that can't be kept -- all we can say is > that the device *was* present, but we know whe

Re: [PATCH] libosd: Remove ignored __weak attribute

2018-10-02 Thread Christoph Hellwig
On Mon, Oct 01, 2018 at 06:16:32PM -0700, Bart Van Assche wrote: > Boaz, the most recent osd patch that is neither trivial nor treewide > refactoring is six years old (51976a8c85ce ("[SCSI] osd_uld: Add osdname & > systemid sysfs at scsi_osd class"). That suggests that nobody is using this > driver

Re: [PATCH] MAINTAINERS: Fix typo in cxlflash stanza

2018-10-02 Thread Uma Krishnan
> On Oct 1, 2018, at 11:26 AM, Matthew R. Ochs wrote: > > The uapi header file listed in the cxlflash stanza has a typo. > > Removed the trailing 's' from the filename. > > Reported-by: Joe Perches > Signed-off-by: Matthew R. Ochs > --- Thanks for taking care of this. Acked-by: Uma Krish

Re: [PATCH] scsi: mptfusion: Remove unnecessary parentheses and simplify null checks

2018-10-02 Thread Nathan Chancellor
On Tue, Oct 02, 2018 at 02:58:21PM +0200, Arnd Bergmann wrote: > On Sat, Sep 15, 2018 at 8:38 AM Nathan Chancellor > wrote: > > > Reported-by: Nick Desaulniers > > Signed-off-by: Nathan Chancellor > > --- > > drivers/message/fusion/mptbase.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 del

Re: [PATCH RESEND] scsi: sg: Prevent potential double frees in sg driver

2018-10-02 Thread Evan Green
On Mon, Oct 1, 2018 at 4:34 PM Douglas Gilbert wrote: > > On 2018-10-02 02:15 AM, Evan Green wrote: > > From: Robb Glasser > > > > sg_ioctl could be spammed by requests, leading to a double free in > > __free_pages. This protects the entry points of sg_ioctl where the > > memory could be corrupte

Re: [PATCH] libosd: Remove ignored __weak attribute

2018-10-02 Thread Boaz Harrosh
On 02/10/18 17:56, Christoph Hellwig wrote: > On Mon, Oct 01, 2018 at 06:16:32PM -0700, Bart Van Assche wrote: >> Boaz, the most recent osd patch that is neither trivial nor treewide >> refactoring is six years old (51976a8c85ce ("[SCSI] osd_uld: Add osdname & >> systemid sysfs at scsi_osd class").

Re: [PATCH] libosd: Remove ignored __weak attribute

2018-10-02 Thread Nick Desaulniers
On Mon, Oct 1, 2018 at 6:16 PM Bart Van Assche wrote: > > On 9/30/18 1:54 PM, Nathan Chancellor wrote: > > diff --git a/include/scsi/osd_types.h b/include/scsi/osd_types.h > > index 48e8a165e136..6b6fdcafa6cc 100644 > > --- a/include/scsi/osd_types.h > > +++ b/include/scsi/osd_types.h > > @@ -28,7

Re: [PATCH] libosd: Remove ignored __weak attribute

2018-10-02 Thread Bart Van Assche
On Tue, 2018-10-02 at 10:24 -0700, Nick Desaulniers wrote: > On Mon, Oct 1, 2018 at 6:16 PM Bart Van Assche wrote: > > Additionally, zero initializers should be left out to minimize > > the size of object files. > > Sorry, my understanding was that global variables either occupy the > .bss sectio

Re: [PATCH] libosd: Remove ignored __weak attribute

2018-10-02 Thread Nick Desaulniers
On Tue, Oct 2, 2018 at 10:57 AM Bart Van Assche wrote: > > On Tue, 2018-10-02 at 10:24 -0700, Nick Desaulniers wrote: > > On Mon, Oct 1, 2018 at 6:16 PM Bart Van Assche wrote: > > > Additionally, zero initializers should be left out to minimize > > > the size of object files. > > > > Sorry, my un

Re: [PATCH v2] scsi: bfa: Avoid implicit enum conversion in bfad_im_post_vendor_event

2018-10-02 Thread Nick Desaulniers
On Thu, Sep 27, 2018 at 4:57 PM Nathan Chancellor wrote: > > Clang warns when one enumerated type is implicitly converted to another. > > drivers/scsi/bfa/bfa_fcs_lport.c:379:26: warning: implicit conversion > from enumeration type 'enum bfa_lport_aen_event' to different > enumeration type 'enum b

Re: [PATCH] libosd: Remove ignored __weak attribute

2018-10-02 Thread Bart Van Assche
On Tue, 2018-10-02 at 15:33 -0700, Nick Desaulniers wrote: > On Tue, Oct 2, 2018 at 10:57 AM Bart Van Assche wrote: > > Explicitly initialized global and static variables end up in the .data > > section and need space in that section. > > Unless the initial value is zero. > https://godbolt.org/z/

[PATCH 09/16] scsi: Replace spin_is_locked() with lockdep

2018-10-02 Thread Lance Roy
lockdep_assert_held() is better suited to checking locking requirements, since it won't get confused when someone else holds the lock. This is also a step towards possibly removing spin_is_locked(). Signed-off-by: Lance Roy Cc: Karan Tilak Kumar Cc: Sesidhar Baddela Cc: "James E.J. Bottomley"

Looking for some help understanding error handling

2018-10-02 Thread Chris.Moore
I'm working on LLDD for a SAS/SATA host adapter, and trying to understand how the system handles link loss and recovery. Say I have a device that gets recognized and attached as sd 12:0:4:0, at /dev/sdb. The drive goes offline temporarily, then comes back online. When it does, it comes back as s

[PATCH 0/3] sd: Rely on the driver core for asynchronous probing

2018-10-02 Thread Bart Van Assche
Hello Martin, During the 2018 edition of LSF/MM there was a session about increasing SCSI disk probing concurrency. This patch series implements what has been proposed during that session, namely: - Make sure that the driver core is aware of asynchronous SCSI LUN probing. - Avoid unnecessary seria

[PATCH 3/3] __device_release_driver(): Do not wait for asynchronous probing

2018-10-02 Thread Bart Van Assche
Since __device_release_driver() is called with the device lock held and since the same device lock is obtained by the functions that perform asynchronous probing (driver_attach_async() and __device_attach_async_helper()), asynchronous probing is already serialized against __device_release_driver().

[PATCH 1/3] sd: Rely on the driver core for asynchronous probing

2018-10-02 Thread Bart Van Assche
As explained during the LSF/MM session about increasing SCSI disk probing concurrency, the problems with the current probing approach are as follows: - The driver core is unaware of asynchronous SCSI LUN probing. wait_for_device_probe() waits for all asynchronous probes except asynchronous SCSI

[PATCH 2/3] sd: Inline sd_probe_part2()

2018-10-02 Thread Bart Van Assche
This patch does not change any functionality. Signed-off-by: Bart Van Assche Cc: Lee Duncan Cc: Hannes Reinecke Cc: Luis R. Rodriguez Cc: Johannes Thumshirn Cc: Christoph Hellwig Cc: Greg Kroah-Hartman --- drivers/scsi/sd.c | 101 -- 1 file chang

[Bug 201313] New: pm80xx mpi_ssp_completion 1883:SAS Address of IO Failure Drive:

2018-10-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201313 Bug ID: 201313 Summary: pm80xx mpi_ssp_completion 1883:SAS Address of IO Failure Drive: Product: IO/Storage Version: 2.5 Kernel Version: 4.18.11-041811-generic Hardware

[Bug 201313] pm80xx mpi_ssp_completion 1883:SAS Address of IO Failure Drive:

2018-10-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201313 --- Comment #1 from MasterCATZ (masterc...@hotmail.com) --- pm80xx mpi_ssp_completion 1874:sas IO status 0x24 [ 708.424035] pm80xx mpi_ssp_completion 1883:SAS Address of IO Failure Drive:500605ba00b9cca2 [ 708.424241] sd 1:0:8:0: Power-on or dev