Re: [Qemu-devel] virtio-console downgrade the virtio-pci-blk performance

2018-10-01 Thread Dr. David Alan Gilbert
* Feng Li (lifeng1...@gmail.com) wrote: > Hi, > I found an obvious performance downgrade when virtio-console combined > with virtio-pci-blk. > > This phenomenon exists in nearly all Qemu versions and all Linux > (CentOS7, Fedora 28, Ubuntu 18.04) distros. > > This is a disk cmd: > -drive > file=

[PATCH] Revert "genirq/affinity: assign vectors to all possible CPUs"

2018-10-01 Thread Paul Menzel
Date: Wed, 29 Aug 2018 17:28:45 +0200 This reverts commit ef86f3a72adb8a7931f67335560740a7ad696d1d. See the discussion in the thread *aacraid: Regression in 4.14.56 with *genirq/affinity: assign vectors to all possible CPUs** on the linux-scsi list. Reverting the commit, the aacraid driver loads

Re: [PATCH] Revert "genirq/affinity: assign vectors to all possible CPUs"

2018-10-01 Thread Christoph Hellwig
On Mon, Oct 01, 2018 at 02:33:07PM +0200, Paul Menzel wrote: > Date: Wed, 29 Aug 2018 17:28:45 +0200 > > This reverts commit ef86f3a72adb8a7931f67335560740a7ad696d1d. This seems rather odd. If add all you'd revert the patch adding the PCI_IRQ_AFFINITY to aacraid, not core infrastructure.

Re: [PATCH] Revert "genirq/affinity: assign vectors to all possible CPUs"

2018-10-01 Thread Paul Menzel
Dear Christoph, On 10/01/18 14:35, Christoph Hellwig wrote: > On Mon, Oct 01, 2018 at 02:33:07PM +0200, Paul Menzel wrote: >> Date: Wed, 29 Aug 2018 17:28:45 +0200 >> >> This reverts commit ef86f3a72adb8a7931f67335560740a7ad696d1d. > > This seems rather odd. If at all you'd revert the patch add

LED trigger for UFS device activity

2018-10-01 Thread Manivannan Sadhasivam
Hello everyone, I'm looking into adding LED trigger support for UFS device activity. This essentially means a dedicated LED will blink upon the UFS device activity like we have for ATA, MTD, NAND devices. Currently, I'm not sure about the places where we have to insert this trigger. My only choic

Re: [PATCH v4 3/6] mpt3sas: Introdude _scsih_get_shost_and_ioc.

2018-10-01 Thread Bjorn Helgaas
[+cc LKML] On Mon, Oct 01, 2018 at 12:57:01PM +0530, Suganath Prabu Subramani wrote: > On Thu, Sep 27, 2018 at 2:39 AM Bjorn Helgaas wrote: > > On Wed, Sep 26, 2018 at 09:52:36AM +0530, Suganath Prabu S wrote: > > > The code for getting shost and IOC is redundant so > > > moved that to function "

Re: [Qemu-devel] virtio-console downgrade the virtio-pci-blk performance

2018-10-01 Thread Feng Li
Hi Dave, My comments are in-line. Dr. David Alan Gilbert 于2018年10月1日周一 下午7:41写道: > > * Feng Li (lifeng1...@gmail.com) wrote: > > Hi, > > I found an obvious performance downgrade when virtio-console combined > > with virtio-pci-blk. > > > > This phenomenon exists in nearly all Qemu versions and al

[PATCH] driver core: device: add BUS_ATTR_WO macro

2018-10-01 Thread Ioana Ciornei
Add BUS_ATTR_WO macro to make it easier to add attributes without auditing the mode settings. Also, use the newly added macro where appropriate. Signed-off-by: Ioana Ciornei --- arch/powerpc/platforms/pseries/ibmebus.c | 12 drivers/block/rbd.c | 48

Re: [PATCH] Revert "genirq/affinity: assign vectors to all possible CPUs"

2018-10-01 Thread Paul Menzel
Dear Christoph, On 10/01/18 14:43, Paul Menzel wrote: > On 10/01/18 14:35, Christoph Hellwig wrote: >> On Mon, Oct 01, 2018 at 02:33:07PM +0200, Paul Menzel wrote: >>> Date: Wed, 29 Aug 2018 17:28:45 +0200 >>> >>> This reverts commit ef86f3a72adb8a7931f67335560740a7ad696d1d. >> >> This seems rat

[PATCH RESEND] scsi: sg: Prevent potential double frees in sg driver

2018-10-01 Thread Evan Green
From: Robb Glasser sg_ioctl could be spammed by requests, leading to a double free in __free_pages. This protects the entry points of sg_ioctl where the memory could be corrupted by a double call to __free_pages if multiple requests are happening concurrently. Signed-off-by: Robb Glasser Signed

[PATCH] MAINTAINERS: Fix typo in cxlflash stanza

2018-10-01 Thread Matthew R. Ochs
The uapi header file listed in the cxlflash stanza has a typo. Removed the trailing 's' from the filename. Reported-by: Joe Perches Signed-off-by: Matthew R. Ochs --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index b22e7fd..103885

Re: [PATCH RESEND] scsi: sg: Prevent potential double frees in sg driver

2018-10-01 Thread Nick Desaulniers
On Mon, Oct 1, 2018 at 9:16 AM Evan Green wrote: > > From: Robb Glasser > > sg_ioctl could be spammed by requests, leading to a double free in > __free_pages. This protects the entry points of sg_ioctl where the > memory could be corrupted by a double call to __free_pages if multiple > requests a

Re: [PATCH RESEND] scsi: sg: Prevent potential double frees in sg driver

2018-10-01 Thread Bart Van Assche
On Mon, 2018-10-01 at 10:12 -0700, Nick Desaulniers wrote: > On Mon, Oct 1, 2018 at 9:16 AM Evan Green wrote: > > > > From: Robb Glasser > > > > sg_ioctl could be spammed by requests, leading to a double free in > > __free_pages. This protects the entry points of sg_ioctl where the > > memory c

Re: [PATCH v4 1/6] mpt3sas: Introduce mpt3sas_base_pci_device_is_available

2018-10-01 Thread Bjorn Helgaas
On Mon, Oct 01, 2018 at 12:27:28PM +0530, Suganath Prabu Subramani wrote: > On Fri, Sep 28, 2018 at 12:40 AM Lukas Wunner wrote: > > On Thu, Sep 27, 2018 at 01:47:46PM -0500, Bjorn Helgaas wrote: > > > I'm not sure how mpt3sas benefits from adding > > > mpt3sas_base_pci_device_is_available() here

Re: [PATCH] libosd: Remove ignored __weak attribute

2018-10-01 Thread Nick Desaulniers
On Sun, Sep 30, 2018 at 1:55 PM Nathan Chancellor wrote: > > Clang warns that the __weak attribute is going to be ignored on > osd_root_object because it's not in the correct location (needs to be > after the type). > > ./include/scsi/osd_types.h:31:21: warning: 'weak' attribute only applies > to

[RESEND][PATCH] scsi: ufs: Fix hynix ufs bug with quirk on hi36xx SoC

2018-10-01 Thread John Stultz
From: Wei Li Hynix ufs has deviations on hi36xx platform which will result in ufs bursts transfer failures. To fix the problem, the Hynix device must set the register VS_DebugSaveConfigTime to 0x10, which will set time reference for SaveConfigTime is 250 ns. The time reference for SaveConfigTime

Re: [PATCH RESEND] scsi: sg: Prevent potential double frees in sg driver

2018-10-01 Thread Douglas Gilbert
On 2018-10-02 02:15 AM, Evan Green wrote: From: Robb Glasser sg_ioctl could be spammed by requests, leading to a double free in __free_pages. This protects the entry points of sg_ioctl where the memory could be corrupted by a double call to __free_pages if multiple requests are happening concur

Re: [PATCH 0/7] Neaten logging uses

2018-10-01 Thread Joe Perches
On Mon, 2018-09-17 at 08:01 -0700, Joe Perches wrote: > Several defects exist in the logging uses > > o Missing KERN_ > o Unnecessary KERN_ uses with panic > o Mismatched MPT3SAS_FMT and %s: with name and __func__ > > Correct these defects and perhaps add some clarity to the logging. Submitted 2

Re: [PATCH] driver core: device: add BUS_ATTR_WO macro

2018-10-01 Thread Greg KH
On Mon, Oct 01, 2018 at 06:32:52PM +0300, Ioana Ciornei wrote: > Add BUS_ATTR_WO macro to make it easier to add attributes without > auditing the mode settings. Also, use the newly added macro where > appropriate. > > Signed-off-by: Ioana Ciornei > --- > arch/powerpc/platforms/pseries/ibmebus.c

Re: [PATCH] libosd: Remove ignored __weak attribute

2018-10-01 Thread Bart Van Assche
On 9/30/18 1:54 PM, Nathan Chancellor wrote: diff --git a/include/scsi/osd_types.h b/include/scsi/osd_types.h index 48e8a165e136..6b6fdcafa6cc 100644 --- a/include/scsi/osd_types.h +++ b/include/scsi/osd_types.h @@ -28,7 +28,7 @@ struct osd_obj_id { osd_id id; }; -static const struct

[PATCH] scsi/pmcraid.c: Use dma_pool_zalloc

2018-10-01 Thread Souptick Joarder
Replaced dma_pool_alloc + memset with dma_pool_zalloc. Signed-off-by: Sabyasachi Gupta Signed-off-by: Souptick Joarder --- drivers/scsi/pmcraid.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c index 4e86994..84a2734 100644

[PATCH] scsi/mpt3sas: Use dma_pool_zalloc

2018-10-01 Thread Souptick Joarder
Replaced dma_pool_alloc + memset with dma_pool_zalloc. Signed-off-by: Brajeswar Ghosh Signed-off-by: Souptick Joarder --- drivers/scsi/mpt3sas/mpt3sas_base.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt

Re: [PATCH] libosd: Remove ignored __weak attribute

2018-10-01 Thread Nathan Chancellor
On Mon, Oct 01, 2018 at 06:16:32PM -0700, Bart Van Assche wrote: > On 9/30/18 1:54 PM, Nathan Chancellor wrote: > > diff --git a/include/scsi/osd_types.h b/include/scsi/osd_types.h > > index 48e8a165e136..6b6fdcafa6cc 100644 > > --- a/include/scsi/osd_types.h > > +++ b/include/scsi/osd_types.h > >

Re: [PATCH v4 3/6] mpt3sas: Introdude _scsih_get_shost_and_ioc.

2018-10-01 Thread Suganath Prabu Subramani
On Thu, Sep 27, 2018 at 2:39 AM Bjorn Helgaas wrote: > > On Wed, Sep 26, 2018 at 09:52:36AM +0530, Suganath Prabu S wrote: > > The code for getting shost and IOC is redundant so > > moved that to function "scsih_get_shost_and_ioc". > > Also checks for NULL are added to IOC and shost. > > > > Signe

Re: aic7xxx DMA overflow error

2018-10-01 Thread Christoph Hellwig
On Sun, Sep 30, 2018 at 07:28:50PM -0400, tedheadster wrote: > Hannes, > I'm getting the following error in a custom configured 4.18 32-bit > x86 kernel supporting PAE, with 16GiB physical memory. It loops > infinitely on the error. > > aic7xxx :00:03.0: dma_direct_map_sg: overflow > 0x0

Re: aic7xxx DMA overflow error

2018-10-01 Thread tedheadster
Christoph, I was able to bisect this to your patch "scsi: reduce use of block bounce buffers". I am getting the error on a 32-bit Dell PowerEdge 6650. It has the aic7xxx integrated onto the motherboard. Again, here is the error: aic7xxx :00:03.0: dma_direct_map_sg: overflow 0x0003ff8000

RE: [PATCH v7 3/8] uapi: ufs: Make utp_upiu_req visible to user space

2018-10-01 Thread Avri Altman
> > + > > +/* > > + * This file intended to be included by both kernel and user space > > + */ > > + > > +#define MAX_CDB_SIZE 16 > > Please rename this constant such that it has either "UFS" or "UTP" in its > name. This name is too generic for a protocol-specific header file. Done. Thanks