Re: [PATCH v4 1/6] mpt3sas: Introduce mpt3sas_base_pci_device_is_available

2018-09-27 Thread Lukas Wunner
On Wed, Sep 26, 2018 at 04:32:41PM -0500, Bjorn Helgaas wrote: > On Wed, Sep 26, 2018 at 09:52:34AM +0530, Suganath Prabu S wrote: > > @@ -6853,6 +6872,13 @@ mpt3sas_wait_for_commands_to_complete(struct > > MPT3SAS_ADAPTER *ioc) > > > > ioc->pending_io_count = 0; > > > > + if (!mpt3sas_b

Re: [PATCH] scsi: qla4xxx: remove redundant check on drvr_wait

2018-09-27 Thread Martin K. Petersen
Colin, > The check for a non-zero drvr_wait is redundant as the same check is > performed earlier in the outer while loop, the inner check will always > be true if we reached this point inside the while loop. Remove the > redundant if check. Applied to 4.20/scsi-queue. Thanks! -- Martin K. P

Re: [PATCH] scsi: mptfusion: Remove unnecessary parentheses and simplify null checks

2018-09-27 Thread Martin K. Petersen
Nathan, > Clang warns when multiple pairs of parentheses are used for a single > conditional statement. Applied to 4.20/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v4 2/6] mpt3sas: Separate out mpt3sas_wait_for_ioc_to_operational

2018-09-27 Thread Suganath Prabu Subramani
Hi Bjorn, Thanks for reviewing. On Thu, Sep 27, 2018 at 2:33 AM Bjorn Helgaas wrote: > > On Wed, Sep 26, 2018 at 09:52:35AM +0530, Suganath Prabu S wrote: > > Introduce mpt3sas_wait_for_ioc_to_operational. > > > > This section of code "wait for IOC to be operational" > > is used in many places a

Re: aacraid: latest driver results in Host adapter abort request. / Outstanding commands on (0,0,0,0):

2018-09-27 Thread Emmanuel Florac
Le Wed, 19 Sep 2018 08:10:41 +0200 Stefan Priebe - Profihost AG écrivait: > Hello, > > after upgrading the aacraid driver / kernel from aacraid 50792 to > aacraid 50877. > > I get aborted comands every night. > I have exactly the same problem since 4.15 was out, and nobody answered... aacraid

Re: aacraid: latest driver results in Host adapter abort request. / Outstanding commands on (0,0,0,0):

2018-09-27 Thread Emmanuel Florac
Le Mon, 24 Sep 2018 08:11:20 +0200 Stefan Priebe - Profihost AG écrivait: > all series 6 controllers are those with problems when high load > happens. > As I mentioned in my messages to the ML since late june, the driver doesn't work either with 7xx5 and 8xx5 controllers. Who's maintaining this

Re: aacraid: latest driver results in Host adapter abort request. / Outstanding commands on (0,0,0,0):

2018-09-27 Thread Emmanuel Florac
Le Sun, 23 Sep 2018 20:22:56 +0200 Stefan Priebe - Profihost AG écrivait: > Am 22.09.2018 um 23:40 schrieb Bart Van Assche: > > On 9/18/18 11:10 PM, Stefan Priebe - Profihost AG wrote: > >> after upgrading the aacraid driver / kernel from aacraid 50792 to > >> aacraid 50877. > > > > The aacr

RE: [PATCH] scsi: qla4xxx: remove redundant check on drvr_wait

2018-09-27 Thread Rangankar, Manish
> -Original Message- > From: Colin King > Sent: Wednesday, September 26, 2018 6:39 PM > To: Dept-Eng QLogic Storage Upstream upstr...@cavium.com>; James E . J . Bottomley ; > Martin K . Petersen ; linux-scsi@vger.kernel.org > Cc: kernel-janit...@vger.kernel.org; linux-ker...@vger.kernel.

[PATCH] qedi: Initialize the stats mutex lock

2018-09-27 Thread Nilesh Javali
Fix kernel NULL pointer dereference, Call Trace: [] __mutex_lock_slowpath+0xa6/0x1d0 [] mutex_lock+0x1f/0x2f [] qedi_get_protocol_tlv_data+0x61/0x450 [qedi] [] ? map_vm_area+0x2e/0x40 [] ? __vmalloc_node_range+0x170/0x280 [] ? qed_mfw_process_tlv_req+0x27d/0xbd0 [qed] [] qed_mfw_fill

Re: aacraid: latest driver results in Host adapter abort request. / Outstanding commands on (0,0,0,0):

2018-09-27 Thread Stefan Priebe - Profihost AG
Am 27.09.2018 um 12:59 schrieb Emmanuel Florac: > Le Wed, 19 Sep 2018 08:10:41 +0200 > Stefan Priebe - Profihost AG écrivait: > >> Hello, >> >> after upgrading the aacraid driver / kernel from aacraid 50792 to >> aacraid 50877. >> >> I get aborted comands every night. >> > > I have exactly the

Re: [PATCH v6 7/7] scsi: ufs-bsg: Add support for uic commands in ufs_bsg_request()

2018-09-27 Thread Christoph Hellwig
> -ufshcd_send_uic_cmd(struct ufs_hba *hba, struct uic_command *uic_cmd) > +int ufshcd_send_uic_cmd(struct ufs_hba *hba, struct uic_command *uic_cmd) > { > int ret; > unsigned long flags; > @@ -2081,6 +2080,7 @@ static inline u8 ufshcd_get_upmcrs(struct ufs_hba *hba) > ufshcd_rel

[PATCH -next] scsi: ufs-qcom: Remove set but not used variable 'val'

2018-09-27 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/ufs/ufs-qcom.c: In function 'ufs_qcom_pwr_change_notify': drivers/scsi/ufs/ufs-qcom.c:919:6: warning: variable 'val' set but not used [-Wunused-but-set-variable] Signed-off-by: YueHaibing --- drivers/scsi/ufs/ufs-qcom.c | 3 --- 1 fil

Re: [PATCH v6 6/7] scsi: ufs-bsg: Add support for raw upiu in ufs_bsg_request()

2018-09-27 Thread Christoph Hellwig
> + case UPIU_TRANSACTION_QUERY_REQ: > + qr = &bsg_request->upiu_req.qr; > + if (qr->opcode == UPIU_QUERY_OPCODE_READ_DESC) > + goto not_supported; > + > + if (ufs_bsg_get_query_desc_size(hba, qr, &desc_len)) > + goto n

RE: [PATCH v6 6/7] scsi: ufs-bsg: Add support for raw upiu in ufs_bsg_request()

2018-09-27 Thread Avri Altman
> > > + case UPIU_TRANSACTION_QUERY_REQ: > > + qr = &bsg_request->upiu_req.qr; > > + if (qr->opcode == UPIU_QUERY_OPCODE_READ_DESC) > > + goto not_supported; > > + > > + if (ufs_bsg_get_query_desc_size(hba, qr, &desc_len)) > > + g

RE: [PATCH v6 7/7] scsi: ufs-bsg: Add support for uic commands in ufs_bsg_request()

2018-09-27 Thread Avri Altman
> > > -ufshcd_send_uic_cmd(struct ufs_hba *hba, struct uic_command *uic_cmd) > > +int ufshcd_send_uic_cmd(struct ufs_hba *hba, struct uic_command > *uic_cmd) > > { > > int ret; > > unsigned long flags; > > @@ -2081,6 +2080,7 @@ static inline u8 ufshcd_get_upmcrs(struct ufs_hba > *hba) > >

Re: [PATCH v4] scsi: ufs: Make sysfs attributes writable

2018-09-27 Thread Christoph Hellwig
On Thu, Sep 27, 2018 at 06:32:47AM +, Avri Altman wrote: > Also, in this context there is the series in > https://www.spinics.net/lists/linux-scsi/msg123479.html > which allows to send UPIUs via a bsg device. > > It's not a provisioning series per-se like Evan's and Sayali's. > It covers the

[PATCH] scsi: qla2xxx: I/Os timing out on surprise removal of

2018-09-27 Thread Bill Kuzeja
When removing an adapter through sysfs, some in flight I/Os can get stuck and take a while to complete (they actually timeout and are retried). We are not handling an early error exit from qla2xxx_eh_abort properly. Fixes: 45235022da99 ("scsi: qla2xxx: Fix driver unload by shutting down chip")

Re: [PATCH v6 3/7] scsi: ufs: Add ufs-bsg module

2018-09-27 Thread Christoph Hellwig
On Thu, Sep 27, 2018 at 06:16:44AM +, Avri Altman wrote: > In V6, we removed the host and device indices from the bsg device name, > But I have some seconds thoughts about it. > > We are using the bsg device in passthrough mode (bsg_transport_ops), > But the device name: "ufs-bsg" does not imp

Re: [PATCH v4 1/6] mpt3sas: Introduce mpt3sas_base_pci_device_is_available

2018-09-27 Thread Bjorn Helgaas
[+cc Ben, Russell, Sam, Oliver in case they have pertinent experience from powerpc error handling; thread begins at https://lore.kernel.org/linux-pci/1537935759-14754-1-git-send-email-suganath-prabu.subram...@broadcom.com/] On Thu, Sep 27, 2018 at 09:03:27AM +0200, Lukas Wunner wrote: > On Wed, Se

Re: [PATCH v4 1/6] mpt3sas: Introduce mpt3sas_base_pci_device_is_available

2018-09-27 Thread Lukas Wunner
On Thu, Sep 27, 2018 at 01:47:46PM -0500, Bjorn Helgaas wrote: > mpt3sas_wait_for_commands_to_complete(...) > { > ... > + if (!mpt3sas_base_pci_device_is_available(ioc)) > +return; > > # In the definitive case, we returned above. If we get here, we > # think the device *mig

Re: [PATCH 0/8] qla2xxx: Bug fixes for the driver

2018-09-27 Thread Ewan D. Milne
On Wed, 2018-09-26 at 22:05 -0700, Himanshu Madhani wrote: > Hi Martin, > > This series fixes issues found during out last test cycle. > > Patch 1,2 and 5 fixes misc NVMe discovery and unload hang in the driver. > > Patch 3 fixes issue discovered during BFS test setup resulting into > install

Re: [PATCH v4] scsi: ufs: Make sysfs attributes writable

2018-09-27 Thread Evan Green
On Thu, Sep 27, 2018 at 7:01 AM Christoph Hellwig wrote: > > On Thu, Sep 27, 2018 at 06:32:47AM +, Avri Altman wrote: > > Also, in this context there is the series in > > https://www.spinics.net/lists/linux-scsi/msg123479.html > > which allows to send UPIUs via a bsg device. > > > > It's not a

Re: [PATCH] scsi: bfa: Avoid implicit enum conversion in bfad_im_post_vendor_event

2018-09-27 Thread Nick Desaulniers
On Tue, Sep 25, 2018 at 9:58 PM Nathan Chancellor wrote: > > Clang warns when one enumerated type is implicitly converted to another. > > drivers/scsi/bfa/bfa_fcs_lport.c:379:26: warning: implicit conversion > from enumeration type 'enum bfa_lport_aen_event' to different > enumeration type 'enum b

Re: [PATCH] scsi: bfa: Avoid implicit enum conversion in bfad_im_post_vendor_event

2018-09-27 Thread Nathan Chancellor
On Thu, Sep 27, 2018 at 04:35:37PM -0700, Nick Desaulniers wrote: > On Tue, Sep 25, 2018 at 9:58 PM Nathan Chancellor > wrote: > > > > Clang warns when one enumerated type is implicitly converted to another. > > > > drivers/scsi/bfa/bfa_fcs_lport.c:379:26: warning: implicit conversion > > from enu

Re: [PATCH] scsi: qla2xxx: Fix comment in MODULE_PARM_DESC in qla2xxx

2018-09-27 Thread Martin K. Petersen
Masanari, > Default value of ql2xasynctmfenable for qla2xxx driver was set to 1 in > commit 043dc1d7e8501. But comment in MODULE_PARAM_DESC was not > modified. Applied to 4.20/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: qla2xxx: don't allow negative thresholds

2018-09-27 Thread Martin K. Petersen
Dan, > We shouldn't allow negative thresholds. I don't know what it would do > but it can't be good. Applied to 4.20/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

[PATCH v2] scsi: bfa: Avoid implicit enum conversion in bfad_im_post_vendor_event

2018-09-27 Thread Nathan Chancellor
Clang warns when one enumerated type is implicitly converted to another. drivers/scsi/bfa/bfa_fcs_lport.c:379:26: warning: implicit conversion from enumeration type 'enum bfa_lport_aen_event' to different enumeration type 'enum bfa_ioc_aen_event' [-Wenum-conversion]

Re: [PATCH] qedi: Initialize the stats mutex lock

2018-09-27 Thread Martin K. Petersen
Nilesh, > Fix kernel NULL pointer dereference, Applied to 4.19/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/8] qla2xxx: Bug fixes for the driver

2018-09-27 Thread Martin K. Petersen
Himanshu, > This series fixes issues found during out last test cycle. > > Patch 1,2 and 5 fixes misc NVMe discovery and unload hang in the driver. > > Patch 3 fixes issue discovered during BFS test setup resulting into > installation failure and hand because driver could not discover BFS Luns.

Re: [PATCH 00/10] NCR5380: Various improvements

2018-09-27 Thread Martin K. Petersen
Finn, > This series addresses issues which became apparent when Michael > Schmitz tried to use an AztecMonster II SATA/SCSI adapter with a 5380 > host. > > That target seems to have some bugs which thoroughly exercise driver > error paths and EH. > > The patch by Hannes Reinecke was cherry-picke