Re: [PATCH v2 03/17] compat_ioctl: use correct compat_ptr() translation in drivers

2018-09-13 Thread Felipe Balbi
Arnd Bergmann writes: > A handful of drivers all have a trivial wrapper around their ioctl > handler, but don't call the compat_ptr() conversion function at the > moment. In practice this does not matter, since none of them are used > on the s390 architecture and for all other architectures, comp

[PATCH RFC] scsi: ufs: Disable blk-mq for now

2018-09-13 Thread Adrian Hunter
blk-mq does not support runtime pm, so disable blk-mq support for now. Fixes: d5038a13eca7 ("scsi: core: switch to scsi-mq by default") Signed-off-by: Adrian Hunter --- drivers/scsi/ufs/ufshcd.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/u

Re: [PATCH RFC] scsi: ufs: Disable blk-mq for now

2018-09-13 Thread Ming Lei
On Thu, Sep 13, 2018 at 02:28:48PM +0300, Adrian Hunter wrote: > blk-mq does not support runtime pm, so disable blk-mq support for now. So could you describe a bit what the issue you are trying to fix? This is host level runtime PM you are trying to address, and if blk-mq runtime isn't enabled, I

[PATCH V3 01/17] blk-mq: allow to pass default queue flags for creating & initializing queue

2018-09-13 Thread Ming Lei
Prepare for converting the flag of BLK_MQ_F_NO_SCHED into per-queue flag, since the following patches need this way for supporting per-host admin queue. Cc: Alan Stern Cc: Christoph Hellwig Cc: Bart Van Assche Cc: Jianchao Wang Cc: Hannes Reinecke Cc: Johannes Thumshirn Cc: Adrian Hunter Cc

[PATCH V3 05/17] SCSI: try to retrieve request_queue via 'scsi_cmnd' if possible

2018-09-13 Thread Ming Lei
Prepare for introduing per-host admin queue. The most important part is that the request originated from admin queue can't be called back to the IO queue associated with scsi_device, especially, one request may be requeued, timedout or completed via block layer helper, so what we should do is to u

[PATCH V3 04/17] blk-mq: don't reserve tags for admin queue

2018-09-13 Thread Ming Lei
Not necessary to reserve tags for admin queue since there isn't many inflight commands in admin queue usually. This change won't starve admin queue too because each blocked queue has equal priority to get one new tag when one driver tag is released, no matter it is freed from any queue. So that I

[PATCH V3 06/17] SCSI: pass 'scsi_device' instance from 'scsi_request'

2018-09-13 Thread Ming Lei
This patch prepares for introducing SCSI per-host admin queue, which is only used for queuing admin requests, which are now submitted via __scsi_execute(). Cc: Alan Stern Cc: Christoph Hellwig Cc: Bart Van Assche Cc: Jianchao Wang Cc: Hannes Reinecke Cc: Johannes Thumshirn Cc: Adrian Hunter

[PATCH V3 03/17] block: rename QUEUE_FLAG_NO_SCHED as QUEUE_FLAG_ADMIN

2018-09-13 Thread Ming Lei
Now all users of QUEUE_FLAG_NO_SCHED is for admin queue only, and not see any drivers need this flag for IO queue. So rename it as QUEUE_FLAG_ADMIN, which looks more straightforward. Cc: Alan Stern Cc: Christoph Hellwig Cc: Bart Van Assche Cc: Jianchao Wang Cc: Hannes Reinecke Cc: Johannes T

[PATCH V3 07/17] SCSI: prepare for introducing admin queue for legacy path

2018-09-13 Thread Ming Lei
Uses scsi_is_admin_queue() and scsi_get_scsi_dev() to retrieve 'scsi_device' for legacy path. The same approach can be used in SCSI_MQ path too, just not very efficiently, and will deal with that in the patch when introducing admin queue for SCSI_MQ. Cc: Alan Stern Cc: Christoph Hellwig Cc: Bar

[PATCH V3 02/17] blk-mq: convert BLK_MQ_F_NO_SCHED into per-queue flag

2018-09-13 Thread Ming Lei
We need to support admin queue for scsi host, and not like NVMe, this support is only from logic view, and the admin queue still has to share same tags with IO queues. Convert BLK_MQ_F_NO_SCHED into per-queue flag so that we can support admin queue for SCSI. Cc: Alan Stern Cc: Christoph Hellwig

[PATCH V3 13/17] SCSI: use the dedicated admin queue to send admin commands

2018-09-13 Thread Ming Lei
Now the per-host dedicated admin queue is ready, so use this queue to send admin commands only. Cc: Alan Stern Cc: Christoph Hellwig Cc: Bart Van Assche Cc: Jianchao Wang Cc: Hannes Reinecke Cc: Johannes Thumshirn Cc: Adrian Hunter Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: l

[PATCH V3 11/17] SCSI: track pending admin commands

2018-09-13 Thread Ming Lei
Firstly we have to make sure that all pending admin commands to one same scsi_device are completed before removing the scsi_device. Secondly scsi_internal_device_block() needs this too. So introduce one waitqueue and atomic counter for this purpose. Cc: Alan Stern Cc: Christoph Hellwig Cc: Bar

[PATCH V3 14/17] SCSI: transport_spi: resume a quiesced device

2018-09-13 Thread Ming Lei
We have to preempt freeze queue in scsi_device_quiesce(), and unfreeze in scsi_device_resume(), so call scsi_device_resume() for the device which is quiesced by scsi_device_quiesce(). Cc: Alan Stern Cc: Christoph Hellwig Cc: Bart Van Assche Cc: Jianchao Wang Cc: Hannes Reinecke Cc: Johannes T

[PATCH V3 09/17] SCSI: don't set .queuedata in scsi_mq_alloc_queue()

2018-09-13 Thread Ming Lei
.queuedata is set in scsi_alloc_sdev() for both non-mq and scsi_mq, so not necessary to do it in scsi_mq_alloc_queue(). Cc: Alan Stern Cc: Christoph Hellwig Cc: Bart Van Assche Cc: Jianchao Wang Cc: Hannes Reinecke Cc: Johannes Thumshirn Cc: Adrian Hunter Cc: "James E.J. Bottomley" Cc: "Ma

[PATCH V3 10/17] SCSI: deal with admin queue busy

2018-09-13 Thread Ming Lei
When request originated from admin queue isn't queued successfully, we deal with it just like for normal requests, that said the admin queue will be rerun after one request in this host is completed. Cc: Alan Stern Cc: Christoph Hellwig Cc: Bart Van Assche Cc: Jianchao Wang Cc: Hannes Reinecke

[PATCH V3 12/17] SCSI: create admin queue for each host

2018-09-13 Thread Ming Lei
The created admin queue will be used to send internal admin commands, so we can simplify the sync between some admin commands and IO requests, typical examples are system suspend and runtime PM. Cc: Alan Stern Cc: Christoph Hellwig Cc: Bart Van Assche Cc: Jianchao Wang Cc: Hannes Reinecke Cc:

[PATCH V3 08/17] SCSI: pass scsi_device to scsi_mq_prep_fn

2018-09-13 Thread Ming Lei
This patchset will introduce per-host admin queue, so it may not to get 'scsi_device' via q->queuedata. Cc: Alan Stern Cc: Christoph Hellwig Cc: Bart Van Assche Cc: Jianchao Wang Cc: Hannes Reinecke Cc: Johannes Thumshirn Cc: Adrian Hunter Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen

[PATCH V3 17/17] block: enable runtime PM for blk-mq

2018-09-13 Thread Ming Lei
Now blk-mq can borrow the runtime PM approach from legacy path, so enable it simply. The only difference with legacy is that: 1) blk_mq_queue_sched_tag_busy_iter() is introduced for checking if queue is idle, instead of maintaining one counter. 2) we have to iterate over scheduler tags for counti

[PATCH V3 15/17] SCSI: use admin queue to implement queue QUIESCE

2018-09-13 Thread Ming Lei
All admin commands are sent via per-host admin queue, so we can simply freeze the IO queue for quiescing scsi device. Also the current SCSI stack guarantees that any request originated from admin queue won't be called back to block layer via the associated IO queue, and it is always dealt with by

[PATCH V3 16/17] block: simplify runtime PM support

2018-09-13 Thread Ming Lei
This patch simplifies runtime PM support by the following approach: 1) resume device in blk_queue_enter() if this device is runtime-suspended or runtime-suspending 2) freeze queue in blk_pre_runtime_suspend() 3) unfreeze queue in blk_pre_runtime_resume() 4) remove checking on RRF_PM because now

Re: [PATCH RFC] scsi: ufs: Disable blk-mq for now

2018-09-13 Thread Adrian Hunter
On 13/09/18 15:05, Ming Lei wrote: > On Thu, Sep 13, 2018 at 02:28:48PM +0300, Adrian Hunter wrote: >> blk-mq does not support runtime pm, so disable blk-mq support for now. > > So could you describe a bit what the issue you are trying to fix? UFS is a low-power solution, so we must be able to ru

Re: [PATCH RFC] scsi: ufs: Disable blk-mq for now

2018-09-13 Thread Ming Lei
On Thu, Sep 13, 2018 at 03:15:39PM +0300, Adrian Hunter wrote: > On 13/09/18 15:05, Ming Lei wrote: > > On Thu, Sep 13, 2018 at 02:28:48PM +0300, Adrian Hunter wrote: > >> blk-mq does not support runtime pm, so disable blk-mq support for now. > > > > So could you describe a bit what the issue you

Re: [PATCH V3 11/17] SCSI: track pending admin commands

2018-09-13 Thread jianchao.wang
Hi Ming On 09/13/2018 08:15 PM, Ming Lei wrote: > EXPORT_SYMBOL(__scsi_execute); > @@ -3246,6 +3251,7 @@ static int scsi_internal_device_block(struct > scsi_device *sdev) > else > scsi_wait_for_queuecommand(sdev); > } > + wait_event(sdev->admin_wq, !

Re: [PATCH] scsi: sd: Contribute to randomness when running rotational device

2018-09-13 Thread Maciej Żenczykowski
On Sun, Sep 9, 2018 at 4:52 AM, Ming Lei wrote: > On Thu, Sep 06, 2018 at 01:37:19PM -0700, Xuewei Zhang wrote: >> Currently a scsi device won't contribute to kernel randomness when it >> uses blk-mq. Since we commonly use scsi on rotational device with >> blk-mq, it make sense to keep contributin

Re: [PATCH RFC] scsi: ufs: Disable blk-mq for now

2018-09-13 Thread Adrian Hunter
On 14/09/18 04:52, Ming Lei wrote: > On Thu, Sep 13, 2018 at 03:15:39PM +0300, Adrian Hunter wrote: >> On 13/09/18 15:05, Ming Lei wrote: >>> On Thu, Sep 13, 2018 at 02:28:48PM +0300, Adrian Hunter wrote: blk-mq does not support runtime pm, so disable blk-mq support for now. >>> >>> So could y

Re: [PATCH -next] scsi: pm80xx: Remove set but not used variable 'device_id'

2018-09-13 Thread Jinpu Wang
On Thu, Sep 13, 2018 at 3:44 AM YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/scsi/pm8001/pm8001_sas.c: In function > 'pm8001_I_T_nexus_event_handler': > drivers/scsi/pm8001/pm8001_sas.c:1052:6: warning: > variable 'device_id' set but not used [-Wunused-but-set

[PATCH v9 0/7] Support for Qualcomm UFS QMP PHY on SDM845

2018-09-13 Thread Can Guo
This patch series adds support for UFS QMP PHY on SDM845 and the compatible string for it. This patch series depends on the current proposed QMP V3 USB3 UNI PHY support for sdm845 driver [1], on the DT bindings for the QMP V3 USB3 PHYs based dirver [2], and also rebased on updated pipe_clk initiali

[PATCH v9 0/7] Support for Qualcomm UFS QMP PHY on SDM845

2018-09-13 Thread Can Guo
This patch series adds support for UFS QMP PHY on SDM845 and the compatible string for it. This patch series depends on the current proposed QMP V3 USB3 UNI PHY support for sdm845 driver [1], on the DT bindings for the QMP V3 USB3 PHYs based dirver [2], and also rebased on updated pipe_clk initiali

Re: [Patch v1 0/7] mpt3sas: Hot-Plug Surprise removal support on IOC.

2018-09-13 Thread Lukas Wunner
On Wed, Sep 12, 2018 at 03:31:07PM +0530, Sreekanth Reddy wrote: > On Wed, Sep 5, 2018 at 1:08 PM, Lukas Wunner wrote: > > On Wed, Sep 05, 2018 at 11:45:45AM +0530, Sreekanth Reddy wrote: > > > I have one more instance where still we need this poll kthread, i.e > > > during the device probe time w

Edit your photos 11

2018-09-13 Thread Jimmy
Hi, We are waiting for your photos. Please send photos to hansre...@outlook.com for further editing. Our team is ready to edit your photos. Do you have photos for editing? We are team who can do following work for you. Cutting out your photos, or retouching if needed. It is for products photos

[PATCH] scsi: csiostor: remove automatic irq affinity assignment

2018-09-13 Thread Varun Prakash
If number of interrupt vectors are more than num_online_cpus() then pci_alloc_irq_vectors_affinity() assigns cpumask based on num_possible_cpus() to the remaining vectors because of this interrupts are not generating for these vectors. This patch fixes this issue by using pci_alloc_irq_vectors() i

[PATCH] scsi : cxgb4i: add DCB support for iSCSI connections

2018-09-13 Thread Varun Prakash
Add IEEE and CEE DCBX support for iSCSI connections. Signed-off-by: Rohit Maheshwari Signed-off-by: Varun Prakash --- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 154 - drivers/scsi/cxgbi/libcxgbi.h | 3 + 2 files changed, 156 insertions(+), 1 deletion(-) di

Re: [PATCH] lpfc: Synchronize access to remoteport via rport

2018-09-13 Thread James Smart
On 9/12/2018 4:28 PM, James Smart wrote: The driver currently uses the ndlp to get the local rport which is then used to get the nvme transport remoteport pointer. There can be cases where a stale remoteport pointer is obtained as synchronization isn't done through the different dereferences. Co

[PATCH v2] lpfc: Synchronize access to remoteport via rport

2018-09-13 Thread James Smart
The driver currently uses the ndlp to get the local rport which is then used to get the nvme transport remoteport pointer. There can be cases where a stale remoteport pointer is obtained as synchronization isn't done through the different dereferences. Correct by using locks to synchronize the der

Re: [PATCH v5] target/iblock: split T10 PI SGL across command bios

2018-09-13 Thread Mike Christie
On 09/04/2018 12:19 PM, Greg Edwards wrote: > When T10 PI is enabled on a backing device for the iblock backstore, the > PI SGL for the entire command is attached to the first bio only. This > works fine if the command is covered by a single bio, but can result in > ref tag errors in the client fo

[PATCH -next] scsi: pm80xx: Remove set but not used variable 'page_code'

2018-09-13 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/pm8001/pm80xx_hwi.c: In function 'pm8001_set_phy_profile': drivers/scsi/pm8001/pm80xx_hwi.c:4679:6: warning: variable 'page_code' set but not used [-Wunused-but-set-variable] Signed-off-by: YueHaibing --- drivers/scsi/pm8001/pm80xx_hw

[PATCH -next] scsi: mptfusion: Use kmemdup rather than duplicating its implementation in mpt_remove_dead_ioc_func

2018-09-13 Thread YueHaibing
Use kmemdup rather than duplicating its implementation Signed-off-by: YueHaibing --- drivers/message/fusion/mptbase.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c index dc1e43a..a32d3d0 100644 --- a/driv

[PATCH -next] [SCSI] aic7xxx: Use kmemdup rather than duplicating its implementation in ahc_loadseq

2018-09-13 Thread YueHaibing
Use kmemdup rather than duplicating its implementation Signed-off-by: YueHaibing --- drivers/scsi/aic7xxx/aic7xxx_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c b/drivers/scsi/aic7xxx/aic7xxx_core.c index f3362f4..8549f1e 10064

[PATCH -next] [SCSI] aic79xx: Use kmemdup rather than duplicating its implementation in ahd_loadseq

2018-09-13 Thread YueHaibing
Use kmemdup rather than duplicating its implementation Signed-off-by: YueHaibing --- drivers/scsi/aic7xxx/aic79xx_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c b/drivers/scsi/aic7xxx/aic79xx_core.c index 9ee75c9..0970bb5 10064

Compliment of the day to you Dear Friend.

2018-09-13 Thread Mrs. Amina Kadi
Compliment of the day to you Dear Friend. Dear Friend. I am Mrs. Amina Kadi. am sending this brief letter to solicit your partnership to transfer $5.5 million US Dollars. I shall send you more information and procedures when I receive positive response from you. Mrs. Amina Kadi