Re: [PATCH] scsi_transport_srp: Fix shost to rport translation

2018-04-13 Thread Bart Van Assche
On Fri, 2018-04-13 at 08:11 +0200, Hannes Reinecke wrote: > On Thu, 12 Apr 2018 13:32:07 -0600 > "Bart Van Assche" wrote: > > +static int find_child_rport(struct device *dev, void *data) > > +{ > > + struct device **child = data; > > + > > + if (scsi_is_srp_rport(dev)) { > > + WARN_O

Only boots with CONFIG_SCSI_MQ_DEFAULT=y

2018-04-13 Thread J William Piggott
Hello, please cc me I'm not subscribed. Beginning with commit 64d513ac "scsi: use host wide tags by default" my system will ONLY boot with CONFIG_SCSI_MQ_DEFAULT=y. Tested through git-stable master (0adb328 v4.16). It never gets far enough to log anything, but here are a few boot messages that I

Re: [PATCH] target: Fix Fortify_panic kernel exception

2018-04-13 Thread Christoph Hellwig
The patch looks fine, but in general I think descriptions of what you fixed in the code or more important than starting out with a backtrace. E.g. please explain what was wrong, how you fixed it and only after that mention how it was caught. (preferably without the whole trace)

Re: [PATCH v2] block: ratelimite pr_err on IO path

2018-04-13 Thread Martin K. Petersen
Jinpu, [CC:ed the mpt3sas maintainers] The ratelimit patch is just an attempt to treat the symptom, not the cause. > Thanks for asking, we updated mpt3sas driver which enables DIX support > (prot_mask=0x7f), all disks are SATA SSDs, no DIF support. > After reboot, kernel reports the IO errors f

Re: [PATCHv2] tcmu: allow userspace to reset netlink

2018-04-13 Thread Mike Christie
On 04/12/2018 10:08 PM, Xiubo Li wrote: > >>> + >>> +if (val != 1) { >>> +pr_err("Invalid block value %d\n", val); >> I think you wanted >> >> "Invalid reset value %d\n" > Yeah, just copied it from other place. >> >>> +return -EINVAL; >>> +} >>> + >>> +spin_unlock(&udev

RE: [Resend Patch 3/3] Storvsc: Select channel based on available percentage of ring buffer to write

2018-04-13 Thread Michael Kelley (EOSG)
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org > On Behalf > Of Long Li > Sent: Tuesday, March 27, 2018 5:49 PM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen > Hemminger ; James E . J . Bottomley > ; > Martin K . Petersen ; > de...@linuxdriverproject.org; linux- > s.

RE: [Resend Patch 2/3] Netvsc: Use the vmbus functiton to calculate ring buffer percentage

2018-04-13 Thread Michael Kelley (EOSG)
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org > On Behalf > Of Long Li > Sent: Tuesday, March 27, 2018 5:49 PM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen > Hemminger ; James E . J . Bottomley > ; > Martin K . Petersen ; > de...@linuxdriverproject.org; linux- > s.

Re: [PATCHv2] tcmu: allow userspace to reset netlink

2018-04-13 Thread Xiubo Li
On 2018/4/14 1:21, Mike Christie wrote: On 04/12/2018 10:08 PM, Xiubo Li wrote: + +if (val != 1) { +pr_err("Invalid block value %d\n", val); I think you wanted "Invalid reset value %d\n" Yeah, just copied it from other place. +return -EINVAL; +} + +spin_unlock(&ud

RE: [Resend Patch 3/3] Storvsc: Select channel based on available percentage of ring buffer to write

2018-04-13 Thread Long Li
> Subject: RE: [Resend Patch 3/3] Storvsc: Select channel based on available > percentage of ring buffer to write > > > -Original Message- > > From: linux-kernel-ow...@vger.kernel.org > > On Behalf Of Long Li > > Sent: Tuesday, March 27, 2018 5:49 PM > > To: KY Srinivasan ; Haiyang Zhang