Re: [PATCH v2 net-next 3/4] qed*: Utilize FW 8.33.1.0

2017-12-27 Thread kbuild test robot
Hi Tomer, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Tomer-Tayar/qed-Refactoring-and-rearranging-FW-API-with-no-functional-impact/20171227-110607 config: i386-randconfig-h0-12271326 (attached as

RE: [PATCH 2/2 v4] scsi: ufs: introduce sysfs entries exposing UFS health info

2017-12-27 Thread Avri Altman
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Greg Kroah-Hartman > Sent: Thursday, December 21, 2017 10:00 AM > To: Jaegeuk Kim > Cc: linux-ker...@vger.kernel.org; linux-scsi@vger.kernel.org; Jaegeuk Kim > > Subje

Re: You will definetely be interested...

2017-12-27 Thread Sra. Angel Rania
Hi Dear, Reading your profile has given me courage in search of a reasponsable and trust worthy Fellow. The past has treated me so awfully but now I am ready to move on despite of my health condition. I will like to have a sincere and important discussion with you that will be in your favor likewi

Re: [PATCH 00/28] aacraid: Refactor for sas transport and bug fixes

2017-12-27 Thread Guilherme G. Piccoli
On 12/26/2017 11:27 PM, Raghava Aditya Renukunta wrote: > [...] >> I was thinking...if possible, and just in case you plan to send a V2 >> after Bart's comments (or any other future reviews this patchset gets), >> how about splitting in 2 patchsets, one for bug fixes and the other for >> improvemen

Re: [PATCH 2/2 v4] scsi: ufs: introduce sysfs entries exposing UFS health info

2017-12-27 Thread Greg Kroah-Hartman
On Wed, Dec 27, 2017 at 09:00:10AM +, Avri Altman wrote: > > > > -Original Message- > > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > > ow...@vger.kernel.org] On Behalf Of Greg Kroah-Hartman > > Sent: Thursday, December 21, 2017 10:00 AM > > To: Jaegeuk Kim > > Cc: lin

[PATCH v1 0/9] ufs: sysfs: read-only access to device descriptors, attributes and flags

2017-12-27 Thread Stanislav Nijnikov
This patch introduces sysfs entries that will provide read-only access to device management data that could be received with UFS query requests. User-space applications will be able to read UFS device descriptors, flags and attributes. This will allow to get full UFS device configuration and its st

[PATCH v1 7/9] ufs: sysfs: unit descriptor

2017-12-27 Thread Stanislav Nijnikov
In addition the patch presents an additional field in the scsi_host_template structure - struct attribute_group **sdev_group. This field allows to define groups of attributes. It will provide an ability to use binary attributes in addition to device attributes and to group them under subfolders if

[PATCH v1 1/9] ufs: sysfs: device descriptor

2017-12-27 Thread Stanislav Nijnikov
Signed-off-by: Stanislav Nijnikov --- Documentation/ABI/testing/sysfs-driver-ufs | 223 + drivers/scsi/ufs/Makefile | 2 +- drivers/scsi/ufs/ufs-sysfs.c | 158 drivers/scsi/ufs/ufs-sysfs.h | 10 ++ dr

[PATCH v1 9/9] ufs: sysfs: attributes

2017-12-27 Thread Stanislav Nijnikov
Signed-off-by: Stanislav Nijnikov --- Documentation/ABI/testing/sysfs-driver-ufs | 141 - drivers/scsi/ufs/ufs-sysfs.c | 90 ++ drivers/scsi/ufs/ufs-sysfs.h | 1 + drivers/scsi/ufs/ufs.h | 27 +- d

[PATCH v1 8/9] ufs: sysfs: flags

2017-12-27 Thread Stanislav Nijnikov
Signed-off-by: Stanislav Nijnikov --- Documentation/ABI/testing/sysfs-driver-ufs | 65 ++ drivers/scsi/ufs/ufs-sysfs.c | 42 +++ drivers/scsi/ufs/ufs.h | 14 +-- drivers/scsi/ufs/ufshcd.c | 1 + 4

[PATCH v1 6/9] ufs: sysfs: string descriptors

2017-12-27 Thread Stanislav Nijnikov
Signed-off-by: Stanislav Nijnikov --- Documentation/ABI/testing/sysfs-driver-ufs | 39 drivers/scsi/ufs/ufs-sysfs.c | 58 ++ drivers/scsi/ufs/ufshcd.c | 5 +-- drivers/scsi/ufs/ufshcd.h | 3 ++ 4 fi

[PATCH v1 5/9] ufs: sysfs: power descriptor

2017-12-27 Thread Stanislav Nijnikov
Signed-off-by: Stanislav Nijnikov --- Documentation/ABI/testing/sysfs-driver-ufs | 10 +++ drivers/scsi/ufs/ufs-sysfs.c | 121 + 2 files changed, 131 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-driver-ufs b/Documentation/ABI/testing/sysf

[PATCH v1 3/9] ufs: sysfs: geometry descriptor

2017-12-27 Thread Stanislav Nijnikov
Signed-off-by: Stanislav Nijnikov --- Documentation/ABI/testing/sysfs-driver-ufs | 175 - drivers/scsi/ufs/ufs-sysfs.c | 84 ++ drivers/scsi/ufs/ufs.h | 36 ++ 3 files changed, 294 insertions(+), 1 deletion(-) diff -

[PATCH v1 4/9] ufs: sysfs: health descriptor

2017-12-27 Thread Stanislav Nijnikov
Signed-off-by: Stanislav Nijnikov --- Documentation/ABI/testing/sysfs-driver-ufs | 28 drivers/scsi/ufs/ufs-sysfs.c | 20 drivers/scsi/ufs/ufs.h | 11 +++ drivers/scsi/ufs/ufshcd.c | 8 ++

[PATCH v1 2/9] ufs: sysfs: interconnect descriptor

2017-12-27 Thread Stanislav Nijnikov
Signed-off-by: Stanislav Nijnikov --- Documentation/ABI/testing/sysfs-driver-ufs | 19 +++ drivers/scsi/ufs/ufs-sysfs.c | 18 ++ drivers/scsi/ufs/ufs.h | 8 3 files changed, 45 insertions(+) diff --git a/Documentation/AB

Re: [PATCH v1 1/9] ufs: sysfs: device descriptor

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 03:49:28PM +0200, Stanislav Nijnikov wrote: > Signed-off-by: Stanislav Nijnikov > --- I never want to take a patch with no changelog text at all, and to have a 9 patch series with nothing written in them at all? That's not good. Please fix up. greg k-h

[PATCH v2 3/9] ufs: sysfs: geometry descriptor

2017-12-27 Thread Stanislav Nijnikov
This patch introduces a sysfs group entry for the UFS geometry descriptor parameters. The group adds "geometry_descriptor" folder under the UFS driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The parameters are shown as hexadecimal numbers. The full information about the parameters could b

[PATCH v2 0/9] ufs: sysfs: read-only access to device descriptors, attributes and flags

2017-12-27 Thread Stanislav Nijnikov
This patch introduces sysfs entries that will provide read-only access to device management data that could be received with UFS query requests. User-space applications will be able to read UFS device descriptors, flags and attributes. This will allow to get full UFS device configuration and its st

[PATCH v2 7/9] ufs: sysfs: unit descriptor

2017-12-27 Thread Stanislav Nijnikov
This patch introduces a sysfs group entry for the UFS unit descriptor parameters. The group adds "unit_descriptor" folder under the corresponding SCSI device sysfs entry (/sys/class/scsi_device/*/device/). The parameters are shown as hexadecimal numbers. The full information about the parameters co

[PATCH v2 9/9] ufs: sysfs: attributes

2017-12-27 Thread Stanislav Nijnikov
This patch introduces a sysfs group entry for the UFS attributes. The group adds "attributes" folder under the UFS driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The attributes are shown as hexadecimal numbers. The full information about the attributes could be found at UFS specifications

[PATCH v2 6/9] ufs: sysfs: string descriptors

2017-12-27 Thread Stanislav Nijnikov
This patch introduces a sysfs group entry for the UFS string descriptors. The group adds "string_descriptors" folder under the UFS driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The folder will contain 5 files that will show string values defined by the UFS spec: a manufacturer name, a pr

[PATCH v2 8/9] ufs: sysfs: flags

2017-12-27 Thread Stanislav Nijnikov
This patch introduces a sysfs group entry for the UFS flags. The group adds "flags" folder under the UFS driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The flags are shown as boolean value ("true" or "false"). The full information about the UFS flags could be found at UFS specifications 2

[PATCH v2 5/9] ufs: sysfs: power descriptor

2017-12-27 Thread Stanislav Nijnikov
This patch introduces a sysfs group entry for the UFS power descriptor parameters. The group adds "power_descriptor" folder under the UFS driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The parameters are shown as hexadecimal numbers. The full information about the parameters could be foun

[PATCH v2 4/9] ufs: sysfs: health descriptor

2017-12-27 Thread Stanislav Nijnikov
This patch introduces a sysfs group entry for the UFS health descriptor parameters. The group adds "health_descriptor" folder under the UFS driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The parameters are shown as hexadecimal numbers. The full information about the parameters could be fo

[PATCH v2 1/9] ufs: sysfs: device descriptor

2017-12-27 Thread Stanislav Nijnikov
This patch introduces a sysfs group entry for the UFS device descriptor parameters. The group adds "device_descriptor" folder under the UFS driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The parameters are shown as hexadecimal numbers. The full information about the parameters could be fo

[PATCH v2 2/9] ufs: sysfs: interconnect descriptor

2017-12-27 Thread Stanislav Nijnikov
This patch introduces a sysfs group entry for the UFS interconnect descriptor parameters. The group adds "interconnect_descriptor" folder under the UFS driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The parameters are shown as hexadecimal numbers. The full information about the parameters

Re: [PATCH v2 1/9] ufs: sysfs: device descriptor

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 05:13:39PM +0200, Stanislav Nijnikov wrote: > +EXPORT_SYMBOL(ufs_sysfs_add_device_management); Whhy is this exported? What external module uses it? > + > +void ufs_sysfs_remove_device_management(struct ufs_hba *hba) > +{ > + sysfs_remove_groups(&hba->dev->kobj, ufs_sy

Re: [PATCH v2 1/9] ufs: sysfs: device descriptor

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 05:13:39PM +0200, Stanislav Nijnikov wrote: > diff --git a/drivers/scsi/ufs/ufs-sysfs.c b/drivers/scsi/ufs/ufs-sysfs.c > new file mode 100644 > index 000..63a8e68 > --- /dev/null > +++ b/drivers/scsi/ufs/ufs-sysfs.c > @@ -0,0 +1,158 @@ > +#include > +#include > + > +#i

Re: [PATCH v2 2/9] ufs: sysfs: interconnect descriptor

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 05:13:40PM +0200, Stanislav Nijnikov wrote: > This patch introduces a sysfs group entry for the UFS interconnect > descriptor parameters. The group adds "interconnect_descriptor" folder > under the UFS driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). > The parameters

Re: [PATCH v2 3/9] ufs: sysfs: geometry descriptor

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 05:13:41PM +0200, Stanislav Nijnikov wrote: > This patch introduces a sysfs group entry for the UFS geometry descriptor > parameters. The group adds "geometry_descriptor" folder under the UFS > driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The parameters > are sho

Re: [PATCH v2 4/9] ufs: sysfs: health descriptor

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 05:13:42PM +0200, Stanislav Nijnikov wrote: > This patch introduces a sysfs group entry for the UFS health descriptor > parameters. The group adds "health_descriptor" folder under the UFS driver > sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The parameters are shown > a

[PATCH 10/12] hpsa: drop unneeded newline

2017-12-27 Thread Julia Lawall
hpsa_show_dev_msg prints other information and a newline after the message string, so the message string does not need to include a newline explicitly. Done using Coccinelle. Signed-off-by: Julia Lawall --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH 00/12] drop unneeded newline

2017-12-27 Thread Julia Lawall
Drop newline at the end of a message string when the printing function adds a newline. The complete semantic patch that detects this issue is as shown below (http://coccinelle.lip6.fr/). It works in two phases - the first phase counts how many uses of a function involve a newline and how many don

Re: [PATCH v2 5/9] ufs: sysfs: power descriptor

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 05:13:43PM +0200, Stanislav Nijnikov wrote: > This patch introduces a sysfs group entry for the UFS power descriptor > parameters. The group adds "power_descriptor" folder under the UFS driver > sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The parameters are shown > as

Re: [PATCH v2 7/9] ufs: sysfs: unit descriptor

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 05:13:45PM +0200, Stanislav Nijnikov wrote: > This patch introduces a sysfs group entry for the UFS unit descriptor > parameters. The group adds "unit_descriptor" folder under the corresponding > SCSI device sysfs entry (/sys/class/scsi_device/*/device/). The parameters > ar

Re: [PATCH v2 8/9] ufs: sysfs: flags

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 05:13:46PM +0200, Stanislav Nijnikov wrote: > This patch introduces a sysfs group entry for the UFS flags. The group adds > "flags" folder under the UFS driver sysfs entry > (/sys/bus/platform/drivers/ufshcd/*). The flags are shown as boolean value > ("true" or "false"). The

Re: [PATCH v2 9/9] ufs: sysfs: attributes

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 05:13:47PM +0200, Stanislav Nijnikov wrote: > This patch introduces a sysfs group entry for the UFS attributes. The > group adds "attributes" folder under the UFS driver sysfs entry > (/sys/bus/platform/drivers/ufshcd/*). The attributes are shown > as hexadecimal numbers. Th

Re: [PATCH v2 6/9] ufs: sysfs: string descriptors

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 05:13:44PM +0200, Stanislav Nijnikov wrote: > This patch introduces a sysfs group entry for the UFS string descriptors. > The group adds "string_descriptors" folder under the UFS driver > sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The folder will contain > 5 files tha

[PATCH v4 net-next 0/4] qed*: Advance to FW 8.33.1.0

2017-12-27 Thread Tomer Tayar
This series advances all qed* drivers to use firmware 8.33.1.0 which brings new capabilities and initial support of new HW. The changes are mostly in qed, and include changes in the FW interface files, as well as updating the FW initialization and debug collection code. The protocol drivers have mi

[PATCH v4 net-next 4/4] qed*: Advance drivers' version to 8.33.0.20

2017-12-27 Thread Tomer Tayar
Signed-off-by: Ariel Elior Signed-off-by: Chad Dupuis Signed-off-by: Manish Rangankar Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qed/qed.h | 8 drivers/net/ethernet/qlogic/qede/qede.h | 6 +++--- drivers/scsi/qedf/qedf_version.h| 8 drivers/scsi/qedi

[PATCH v2] target: add a target/iscsi driver-api Documentation chapter

2017-12-27 Thread Randy Dunlap
From: Randy Dunlap Add a driver-api document for target/iSCSI interfaces. Signed-off-by: Randy Dunlap --- This patch depends on 4 previous patches to driver source files: [PATCH] target: fix kernel-doc warnings in drivers/target/target_core_transport.c https://marc.info/?l=linux-scsi&m=151

[PATCH] mpt3sas: Proper handling of set/clear of "ATA command pending" flag.

2017-12-27 Thread Chaitra P B
1.In IO path, setting of "ATA command pending" flag early before device removal, invalid device handle etc., checks causes any new commands to be always returned with SAM_STAT_BUSY and when the driver removes the drive the SML issues SYNC Cache command and that command is always returned with S