Re: [PATCH] scsi: Always retry internal target error

On 10/18/2017 08:34 AM, Christoph Hellwig wrote: > On Wed, Oct 18, 2017 at 08:15:46AM +0200, Hannes Reinecke wrote: >>> It's decidedly awful to have vendor/model-specific triggers in >>> scsi_error. >>> >>> What are the drawbacks of just always refiring on AC/0x44/ITF? >>> >> Hmm. 'Internal target

Re: [PATCH V4 0/9] pm80xx updates

On Wed, Oct 18, 2017 at 8:09 AM, Viswas G wrote: > > This patch set include some bug fixes and enhancement for pm80xx driver. > > Changes from V3: > - Fixed kbuild warnings for patch 4 and 5. > > Changes from V2: > - Corrected date. > > Changes from V1: > - sas_identify_fra

Re: [PATCH v2 0/5] qcom-ufs: phy/hcd: Refactor phy initialization code

On Thursday 12 October 2017 11:49 AM, Vivek Gautam wrote: > Refactoring the qcom-ufs phy and host controller code to move > further towards the generic phy usage. Right now the qcom-ufs exports > a bunch of APIs that are used by the host controller to initialize > the phy. > With this patch serie

Re: [PATCH V8 5/5] libata: Align DMA buffer to dma_get_cache_alignment()

On Tue, Oct 17, 2017 at 04:05:42PM +0800, Huacai Chen wrote: > In non-coherent DMA mode, kernel uses cache flushing operations to > maintain I/O coherency, so in ata_do_dev_read_id() the DMA buffer > should be aligned to ARCH_DMA_MINALIGN. Otherwise, If a DMA buffer > and a kernel structure share a

Re: [PATCH v2 12/15] RDMA/cma: make config_item_type const

On Mon, 2017-10-16 at 17:18 +0200, Bhumika Goyal wrote: > Make these structures const as they are either passed to the > functions > having the argument as const or stored as a reference in the > "ci_type" > const field of a config_item structure. > > Signed-off-by: Bhumika Goyal Acked-by: Doug

Re: [PATCH v10 00/10] block, scsi, md: Improve suspend and resume

On Wed, 2017-10-18 at 07:02 +0200, Oleksandr Natalenko wrote: > I've indeed tested some previous versions of this patchset, but still use > Ming's solution. > > Can it be clarified which one (Bart's or Ming's) is a correct approach? Hello Oleksandr, I think this version (v10) has significant ad

Re: [PATCH v2 02/15] usb: gadget: make config_item_type structures const

Hi Bhumika, Thank you for the patch. On Monday, 16 October 2017 18:18:41 EEST Bhumika Goyal wrote: > Make these structures const as they are only passed to the const > argument of the functions config_{group/item}_init_type_name. > > Signed-off-by: Bhumika Goyal > --- > * Changes in v2- Combine

Patch: add to Documentation/scsi for scsi_dev_flags and command line passing

Tired of forgetting about this so documented it for others so they also don't spend unnecessary time figuring this out. Signed-off-by: Laurence Oberman diff --git a/Documentation/scsi/scsi-parameters.txt b/Documentation/scsi/scsi-parameters.txt index 8477655..c9e9ce8 100644 --- a/Documentation/s

Re: [PATCH V8 1/5] dma-mapping: Rework dma_get_cache_alignment()

On Tue, Oct 17, 2017 at 04:05:38PM +0800, Huacai Chen wrote: > Make dma_get_cache_alignment() to accept a 'dev' argument. As a result, > it can return different alignments due to different devices' I/O cache > coherency. > > Currently, ARM/ARM64 and MIPS support coherent & noncoherent devices > co

Re: Patch: add to Documentation/scsi for scsi_dev_flags and command line passing

On 10/18/17 10:13, Laurence Oberman wrote: > Tired of forgetting about this so documented it for others so they also > don't spend unnecessary time figuring this out. > > Signed-off-by: Laurence Oberman > > diff --git a/Documentation/scsi/scsi-parameters.txt > b/Documentation/scsi/scsi-parameter

Re: Patch: add to Documentation/scsi for scsi_dev_flags and command line passing

On 10/18/17 10:28, Laurence Oberman wrote: > I just noticed that > Was taken straight out of git after changing the Doc file. > Let me see why git did that > It's more likely that Evolution did it. > > On Wed, Oct 18, 2017 at 1:25 PM, Randy Dunlap > wrote: > >

Re: Patch: add to Documentation/scsi for scsi_dev_flags and command line passing

Indeed it was Evolution and then linux-scsi rejected my fix. Trying again, for some reason it thought I had html Signed-off-by: Laurence Oberman --- a/Documentation/scsi/scsi-parameters.txt +++ b/Documentation/scsi/scsi-parameters.txt @@ -116,3 +116,11 @@ parameters may be changed at runtime by

Re: [PATCH V8 5/5] libata: Align DMA buffer to dma_get_cache_alignment()

> This function is called only for the PIO mode commands, so I doubt this > is > necessary... That is true but there are platforms out there that issue disk level PIO commands via DMA (or can do so). Indeed the Cyrix MediaGX could do that in the 1990s but I never add support 8) So I think i

Re: [PATCH v2 6/8] scsi/ipr: Use sgl_alloc_order() and sgl_free_order()

On 10/17/2017 01:19 AM, Hannes Reinecke wrote: > On 10/17/2017 12:49 AM, Bart Van Assche wrote: >> Use the sgl_alloc_order() and sgl_free_order() functions instead >> of open coding these functions. >> >> Signed-off-by: Bart Van Assche >> Reviewed-by: Johannes Thumshirn >> Cc: linux-scsi@vger.ker

Re: Patch: add to Documentation/scsi for scsi_dev_flags and command line passing

Laurence, > Indeed it was Evolution and then linux-scsi rejected my fix. Please use git send-email for patch submissions. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: Handle power-on reset unit attention

Hannes, > As per SAM there is a status precedence, with any sense code 29/XX > taking second place just after an ACA ACTIVE status. Additionally, > each target might prefer to not queue any unit attention conditions, > but just report one. Due to the above this will be that one with the > highe

Re: [PATCH V4 0/9] pm80xx updates

Viswas, > This patch set include some bug fixes and enhancement for pm80xx > driver. Applied to 4.15/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] sd: Micro-optimize READ / WRITE CDB encoding

On 2017-10-17 06:41 PM, Bart Van Assche wrote: On Tue, 2017-10-17 at 18:17 -0400, Douglas Gilbert wrote: On 2017-10-17 05:03 PM, Bart Van Assche wrote: @@ -1025,7 +1025,6 @@ static int sd_setup_read_write_cmnd(struct scsi_cmnd *SCpnt) struct gendisk *disk = rq->rq_disk; struct