On Wed, 16 Aug 2017, Arvind Yadav wrote:
> pnp_device_id are not supposed to change at runtime. All functions
> working with pnp_device_id provided by work with
> const pnp_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav
Acked-by: Finn Thain
> ---
> driver
On Thu, Aug 10, 2017 at 11:06:04AM +0200, Christoph Hellwig wrote:
> > @@ -463,9 +472,9 @@ static struct nvmet_fc_fcp_iod *
> > nvmet_fc_alloc_fcp_iod(struct nvmet_fc_tgt_queue *queue)
> > {
> > static struct nvmet_fc_fcp_iod *fod;
>
> This isn't new, but is this really supposed to be a stat
From: Colin Ian King
Trivial fix to variable name, sfp_additonal_info should be
sfp_additional_info (add in missing i).
Signed-off-by: Colin Ian King
---
drivers/scsi/qla2xxx/qla_isr.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/
On Mon, Aug 14, 2017 at 06:32:17PM +0200, Benjamin Block wrote:
> > - blk_end_request_all(rq, BLK_STS_OK);
> > -
> > put_device(job->dev); /* release reference for the request */
> >
> > kfree(job->request_payload.sg_list);
> > kfree(job->reply_payload.sg_list);
> > - kfree(job);
On 14/08/17 18:21, Bart Van Assche wrote:
> On Sun, 2017-08-13 at 19:44 +0200, Christoph Hellwig wrote:
>> Defaulting to scsi-mq in 4.13-rc has shown various regressions
>> on setups that we didn't previously consider. Fixes for them are
>> in progress, but too invasive to make it in this cycle.
>-Original Message-
>From: Hannes Reinecke [mailto:h...@suse.de]
>Sent: Tuesday, August 15, 2017 5:36 PM
>To: Martin K. Petersen
>Cc: Christoph Hellwig; James Bottomley; Sumit Saxena; Kashyap Desai;
>megaraidlinux@broadcom.com; linux-scsi@vger.kernel.org; Hannes
>Reinecke
>Subject: [PAT
>-Original Message-
>From: Hannes Reinecke [mailto:h...@suse.de]
>Sent: Tuesday, August 15, 2017 5:29 PM
>To: Martin K. Petersen
>Cc: Christoph Hellwig; James Bottomley; Sumit Saxena; Kashyap Desai;
>megaraidlinux@broadcom.com; linux-scsi@vger.kernel.org; Hannes
>Reinecke; Hannes Reinec
On 08/16/2017 03:05 PM, Sumit Saxena wrote:
>> -Original Message-
>> From: Hannes Reinecke [mailto:h...@suse.de]
>> Sent: Tuesday, August 15, 2017 5:29 PM
>> To: Martin K. Petersen
>> Cc: Christoph Hellwig; James Bottomley; Sumit Saxena; Kashyap Desai;
>> megaraidlinux@broadcom.com; lin
If nud_state is not valid then call neigh_event_send()
to update MAC address.
Signed-off-by: Varun Prakash
---
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
index a69a9ac..1d02cf9
For an unknown reason this patch causes the boot process to hang on
PowerPC systems:
sd 0:2:0:0: [sda] 272646144 512-byte logical blocks: (140 GB/130 GiB)
sd 0:2:0:0: [sda] 4096-byte physical blocks
sd 0:2:0:0: [sda] Write Protect is off
INFO: task swapper/5:1 blocked for more than 120 seconds.
A couple of minor fixes (st, ses) and some bigger driver fixes for
qla2xxx (crash triggered by fw dump) and ipr (lockdep problems with
mq).
The patch is available here:
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes
The short changelog is:
Bodo Stroesser (1):
scsi:
Hi list,
some time ago, I had a filesystem corruption on a simple, two disks
RAID1 MD array. On the affected machine, /var/log/messages shown some
"failed command: WRITE FPDMA QUEUED" entries, but *no* action (ie: kick
off disk) was taken by MDRAID. I tracked down the problem to an instable
po
Hannes,
> I still would like to keep the above, as the admin can feed blacklist
> flags via the kernel commandline, and we don't do any validity checks on
> that. So we might end up with invalid flags after all.
I suggest you handle this by printing something along the lines of
"INVALID_BIT_SET(
Bart,
> For an unknown reason this patch causes the boot process to hang on
> PowerPC systems:
OK, dropped it from fixes for now.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Varun,
> If nud_state is not valid then call neigh_event_send() to update MAC
> address.
Applied to 4.13/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Hannes,
> here's now the third attempt to add support for legacy boards, ie for
> boards previously supported by cciss only. With this patchset the
> hpsa driver should work with all Smart Array boards if the
> 'hpsa_allow_any' module option is set, rendering the cciss driver
> obsolete. Conseq
Hannes,
> The error code from a scsi_execute_req() is a SCSI status, not
> a normal errno. So whenever it returns a value here an error
> occurred and there's no point in looking at the page number.
424f727b9413 scsi: ses: Fix wrong page error
--
Martin K. Petersen Oracle Linux Engineerin
Hannes,
> some arrays (most notably 3Par) only support simple subenclosures.
> Sadly our ses implementation doesn't handle this properly, so we're
> greeted with error messages like:
>
> scsi 1:0:0:254: Wrong diagnostic page; asked for 2 got 0
> scsi 1:0:0:254: Failed to get diagnostic page 0xfff
Colin,
> An optional discovery status should be printed with a pr_cont and
> needs a leading space to make it more readable. The final new line
> should also be a pr_cont and the indentation is out by one, so fix
> that too.
Applied to 4.14/scsi-queue.
--
Martin K. Petersen Oracle Linux E
Dan,
> If i is negative then it's less than OS_FM_TAB_MAX so we read before
> the start of the STp->header_cache->dat_fm_tab.fm_tab_ent[] array.
Applied to 4.14/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> Trivial fix to variable name, sfp_additonal_info should be
> sfp_additional_info (add in missing i).
Applied to 4.14/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Martin,
On 8/17/17 09:11, Martin K. Petersen wrote:
>
> Bart,
>
>> For an unknown reason this patch causes the boot process to hang on
>> PowerPC systems:
>
> OK, dropped it from fixes for now.
>
> Thanks!
It means that commit 70e42fd02c46e2aa9ab07b766d418637e3a51de7 "scsi:
sd_zbc: Write unlo
Chad,
> Please apply the following patches at your earliest convenience.
Applied to 4.14/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
Martin,
On 8/17/17 09:41, Damien Le Moal wrote:
> Martin,
>
> On 8/17/17 09:11, Martin K. Petersen wrote:
>>
>> Bart,
>>
>>> For an unknown reason this patch causes the boot process to hang on
>>> PowerPC systems:
>>
>> OK, dropped it from fixes for now.
>>
>> Thanks!
>
> It means that commit 70
Damien,
> It means that commit 70e42fd02c46e2aa9ab07b766d418637e3a51de7 "scsi:
> sd_zbc: Write unlock zone from sd_uninit_cmnd()" will need to be
> reverted too as it will not solve the potential deadlock anymore. Bart's
> patch was needed for it to work.
OK, also dropped.
> (2) may actually be
Damien,
> Actually, we can keep that commit as it makes the sq case cleaner
> anyway. But we need something else to prevent deadlock in the mq
> case...
OK, put it back.
Please send a lockout patch. We can always zap it if we find out what
went wrong with Bart's patch and queue a "real" fix.
-
Arvind,
> pnp_device_id are not supposed to change at runtime. All functions
> working with pnp_device_id provided by work with
> const pnp_device_id. So mark the non-const structs as const.
Applied to 4.14/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Hannes,
> struct scsi_changer needs refcounting as the device might be removed
> while the fd is still open.
Applied to 4.14/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
weiping,
> if scsi_host_template->host_reset is NULL, when user "echo adapter >
> /sys/class/scsi_host/hostx/host_reset", -EINVAL will return even
> string compare successfully. It make user confuse.
>
> change to:
> -EINVAL if string not match "adapter" / "firmware";
> -EOPNOTSUPP
On Wed, 2017-08-16 at 20:52 -0400, Martin K. Petersen wrote:
> Damien,
>
> > Actually, we can keep that commit as it makes the sq case cleaner
> > anyway. But we need something else to prevent deadlock in the mq
> > case...
>
> OK, put it back.
>
> Please send a lockout patch. We can always zap
Bart,
> I'm 99% sure there is nothing wrong with my patch but that my patch
> uncovered a bug in the ipr driver (drivers/scsi/ipr). See also
> "WARNING: CPU: 15 PID: 0 at block/blk-mq.c:
> __blk_mq_run_hw_queue+0x1d8/0x1f0F"
> (https://marc.info/?l=linux-block&m=150290686719644).
But I alrea
Tom,
> Some devices may not be decent enough to report lbpme bit properly
> even when they do support unmap and report relevant information in the
> block limits and logical block provisioning VPDs properly (Namely,
> ASMedia ASM1351, a UAS-SATA bridge). One of the reasons is, lbpme=1 is
> not a
On Wed, 2017-08-16 at 22:00 -0400, Martin K. Petersen wrote:
> Bart,
>
> > I'm 99% sure there is nothing wrong with my patch but that my patch
> > uncovered a bug in the ipr driver (drivers/scsi/ipr). See also
> > "WARNING: CPU: 15 PID: 0 at block/blk-mq.c:
> > __blk_mq_run_hw_queue+0x1d8/0x1f
blk-mq may not maintain write requests order at dispatch time. So host
managed drives will not reliably work. Worse, potential reordering of
write requests on requeue may cause the zone write locking code to
deadlock command dispatch to the disk. So for now, until the write
ordering issue is fixed,
Bart,
> When I checked earlier today the ipr patch was not yet in linux-next
That's weird. They were both committed two weeks ago.
They appear to be in there now, though:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/drivers/scsi?ofs=50
--
Martin K. Petersen Or
On Thu, 2017-08-10 at 13:46 -0500, Don Brace wrote:
> From: Kevin Barnett
To misspell someone else's company name could be considered unfortunate
... to misspell your own looks like carelessness.
You've done this twice, by the way.
James
> Reviewed-by: Scott Benesh
> Signed-off-by: Kevin Barn
36 matches
Mail list logo
