Re: [PATCH 0/6] constify pci_error_handlers structures

2017-08-12 Thread Christoph Hellwig
On Sat, Aug 12, 2017 at 07:44:28AM +0200, Julia Lawall wrote: > These pci_error_handlers structures are only stored in the err_handler > field of a pci_driver structure, and this field is declared as const. Thus > the pci_error_handlers structures can be const too. > > Done with the help of Cocci

Re: [PATCH 0/6] constify pci_error_handlers structures

2017-08-12 Thread Julia Lawall
On Sat, 12 Aug 2017, Christoph Hellwig wrote: > On Sat, Aug 12, 2017 at 07:44:28AM +0200, Julia Lawall wrote: > > These pci_error_handlers structures are only stored in the err_handler > > field of a pci_driver structure, and this field is declared as const. Thus > > the pci_error_handlers stru

Re: [PATCH 0/6] constify pci_error_handlers structures

2017-08-12 Thread Christoph Hellwig
On Sat, Aug 12, 2017 at 09:52:28AM +0200, Julia Lawall wrote: > OK, sure. So to be precise, you want the fields error_detected, > mmio_enabled, etc to be added as new fields to the pci_driver structure? Yes. > They both have a resume field, though. What should the pci_error_handlers > resume fu

Re: [PATCH 0/6] constify pci_error_handlers structures

2017-08-12 Thread Julia Lawall
On Sat, 12 Aug 2017, Christoph Hellwig wrote: > On Sat, Aug 12, 2017 at 09:52:28AM +0200, Julia Lawall wrote: > > OK, sure. So to be precise, you want the fields error_detected, > > mmio_enabled, etc to be added as new fields to the pci_driver structure? > > Yes. > > > They both have a resume f

Re: [PATCH 0/6] constify pci_error_handlers structures

2017-08-12 Thread Julia Lawall
Another issue arises in the files drivers/infiniband/hw/hfi1/pcie.c and drivers/infiniband/hw/qib/qib_pcie.c, where the pci_error_handlers structure is defined in one file and used in another file. The structure definition references various functions that are static in the same file. Should I try

[GIT PULL] target fixes for v4.13-rc5

2017-08-12 Thread Nicholas A. Bellinger
Hi Linus, Here are the target-pending fixes for v4.13-rc5. Please go ahead and pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master The highlights include: - Fix iscsi-target payload memory leak during ISCSI_FLAG_TEXT_CONTINUE (Varun Prakash) - Fix tcm_qla

[PATCH] scsi: pmcraid: fix duplicated code for different branches

2017-08-12 Thread Gustavo A. R. Silva
Refactor code in order to avoid identical code for different branches. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- This code was tested by compilation only. drivers/scsi/pmcraid.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff

RE: [PATCH 3/6] scsi: aacraid: constify pci_error_handlers structures

2017-08-12 Thread Dave Carroll
> > These pci_error_handlers structures are only stored in the err_handler field > of a > pci_driver structure, and this field is declared as const. Thus the > pci_error_handlers structures can be const too. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > dri