On Fri, Aug 11, 2017 at 5:33 AM, Martin K. Petersen
wrote:
>
> Vivek,
>
>> Can you kindly review this patch series (for UFS controller changes)
>> and consider giving your Ack so that Kishon can pull in the series
>> through phy tree.
>
> SCSI piece looks OK.
Thank you Martin for your review.
>
>
On Thu, Aug 10, 2017 at 09:08:49PM +0200, Helge Deller wrote:
> On parisc I see this UBSAN warning with a sym53c896:
>
> UBSAN: Undefined behaviour in ./drivers/scsi/sym53c8xx_2/sym_hipd.c:762:24
> index -1903078336 is out of range for type 'u32 [7]'
>
> Avoid this warning by switching to dev64
[+ Martin and linux-scsi]
Given that we need this big pile and a few bfq fixes to avoid
major regressesions I'm tempted to revert the default to scsi-mq
for 4.14, but bring it back a little later for 4.15.
What do you think? Maybe for 4.15 we could also do it through the
block tree where all the
I apologize if this message should reach you twice, I'm having trouble with the
original mail account.
Since the problem is fixed it didn't seem necessary to me to say that, but I
later recalled what was different that could have caused the problem. I used a
SATA to USB controller and while the
My point was that we now gurantee that that the sense data is not
a stack pointer an a driver can DMA to it. Now for BSG the sense
data is "just" abused as reply, but the point still stands - we
don't want to pass a possible stack pointer to drivers in a data
buffer because we want to allow DMA to
But patch 1 still creates an additional copy of the sense data for
all bsg users.
Can you test the patch below which implements my suggestion? Your
other patches should still apply fine on top modulo minor context
changes.
---
>From 4cd32ee48e334b62b55bff0d380833b978454040 Mon Sep 17 00:00:00 20
внимания;
Ваши сообщения превысил лимит памяти, который составляет 5 Гб, определенных
администратором, который в настоящее время работает на 10.9GB, Вы не сможете
отправить или получить новую почту, пока вы повторно не проверить ваш почтовый
ящик почты. Чтобы восстановить работоспособность Ва
On 8.8.2017 10:35, Hannes Reinecke wrote:
> Older Controller might not support volume status, so assume
> the volume is online here.
>
> Signed-off-by: Hannes Reinecke
> ---
> drivers/scsi/hpsa.c | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/scsi/hpsa.c b/drivers/s
Since the problem is fixed it didn't seem necessary to me to say that, but I
later recalled what was different that could have caused the problem. I used a
SATA to USB controller and while the disk was mounted and read from, I noticed
that the SATA wasn't correctly plugged in (although it worked
The following shows in dmesg when the USB side is plugged in:
usb 1-3: new high-speed USB device number 5 using xhci_hcd
usb 1-3: New USB device found, idVendor=174c, idProduct=55aa
usb 1-3: New USB device strings: Mfr=2, Product=3, SerialNumber=1
usb 1-3: Product: ASM1153 USB3.0 TO SATA
usb 1-3:
On Fri, Aug 11, 2017 at 11:14:15AM +0200, Christoph Hellwig wrote:
> But patch 1 still creates an additional copy of the sense data for
> all bsg users.
>
Huh? What additional copy? There is one reply-buffer and that is copied
into the user-buffer should it contain valid data. Just like in your
pa
On 10/08/2017 23:41, Michael S. Tsirkin wrote:
>>> Then we probably should fail probe if vq size is too small.
>> What does this mean?
>
> We must prevent driver from submitting s/g lists > vq size to device.
What is the rationale for the limit? It makes no sense if indirect
descriptors are avai
Reformat blacklist flags to make the values easier to read and
to enhance error checking.
Signed-off-by: Hannes Reinecke
---
include/scsi/scsi_devinfo.h | 77 ++---
1 file changed, 51 insertions(+), 26 deletions(-)
diff --git a/include/scsi/scsi_devinfo.h
the SCSI blacklist handling seems to be rather tricky issue;
everytime a fix is included it tends to break other devices.
This patchset attempt to simplify the devlist handling yet again,
but this time implementing the framework for regression testing, too.
A patch adding a regression test to the b
Signed-off-by: Hannes Reinecke
---
drivers/scsi/scsi_devinfo.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index 28fea83..776c701 100644
--- a/drivers/scsi/scsi_devinfo.c
+++
When checking the model and vendor string we need to use the
minimum value of either string, otherwise we'll miss out on
wildcard matches.
And we should take card when matching with zero size strings;
results might be unpredictable.
With this patch the rules for matching devinfo strings are
as foll
For testing purposes we need to be able to pass in the inquiry
vendor and model.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/scsi_debug.c | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index
Each scsi device is scanned according to the found blacklist flags,
but this information is never presented to sysfs.
This makes it quite hard to figure out if blacklisting worked as
expected.
With this patch we're exporting an additional attribute 'blacklist'
containing the blacklist flags for thi
On Fri, 2017-08-11 at 01:11 -0700, Christoph Hellwig wrote:
> [+ Martin and linux-scsi]
>
> Given that we need this big pile and a few bfq fixes to avoid
> major regressesions I'm tempted to revert the default to scsi-mq
> for 4.14, but bring it back a little later for 4.15.
>
> What do you think
On Fri, Aug 11, 2017 at 03:49:29PM +0200, Benjamin Block wrote:
> On Fri, Aug 11, 2017 at 11:14:15AM +0200, Christoph Hellwig wrote:
> > But patch 1 still creates an additional copy of the sense data for
> > all bsg users.
> >
>
> Huh? What additional copy? There is one reply-buffer and that is co
On Fri, 11 Aug 2017, Hannes Reinecke wrote:
> When checking the model and vendor string we need to use the
> minimum value of either string, otherwise we'll miss out on
> wildcard matches.
You really should fix this sentence.
> And we should take card when matching with zero size strings;
> resu
On Fri, Aug 11, 2017 at 04:36:49PM +0200, Christoph Hellwig wrote:
> On Fri, Aug 11, 2017 at 03:49:29PM +0200, Benjamin Block wrote:
> > On Fri, Aug 11, 2017 at 11:14:15AM +0200, Christoph Hellwig wrote:
> > > But patch 1 still creates an additional copy of the sense data for
> > > all bsg users.
>
On Fri, Aug 11, 2017 at 05:32:03PM +0200, Benjamin Block wrote:
> So when the bsg interface is used with something different than the
> bsg-lib request queue?
Yes.
> I haven't actually thought about that (presuming
> the bsg-lib queue was the only one being used). Fair enough, I haven't
> complet
On Fri, 2017-08-11 at 11:05 +1000, Michael Ellerman wrote:
> kworker/u193:0 D12736 6 2 0x0800
> Workqueue: events_unbound async_run_entry_fn
> Call Trace:
> [c003f7597410] [c0150d00] console_unlock+0x330/0x770 (unreliable)
> [c003f75975e0] [c001b3b8] __switch_t
On Fri, Aug 11, 2017 at 05:35:53PM +0200, Christoph Hellwig wrote:
> On Fri, Aug 11, 2017 at 05:32:03PM +0200, Benjamin Block wrote:
> > So when the bsg interface is used with something different than the
> > bsg-lib request queue?
>
> Yes.
>
> > I haven't actually thought about that (presuming
>
> -Original Message-
> From: Hannes Reinecke [mailto:h...@suse.de]
> Sent: Friday, August 11, 2017 1:43 AM
> To: Don Brace ; James Bottomley
> ; Christoph Hellwig
>
> Cc: Martin K. Petersen ; Meelis Roos
> ; linux-scsi@vger.kernel.org
> Subject: Re: [PATCH RESEND 0/6] hpsa: support legacy
Greetings from Mr. Abdul Karim
Assalamu`Alaikum.
My Name is Mr. Abdul Karim I am a banker by profession. I'm from
Ouagadougou, Burkina Faso, West Africa. My reason for contacting you
is to transfer an abandoned $15.5M to your account.
The owner of this fund died since 2004 with his Next Of Kin.
On Fri, Aug 11, 2017 at 04:09:26PM +0200, Paolo Bonzini wrote:
> On 10/08/2017 23:41, Michael S. Tsirkin wrote:
> >>> Then we probably should fail probe if vq size is too small.
> >> What does this mean?
> >
> > We must prevent driver from submitting s/g lists > vq size to device.
>
> What is the
On 11/08/2017 19:23, Michael S. Tsirkin wrote:
> On Fri, Aug 11, 2017 at 04:09:26PM +0200, Paolo Bonzini wrote:
>> On 10/08/2017 23:41, Michael S. Tsirkin wrote:
> Then we probably should fail probe if vq size is too small.
What does this mean?
>>>
>>> We must prevent driver from submittin
These pci_error_handlers structures are only stored in the err_handler
field of a pci_driver structure, and this field is declared as const. Thus
the pci_error_handlers structures can be const too.
Done with the help of Coccinelle.
---
drivers/misc/genwqe/card_base.c |2 +-
drivers/sc
These pci_error_handlers structures are only stored in the err_handler
field of a pci_driver structure, and this field is declared as const. Thus
the pci_error_handlers structures can be const too.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/scsi/bfa/bfad.c |
These pci_error_handlers structures are only stored in the err_handler
field of a pci_driver structure, and this field is declared as const. Thus
the pci_error_handlers structures can be const too.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/scsi/csiostor/csio_in
These pci_error_handlers structures are only stored in the err_handler
field of a pci_driver structure, and this field is declared as const. Thus
the pci_error_handlers structures can be const too.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/scsi/mpt3sas/mpt3sas_
These pci_error_handlers structures are only stored in the err_handler
field of a pci_driver structure, and this field is declared as const. Thus
the pci_error_handlers structures can be const too.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/scsi/be2iscsi/be_main
These pci_error_handlers structures are only stored in the err_handler
field of a pci_driver structure, and this field is declared as const. Thus
the pci_error_handlers structures can be const too.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/scsi/aacraid/linit.c
35 matches
Mail list logo
