On 02/14/2017 08:15 PM, Christoph Hellwig wrote:
> This gives us a clear state even if a command didn't return sense data.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/scsi/scsi_common.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/scsi_commo
On 02/14/2017 08:15 PM, Christoph Hellwig wrote:
> Remove bogus evaluations of retval and sshdr when the device is offline,
> and fix a possible NULL pointer dereference by allocating the 8 byte
> sized sense header on stack.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/scsi/sd.c | 25 ++
On 02/14/2017 09:44 PM, Raghava Aditya Renukunta wrote:
> Replaced camel case with snake case for init supported options.
>
> Suggested-by: Johannes Thumshirn
> Signed-off-by: Raghava Aditya Renukunta
>
> Reviewed-by: David Carroll
> ---
\o/
Bonus-points-awarded-by: Johannes Thumshirn
Revie
On 02/14/2017 09:44 PM, Raghava Aditya Renukunta wrote:
> The channel being used for raw srb commands is retrieved from the utility
> sent fibs and is converted into physical channel id. The driver does not
> need to to do this since the management utility sends the correct channel
> id in the firs
On 02/14/2017 09:44 PM, Raghava Aditya Renukunta wrote:
> This issue showed up on a kdump debug(single CPU on powerkvm), when EEH
> errors rendered the adapter unusable. The driver correctly detected the
> issue and attempted to restart the controller, in doing so the driver
> attempted to read the
On Tue, Feb 07, 2017 at 02:19:09PM +0100, Christoph Hellwig wrote:
> Patch 1-7 look fine to me with minor fixups, and I'd love to see
> them go into 4.11.
Any chance to see a resend of these?
On 02/15/2017 09:15 AM, Christoph Hellwig wrote:
> On Tue, Feb 07, 2017 at 02:19:09PM +0100, Christoph Hellwig wrote:
>> Patch 1-7 look fine to me with minor fixups, and I'd love to see
>> them go into 4.11.
>
> Any chance to see a resend of these?
>
Sure.
Will do shortly.
Cheers,
Hannes
--
D
On 02/14/2017 08:15 PM, Christoph Hellwig wrote:
> Hi all,
>
> this series is on top of the scsi_request changes in Jens' tree and
> further improves the handling of the sense buffer.
>
Sorry, but I'm feeling really daft: which scsi_request changes?
To be found in which tree?
I dimly remember see
On 02/14/2017 09:44 PM, Raghava Aditya Renukunta wrote:
> Arrconf management utility at times sends fibs with AdapterProcessed set
> in its fibs. This causes the controller to panic and lockup.
>
> Fixed by failing the commands that have AdapterProcessed set in its flag.
>
> Signed-off-by: Raghav
On Mon, Feb 13, 2017 at 6:41 PM, Hannes Reinecke wrote:
> On 02/13/2017 07:15 AM, Sreekanth Reddy wrote:
>> On Fri, Feb 10, 2017 at 12:29 PM, Hannes Reinecke wrote:
>>> On 02/10/2017 05:43 AM, Sreekanth Reddy wrote:
On Thu, Feb 9, 2017 at 6:42 PM, Hannes Reinecke wrote:
> On 02/09/2017
On 02/14/2017 09:44 PM, Raghava Aditya Renukunta wrote:
> aac_fib_map_free frees misaligned fib dma memory, additionally it does not
> free up the whole memory.
>
> Fixed by changing the code to free up the correct and full memory
> allocation.
>
> Cc: sta...@vger.kernel.org
> Fixes: e8b12f0fb83
On 02/14/2017 09:44 PM, Raghava Aditya Renukunta wrote:
> Added support to retrieve driver version from a new sysfs variable called
> driver_version. It makes it easier for the user to figure out the driver
> version that is currently running.
>
> Signed-off-by: Raghava Aditya Renukunta
>
> Revi
On 02/14/2017 09:44 PM, Raghava Aditya Renukunta wrote:
> After controller shutdown, all sync fibs time out due to not knowing
> about the switch to INT-x mode
>
> Fixed by replacing aac_src_access_devreg() to aac_set_intx_mode() call.
>
> Cc: sta...@vger.kernel.org
> Fixes: 495c021767bd78c998 (a
On 02/14/2017 09:44 PM, Raghava Aditya Renukunta wrote:
> aac_command_thread checks on the health of controller periodically,
> using aac_check_health. If the status is an error state KERNEL_PANIC or
> anything else. The driver will attempt to restart the adapter, but the
> response is not checked
On 02/14/2017 09:44 PM, Raghava Aditya Renukunta wrote:
> During the IOP reset stress testing, it was found that the drives can be
> marked offline when the adapter controller crashes and IO's are running
> in parallel. When the controller does come back from the reset, the drive
> that is marked
On 02/14/2017 09:44 PM, Raghava Aditya Renukunta wrote:
> When the command thread performs a periodic time sync and the firmware is
> going through an assert during that time, the command thread waits for the
> response that would never arrive. The SCSI Mid layer's error handler would
> eventually
On 02/14/2017 09:44 PM, Raghava Aditya Renukunta wrote:
> Currently driver checks the health status of the adapter once every 24
> hours. When that happens the driver becomes dependent on the kernel to
> figure out if the adapter is misbehaving. This might take some time
> (when the adapter is idl
On 02/14/2017 09:44 PM, Raghava Aditya Renukunta wrote:
> When the SMART family of controller panic (KERNEL_PANIC) , they do not
^ controllers?^ extra space
> honor IOP resets. So better to skip it and directly perform a IWBR reset.
>
> Signed-off-by: Ra
On 02/14/2017 09:44 PM, Raghava Aditya Renukunta wrote:
> The driver currently checks the SELF_TEST_FAILED first and then
> KERNEL_PANIC next. Under error conditions(boot code failure) both
> SELF_TEST_FAILED and KERNEL_PANIC can be set at the same time.
>
> The driver has the capability to reset
On 02/14/2017 09:44 PM, Raghava Aditya Renukunta wrote:
> Currently the adapter firmware does not save outstanding I/O's log
> information when an IOP reset is triggered. This is problematic when
> trying to root cause and debug issues.
>
> Fixed by adding sync command to trigger I/O log file sa
On 02/14/2017 09:44 PM, Raghava Aditya Renukunta wrote:
> Updated driver version to 50792
>
> Signed-off-by: Raghava Aditya Renukunta
>
> Reviewed-by: David Carroll
> ---
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.
On 02/14/2017 09:44 PM, Raghava Aditya Renukunta wrote:
> The driver does not unlock the reply queue spin lock after handling SMART
> adapter events. Instead it might attempt to unlock an already unlocked
> spin lock.
>
> Fixed by making sure the driver locks the spin lock before freeing it.
>
>
>
>
> Hannes,
>
> Result I have posted last time is with merge operation enabled in block
> layer. If I disable merge operation then I don't see much improvement
> with
> multiple hw request queues. Here is the result,
>
> fio results when nr_hw_queues=1,
> 4k read when numjobs=24: io=248387MB, bw=
On 02/15/2017 10:18 AM, Kashyap Desai wrote:
>>
>>
>> Hannes,
>>
>> Result I have posted last time is with merge operation enabled in block
>> layer. If I disable merge operation then I don't see much improvement
>> with
>> multiple hw request queues. Here is the result,
>>
>> fio results when nr_h
Hi James,
This patch set adds support for NVME over Fabrics FC transport
to lpfc
The internals of the driver are reworked to support being either:
a SCSI initiator;
a NVME intiator;
both a SCSI initiator and a NVME initiator;
or a NVME target.
The driver effectively has parallel NVME and S
>-Original Message-
>From: Arnd Bergmann [mailto:a...@arndb.de]
>Sent: Wednesday, February 15, 2017 2:52 AM
>To: James E.J. Bottomley; Martin K. Petersen
>Cc: Arnd Bergmann; Kashyap Desai; Sumit Saxena; Shivasharan S; Tomas
Henzl;
>Hannes Reinecke; Sasikumar Chandrasekaran;
>megaraidlinux..
>-Original Message-
>From: Arnd Bergmann [mailto:a...@arndb.de]
>Sent: Wednesday, February 15, 2017 2:52 AM
>To: James E.J. Bottomley; Martin K. Petersen
>Cc: Arnd Bergmann; Kashyap Desai; Sumit Saxena; Shivasharan S; Tomas
Henzl;
>Hannes Reinecke; Sasikumar Chandrasekaran;
>megaraidlinux..
>-Original Message-
>From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
>Sent: Tuesday, February 14, 2017 10:09 PM
>To: Kashyap Desai; Shivasharan S
>Cc: Sumit Saxena; James E.J. Bottomley; Martin K. Petersen;
>megaraidlinux@broadcom.com; linux-scsi@vger.kernel.org; kernel-
>janit...
From: "Dupuis, Chad"
Dave, please apply the qed patch to net-next at your earliest convenience.
Martin, the qed patch needs to be applied first as the qedf patch is dependent
on the FCoE bits in the first qed driver patch.
This series introduces the hardware offload FCoE initiator driver for the
From: Arun Easi
This adds the backbone required for the various HW initalizations
which are necessary for the FCoE driver (qedf) for QLogic FastLinQ
4 line of adapters - FW notification, resource initializations, etc.
Signed-off-by: Arun Easi
Signed-off-by: Yuval Mintz
---
drivers/net/eth
On Wed, Feb 15, 2017 at 09:19:18AM +0100, Hannes Reinecke wrote:
> On 02/14/2017 08:15 PM, Christoph Hellwig wrote:
> > Hi all,
> >
> > this series is on top of the scsi_request changes in Jens' tree and
> > further improves the handling of the sense buffer.
> >
> Sorry, but I'm feeling really da
On Wed, 2017-02-15 at 11:12 +0900, Damien Le Moal wrote:
> + resid = round_up(resid, sector_size);
> + if (resid < good_bytes)
> + good_bytes -= resid;
> + else
> + good_bytes = 0;
>
On Wed, 2017-02-15 at 16:04 +0100, Christoph Hellwig wrote:
> On Wed, Feb 15, 2017 at 09:19:18AM +0100, Hannes Reinecke wrote:
> > On 02/14/2017 08:15 PM, Christoph Hellwig wrote:
> > > Hi all,
> > >
> > > this series is on top of the scsi_request changes in Jens' tree and
> > > further improves t
On 2/15/2017 2:12 AM, Sagi Grimberg wrote:
The patches were cut against 1/30 scsi.git tree, misc branch.
** THEY ARE INTENDED FOR THE SCSI.GIT TREE, MISC BRANCH **
The lpfc version in the linux-block.git tree is rather old. I have a
recipe for how to get it to a version that syncs with the
On Wed, 2017-02-15 at 11:12 +0900, Damien Le Moal wrote:
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> index 1f5d92a..d05a328 100644
> --- a/drivers/scsi/sd.c
> +++ b/drivers/scsi/sd.c
> @@ -1790,6 +1790,8 @@ static int sd_done(struct scsi_cmnd *SCpnt)
> {
> int result = SCpnt->resu
> On 02/14/2017 09:44 PM, Raghava Aditya Renukunta wrote:
> > This issue showed up on a kdump debug(single CPU on powerkvm), when
> EEH
> > errors rendered the adapter unusable. The driver correctly detected the
> > issue and attempted to restart the controller, in doing so the driver
> > attemp
> -Original Message-
> From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
> Sent: Wednesday, February 15, 2017 12:20 AM
> To: Raghava Aditya Renukunta
> ; j...@linux.vnet.ibm.com;
> martin.peter...@oracle.com; linux-scsi@vger.kernel.org
> Cc: Dave Carroll ; Gana Sridaran
> ; Scott Benes
> -Original Message-
> From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
> Sent: Wednesday, February 15, 2017 12:32 AM
> To: Raghava Aditya Renukunta
> ; j...@linux.vnet.ibm.com;
> martin.peter...@oracle.com; linux-scsi@vger.kernel.org
> Cc: Dave Carroll ; Gana Sridaran
> ; Scott Benes
On Fri, 2017-02-03 at 19:38 +, Colin King wrote:
> From: Colin Ian King
>
> On an allocation failure of gd, the current exit path is via out_free_devt
> which leaves sdpk still allocated and hence it gets leaked. Fix this by
> correcting the order of resource free'ing with a change in the err
> -Original Message-
> From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
> Sent: Wednesday, February 15, 2017 12:33 AM
> To: Raghava Aditya Renukunta
> ; j...@linux.vnet.ibm.com;
> martin.peter...@oracle.com; linux-scsi@vger.kernel.org
> Cc: Dave Carroll ; Gana Sridaran
> ; Scott Benes
> -Original Message-
> From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
> Sent: Wednesday, February 15, 2017 12:49 AM
> To: Raghava Aditya Renukunta
> ; j...@linux.vnet.ibm.com;
> martin.peter...@oracle.com; linux-scsi@vger.kernel.org
> Cc: Dave Carroll ; Gana Sridaran
> ; Scott Benes
On 02/15/2017 08:04 AM, James Smart wrote:
> On 2/15/2017 2:12 AM, Sagi Grimberg wrote:
>> Also, can you send your patchset threaded? It usually does so
>> when generating the patches with git format-patch, not sure
>> how this is not the case with your set... It would make my
>> life a bit easier.
> -Original Message-
> From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
> Sent: Wednesday, February 15, 2017 12:44 AM
> To: Raghava Aditya Renukunta
> ; j...@linux.vnet.ibm.com;
> martin.peter...@oracle.com; linux-scsi@vger.kernel.org
> Cc: Dave Carroll ; Gana Sridaran
> ; Scott Benes
Hi Martin,
This series contains small cleanup + fix for regression that was introduced by
pci_alloc_irq_vectors_affinity() call in driver.
Please apply this series to 4.10/scsi-fixes at your earliest convenience.
Thanks,
Himanshu
Michael Hernandez (3):
qla2xxx: Cleaned up queue configuration
From: Michael Hernandez
This patch cleaned up queue configuration code, such that
once initialized, we should not touch msix_count value.
This will prevent incorrect numbers of MSI-X vectors requested
while performing target mode configuration.
Fixes: d745952 ("scsi: qla2xxx: Add multiple queue
From: Michael Hernandez
For target mode, we need to increase minimum vectors value by one to
account for ATIO queue.
Following stack trace will be seen
Call Trace:
qla24xx_config_rings+0x15a/0x230 [qla2xxx]
qla2x00_init_rings+0x1a1/0x3a0 [qla2xxx]
qla2x00_restart_isp+0x5c/0x120 [qla2xxx]
qla2x0
From: Michael Hernandez
Target mode initialization was not calculating response
queue values correctly resulting into one less MSI-X vector.
Fixes: 093df73 ("scsi: qla2xxx: Fix Target mode handling with Multiqueue
changes.")
Signed-off-by: Michael Hernandez
Signed-off-by: Himanshu Madhani
---
3.16.40-rc1 review patch. If anyone has any objections, please let me know.
--
From: Andrey Grodzovsky
commit 18f6084a989ba1b38702f9af37a2e4049a924be6 upstream.
This is a work around for a bug with LSI Fusion MPT SAS2 when perfoming
secure erase. Due to the very long time the
Bart,
On 2/16/17 00:10, Bart Van Assche wrote:
> On Wed, 2017-02-15 at 11:12 +0900, Damien Le Moal wrote:
>> +resid = round_up(resid, sector_size);
>> +if (resid < good_bytes)
>> +good_bytes -= resid;
>> +else
Bart,
On 2/16/17 01:42, Bart Van Assche wrote:
> On Wed, 2017-02-15 at 11:12 +0900, Damien Le Moal wrote:
>> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
>> index 1f5d92a..d05a328 100644
>> --- a/drivers/scsi/sd.c
>> +++ b/drivers/scsi/sd.c
>> @@ -1790,6 +1790,8 @@ static int sd_done(struct
On Thu, 2017-02-16 at 09:54 +0900, Damien Le Moal wrote:
> On 2/16/17 01:42, Bart Van Assche wrote:
> > An additional concern: what if the size of the Data-Out buffer is not a
> > multiple of the logical block size? Shouldn't we round down (good_bytes -
> > resid) instead of rounding up resid?
>
>
> "Christoph" == Christoph Hellwig writes:
Applied to 4.11/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
On Wed, Feb 15 2017 at 9:01pm -0500,
Mike Snitzer wrote:
> On Tue, Feb 14 2017 at 6:00pm -0500,
> Keith Busch wrote:
>
> > On Tue, Feb 14, 2017 at 01:35:45PM -0800, Bart Van Assche wrote:
> > > On 02/14/2017 01:19 PM, Keith Busch wrote:
> > > > These devices are mulitpath capable, and have be
> "Dan" == Dan Carpenter writes:
Dan> The "sz" variable is in terms of bytes, but we're treating the
Dan> buffer as an array of __le32 so we have to divide by 4.
Dan> Fixes: def0eab3af86 ("scsi: megaraid_sas: enhance debug logs in OCR
Dan> context") Signed-off-by: Dan Carpenter
Applied to
> "Arnd" == Arnd Bergmann writes:
Arnd> When building with a dma_addr_t that is different from pointer
Arnd> size, we get this warning:
Applied to 4.11/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Bart,
On 2/16/17 10:10, Bart Van Assche wrote:
> On Thu, 2017-02-16 at 09:54 +0900, Damien Le Moal wrote:
>> On 2/16/17 01:42, Bart Van Assche wrote:
>>> An additional concern: what if the size of the Data-Out buffer is not a
>>> multiple of the logical block size? Shouldn't we round down (good_by
Bart,
On 2/16/17 11:52, Damien Le Moal wrote:
> Bart,
>
> On 2/16/17 10:10, Bart Van Assche wrote:
>> On Thu, 2017-02-16 at 09:54 +0900, Damien Le Moal wrote:
>>> On 2/16/17 01:42, Bart Van Assche wrote:
An additional concern: what if the size of the Data-Out buffer is not a
multiple of
On Thu, 2017-02-16 at 11:52 +0900, Damien Le Moal wrote:
> Thanks for the pointers. I checked libiscsi tests. And from what is done
> there, it seems to me that it is basically impossible to distinguished
> between a buggy hardware response and an in-purpose (or buggy) not
> aligned data-out buffer
> "Damien" == Damien Le Moal writes:
Damien,
Damien> So the conclusion may be that we need to drop everything ? The
Damien> mpt3sas patch breaks ZBC now, so that must be removed too.
Nah.
But it's important that we restrict the rounding to TYPE_FS requests
(i.e. I/Os issued by the kernel w
> "Christoph" == Christoph Hellwig writes:
Christoph> this series is on top of the scsi_request changes in Jens'
Christoph> tree and further improves the handling of the sense buffer.
Very nice cleanup!
Christoph> The first patch prevents any possibily of reusing stale sense
Christoph> code
Martin,
On 2/16/17 12:36, Martin K. Petersen wrote:
> Damien,
>
> Damien> So the conclusion may be that we need to drop everything ? The
> Damien> mpt3sas patch breaks ZBC now, so that must be removed too.
>
> Nah.
>
> But it's important that we restrict the rounding to TYPE_FS requests
> (i.e.
Bart,
On 2/16/17 12:28, Bart Van Assche wrote:
> On Thu, 2017-02-16 at 11:52 +0900, Damien Le Moal wrote:
>> Thanks for the pointers. I checked libiscsi tests. And from what is done
>> there, it seems to me that it is basically impossible to distinguished
>> between a buggy hardware response and a
Any device might be setting a queuedata structure, so we need to
check if the queuedata really belongs to a SCSI device before
proceeding.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/scsi_dh.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_dh.c b/dri
On 02/15/2017 07:08 PM, Raghava Aditya Renukunta wrote:
>
> I will put in the queue for the next set of patch submissions and chip away
> at it bit by bit.
Yay, thanks.
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49
On 02/15/2017 07:12 PM, Raghava Aditya Renukunta wrote:
>
> I agree , but it makes it easier to get the driver version when I am
> developing
> and I don't know which driver version is currently loaded
>
> In addition internally our test automation suites use this information as
> opposed to mod
65 matches
Mail list logo
