Re: [PATCH v2 0/2] scsi: storvsc: Add support for FC lightweight host.

2017-01-29 Thread Christoph Hellwig
On Sun, Jan 29, 2017 at 12:35:32AM +, KY Srinivasan wrote: > Windows has chosen this model for virtualizing FC devices to the guest - > without rports (or vports). As I noted in my earlier email, James came > up with this notion of a lightweight template almost a year ago. We can > certainly pi

[PATCH] storvsc: remove bogus code to transfer struct scatterlist

2017-01-29 Thread Christoph Hellwig
Remove a piece of code in storvsc_queuecommand that tries to pass the physical address of the kernel struct scatterlist pointer to the host. Fortunately the code can't ever be reached anyway. Signed-off-by: Christoph Hellwig --- drivers/scsi/storvsc_drv.c | 7 --- 1 file changed, 7 deletion

Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak

2017-01-29 Thread h...@lst.de
Hi Bart, thanks for the analysis. I think the main issue here is that we shouldn't try to assign affinity masks if there are not affinity vectors left to assign. Does the patch below fix the issue for you? diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index 50c5003..96c0713 100644 --- a/dr

[Bug 176951] boot fails unless acpi=off Acer Travelmate X-349

2017-01-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=176951 --- Comment #20 from Martin Goyot --- A new Bios update is available on Acer's website: https://www.acer.com/ac/en/GB/content/support-product/6917?b=1 v1.08 apparently. If anyone has tried it, does it solve the remaining problems? -- You are r

Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak

2017-01-29 Thread Bart Van Assche
On Sun, 2017-01-29 at 10:07 +0100, h...@lst.de wrote: > Hi Bart, > > thanks for the analysis. I think the main issue here is that we shouldn't > try to assign affinity masks if there are not affinity vectors left to > assign. > > Does the patch below fix the issue for you? > > diff --git a/driv

Re: Advanced Format SAT devices show incorrect physical block size

2017-01-29 Thread Pali Rohár
On Wednesday 11 January 2017 16:23:29 Alan Stern wrote: > On Tue, 10 Jan 2017, James Bottomley wrote: > > On Tue, 2017-01-10 at 16:00 -0500, Alan Stern wrote: > > > In theory, I suppose we could change the kernel so that it would > > > default to READ CAPACITY(16) for devices that report a SCSI lev

Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-01-29 Thread Michael Schmitz
Hi Finn, Am 16.01.2017 um 12:50 schrieb Finn Thain: > This series removes some unused code and related comments, > addresses the warnings generated by 'make W=1' and 'make C=1' > and fixes a theoretical bug in the bus reset method in atari_scsi. > > There's also a patch to add a missing error ch

Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-01-29 Thread Finn Thain
On Mon, 30 Jan 2017, Michael Schmitz wrote: > > Michael, Ondrej, can I get you to review/test please? > > No regressions during testing on my Falcon both using default settings, > i.e. can_queue=1 or internal queueing (can_queue=4, cmd_per_lun=2), and > the legacy IDE driver. > > I've seen a

Re: split scsi passthrough fields out of struct request V2

2017-01-29 Thread Hannes Reinecke
On 01/27/2017 10:27 PM, Bart Van Assche wrote: > On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: >> this series splits the support for SCSI passthrough commands from the >> main struct request used all over the block layer into a separate >> scsi_request structure that drivers that want

Re: [RFC PATCH] scsi, block: fix duplicate bdi name registration crashes

2017-01-29 Thread Hannes Reinecke
On 01/29/2017 05:58 AM, Dan Williams wrote: > Warnings of the following form occur because scsi reuses a devt number > while the block layer still has it referenced as the name of the bdi > [1]: > > WARNING: CPU: 1 PID: 93 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x62/0x80 > sysfs: cannot create dupl

scsi: use-after-free in sg_start_req

2017-01-29 Thread Dmitry Vyukov
Hello, The following program triggers use-after-free in sg_start_req: https://gist.githubusercontent.com/dvyukov/be6561d2819fe30a78711234e53866b8/raw/1d75d4508f7a8ebb0b1ec0d18c0054fbffbc0708/gistfile1.txt BUG: KASAN: use-after-free in bio_copy_user_iov+0xee1/0xf00 block/bio.c:1248 at addr 880

Re: [RFC PATCH] scsi, block: fix duplicate bdi name registration crashes

2017-01-29 Thread Omar Sandoval
On Mon, Jan 30, 2017 at 08:05:52AM +0100, Hannes Reinecke wrote: > On 01/29/2017 05:58 AM, Dan Williams wrote: > > Warnings of the following form occur because scsi reuses a devt number > > while the block layer still has it referenced as the name of the bdi > > [1]: > > > > WARNING: CPU: 1 PID:

Re: [RFC PATCH] scsi, block: fix duplicate bdi name registration crashes

2017-01-29 Thread Dan Williams
On Sun, Jan 29, 2017 at 11:22 PM, Omar Sandoval wrote: > On Mon, Jan 30, 2017 at 08:05:52AM +0100, Hannes Reinecke wrote: >> On 01/29/2017 05:58 AM, Dan Williams wrote: >> > Warnings of the following form occur because scsi reuses a devt number >> > while the block layer still has it referenced as