On Wed, Jan 18, 2017 at 06:34:02PM -0800, James Smart wrote:
>
>
> On 1/18/2017 1:50 AM, Johannes Thumshirn wrote:
>
> >>@@ -4959,11 +4968,11 @@ lpfc_send_taskmgmt(struct lpfc_vport *vport, struct
> >>scsi_cmnd *cmnd,
> >>int status;
> >>rdata = lpfc_rport_data_from_scsi_device(cmnd->de
On Wed, Jan 18, 2017 at 06:45:46PM -0800, James Smart wrote:
>
>
> On 1/18/2017 2:11 AM, Johannes Thumshirn wrote:
> >On Tue, Jan 17, 2017 at 05:20:46PM -0800, James Smart wrote:
> >>NVME Initiator: Base modifications
> >>
> >>This is part B of parts A..F.
> >>
> >>Part B is limited to lpfc_attr.
e wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Himanshu-Madhani/qla2xxx-Feature-updates-for-target/20170119-105115
:: branch date: 2 hours ago
:: commit date: 2 hours ago
>> drivers/scsi/qla2xxx/qla_init.c:269:5
I think you missed:
http://git.infradead.org/nvme.git/commit/49c91e3e09dc3c9dd1718df85112a8cce3ab7007
I indeed did, thanks.
But it doesn't help.
We're still having to wait for the first interrupt, and if we're really
fast that's the only completion we have to process.
Try this:
diff --gi
On Wed, Jan 18, 2017 at 06:54:37PM -0800, James Smart wrote:
>
>
> On 1/18/2017 3:03 AM, Johannes Thumshirn wrote:
> >
> >>+ /* maximum number of xris available for nvme buffers */
> >>+ els_xri_cnt = lpfc_sli4_get_els_iocb_cnt(phba);
> >>+ phba->sli4_hba.nvme_xri_max = phba->sli4_hba.max_c
On Thu, Jan 19, 2017 at 12:32:47AM +0800, John Garry wrote:
> From: Xiang Chen
>
> The v2 SAS controller needs more time to detect channel idle
> and send setup link request than SATA disk does, so it is
> difficult for SAS controller to setup an STP link. Therefore it
> may cause some IO timeout
On Thu, Jan 19, 2017 at 12:32:48AM +0800, John Garry wrote:
> From: Xiang Chen
>
> Set SMP connection timeout and continue AWT timer;
> Clear ITCT table when dev gone.
>
> Signed-off-by: Xiang Chen
> Signed-off-by: John Garry
> ---
> drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 11 +++
>
On Thu, Jan 19, 2017 at 12:32:49AM +0800, John Garry wrote:
> The message to inform that the controller has no refclk
> is currently at warning level, which is unnecessary, so
> downgrade to debug.
>
> Signed-off-by: John Garry
> Reviewed-by: Xiang Chen
> ---
Looks good,
Reviewed-by: Johannes T
On Thu, Jan 19, 2017 at 12:32:52AM +0800, John Garry wrote:
> From: Xiang Chen
>
> There is a potential probe issue in how we trigger the hw initialisation.
> Although we use 1s timer to delay hw initialisation, there is still a
> potential that sas_register_ha() is not be finished before we star
On 19/01/2017 08:44, Johannes Thumshirn wrote:
On Thu, Jan 19, 2017 at 12:32:48AM +0800, John Garry wrote:
From: Xiang Chen
Set SMP connection timeout and continue AWT timer;
Clear ITCT table when dev gone.
Signed-off-by: Xiang Chen
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_
On Thu, Jan 19, 2017 at 12:32:53AM +0800, John Garry wrote:
> From: Xiang Chen
>
> There is an issue that hisi_sas_dev.running_req is not
> decremented properly for internal abort and TMF.
>
> To resolve, only decrease running_req in hisi_sas_slot_task_free()
>
> Signed-off-by: Xiang Chen
> Si
On Thu, Jan 19, 2017 at 12:32:50AM +0800, John Garry wrote:
> From: Xiang Chen
>
> Correctly set registers in v2 for root PHY hardreset for directly
> attached disk.
>
> Signed-off-by: Xiang Chen
> Signed-off-by: John Garry
> ---
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thum
On Thu, Jan 19, 2017 at 12:32:51AM +0800, John Garry wrote:
> Downgrade the exit print in hisi_sas_internal_task_abort()
> to dbg level, as info is not required.
>
> Signed-off-by: John Garry
> Reviewed-by: Xiang Chen
> ---
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn
On Thu, Jan 19, 2017 at 10:12:17AM +0200, Sagi Grimberg wrote:
>
> >>>I think you missed:
> >>>http://git.infradead.org/nvme.git/commit/49c91e3e09dc3c9dd1718df85112a8cce3ab7007
> >>
> >>I indeed did, thanks.
> >>
> >But it doesn't help.
> >
> >We're still having to wait for the first interrupt, an
On Thu, Jan 19, 2017 at 10:23:28AM +0200, Sagi Grimberg wrote:
> Christoph suggest to me once that we can take a hybrid
> approach where we consume a small amount of completions (say 4)
> right away from the interrupt handler and if we have more
> we schedule irq-poll to reap the rest. But back the
Christoph suggest to me once that we can take a hybrid
approach where we consume a small amount of completions (say 4)
right away from the interrupt handler and if we have more
we schedule irq-poll to reap the rest. But back then it
didn't work better which is not aligned with my observations
that
On Wed, Jan 11, 2017 at 11:07 PM, Jens Axboe wrote:
> On 01/11/2017 06:43 AM, Johannes Thumshirn wrote:
>> Hi all,
>>
>> I'd like to attend LSF/MM and would like to discuss polling for block
>> drivers.
>>
>> Currently there is blk-iopoll but it is neither as widely used as NAPI in the
>> network
On 01/19/2017 11:57 AM, Ming Lei wrote:
> On Wed, Jan 11, 2017 at 11:07 PM, Jens Axboe wrote:
>> On 01/11/2017 06:43 AM, Johannes Thumshirn wrote:
>>> Hi all,
>>>
>>> I'd like to attend LSF/MM and would like to discuss polling for block
>>> drivers.
>>>
>>> Currently there is blk-iopoll but it is
Hi Jens,
upon further testing with your blk-mq-sched branch I hit a queue stall
during requeing:
[ 202.340959] sd 3:0:4:1: tag#473 Send: scmd 0x880422e7a440
[ 202.340962] sd 3:0:4:1: tag#473 CDB: Test Unit Ready 00 00 00 00 00 00
[ 202.341161] sd 3:0:4:1: tag#473 Done: ADD_TO_MLQUEUE Resul
On 01/19/2017 04:27 AM, Hannes Reinecke wrote:
> Hi Jens,
>
> upon further testing with your blk-mq-sched branch I hit a queue stall
> during requeing:
>
> [ 202.340959] sd 3:0:4:1: tag#473 Send: scmd 0x880422e7a440
> [ 202.340962] sd 3:0:4:1: tag#473 CDB: Test Unit Ready 00 00 00 00 00 00
When we're hitting a busy condition in queuecommand() we need to
stop the hardware queue before calling blk_mq_delay_queue(); if
we don't blk_mq_delay_queue() will not do anything and requeue
will never triggered.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/scsi_lib.c | 4 +++-
1 file change
On 01/19/2017 03:09 PM, Jens Axboe wrote:
> On 01/19/2017 04:27 AM, Hannes Reinecke wrote:
>> Hi Jens,
>>
>> upon further testing with your blk-mq-sched branch I hit a queue stall
>> during requeing:
>>
>> [ 202.340959] sd 3:0:4:1: tag#473 Send: scmd 0x880422e7a440
>> [ 202.340962] sd 3:0:4:1
On 01/19/2017 06:24 AM, Hannes Reinecke wrote:
> On 01/19/2017 03:09 PM, Jens Axboe wrote:
>> On 01/19/2017 04:27 AM, Hannes Reinecke wrote:
>>> Hi Jens,
>>>
>>> upon further testing with your blk-mq-sched branch I hit a queue stall
>>> during requeing:
>>>
>>> [ 202.340959] sd 3:0:4:1: tag#473 Se
On 01/19/2017 06:52 AM, Hannes Reinecke wrote:
> On 01/19/2017 03:46 PM, Christoph Hellwig wrote:
>> On Thu, Jan 19, 2017 at 03:17:45PM +0100, Hannes Reinecke wrote:
>>> When we're hitting a busy condition in queuecommand() we need to
>>> stop the hardware queue before calling blk_mq_delay_queue();
On Thu, Jan 19, 2017 at 06:58:09AM -0800, Jens Axboe wrote:
> Yeah, I made that patch and grepped the tree. The usage in the fc
> code in nvme looks weird. It's stopping all potential hardware queues,
> yet only delaying one.
>
> if (op->rq) {
>
Signed-off-by: Chaitra P B
Suganath Prabu
---
drivers/scsi/mpt3sas/mpt3sas_base.h |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h
b/drivers/scsi/mpt3sas/mpt3sas_base.h
index 83cfa16..4ab634f 100644
--- a/drivers/s
Driver processes the event MPI26_EVENT_ACTIVE_CABLE_DEGRADED
when a cable is present and is running at a degraded speed
(below the SAS3 12 Gb/s rate). Prints added
to inform the user that the cable is not running at
optimal speed.
Signed-off-by: Chaitra P B
Suganath Prabu
---
dri
Due existence of loop in the IO path our HBA will receive heavy IOs and
also as driver is not updating the Reply Post Host Index frequently, So
there will be a high chance that our Firmware unable to find any free entry
in the Reply Post Descriptor Queue (i.e. Queue overflow occurs) and can
observe
Small glitch/degraded performance in Crusader is improved with SAS
drives by removing unnecessary spinlocks while clearing scsi command
in drivers internal lookup table.
Signed-off-by: Chaitra P B
Suganath Prabu
---
drivers/scsi/mpt3sas/mpt3sas_base.c |1 +
drivers/scsi/mpt3
Here is the change list:
Posting 4 patches for mpt3sas driver enhancement and defect fixes.
* Handle cable event for notifying degraded speed.
* Performance improvement for Crusader.
* Fix Firmware fault state 0x2100 during heavy 4K RR
FIO stress test.
* Updated driver version to 15.100
On Thu, 2017-01-19 at 21:19 +0530, Chaitra P B wrote:
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> index 5ffbfb1..b3f9f7a 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> @@ -1096,6 +1096,27 @@ _scs
On Thu, 2017-01-19 at 15:17 +0100, Hannes Reinecke wrote:
> When we're hitting a busy condition in queuecommand() we need to
> stop the hardware queue before calling blk_mq_delay_queue(); if
> we don't blk_mq_delay_queue() will not do anything and requeue
> will never triggered.
>
> Signed-off-by:
Nevermind - I misread the "-" for "+". will fix
-- james
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/19/2017 03:46 PM, Christoph Hellwig wrote:
> On Thu, Jan 19, 2017 at 03:17:45PM +0100, Hannes Reinecke wrote:
>> When we're hitting a busy condition in queuecommand() we need to
>> stop the hardware queue before calling blk_mq_delay_queue(); if
>> we don't blk_mq_delay_queue() will not do any
On Wed, Jan 18, 2017 at 03:28:57PM -0500, Cathy Avery wrote:
> The patch provides a means to offer a lightweight option to the
> current FC transport class. The new option is selected by a
> driver when it indicates it wants the lightweight
> transport via fc_function_template.
This need some real
On 01/19/2017 10:11 AM, Christoph Hellwig wrote:
On Wed, Jan 18, 2017 at 03:28:57PM -0500, Cathy Avery wrote:
The patch provides a means to offer a lightweight option to the
current FC transport class. The new option is selected by a
driver when it indicates it wants the lightweight
transport
On 01/18/2017 06:15 PM, Dan Carpenter wrote:
On Wed, Jan 18, 2017 at 03:28:58PM -0500, Cathy Avery wrote:
Enable FC lightweight host option so that the luns exposed by
the driver may be manually scanned.
Signed-off-by: Cathy Avery
---
drivers/scsi/storvsc_drv.c | 6 +-
1 file changed,
On Thu, Jan 19, 2017 at 03:17:45PM +0100, Hannes Reinecke wrote:
> When we're hitting a busy condition in queuecommand() we need to
> stop the hardware queue before calling blk_mq_delay_queue(); if
> we don't blk_mq_delay_queue() will not do anything and requeue
> will never triggered.
I suspect t
On Thu, Jan 19, 2017 at 03:34:58PM -0500, Tejun Heo wrote:
> So, unless we allocate one mempool per port, we're gonna have to
> synchronize around its use anyway. mempool can't guarantee allocation
> to multiple users at the same time. If this is something which
> affects scalability, I'm complet
On Wed, 2017-01-18 at 15:19 -0800, Himanshu Madhani wrote:
> Changes from v2 --> v3
>
> o Cleaned up sparse warnings reported by you.
Not all warnings have been addressed. I still see the following smatch
warnings:
CHECK drivers/scsi/qla2xxx/qla_init.c
drivers/scsi/qla2xxx/qla_init.c:265: ql
On 01/18/2017 06:02 AM, Hannes Reinecke wrote:
> On 01/17/2017 05:50 PM, Sagi Grimberg wrote:
>>
>>> So it looks like we are super not efficient because most of the
>>> times we catch 1
>>> completion per interrupt and the whole point is that we need to find
>>> more! This fio
>>>
This is a set of 12 fixes including the mpt3sas one that was causing
hangs on ATA passthrough. The others are a couple of zoned block
device fixes, a SAS device detection bug which lead to SATA drives not
being matched to bays, two qla2xxx MSI fixes, a qla2xxx req for rsp
confusion caused by cut a
From: Quinn Tran
Reviewed-by: Christoph Hellwig
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_def.h| 1 +
drivers/scsi/qla2xxx/qla_target.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drive
From: Quinn Tran
Callback for sp->done expects scsi_qla_host is passed in as argument,
Instead qla_hw_data is passed in.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_isr.c | 8
drivers/scsi/qla2xxx/qla_mr.c | 6 +++---
drivers/scsi/qla2xxx/q
With support for dual mode in the driver, this mode becomes
dead code. Remove reverse_ini_mode from code.
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_def.h| 1 -
drivers/scsi/qla2xxx/qla_target.c | 10 --
drivers/scsi/qla2xxx/qla_target.h | 8
3 files chan
During initial implementation, tape support was included but not
enabled by default on target. So far, we don't see any target
customer requesting this support. Since this code is not being
used actively, we want to remove it and we will add back if there
are any request in future for SRR support.
From: Quinn Tran
Move code code which converts Task Mgmt Command flags for
ATIO to TCM #defines, from qla2xxx driver to tcm_qla2xxx
driver.
Reviewed-by: Christoph Hellwig
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_target.c | 75 ---
From: Quinn Tran
Updated code with d_id from s_id for better readabilty
and clarity.
Reviewed-by: Christoph Hellwig
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_dfs.c | 9 -
drivers/scsi/qla2xxx/qla_target.c | 24 +++---
From: Quinn Tran
Add switch to allow both Initiator Mode & Target
mode to operate at the same time.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_def.h | 1 +
drivers/scsi/qla2xxx/qla_init.c| 6 +-
drivers/scsi/qla2xxx/qla_isr.c | 19 +
From: Quinn Tran
Trace flags are useful during debugging crash dumps
using crash utility. These trace flags makes it easier
to understand various states a command has successfully
completed.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_target.c | 28
Hi Bart,
Please consider this updated series for inclusion in target-pending.
Changes from v3 --> v4
o Fixed warnings reported by smatch tool.
o Fixed indentatation warnings reported by smatch tool.
Changes from v2 --> v3
o Cleaned up sparse warnings reported by you.
Changes from v1 --> v2
o
From: Quinn Tran
Current code blindly does State Change Registration when
the link is up. Move SCR behind fabric scan, so that arbitrated
loop scan would not get erroneous error message.
Some of the other improvements are as follows
- Add session deletion for TPRLO and send acknowledgment for T
From: Quinn Tran
Current code merges qla_tgt_sess and fc_port structure
into single fc_port structure represeting same I-T nexus.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_def.h | 112 -
drivers/scsi/qla2xxx/qla_dfs.c | 4 +-
From: Joe Carnuccio
This patch simplifies SRB structure usage in driver.
- Simplify sp->done() and sp->free() interfaces.
- Remove sp->fcport->vha to use vha pointer from sp.
- Use sp->vha context in qla2x00_rel_sp().
Signed-off-by: Joe Carnuccio
Signed-off-by: Himanshu Madhani
---
drivers/s
On 01/19/2017 05:11 PM, Bart Van Assche wrote:
> On Thu, 2017-01-19 at 15:17 +0100, Hannes Reinecke wrote:
>> When we're hitting a busy condition in queuecommand() we need to
>> stop the hardware queue before calling blk_mq_delay_queue(); if
>> we don't blk_mq_delay_queue() will not do anything and
55 matches
Mail list logo
