On 01/18/2017 02:20 AM, James Smart wrote:
>
> NVME Target: Receive buffer updates
>
> Allocates buffer pools and configures adapter interfaces to handle
> receive buffer (asynchronous FCP CMD ius, first burst data)
> from the adapter. Splits by protocol, etc.
>
> Signed-off-by: Dick Kennedy
>
On 01/18/2017 02:20 AM, James Smart wrote:
>
> NVME Target: Merge into FC discovery
>
> Adds NVME PRLI handling and Nameserver registrations for NVME
>
> Signed-off-by: Dick Kennedy
> Signed-off-by: James Smart
> ---
> drivers/scsi/lpfc/lpfc_ct.c| 8 +++-
> drivers/scsi/lpfc/lpfc
On 01/18/2017 02:20 AM, James Smart wrote:
>
> NVME Target: Tie in to NVME Fabrics nvmet_fc LLDD target api
>
> Adds the routines to:
> - register and deregister the FC port as a nvmet-fc targetport
> - binding of nvme queues to adapter WQs
> - receipt and passing of NVME LS's to transport, sendi
On 01/18/2017 02:20 AM, James Smart wrote:
>
> NVME Target: Add debugfs support
>
> Adds debugfs snippets to cover the new NVME target functionality
>
> Signed-off-by: Dick Kennedy
> Signed-off-by: James Smart
> ---
> drivers/scsi/lpfc/lpfc_debugfs.c | 387
> +
On 01/18/2017 02:20 AM, James Smart wrote:
>
> Update copyrights to 2017 for all files touched in this patch set
>
> Signed-off-by: Dick Kennedy
> Signed-off-by: James Smart
> ---
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
On 01/18/2017 02:21 AM, James Smart wrote:
>
> Update lpfc version to 11.2.0.7
>
> Signed-off-by: Dick Kennedy
> Signed-off-by: James Smart
> ---
> drivers/scsi/lpfc/lpfc_version.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_version.h
> b/d
On Tue, Jan 17, 2017 at 10:06:51PM +0200, Sagi Grimberg wrote:
>
>> @@ -1014,9 +1013,9 @@ static int nvme_rdma_map_data(struct nvme_rdma_queue
>> *queue,
>> }
>>
>
> Christoph, a little above here we still look at blk_rq_bytes(),
> shouldn't that look at blk_rq_payload_bytes() too?
The check
On 01/18/2017 02:20 AM, James Smart wrote:
>
> NVME Initiator: Base modifications
>
> This is part E of parts A..F.
>
> Part E is limited to lpfc_sli.c. This is the location of most of changes
> for the following:
> - sli3 ring vs sli4 wq splits
> - io abort interfaces
> - actual queuing routine
Hi James,
On Tue, Jan 17, 2017 at 05:20:45PM -0800, James Smart wrote:
>
> NVME Initiator: Base modifications
>
> This is part A of parts A..F.
>
> Part A is the bulk of the file list changed by the modifications as
> most mods are small-ish. Changes may be for any aspect below.
>
> *
On 01/18/2017 02:20 AM, James Smart wrote:
>
> NVME Initiator: Base modifications
>
> This is part F of parts A..F.
>
> Part F is limited to lpfc_debugfs.[ch]. It contains the modifications in
> the existing debugfs snippets to work with the base modifications.
>
> *
>
> Refer to Part
Lieber Freund.
Erlauben Sie mir, auf diese Weise auf Sie zuzugehen. Ich bin Dr. Arnold
Kristofferson, ein US-Auftragnehmer, der mit Nichtkämpfer US Marine in
Ba'qubah, Irak arbeitet. Ich habe die Summe von 10,6 Millionen Dollar, die ich
aus einem Rohöl-Deal gemacht habe, und ich möchte, dass Si
On Tue, Jan 17, 2017 at 05:20:46PM -0800, James Smart wrote:
>
> NVME Initiator: Base modifications
>
> This is part B of parts A..F.
>
> Part B is limited to lpfc_attr.c: lpfc attribute modifications
>
> *
>
> Refer to Part A for a description of base modifications
>
> Signed-off-by:
On Tue, Jan 17, 2017 at 05:20:47PM -0800, James Smart wrote:
>
> NVME Initiator: Base modifications
>
> This is part C of parts A..F.
>
> Part C is the 1st half of the mods to lpfc_init.c. This is the location
> of most of changes for the following:
> - sli3 ring vs sli4 wq splits
> - buffer poo
On Tue, Jan 17, 2017 at 05:20:48PM -0800, James Smart wrote:
>
> NVME Initiator: Base modifications
>
> This is part D of parts A..F.
>
> Part D is the 2nd half of the mods to lpfc_init.c. This is the location
> of most of changes for the following:
> - sli3 ring vs sli4 wq splits
> - buffer poo
On Tue, Jan 17, 2017 at 06:38:43PM +0200, Sagi Grimberg wrote:
>
> >Just for the record, all tests you've run are with the upper irq_poll_budget
> >of
> >256 [1]?
>
> Yes, but that's the point, I never ever reach this budget because
> I'm only processing 1-2 completions per interrupt.
>
> >We (
On 01/17/2017 05:50 PM, Sagi Grimberg wrote:
>
>> So it looks like we are super not efficient because most of the
>> times we catch 1
>> completion per interrupt and the whole point is that we need to find
>> more! This fio
>> is single threaded with QD=32 so I'd expect that we
So what you say is you saw a consomed == 1 [1] most of the time?
[1] from
http://git.infradead.org/nvme.git/commitdiff/eed5a9d925c59e43980047059fde29e3aa0b7836
Exactly. By processing 1 completion per interrupt it makes perfect sense
why this performs poorly, it's not worth paying the soft-ir
On Wed, Jan 18, 2017 at 5:27 PM, Sagi Grimberg wrote:
>
>> So what you say is you saw a consomed == 1 [1] most of the time?
>>
>> [1] from
>> http://git.infradead.org/nvme.git/commitdiff/eed5a9d925c59e43980047059fde29e3aa0b7836
>
>
> Exactly. By processing 1 completion per interrupt it makes perfe
Your report provided this stats with one-completion dominance for the
single-threaded case. Does it also hold if you run multiple fio
threads per core?
It's useless to run more threads on that core, it's already fully
utilized. That single threads is already posting a fair amount of
submission
On Wed, Jan 18, 2017 at 04:27:24PM +0200, Sagi Grimberg wrote:
>
> >So what you say is you saw a consomed == 1 [1] most of the time?
> >
> >[1] from
> >http://git.infradead.org/nvme.git/commitdiff/eed5a9d925c59e43980047059fde29e3aa0b7836
>
> Exactly. By processing 1 completion per interrupt it m
Hannes just spotted this:
static int nvme_queue_rq(struct blk_mq_hw_ctx *hctx,
const struct blk_mq_queue_data *bd)
{
[...]
__nvme_submit_cmd(nvmeq, &cmnd);
nvme_process_cq(nvmeq);
spin_unlock_irq(&nvmeq->q_lock);
return BLK_MQ_RQ_QUEUE_OK;
On Wed, Jan 18, 2017 at 05:14:36PM +0200, Sagi Grimberg wrote:
>
> >Hannes just spotted this:
> >static int nvme_queue_rq(struct blk_mq_hw_ctx *hctx,
> > const struct blk_mq_queue_data *bd)
> >{
> >[...]
> >__nvme_submit_cmd(nvmeq, &cmnd);
> >nvme_process_cq
On Wed, Jan 18, 2017 at 5:40 PM, Sagi Grimberg wrote:
>
>> Your report provided this stats with one-completion dominance for the
>> single-threaded case. Does it also hold if you run multiple fio
>> threads per core?
>
>
> It's useless to run more threads on that core, it's already fully
> utilize
On 01/18/2017 04:16 PM, Johannes Thumshirn wrote:
> On Wed, Jan 18, 2017 at 05:14:36PM +0200, Sagi Grimberg wrote:
>>
>>> Hannes just spotted this:
>>> static int nvme_queue_rq(struct blk_mq_hw_ctx *hctx,
>>> const struct blk_mq_queue_data *bd)
>>> {
>>> [...]
>>>__n
The message to inform that the controller has no refclk
is currently at warning level, which is unnecessary, so
downgrade to debug.
Signed-off-by: John Garry
Reviewed-by: Xiang Chen
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dri
From: Xiang Chen
Correctly set registers in v2 for root PHY hardreset for directly
attached disk.
Signed-off-by: Xiang Chen
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw
From: Xiang Chen
The v2 SAS controller needs more time to detect channel idle
and send setup link request than SATA disk does, so it is
difficult for SAS controller to setup an STP link. Therefore it
may cause some IO timeouts.
We need to periodically configure the SAS controller so it
doesn't r
From: Xiang Chen
Set SMP connection timeout and continue AWT timer;
Clear ITCT table when dev gone.
Signed-off-by: Xiang Chen
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/hisi_
Downgrade the exit print in hisi_sas_internal_task_abort()
to dbg level, as info is not required.
Signed-off-by: John Garry
Reviewed-by: Xiang Chen
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c
This patchset introduces some misc fixes and improvements.
Most signifigantly this patchset includes a workaround
for a SATA IO issue on v2 hw (hip06/7).
John Garry (2):
scsi: hisi_sas: downgrade refclk message
scsi: hisi_sas: downgrade internal abort exit print
Xiang Chen (5):
scsi: hisi_
From: Xiang Chen
There is an issue that hisi_sas_dev.running_req is not
decremented properly for internal abort and TMF.
To resolve, only decrease running_req in hisi_sas_slot_task_free()
Signed-off-by: Xiang Chen
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 8 -
From: Xiang Chen
There is a potential probe issue in how we trigger the hw initialisation.
Although we use 1s timer to delay hw initialisation, there is still a
potential that sas_register_ha() is not be finished before we start
the PHY init from hw->hw_init().
To avoid this issue, initialise the
On 01/16/2017 08:53 PM, Dupuis, Chad wrote:
> From: Arun Easi
>
> This adds the backbone required for the various HW initalizations
> which are necessary for the FCoE driver (qedf) for QLogic FastLinQ
> 4 line of adapters - FW notification, resource initializations, etc.
>
> Signed-off-by: A
On 01/16/2017 08:53 PM, Dupuis, Chad wrote:
> From: "Dupuis, Chad"
>
> The QLogic FastLinQ Driver for FCoE (qedf) is the FCoE specific module for
> 41000
> Series Converged Network Adapters by QLogic. This patch consists of following
> changes:
>
> - MAINTAINERS Makefile and Kconfig changes for
On Tue, Jan 17, 2017 at 05:20:44PM -0800, James Smart wrote:
>
> Move to new pci_alloc_irq_vectors() interface for intx/msi/msix
>
> Note: io channel paradigm remains, for now.
Not exactly a well written changelog. I'd like to know why this is
better than my version here:
http://git.infradead.
Hello,
On Tue, Jan 17, 2017 at 08:25:21PM +0530, Rameshwar Sahu wrote:
> Hi Tejun,
>
> On Fri, Nov 18, 2016 at 3:15 PM, Rameshwar Prasad Sahu wrote:
> > This patch enables NCQ support for APM X-Gene SATA controller hardware v1.1
> > that was broken with hardware v1.0. Second thing, here we shoul
Currently virtual FC hosts or lightweight hosts are not able to be
manually scanned via sysfs due to the fact that they do not
contain the complete characteristic set associated with a normal FC host
( missing rports, vports, etc ) and are not consistent with the current FC
transport model.
Patch
The patch provides a means to offer a lightweight option to the
current FC transport class. The new option is selected by a
driver when it indicates it wants the lightweight
transport via fc_function_template.
Signed-off-by: Cathy Avery
---
drivers/scsi/scsi_transport_fc.c | 125
Enable FC lightweight host option so that the luns exposed by
the driver may be manually scanned.
Signed-off-by: Cathy Avery
---
drivers/scsi/storvsc_drv.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 888e1
On Wed, Jan 18, 2017 at 03:28:58PM -0500, Cathy Avery wrote:
> Enable FC lightweight host option so that the luns exposed by
> the driver may be manually scanned.
>
> Signed-off-by: Cathy Avery
> ---
> drivers/scsi/storvsc_drv.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> d
From: Quinn Tran
Trace flags are useful during debugging crash dumps
using crash utility. These trace flags makes it easier
to understand various states a command has successfully
completed.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_target.c | 28
Hi Bart,
Please consider this updated series for inclusion in target-pending.
Changes from v2 --> v3
o Cleaned up sparse warnings reported by you.
Changes from v1 --> v2
o Updated review comments and added Reviewed-by tags for necessary patches.
o We left the one particular review comment to a
From: Quinn Tran
Reviewed-by: Christoph Hellwig
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_def.h| 1 +
drivers/scsi/qla2xxx/qla_target.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drive
During initial implementation, tape support was included but not
enabled by default on target. So far, we don't see any target
customer requesting this support. Since this code is not being
used actively, we want to remove it and we will add back if there
are any request in future for SRR support.
From: Quinn Tran
Move code code which converts Task Mgmt Command flags for
ATIO to TCM #defines, from qla2xxx driver to tcm_qla2xxx
driver.
Reviewed-by: Christoph Hellwig
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_target.c | 75 ---
From: Quinn Tran
Add switch to allow both Initiator Mode & Target
mode to operate at the same time.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_def.h | 1 +
drivers/scsi/qla2xxx/qla_init.c| 6 +-
drivers/scsi/qla2xxx/qla_isr.c | 19 +
From: Quinn Tran
Current code blindly does State Change Registration when
the link is up. Move SCR behind fabric scan, so that arbitrated
loop scan would not get erroneous error message.
Some of the other improvements are as follows
- Add session deletion for TPRLO and send acknowledgment for T
From: Quinn Tran
Updated code with d_id from s_id for better readabilty
and clarity.
Reviewed-by: Christoph Hellwig
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_dfs.c | 9 -
drivers/scsi/qla2xxx/qla_target.c | 24 +++---
From: Joe Carnuccio
This patch simplifies SRB structure usage in driver.
- Simplify sp->done() and sp->free() interfaces.
- Remove sp->fcport->vha to use vha pointer from sp.
- Use sp->vha context in qla2x00_rel_sp().
Signed-off-by: Joe Carnuccio
Signed-off-by: Himanshu Madhani
---
drivers/s
From: Quinn Tran
Current code merges qla_tgt_sess and fc_port structure
into single fc_port structure represeting same I-T nexus.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_def.h | 112 -
drivers/scsi/qla2xxx/qla_dfs.c | 4 +-
From: Quinn Tran
Callback for sp->done expects scsi_qla_host is passed in as argument,
Instead qla_hw_data is passed in.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_isr.c | 8
drivers/scsi/qla2xxx/qla_mr.c | 6 +++---
drivers/scsi/qla2xxx/q
With support for dual mode in the driver, this mode becomes
dead code. Remove reverse_ini_mode from code.
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_def.h| 1 -
drivers/scsi/qla2xxx/qla_target.c | 10 --
drivers/scsi/qla2xxx/qla_target.h | 8
3 files chan
This will be addressed in v2 of the series. The warning pops up when
CONFIG_DCB is not set. Thanks.
Regards,
-Arun
On Tue, 17 Jan 2017, 6:35am, kbuild test robot wrote:
> Hi Arun,
>
> [auto build test WARNING on net-next/master]
> [also build test WARNING on v4.10-rc4 next-20170117]
> [if your
On 1/17/2017 11:07 PM, Hannes Reinecke wrote:
- * lpfc_sli4_post_scsi_sgl_list - Post blocks of scsi buffer sgls from a list
+ * lpfc_sli4_post_scsi_sgl_list - Psot blocks of scsi buffer sgls from a list
* @phba: pointer to lpfc hba data structure.
* @post_sblist: pointer to the scsi bu
On 1/17/2017 11:17 PM, Hannes Reinecke wrote:
@@ -3315,16 +3421,121 @@ lpfc_sli4_xri_sgl_update(struct lpfc_hba *phba)
[ .. ]
Unsafe.
'nvme_xri_cnt' is updated under the lock, but not tested with the lock
held. Please fix.
Yep - will fix.
-- james
--
To unsubscribe from this list: send
On 1/17/2017 11:34 PM, Hannes Reinecke wrote:
Is this ever reset?
I don't see it here ...
the lpfc_sli4_hba_setup(), which resets the function and reinits, clears
the flag.
[ .. ]
@@ -4380,9 +4469,12 @@ lpfc_sli_chipset_init(struct lpfc_hba *phba)
* configured.
**/
int
-lpfc_sli
On 1/18/2017 1:50 AM, Johannes Thumshirn wrote:
@@ -4959,11 +4968,11 @@ lpfc_send_taskmgmt(struct lpfc_vport *vport, struct
scsi_cmnd *cmnd,
int status;
rdata = lpfc_rport_data_from_scsi_device(cmnd->device);
- if (!rdata || !rdata->pnode || !NLP_CHK_NODE_ACT(rdata->pnode
On 1/18/2017 2:11 AM, Johannes Thumshirn wrote:
On Tue, Jan 17, 2017 at 05:20:46PM -0800, James Smart wrote:
NVME Initiator: Base modifications
This is part B of parts A..F.
Part B is limited to lpfc_attr.c: lpfc attribute modifications
*
Refer to Part A for a description of base m
On 1/18/2017 5:39 AM, Johannes Thumshirn wrote:
I know this might be annoying by now, but it's really hard to follow
code that
is so much indented and lpfc really needs some love in the readability case.
Please don't misunderstand me, it has nothing to do with you and lpfc is not
the only drive
On 1/18/2017 3:03 AM, Johannes Thumshirn wrote:
+ /* maximum number of xris available for nvme buffers */
+ els_xri_cnt = lpfc_sli4_get_els_iocb_cnt(phba);
+ phba->sli4_hba.nvme_xri_max = phba->sli4_hba.max_cfg_param.max_xri -
+ els_xri_cn
On 1/18/2017 8:54 AM, Christoph Hellwig wrote:
On Tue, Jan 17, 2017 at 05:20:44PM -0800, James Smart wrote:
Move to new pci_alloc_irq_vectors() interface for intx/msi/msix
Note: io channel paradigm remains, for now.
Not exactly a well written changelog. I'd like to know why this is
better th
@@ -1014,9 +1013,9 @@ static int nvme_rdma_map_data(struct nvme_rdma_queue
*queue,
}
Christoph, a little above here we still look at blk_rq_bytes(),
shouldn't that look at blk_rq_payload_bytes() too?
The check is ok for now as it's just zero vs non-zero. It's somewhat
broken for W
62 matches
Mail list logo
