[PATCH 2/9] qla2xxx: Cleanup TMF code translation from qla_target.

From: Quinn Tran Move code code which converts Task Mgmt Command flags for ATIO to TCM #defines, from qla2xxx driver to tcm_qla2xxx driver. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 71 +++--- drivers/scs

[PATCH 0/9] qla2xxx: Cleanup for target code.

Hi Christoph, Bart, I am submitting this reworked series of patches which were consolidated and modified in a single patch in previous submission. Here's link to the patch submitted on Dec 6, 2016. http://www.spinics.net/lists/target-devel/msg13657.html The existing code access TCM/LIO structu

[PATCH 6/9] qla2xxx: Remove direct access of scsi_status field in se_cmd

From: Quinn Tran Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h| 1 + drivers/scsi/qla2xxx/qla_target.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h index

[PATCH 3/9] qla2xxx: Move percpu_ida_{alloc|free} to tcm_qla2xxx.

From: Quinn Tran Moving code to from qla_target to tcm_qla2xxx. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 37 ++--- drivers/scsi/qla2xxx/qla_target.h | 2 ++ drivers/scsi/qla2xxx/tcm_qla2xxx.c | 36

[PATCH 4/9] qla2xxx: Cleanup for sess_kref handling

From: Quinn Tran Remove se_session internal knowledge. tcm_qla2xxx driver is the only one that have this knowledge. Also check if sess is not NULL before getting kref. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 13 +++-- drivers

[PATCH 8/9] qla2xxx: Add T10-DIF opcode/type in qla_tgt_cmd

From: Quinn Tran Add T10-DIF/PI protection opcode/type field to qla_tgt_cmd. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 126 -- drivers/scsi/qla2xxx/qla_target.h | 4 ++ 2 files changed, 58 insertions

[PATCH 5/9] qla2xxx: Move Command residual check from qla2xxx to tcm_qla2xxx

From: Quinn Tran Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 8 drivers/scsi/qla2xxx/qla_target.h | 1 + drivers/scsi/qla2xxx/tcm_qla2xxx.c | 14 ++ 3 files changed, 19 insertions(+), 4 deletions(-) diff --git a/dr

[PATCH 9/9] qla2xxx: Remove se_cmd struct out of qla_tgt_cmd/qla_tgt_mgmt_cmd

From: Quinn Tran Move se_cmd struct outside of qla_tgt_cmd/qla_tgt_mgmt_cmd. To convert the pointer from one struct to another, new inline functions was added to take care of the convertion. Cleanup dead SRR code. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla

[PATCH 1/9] qla2xxx: Move cmd search out of qla during ABTS

From: Quinn Tran move cmd search out of qla to remove symbol dependency. The command list is held in se_session struct. This knowledege should be in tcm_qla2xxx. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 45 +++-

[PATCH 7/9] qla2xxx: Remove direct access to t_task_cdb/t_task_lba field

From: Quinn Tran qla2xxx currently access t_task_cdb/t_task_lba field in se_cmd struct. Remove access of TCM's private data struct. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 32 +--- drivers/scsi/qla2xxx/qla_

Re: [PATCH 0/9] qla2xxx: Cleanup for target code.

On Sun, Dec 18, 2016 at 01:02:40AM -0800, Himanshu Madhani wrote: > Hi Christoph, Bart, > > I am submitting this reworked series of patches which were consolidated > and modified in a single patch in previous submission. Please resend a series with just the actually useful bug fixes first, thank

Re: [PATCH 3/9] qla2xxx: Move percpu_ida_{alloc|free} to tcm_qla2xxx.

On Sun, Dec 18, 2016 at 01:02:43AM -0800, Himanshu Madhani wrote: > From: Quinn Tran > > Moving code to from qla_target to tcm_qla2xxx. > > Signed-off-by: Quinn Tran > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_target.c | 37 ++--- > driv

Re: [PATCH 4/9] qla2xxx: Cleanup for sess_kref handling

On Sun, Dec 18, 2016 at 01:02:44AM -0800, Himanshu Madhani wrote: > From: Quinn Tran > > Remove se_session internal knowledge. tcm_qla2xxx > driver is the only one that have this knowledge. > > Also check if sess is not NULL before getting kref. Same again, adding code and interfaces:NKA for th

Re: [PATCH 5/9] qla2xxx: Move Command residual check from qla2xxx to tcm_qla2xxx

NAK again, duplicating a field in a common structure in a driver-specific one is an absolute anti-pattern. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.htm

Re: [PATCH 7/9] qla2xxx: Remove direct access to t_task_cdb/t_task_lba field

NAK again, duplicating fields in a common structure in a driver-specific one is an absolute anti-pattern. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 8/9] qla2xxx: Add T10-DIF opcode/type in qla_tgt_cmd

NAK again, duplicating fields in a common structure in a driver-specific one is an absolute anti-pattern. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 9/9] qla2xxx: Remove se_cmd struct out of qla_tgt_cmd/qla_tgt_mgmt_cmd

On Sun, Dec 18, 2016 at 01:02:49AM -0800, Himanshu Madhani wrote: > From: Quinn Tran > > Move se_cmd struct outside of qla_tgt_cmd/qla_tgt_mgmt_cmd. > To convert the pointer from one struct to another, new inline > functions was added to take care of the convertion. > > Cleanup dead SRR code. P

Re: [PATCH 6/9] qla2xxx: Remove direct access of scsi_status field in se_cmd

Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/9] qla2xxx: Cleanup TMF code translation from qla_target.

Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Uninitialized variable in bfad_im_bsg_els_ct_request

Hello, Currently on Linus master tree and in linux-next [1], bfad_im_bsg_els_ct_request() code starts with the following code: int bfad_im_bsg_els_ct_request(struct bsg_job *job) { /*...*/ struct fc_bsg_request *bsg_request = bsg_request; struct fc_bsg_reply *bsg_reply = j

Uninitialized variable in bfad_im_bsg_els_ct_request

Hello, Currently on Linus master tree and in linux-next [1], bfad_im_bsg_els_ct_request() code starts with the following code: int bfad_im_bsg_els_ct_request(struct bsg_job *job) { /*...*/ struct fc_bsg_request *bsg_request = bsg_request; struct fc_bsg_reply *bsg_reply = j

[PATCH] scsi/qla4: comments correction

Signed-off-by: Cao jin --- drivers/scsi/qla4xxx/ql4_os.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 01c3610a60cf..fc60e0a1043e 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/q

KREDITANGEBOTE

-- Darlehen für alle möglichen Zwecke Wir bieten Ihnen zwischen € 5000 und € 20 Millionen, können Sie Ihre Anfrage direkt per E-Mail: mkfinancial.onl...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More maj