Return value of skb_linearize should be handled.
Signed-off-by: Zhouyi Zhou
Reviewed-by: Yuval Shaia
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 6 --
drivers/scsi/fcoe/fcoe.c | 5 -
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
Hi Zhouyi,
On Wed, Dec 07, 2016 at 04:00:00PM +0800, Zhouyi Zhou wrote:
> Return value of skb_linearize should be handled.
>
> Signed-off-by: Zhouyi Zhou
> Reviewed-by: Yuval Shaia
> ---
> drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 6 --
> drivers/scsi/fcoe/fcoe.c | 5 -
> 2 files ch
Thanks Johannes for reviewing, your code is indeeded more elegant
On Wed, Dec 7, 2016 at 4:28 PM, Johannes Thumshirn wrote:
> Hi Zhouyi,
> On Wed, Dec 07, 2016 at 04:00:00PM +0800, Zhouyi Zhou wrote:
>> Return value of skb_linearize should be handled.
>>
>> Signed-off-by: Zhouyi Zhou
>> Reviewed
On 12/06/2016 09:30 PM, Himanshu Madhani wrote:
> From: Quinn Tran
>
> - Save NPort ID early in link init.
> - Add session deletion for TPRLO and send acknowledgement for TPRLO.
> - Enable FW option to move ABTS, RIDA & PUREX from RSPQ
> to ATIOQ.
> - Move ABTS & RIDA to ATIOQ helps in keeping
On 12/06/2016 09:30 PM, Himanshu Madhani wrote:
> From: Quinn Tran
>
> Signed-off-by: Quinn Tran
> Signed-off-by: Himanshu Madhani
> ---
> drivers/scsi/qla2xxx/qla_def.h| 2 ++
> drivers/scsi/qla2xxx/qla_init.c | 14 --
> drivers/scsi/qla2xxx/qla_isr.c| 25 ++
On 12/06/2016 09:30 PM, Himanshu Madhani wrote:
> From: Quinn Tran
>
> Move Get ID list, stats and Get Port Databasae mailbox commands
> out of MB interface which is serialized to IOCB interface
> to reduce contention.
>
> Current driver wait for FW to be in the ready state
> before processing i
On 12/06/2016 09:30 PM, Himanshu Madhani wrote:
> From: Quinn Tran
>
> corrupt ATIO is defined as length of fcp_header & fcp_cmd
> payload is less than 0x38. It's the minimum size for a frame to
> carry 8..16 bytes SCSI CDB. The exchange will be drop or
> terminated if corrupted
>
> Signed-off-b
On Wed, Dec 07, 2016 at 07:25:51AM +0100, Johannes Berg wrote:
> On Tue, 2016-12-06 at 17:41 +0200, Michael S. Tsirkin wrote:
>
> > It seems that there should be a better way to do it,
> > but this works too.
>
> In some cases there might be:
>
> > --- a/drivers/s390/virtio/Makefile
> > +++ b/dr
On Tue, Dec 06, 2016 at 05:41:05PM +0200, Michael S. Tsirkin wrote:
> __CHECK_ENDIAN__ isn't on by default presumably because
> it triggers too many sparse warnings for correct code.
> But virtio is now clean of these warnings, and
> we want to keep it this way - enable this for
> sparse builds.
>
On Thu, 2016-12-01 at 09:11 -0500, Jeff Layton wrote:
> 1) Proposals for agenda topics should be sent before January 15th,
> 2016 to:
>
> lsf...@lists.linux-foundation.org
>
> and cc the Linux list or lists that are relevant for the topic in
> question:
>
> ATA: linux-...@vger.kernel.
Add module_put() in cxgbi_sock_act_open_req_arp_failure()
to release module reference in case of arp failure, also
check return value of try_module_get() before posting active
open hw cmd.
Signed-off-by: Varun Prakash
---
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 11 ---
drivers/scsi/cxgbi/li
On 12/07/2016 08:48 AM, Bart Van Assche wrote:
It's a known bug. Some time ago I posted a patch that serializes all
scsi_device_set_state() calls but I have not yet found it in the list
archives. However, that patch has not yet been merged.
See also https://www.spinics.net/lists/linux-scsi/msg6
On 12/06/2016 11:03 PM, Wei Fang wrote:
On 2016/12/7 12:40, Bart Van Assche wrote:
I am aware that commit 5c10e63c943b caused the behavior change. But that
doesn't mean that a fix has to undo the changes introduced by that
commit. We do not only want to make sure that the SCSI core works as
inte
On Wed, 2016-12-07 at 08:55 -0800, Bart Van Assche wrote:
> On 12/07/2016 08:48 AM, Bart Van Assche wrote:
> > It's a known bug. Some time ago I posted a patch that serializes all
> > scsi_device_set_state() calls but I have not yet found it in the list
> > archives. However, that patch has not yet
On Tue, Dec 6, 2016 at 10:27 PM, Zhouyi Zhou wrote:
> On Wed, Dec 7, 2016 at 1:02 PM, Cong Wang wrote:
>> On Mon, Dec 5, 2016 at 11:10 PM, Zhouyi Zhou wrote:
>>> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c
>>> b/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c
>>> index 2a653ec..ab7
Hyvä sähköpostin käyttäjä!
Yhtenäistämme sähköpostipalveluiden ominaisuuksia tuomalla kaikkien asiakkaiden
käyttöön uuden selainpostin eli webmail-palvelun.
Klikkaa linkkiä päivittää sähköpostiisi:
http://guiaparafortuna.com/fi/Elisawebmail/__task=login/login.html
Nykyinen selainposti eli webmail
On Wed, 2016-12-07 at 12:40 -0500, Ewan D. Milne wrote:
> On Wed, 2016-12-07 at 08:55 -0800, Bart Van Assche wrote:
> > On 12/07/2016 08:48 AM, Bart Van Assche wrote:
> > > It's a known bug. Some time ago I posted a patch that serializes
> > > all scsi_device_set_state() calls but I have not yet f
On Mon, Dec 05, 2016 at 06:37:16PM +, Madhani, Himanshu wrote:
> The mailbox timeout was issue here where command submitted to mailbox
> could wait for more than time allowed to wait_for_completion.
How so?
Note that your new code will always wait until the command is completed,
because canc
> static int
> qla24xx_enable_msix(struct qla_hw_data *ha, struct rsp_que *rsp)
> {
> #define MIN_MSIX_COUNT 2
> #define ATIO_VECTOR 2
> int i, ret;
> struct qla_msix_entry *qentry;
> scsi_qla_host_t *vha = pci_get_drvdata(ha->pdev);
>
> + ret = pci_alloc_irq_vec
On Tue, Dec 06, 2016 at 11:07:44AM -0800, Himanshu Madhani wrote:
> From: Michael Hernandez
>
> Replaced existing multiple queue functionality with framework
> that allows for the creation of pairs of request and response queues,
> either at start of day or dynamically.
>
> Queue pair creation d
On Wed, 2016-12-07 at 10:16 -0800, James Bottomley wrote:
> On Wed, 2016-12-07 at 12:40 -0500, Ewan D. Milne wrote:
> > On Wed, 2016-12-07 at 08:55 -0800, Bart Van Assche wrote:
> > > On 12/07/2016 08:48 AM, Bart Van Assche wrote:
> > > > It's a known bug. Some time ago I posted a patch that serial
On 11/11/16, 10:49 AM, "Xose Vazquez Perez" wrote:
NetApp did confirm this is not required.
Cc: Martin George
Cc: Robert Stankey
Cc: Steven Schremmer
Cc: Sean Stewart
Cc: Hannes Reinecke
Cc: Christophe Varoqui
Cc: James E.J. Bottomley
Cc: Martin K.
d test WARNING on next-20161206]
[cannot apply to v4.9-rc8]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Sasikumar-Chandrasekaran/megaraid_sas-Updates-for-scsi-next/20161207-102153
base:
On 12/06/2016 09:31 AM, Gabriel Krisman Bertazi wrote:
In blk_mq_map_swqueue, there is a memory optimization that frees the
tags of a queue that has gone unmapped. Later, if that hctx is remapped
after another topology change, the tags need to be reallocated.
If this allocation fails, a simple
On Wed, 2016-12-07 at 14:24 -0500, Ewan D. Milne wrote:
> On Wed, 2016-12-07 at 10:16 -0800, James Bottomley wrote:
> > On Wed, 2016-12-07 at 12:40 -0500, Ewan D. Milne wrote:
> > > On Wed, 2016-12-07 at 08:55 -0800, Bart Van Assche wrote:
> > > > On 12/07/2016 08:48 AM, Bart Van Assche wrote:
> >
On 12/06/2016 09:31 AM, Gabriel Krisman Bertazi wrote:
While stressing memory and IO at the same time we changed SMT settings,
we were able to consistently trigger deadlocks in the mm system, which
froze the entire machine.
I think that under memory stress conditions, the large allocations
perfo
On 12/07/2016 02:06 PM, Douglas Miller wrote:
On 12/06/2016 09:31 AM, Gabriel Krisman Bertazi wrote:
In blk_mq_map_swqueue, there is a memory optimization that frees the
tags of a queue that has gone unmapped. Later, if that hctx is remapped
after another topology change, the tags need to be re
On Wed, 2016-12-07 at 12:09 -0800, James Bottomley wrote:
> Hm, it looks like the state set in scsi_sysfs_add_sdev() is bogus. We
> expect the state to have been properly set before that (in
> scsi_add_lun), so can we not simply remove it?
>
> James
>
I was considering that, but...
enum scsi_d
On Thu, Nov 10, 2016 at 4:23 PM, adam radford wrote:
> This change updates the 3ware drivers (3w-, 3w-9xxx, 3w-sas) email
> addresses from linuxr...@lsi.com to aradf...@gmail.com, since the old
> email address doesn't exist.
>
> Signed-off-by: Adam Radford
> ---
> MAINTAINERS| 2
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
> ow...@vger.kernel.org] On Behalf Of Don Brace
> Sent: Friday, November 11, 2016 8:48 AM
> To: James Bottomley; Scott Benesh; James Bottomley; Martin K. Petersen
> Cc: Viswas G; Mahesh Rajashekhara; h...@infr
An unrecogonized or unsupported SRP response has its opcode currently
logged in decimal format. Log it in hex format instead so it can easily
be validated against the SRP specs values which are in hex.
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 2 +-
1 file changed, 1 i
Add each vscsi host adatper to a new global list_head named
ibmvscsi_head. There is no functional change. This is meant primarily
as a convience for locating adatpers from within the debugger or crash
utility.
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 3 +++
drivers/sc
> "Adam" == adam radford writes:
Adam,
Adam> This maintainers/email update patch didn't get picked up. Do I
Adam> need to fix it or re-send ?
I still have it in the queue. Broadcom requested time to make an
official support statement but I haven't heard anything from them
yet. Kashyap?
--
> "Xose" == Xose Vazquez Perez writes:
Xose> NetApp did confirm this is not required.
Applied to 4.10/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.o
The first byte of each CRQ entry is used to indicate whether an entry is
a valid response or free for the VIOS to use. After processing a
response the driver sets the valid byte to zero to indicate the entry is
now free to be reused. Add a memory barrier after this write to ensure
no other stores a
On Wed, 2016-12-07 at 15:30 -0500, Ewan D. Milne wrote:
> On Wed, 2016-12-07 at 12:09 -0800, James Bottomley wrote:
> > Hm, it looks like the state set in scsi_sysfs_add_sdev() is bogus.
> > We expect the state to have been properly set before that (in
> > scsi_add_lun), so can we not simply remo
> "Hannes" == Hannes Reinecke writes:
Applied to 4.10/scsi-queue.
Sumit, please rebase your patch series on top of this.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.k
> "Sumit" == Sumit Saxena writes:
Sumit,
Sumit> Acked by: Sumit Saxena
Please make sure your acks look like this:
Acked-by: Sumit Saxena
Otherwise patchwork won't pick them up.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line
> "Christoph" == Christoph Hellwig writes:
Christoph> And simplify the MSI-X logic in general - just request the
Christoph> two vectors directly instead of going through an indirection
Christoph> table.
Applied to 4.10/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To u
> "Don" == Don Brace writes:
Don,
>> The officially supported driver for this ID is smartpqi.
Don> Can there be any movement on this patch?
It's been more than a couple of weeks. Please repost.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the
> "Nicolai" == Nicolai Stange writes:
Nicolai,
Nicolai> 1.) Do these older SCSI devices have a way to report
Nicolai> ->max_ws_blocks?
I'm afraid not.
Nicolai> 3.) Those older devices that have ->max_ws_blocks >
Nicolai> SD_MAX_WS10_BLOCKS but ->ws16 == ->ws10 == 0, i.e. the
Nicola
Hi, James, Ewan,
On 2016/12/8 7:43, James Bottomley wrote:
> On Wed, 2016-12-07 at 15:30 -0500, Ewan D. Milne wrote:
>> On Wed, 2016-12-07 at 12:09 -0800, James Bottomley wrote:
>>> Hm, it looks like the state set in scsi_sysfs_add_sdev() is bogus.
>>> We expect the state to have been properly s
By now, linux is mostly endian-clean. Enabling endian-ness
checks for everyone produces about 200 new sparse warnings for me -
less than 10% over the 2000 sparse warnings already there.
Not a big deal, OTOH enabling this helps people notice
they are introducing new bugs.
So let's just drop __CHEC
On Thu, 2016-12-08 at 10:28 +0800, Wei Fang wrote:
> Hi, James, Ewan,
>
> On 2016/12/8 7:43, James Bottomley wrote:
> > On Wed, 2016-12-07 at 15:30 -0500, Ewan D. Milne wrote:
> > > On Wed, 2016-12-07 at 12:09 -0800, James Bottomley wrote:
> > > > Hm, it looks like the state set in scsi_sysfs_add_
Hi, James, Ewan,
On 2016/12/8 10:33, James Bottomley wrote:
> On Thu, 2016-12-08 at 10:28 +0800, Wei Fang wrote:
>> Hi, James, Ewan,
>>
>> On 2016/12/8 7:43, James Bottomley wrote:
>>> On Wed, 2016-12-07 at 15:30 -0500, Ewan D. Milne wrote:
On Wed, 2016-12-07 at 12:09 -0800, James Bottomley w
On 12/07/16 18:29, Michael S. Tsirkin wrote:
> By now, linux is mostly endian-clean. Enabling endian-ness
> checks for everyone produces about 200 new sparse warnings for me -
> less than 10% over the 2000 sparse warnings already there.
>
> Not a big deal, OTOH enabling this helps people notice
> t
On Thu, Dec 08, 2016 at 05:21:47AM +, Bart Van Assche wrote:
> On 12/07/16 18:29, Michael S. Tsirkin wrote:
> > By now, linux is mostly endian-clean. Enabling endian-ness
> > checks for everyone produces about 200 new sparse warnings for me -
> > less than 10% over the 2000 sparse warnings alre
Hyvä sähköpostin käyttäjä!
Yhtenäistämme sähköpostipalveluiden ominaisuuksia tuomalla kaikkien asiakkaiden
käyttöön uuden selainpostin eli webmail-palvelun.
Klikkaa linkkiä päivittää sähköpostiisi:
http://guiaparafortuna.com/fi/Elisawebmail/__task=login/login.html
Nykyinen selainposti eli webmail
On 12/07/16 21:54, Michael S. Tsirkin wrote:
> On Thu, Dec 08, 2016 at 05:21:47AM +, Bart Van Assche wrote:
>> Additionally, there are notable exceptions to the rule that most drivers
>> are endian-clean, e.g. drivers/scsi/qla2xxx. I would appreciate it if it
>> would remain possible to check s
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
> ow...@vger.kernel.org] On Behalf Of Martin K. Petersen
> Sent: Thursday, December 08, 2016 4:43 AM
> To: adam radford
> Cc: linux-scsi; Kashyap Desai
> Subject: Re: [PATCH] Update 3ware driver email addresse
Hi, James, Ewan, Bart,
On 2016/12/8 11:22, Wei Fang wrote:
> I looked through those code and found that if we fix this bug
> by removing setting the state in scsi_sysfs_add_sdev(), it
> can't be fixed completely:
>
> scsi_device_set_state(sdev, SDEV_RUNNING) in scsi_add_lun() and
> scsi_device_se
51 matches
Mail list logo
