4.8-stable review patch. If anyone has any objections, please let me know.
--
From: Andrey Grodzovsky
commit 18f6084a989ba1b38702f9af37a2e4049a924be6 upstream.
This is a work around for a bug with LSI Fusion MPT SAS2 when perfoming
secure erase. Due to the very long time the o
4.4-stable review patch. If anyone has any objections, please let me know.
--
From: Andrey Grodzovsky
commit 18f6084a989ba1b38702f9af37a2e4049a924be6 upstream.
This is a work around for a bug with LSI Fusion MPT SAS2 when perfoming
secure erase. Due to the very long time the o
> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Tuesday, November 29, 2016 8:58 AM
> To: Cathy Avery
> Cc: KY Srinivasan ; Haiyang Zhang
> ; j...@linux.vnet.ibm.com;
> martin.peter...@oracle.com; de...@linuxdriverproject.org; linux-
> ker...@vg
On Tue, Nov 29, 2016 at 10:18:09PM +0530, Martin K. Petersen wrote:
> > "Quentin" == Quentin Lambert writes:
>
> Quentin> Most error branches following the call to dst_neigh_lookup
> Quentin> contain a call to neigh_release. This patch add these calls
> Quentin> where they are missing.
>
> V
On 11/18/2016 07:10 AM, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig
> ---
> drivers/scsi/isci/host.h | 1 -
> drivers/scsi/isci/init.c | 21 +
> 2 files changed, 9 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/scsi/isci/host.h b/drivers/scsi/isci/ho
Signed-off-by: Christoph Hellwig
---
drivers/scsi/isci/host.h | 1 -
drivers/scsi/isci/init.c | 23 ++-
2 files changed, 10 insertions(+), 14 deletions(-)
diff --git a/drivers/scsi/isci/host.h b/drivers/scsi/isci/host.h
index 22a9bb1..b353992 100644
--- a/drivers/scsi/isci/h
On Fri, 2016-11-25 at 12:56 -0500, Ewan Milne wrote:
> I think what we need to understand is what caused the regression in the
> first place, I probably should have been bisecting the original failure
> rather than trying to find where it started working.
>
Bisecting leads to this commit:
commit
> "Cathy" == Cathy Avery writes:
Cathy> On a 32 bit kernel sizeof(void *) is not 64 bits as hv_mpb_array
Cathy> requires. Also the buffer needs to be cleared or the upper bytes
Cathy> will contain junk.
Applied to 4.10/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To u
> "KY" == KY Srinivasan writes:
KY> Done.
Thank you!
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-i
> "Souptick" == Souptick Joarder writes:
Souptick> In lpfc_new_scsi_buf_s3() and lpfc_new_scsi_buf_s4()
Souptick> pci_pool_alloc followed by memset will be replaced by
Souptick> pci_pool_zalloc()
Applied to 4.10/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscr
> "Uma" == Uma Krishnan writes:
Uma> The first four patches in this patch series include fixes for
Uma> command room violation and lun table management.
Applied patches 1-4 to 4.10/scsi-queue. The remainder of the series
needs review.
Thanks!
--
Martin K. Petersen Oracle Linux Engine
> "Quentin" == Quentin Lambert writes:
Quentin> Most error branches following the call to dst_neigh_lookup
Quentin> contain a call to neigh_release. This patch add these calls
Quentin> where they are missing.
Applied to 4.10/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
-
> "Arun" == Arun Easi writes:
Arun,
Arun> So far, we have been posting qedi changes split into functional
Arun> blocks, for review, but was not bisectable. With Martin ok to our
Arun> request to squash all patches while committing to tree, we were
Arun> wondering if we should post the qedi p
> "Greg" == Greg Kroah-Hartman writes:
Greg,
Greg> From: Andrey Grodzovsky
Greg> commit 18f6084a989ba1b38702f9af37a2e4049a924be6 upstream.
Please also queue 7ff723ad0f87 ("scsi: mpt3sas: Unblock device after
controller reset") which just hit Linus' tree. It's a bug fix for the
patch above
> "Nilesh" == Javali, Nilesh writes:
Nilesh> We would test this internally and then ACK within a week.
Sounds good. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vge
Thanks for the response, Martin.
On Wed, 30 Nov 2016, 8:45am, Martin K. Petersen wrote:
> > "Arun" == Arun Easi writes:
>
> Arun,
>
> Arun> So far, we have been posting qedi changes split into functional
> Arun> blocks, for review, but was not bisectable. With Martin ok to our
> Arun> requ
We recently introduced a kfree() in the caller for this function.
That's where, logically, you would think the kfree() should be.
Unfortunately the code was just ugly and not buggy so the static
checker warning was a false postive and introduced a double free.
I've removed the old kfree() and left
On 11/30/2016 08:36 PM, Dan Carpenter wrote:
We recently introduced a kfree() in the caller for this function.
That's where, logically, you would think the kfree() should be.
Unfortunately the code was just ugly and not buggy so the static
checker warning was a false postive and introduced a do
Signed-off-by: Himanshu Madhani
Signed-off-by: Giridhar Malavali
---
drivers/scsi/qla2xxx/qla_mbx.c | 52 ++
1 file changed, 52 insertions(+)
diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
index 23698c9..b31c36b 100644
--- a/
From: Samy
Signed-off-by: Samy
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_def.h | 3 ++
drivers/scsi/qla2xxx/qla_mbx.c | 88 ++
drivers/scsi/qla2xxx/qla_os.c | 24
3 files changed, 91 insertions(+), 24 deletions(-)
diff
From: Michael Hernandez
Replaced existing multiple queue functionality with framework
that allows for the creation of pairs of request and response queues,
either at start of day or dynamically.
Signed-off-by: Sawan Chandak
Signed-off-by: Michael Hernandez
Signed-off-by: Himanshu Madhani
---
From: Quinn Tran
- Fix race condition between dpc_thread accessing Multiqueue resources
and qla2x00_remove_one thread trying to free resource.
- Fix out of order free for Multiqueue resources. Also, Multiqueue
interrupts needs a workqueue. Interrupt needed to stop before
the wq can be destr
From: Sawan Chandak
Tell the SCSI layer how many hardware queues we have based on the number
of max queue pairs created. The number of max queue pairs created will
depend on number of MSI X vector count or number of CPU's in a system.
This feature can be turned on via CONFIG_SCSI_MQ_DEFAULT or p
Hi Martin,
Please consider this revised series for scsi-misc inclusion
at your earliest convenience.
Changes from v1 --> v2
o Split up the patches for Multiqueue into infrastucture changes
and support for adding multiqueue capablity in the driver as
per Ewan's suggestion.
o Incorporate new p
Looks good. Thanks! Here is an updated version that should apply
cleanly on top of scsi-next.
8<
From: Benjamin Herrenschmidt
LSIs must be ack'ed with an MMIO otherwise they remain asserted
forever. This is controlled by the "clear_isr" flag.
While we set that flag properly when deciding initi
From: "Matthew R. Ochs"
As staging for the removal of the AFU command pool, remove the reliance
upon the pool for the internal AFU sync command. Instead of obtaining an
AFU command from the pool, dynamically allocate memory with the appropriate
alignment requirements. Since the AFU sync service
From: "Matthew R. Ochs"
The cxlflash driver originally required a per-command 4K buffer that
hosted data passed to the AFU. When the routines that initiate AFU
and internal SCSI commands were refactored to use scsi_execute(), the
need for this buffer became obsolete. As it is no longer necessary
This looks good !
From: "Matthew R. Ochs"
Instead of using a private pool of AFU commands, use cmd_size to prime
the private pool of SCSI commands such that they are allocated with a
size large enough to contain an aligned AFU command. Use scsi_cmd_priv()
to derive the aligned/zeroed private c
From: "Matthew R. Ochs"
The send_tmf() routine includes some copy/paste cruft that can be
removed as well as the setting of an AFU command-specific while
holding the tmf_slock. While not a bug, it is out of place and
should be shifted down alongside the other command initialization
statements fo
From: "Matthew R. Ochs"
Clean up and remove the remaining private command pool infrastructure
that is no longer required.
Signed-off-by: Matthew R. Ochs
Acked-by: Uma Krishnan
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vge
From: "Matthew R. Ochs"
The original design of the cxlflash driver required AFU commands
to convey state information across multiple threads. The IOASA
"host use" byte was used to track if a command was done, errored,
or timed out. A per-command spin lock was used to serialize access
to this byt
From: "Matthew R. Ochs"
With the removal of the static private command pool, the ability to
'complete' outstanding commands was lost. While not an issue for the
commands originating outside the driver, internal AFU commands are
synchronous and therefore have a timeout associated with them. To
av
From: "Matthew R. Ochs"
The queuecommand routine is disorganized where it populates the
private command and also contains some logic/statements that are
not needed given that cxlflash devices do not (and likely never
will) support scatter-gather.
Restructure the code to remove the unnecessary l
From: "Matthew R. Ochs"
As staging for supporting hardware with a different queuing mechanism,
move the send_cmd() and context_reset() routines to function pointers
that are configured when the AFU is initialized. In addition, rename
the existing routines to better reflect the queue model they s
From: "Matthew R. Ochs"
Currently, when sending a SCSI command, the pointer is stored in a
reserved field of the AFU command descriptor for retrieval once the
SCSI command has completed. In order to support new descriptor formats
that make use of the reserved field, the pointer is migrated to ou
Passing one instead of 8 or 16 arguments reduces the size of the
generated code somewhat:
add/remove: 2/3 grow/shrink: 1/4 up/down: 1772/-2137 (-365)
There's one more candidate, unique_id_show, but that uses %02X, and I'm
not sure it would be ok to start using lowercase there, so I've left it
alo
Your shipment(s) is scheduled for delivery
Scheduled Delivery Date: 12/02/2016
Shipper: Chambers Group.
Kindly view the attached document for shipment/delivery details and
tracking procedure. You can also request a delivery change (e.g.
reschedule or reroute) from the tracking detail.
Approxima
> "Dan" == Dan Carpenter writes:
Dan> We recently introduced a kfree() in the caller for this function.
Dan> That's where, logically, you would think the kfree() should be.
Dan> Unfortunately the code was just ugly and not buggy so the static
Dan> checker warning was a false postive and intro
> "Uma" == Uma Krishnan writes:
Uma> The first four patches in this patch series include fixes for
Uma> command room violation and lun table management.
Applied patches 5 through 14 to 4.10/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: se
> "Brian" == Brian King writes:
Brian> Looks good. Thanks! Here is an updated version that should apply
Brian> cleanly on top of scsi-next.
Applied to 4.10/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe l
On Mon, Nov 28, 2016 at 4:56 PM, Souptick Joarder wrote:
> Inside mvs_task_prep(), pci_pool_alloc() followed by memset will be
> replaced by pci_pool_zalloc()
>
> Signed-off-by: Souptick joarder
> ---
> drivers/scsi/mvsas/mv_sas.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> dif
On Wed, Nov 30, 2016 at 11:49:56AM -0500, Martin K. Petersen wrote:
> > "Greg" == Greg Kroah-Hartman writes:
>
> Greg,
>
> Greg> From: Andrey Grodzovsky
>
> Greg> commit 18f6084a989ba1b38702f9af37a2e4049a924be6 upstream.
>
> Please also queue 7ff723ad0f87 ("scsi: mpt3sas: Unblock device a
On 11/30/2016 05:21 PM, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig
Reviewed-by: Artur Paszkiewicz
Thanks,
Artur
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.ker
On 11/30/2016 09:24 PM, Himanshu Madhani wrote:
> From: Samy
>
> Signed-off-by: Samy
> Signed-off-by: Himanshu Madhani
> ---
> drivers/scsi/qla2xxx/qla_def.h | 3 ++
> drivers/scsi/qla2xxx/qla_mbx.c | 88
> ++
> drivers/scsi/qla2xxx/qla_os.c | 24
44 matches
Mail list logo