On Wed, Nov 16, 2016 at 05:58:14PM +0100, Arnd Bergmann wrote:
> On Tuesday, November 15, 2016 4:05:31 PM CET Johannes Thumshirn wrote:
> > On Tue, Nov 15, 2016 at 02:50:17PM +, Bart Van Assche wrote:
> > > On Tue, 2016-11-15 at 10:18 +0100, Johannes Thumshirn wrote:
> > > > On Tue, Nov 08, 201
Export fc_bsg_jobdone so drivers can use it directly instead of doing
the round-trip via struct fc_bsg_job::job_done() and use it in the LLDDs.
That way we can also unify the interfaces of fc_bsg_jobdone and bsg_job_done.
As we've converted all LLDDs over to use fc_bsg_jobdone() directly,
we can r
struct fc_bsg_buffer is just a clone of struct bsg_buffer from bsg-lib,
so use this one instead.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
Reviewed-by: Christoph Hellwig
---
drivers/scsi/lpfc/lpfc_bsg.c | 3 ++-
drivers/scsi/scsi_transport_fc.c | 2 +-
include/scsi/s
Provide fc_bsg_to_rport() helper that will become handy when we're moving
from struct fc_bsg_job to a plain struct bsg_job. Also move all LLDDs to use
the new helper.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
Acked-by: Tyrel Datwyler
---
drivers/s390/scsi/zfcp_fc.c |
fc_destroy_bsgjob() and bsg_destroy_job() are now 1:1 copies, so use the
later. As bsg_destroy_job() comes from bsg-lib we need to select it in Kconfig
once CONFOG_SCSI_FC_ATTRS is active.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
block/bsg-lib.c | 7 +
Now that all conversions are done, move the FibreChannel bsg code over to the
bsg library.
This patch is derived from work done by Mike Christie in 2011 [1] but only the
iscsi parts got merged back then.
[1] http://marc.info/?l=linux-scsi&m=131149780921009&w=2
Signed-off-by: Johannes Thumshirn
fc_bsg_jobdone() and bsg_job_done() are 1:1 copies now so use the bsg-lib one
instead of the FC private implementation.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
Acked-by: Tyrel Datwyler
---
drivers/s390/scsi/zfcp_fc.c | 2 +-
drivers/scsi/bfa/bfad_bsg.c | 4 ++
Change FC drivers to use 'struct bsg_job' from bsg-lib.h instead of 'struct
fc_bsg_job' from scsi_transport_fc.h and remove 'struct fc_bsg_job'.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
Acked-by: Tyrel Datwyler
---
drivers/s390/scsi/zfcp_ext.h | 4 +--
drivers/s390/s
Don't use fc_bsg_job::request and fc_bsg_job::reply directly, but use
helper variables bsg_request and bsg_reply. This will be helpfull when
transitioning to bsg-lib.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
drivers/s390/scsi/zfcp_fc.c | 9 +-
drivers/scsi/bfa/
Add bsg_job_put() and bsg_job_get() so don't need to export
bsg_destroy_job() any more.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
block/bsg-lib.c | 17 ++---
drivers/scsi/scsi_transport_fc.c | 4 ++--
include/linux/bsg-lib.h | 3 +
bsg_softirq_done() and fc_bsg_softirq_done() are copies of each other, so
ditch the fc specific one.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
block/bsg-lib.c | 3 ++-
drivers/scsi/scsi_transport_fc.c | 15 ++-
include/linux/bsg-lib.h
Implement kref backed reference counting instead of rolling our own. This
elimnates the need of the following fields in 'struct fc_bsg_job':
* ref_cnt
* state_flags
* job_lock
bringing us close to unification of 'struct fc_bsg_job' and 'struct bsg_job'.
Signed-off-by: Johannes Thumshirn
---
driv
Provide fc_bsg_to_shost() helper that will become handy when we're moving from
struct fc_bsg_job to a plain struct bsg_job. Also use this little helper in
the LLDDs.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
Acked-by: Tyrel Datwyler
---
drivers/s390/scsi/zfcp_fc.c |
Don't set FC_RQST_STATE_DONE before calling fc_bsg_jobdone() as
fc_bsg_jobdone() calls blk_complete_requeust() which raises a soft-IRQ that
ends up in fc_bsg_sofirq_done() and fc_bsg_softirq_done() sets the
FC_RQST_STATE_DONE flag.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
-
While issuing any ATA Pass-through command to Firmware,
driver will block the device, it will unblock the device only if that
IO completes through ISR path. But if in-between any host reset
occurs then driver won't unblock the device and
device will be in blocked state.
Signed-off-by: Suganath Pra
Older controllers use SCSI target id '0' for the first internal
disk. As the controllers are now placed on the same bus than the
internal disks this leads to a clash with the SCSI target id of
controller.
This patch checks the SCSI revision, and moves older controller
to bus '3' to be compatible wi
On 11/16/2016 05:09 PM, brace77...@gmail.com wrote:
> On 10/31/2016 02:06 PM, Don Brace wrote:
>> On 10/27/2016 01:15 PM, Jack Suter wrote:
>>> Hi there,
>>>
>>> Commit "hpsa: Change SAS transport devices to bus 0."
>>> (09371d623c9c3dc6ed7f53ec8ab01d25f0c6c697) breaks the hpacucli utility
>>> for
On 11/17/2016 10:31 AM, Johannes Thumshirn wrote:
> Implement kref backed reference counting instead of rolling our own. This
> elimnates the need of the following fields in 'struct fc_bsg_job':
> * ref_cnt
> * state_flags
> * job_lock
> bringing us close to unification of 'struct fc_bsg_job' and '
On Thursday, November 17, 2016 1:39:27 PM CET Johannes Thumshirn wrote:
> Commit 540eb1eef 'scsi: libfc: fix seconds_since_last_reset calculation'
> removed the use of 'struct timespec' from fc_get_host_stats(). This broke the
> output of 'fcoeadm -s' after kernel 4.8-rc1.
>
> Fixes: 540eb1eef ('s
On 1.11.2016 17:40, Tomas Henzl wrote:
> rport can't be null here, it would have failed already in
> fc_remote_port_chkready
>
> Signed-off-by: Tomas Henzl
Martin,
another (better) patch "fnic: Correcting rport check location in
fnic_queuecommand_lck"
has been added to 4.10/scsi-queue.
Please
This series has two patches: the first is a simple conversion of
lpfc to use pci_alloc_irq_vectors. The second is more interesting,
and makes use of the PCI_IRQ_AFFINITY option to use the core interrupt
affinity assignment that takes nodes into account and can be easily
queried. It also ensures w
This avoids having to store the msix_entries array and simpliefies the
shutdown and cleanup path a lot.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/lpfc/lpfc.h | 2 -
drivers/scsi/lpfc/lpfc_init.c | 240 ++
drivers/scsi/lpfc/lpfc_sli4.h | 1
Commit 540eb1eef 'scsi: libfc: fix seconds_since_last_reset calculation'
removed the use of 'struct timespec' from fc_get_host_stats(). This broke the
output of 'fcoeadm -s' after kernel 4.8-rc1.
Fixes: 540eb1eef ('scsi: libfc: fix seconds_since_last_reset calculation')
Signed-off-by: Johannes Thu
Dear Linux folks,
On 11/16/16 22:24, Donald Buczek wrote:
On 10.11.2016 14:59, Martin K. Petersen wrote:
"Paul" == Paul Menzel writes:
Linux does not provide device discovery ordering guarantees. You need
to fix your scripts to use UUIDs, filesystem labels, or DM devices to
get stable nami
Use the PCI_IRQ_AFFINITY flags to pci_alloc_irq_vectors to get automatic
assignment of irq affinity from the core PCI and interrupt handling code.
For blk-mq we just have to wire it up to the default map_queues handler,
and for the non blk-mq case we keep a local copy of the map_queues helper,
whi
Add reference counting to 'struct bsg_job' so we can implement a reuqest
timeout handler for bsg_jobs, which is needed for Fibre Channel.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
block/bsg-lib.c | 7 +--
include/linux/bsg-lib.h | 2 ++
2 files changed, 7 in
On 11/17/2016 04:39 AM, Johannes Thumshirn wrote:
Commit 540eb1eef 'scsi: libfc: fix seconds_since_last_reset calculation'
removed the use of 'struct timespec' from fc_get_host_stats(). This broke the
output of 'fcoeadm -s' after kernel 4.8-rc1.
Reviewed-by: Bart Van Assche
--
To unsubscribe f
Unexport bsg_softirq_done() again, we don't need it outside of bsg-lib.c
anymore now that scsi_transport_fc is a pure bsg-lib client.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
block/bsg-lib.c | 3 +--
include/linux/bsg-lib.h | 1 -
2 files changed, 1 insertion(+
On 11/11/2016 08:49, wangyijing wrote:
I have not seen the flutter issue. I am just trying to solve the horrible WARN
dump.
However I do understand that there may be a issue related to how we queue the
events; there was a recent attempt to fix this, but it came to nothing:
https://www.spinics.n
This series converts the current bsg usage in the FibreChannel drivers over
to use bsg-lib. SAS will follow once FC is in a good enough shape.
I did take some inspiration from a similar patchset from Mike Christie
dating back to 2011 but it's not a 1:1 copy. Patch 15/16 is heavily based
on his ser
> On 2016-11-15 21:03, Kiwoong Kim wrote:
> > Some UFS host controllers may clear a transfer request slot
> > by setting an associated bit in UTRLCLR/UTMRLCLR to 1, not 0.
> > That's opposite to what UFS spec describes.
> >
>
> This was the comment on v2: "As Martin mentioned in other email, pleas
> On Nov 15, 2016, at 5:13 PM, Uma Krishnan wrote:
>
> The following Oops is encountered when blk_mq is enabled with the
> cxlflash driver:
>
> [ 2960.817172] Oops: Kernel access of bad area, sig: 11 [#5]
> [ 2960.817309] NIP __blk_mq_run_hw_queue+0x278/0x4c0
> [ 2960.817313] LR __blk_mq_run_hw
> On Nov 15, 2016, at 5:14 PM, Uma Krishnan wrote:
>
> During test, the following crash was observed:
>
> [34538.981505] Faulting instruction address: 0xd7c9c870
> cpu 0x9: Vector: 300 (Data Access) at [c007f1e8f590]
>pc: d7c9c870: cxlflash_restore_luntable+0x70/0x1d0 [cx
> On Nov 15, 2016, at 5:14 PM, Uma Krishnan wrote:
>
> Currently, the context reset routine waits for command room to
> be available before sending the reset request. Per review of the
> SISLite specification and clarifications from the CXL Flash AFU
> designers, this wait is unnecessary. The res
On 2016-11-17 05:52, Kiwoong Kim wrote:
On 2016-11-15 21:03, Kiwoong Kim wrote:
> Some UFS host controllers may clear a transfer request slot
> by setting an associated bit in UTRLCLR/UTMRLCLR to 1, not 0.
> That's opposite to what UFS spec describes.
>
This was the comment on v2: "As Martin men
Hi Uma,
I do see a potential hang issue with this patch. See my comments below.
-matt
> On Nov 15, 2016, at 5:14 PM, Uma Krishnan wrote:
>
> During test, a command room violation interrupt is occasionally seen
> for the master context when the CXL flash devices are stressed.
>
> After study
On 17.11.2016 15:55, Paul Menzel wrote:
Dear Linux folks,
On 11/16/16 22:24, Donald Buczek wrote:
The relevant commit is 703b5fa which includes
The commit message summary is *fs/dcache.c: Save one 32-bit multiply
in dcache lookup*.
static inline unsigned long end_name_hash(unsigned l
Thanks from me as well for the patch. I've tested it on the problematic
controller and it appears to be working. The hpsa driver isn't throwing
any errors and hpacucli works as expected.
Cheers,
Jack Suter
On Thu, Nov 17, 2016, at 06:17, Hannes Reinecke wrote:
> On 11/16/2016 05:09 PM, brace77..
Fix the printk continuations when running the mptfusion driver.
This patch brings the capabilities into one single syslog line again:
mptbase: ioc1: Initiating bringup
ioc1: LSI53C1030 B2: Capabilities={Initiator,Target}
scsi host3: ioc1: LSI53C1030 B2, FwRev=01032341h, Ports=1, MaxQ=255,
It appears on bus 3 for both hpsa and the sas transport for me. I can
test the patch on a few controllers with newer firmware too if you'd
like.
# lsscsi
[0:1:0:0]diskHP LOGICAL VOLUME 1.66 /dev/sda
[0:1:0:1]diskHP LOGICAL VOLUME 1.66 /dev/sdb
[0:1:0:2]disk
> -Original Message-
> From: Hannes Reinecke [mailto:h...@suse.de]
> Sent: Thursday, November 17, 2016 5:16 AM
> To: Don Brace
> Cc: Martin K. Petersen; Christoph Hellwig; James Bottomley; Johannes
> Thumshirn; Jack Suter; linux-scsi@vger.kernel.org; Hannes Reinecke; Hannes
> Reinecke
> Sub
Thanks for catching this Matt. Looking into this. Will send out a V2.
On 11/17/2016 1:36 PM, Matthew R. Ochs wrote:
Hi Uma,
I do see a potential hang issue with this patch. See my comments below.
-matt
On Nov 15, 2016, at 5:14 PM, Uma Krishnan wrote:
During test, a command room violation
https://bugzilla.kernel.org/show_bug.cgi?id=188061
Bug ID: 188061
Summary: On quad port QLE2564 can't add in target only 2 ports
Product: SCSI Drivers
Version: 2.5
Kernel Version: 4.8.6-201.fc24.x86_64
Hardware: x86-64
OS:
> "Johannes" == Johannes Thumshirn writes:
Johannes> Commit 540eb1eef 'scsi: libfc: fix seconds_since_last_reset
Johannes> calculation' removed the use of 'struct timespec' from
Johannes> fc_get_host_stats(). This broke the output of 'fcoeadm -s'
Johannes> after kernel 4.8-rc1.
Applied to 4.
> "Hannes" == Hannes Reinecke writes:
Hannes> Older controllers use SCSI target id '0' for the first internal
Hannes> disk. As the controllers are now placed on the same bus than the
Hannes> internal disks this leads to a clash with the SCSI target id of
Hannes> controller. This patch checks
> "Hannes" == Hannes Reinecke writes:
Hannes> Use pci_alloc_irq_vectors and drop the hand-crafted interrupt
Hannes> affinity routines.
Applied to 4.10/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> "Suganath" == Suganath Prabu S
> writes:
Suganath> While issuing any ATA Pass-through command to Firmware, driver
Suganath> will block the device, it will unblock the device only if that
Suganath> IO completes through ISR path. But if in-between any host
Suganath> reset occurs then dri
> "Helge" == Helge Deller writes:
Helge> Fix the printk continuations when running the mptfusion driver.
Helge> This patch brings the capabilities into one single syslog line
Helge> again:
Helge>mptbase: ioc1: Initiating bringup ioc1: LSI53C1030 B2:
Helge>Capabilities={Initiator,Targe
> "Tomas" == Tomas Henzl writes:
Tomas> Martin, another (better) patch "fnic: Correcting rport check
Tomas> location in fnic_queuecommand_lck" has been added to
Tomas> 4.10/scsi-queue.
Tomas> Please drop this one.
Done!
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe
> "John" == John Garry writes:
John> @Maintainers, would you be willing to accept this patch as an
John> interim fix for the dastardly WARN while we try to fix the flutter
John> issue?
I'll defer to James since I don't have much libsas experience.
--
Martin K. Petersen Oracle Linux En
On Thu, Nov 17, 2016 at 7:23 AM, John Garry wrote:
> On 11/11/2016 08:49, wangyijing wrote:
>
> I have not seen the flutter issue. I am just trying to solve the
> horrible WARN dump.
> However I do understand that there may be a issue related to how we
> queue the events; there
And simply the interrupt handler by splitting the INTx case that needs
to deal with shared interrupts into a separate helper.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/vmw_pvscsi.c | 104 +-
drivers/scsi/vmw_pvscsi.h | 5 ---
2 files changed,
Signed-off-by: Christoph Hellwig
---
drivers/scsi/isci/host.h | 1 -
drivers/scsi/isci/init.c | 21 +
2 files changed, 9 insertions(+), 13 deletions(-)
diff --git a/drivers/scsi/isci/host.h b/drivers/scsi/isci/host.h
index 22a9bb1..b353992 100644
--- a/drivers/scsi/isci/host
Signed-off-by: Christoph Hellwig
---
drivers/scsi/pmcraid.c | 92 ++
drivers/scsi/pmcraid.h | 1 -
2 files changed, 41 insertions(+), 52 deletions(-)
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 68a5c34..b517642 100644
--- a/
And simplify the MSI-X logic in general - just request the two
vectors directly instead of going through an indirection table.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/qla4xxx/ql4_def.h | 18 +
drivers/scsi/qla4xxx/ql4_glbl.h | 1 -
drivers/scsi/qla4xxx/ql4_isr.c | 25 +--
Hi all,
this is a patchset to get hpsa working on older controllers.
Most notably older controller do not support the extended REPORT PHYS
command, so we need to fallback to the legacy version here.
I've also added a new sysfs HBA attribute 'ctlr_num', which displays
the current controller number.
Older SmartArray controller do not support the extended REPORT PHYS
command, so fallback to use the legacy version here.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/hpsa.c | 28 ++--
1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/
NOT_READY is a sense key, not a legit scsi hostbyte value.
Use DID_NO_CONNECT instead.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/hpsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index ea64c01..488e17c 100644
--- a/drivers/
Add a sysfs attribute 'ctlr_num' holding the current HPSA controller
number. This is required to construct compability 'cciss' links.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/hpsa.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.
59 matches
Mail list logo
