On Tue, Nov 08, 2016 at 03:04:43PM +, Bart Van Assche wrote:
[...]
> Hello Johannes,
>
> I think the above code will miscalculate seconds_since_last_reset if
> 'jiffies' wraps around after an lport has been created and before
> seconds_since_last_reset is computed. Shouldn't seconds_since_
>-Original Message-
>From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
>Sent: Tuesday, November 15, 2016 5:18 AM
>To: Tomas Henzl
>Cc: linux-scsi@vger.kernel.org; sumit.sax...@broadcom.com;
>kashyap.de...@broadcom.com
>Subject: Re: [PATCH] megaraid-sas: request irqs later
>
>
Some UFS host controllers may think
granularitys of PRDT length and offset as bytes, not double words.
Signed-off-by: Kiwoong Kim
---
drivers/scsi/ufs/ufshcd.c | 28 +---
drivers/scsi/ufs/ufshcd.h | 6 ++
2 files changed, 27 insertions(+), 7 deletions(-)
diff --git
Some UFS host controllers may clear a transfer request slot
by setting an associated bit in UTRLCLR/UTMRLCLR to 1, not 0.
That's opposite to what UFS spec describes.
v2: modify the commit message, remove unrelated changes
Signed-off-by: Kiwoong Kim
---
drivers/scsi/ufs/ufshcd.c | 28 +++
Some UFS host controllers might not be able to
reset UIC by setting HCE to 1.
Those controllers should invoke 'DME reset' and 'DME enable'
in order instead.
V2
- modify the commit message
- change the name of the quirk
(s/UFSHCD_QUIRK_USE_OF_HCE/UFSHCD_QUIRK_BROKEN_HCE)
Signed-off-by: Kiwoong Kim
If UFS driver resets interrupt aggregation timer and counter
when there are some pended tasks, an IO competion interrupt
of any corresponing task may be issued.
That would casue a command timeout.
One thing you should mind to use interrupt aggreation
with this quirk is that the host controller sho
These things are defined to be used by some UFS Host controllers.
And a new file for some declarations of mphy standard is added
V2
- modify the commit message
- add a new macro for UECDL
- add two definitions about UECDL
- change the names of two macros
(s/IS_PWR_MODE_HS/IS_HS_PWR_MODE, s/IS_PWR_
On Tue, Oct 25, 2016 at 09:43:14AM +0200, Johannes Thumshirn wrote:
> On Fri, Oct 14, 2016 at 09:38:21AM +0200, Johannes Thumshirn wrote:
> > On Thu, Oct 13, 2016 at 05:55:11PM +0200, Steffen Maier wrote:
> > > Hm, still behaves for me like I reported for v2:
> > > http://marc.info/?l=linux-scsi&m=
We set ufshcd_state to UFSHCD_STATE_ERROR when an err handler
fails. So I think UFSHCD_STATE_ERROR means host not works any more.
Set it before schedule eh_work is not correct.
Signed-off-by: Zang Leigang
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 05c7456..a7724ad 1
A scan work can run simultaneously with fc_remote_port_delete().
If a scsi device is added to the ->__devices list in the scan work,
it can be touched and will be blocked in scsi_target_block(), and
QUEUE_FLAG_STOPPED will be setted to the scsi device's request queue.
But unfortunately, this flag w
Hi Johannes,
On 11/15/2016 12:56 PM, Johannes Thumshirn wrote:
On Tue, Oct 25, 2016 at 09:43:14AM +0200, Johannes Thumshirn wrote:
On Fri, Oct 14, 2016 at 09:38:21AM +0200, Johannes Thumshirn wrote:
On Thu, Oct 13, 2016 at 05:55:11PM +0200, Steffen Maier wrote:
Hm, still behaves for me like I
On Tue, Nov 15, 2016 at 03:31:27PM +0100, Steffen Maier wrote:
> Hi Johannes,
>
> On 11/15/2016 12:56 PM, Johannes Thumshirn wrote:
> > On Tue, Oct 25, 2016 at 09:43:14AM +0200, Johannes Thumshirn wrote:
> > > On Fri, Oct 14, 2016 at 09:38:21AM +0200, Johannes Thumshirn wrote:
> > > > On Thu, Oct
On Tue, 2016-11-15 at 10:18 +0100, Johannes Thumshirn wrote:
> On Tue, Nov 08, 2016 at 03:04:43PM +, Bart Van Assche wrote:
> > I think the above code will miscalculate seconds_since_last_reset
> > if
> > 'jiffies' wraps around after an lport has been created and before
> > seconds_since_last
On Tue, Nov 15, 2016 at 02:50:17PM +, Bart Van Assche wrote:
> On Tue, 2016-11-15 at 10:18 +0100, Johannes Thumshirn wrote:
> > On Tue, Nov 08, 2016 at 03:04:43PM +, Bart Van Assche wrote:
> > > I think the above code will miscalculate seconds_since_last_reset
> > > if
> > > 'jiffies' wrap
On Tue, Nov 15, 2016 at 03:31:27PM +0100, Steffen Maier wrote:
> Hi Johannes,
>
> On 11/15/2016 12:56 PM, Johannes Thumshirn wrote:
> > On Tue, Oct 25, 2016 at 09:43:14AM +0200, Johannes Thumshirn wrote:
> > > On Fri, Oct 14, 2016 at 09:38:21AM +0200, Johannes Thumshirn wrote:
> > > > On Thu, Oct
> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Monday, November 14, 2016 5:44 PM
> To: Don Brace
> Cc: j...@linux.vnet.ibm.com; John Hall; Kevin Barnett; Mahesh
> Rajashekhara; Bader Ali-saleh; h...@infradead.org; Scott Teel; Viswas G;
> Justin L
Hello, Rameshwar.
On Fri, Nov 11, 2016 at 01:36:28PM +0530, Rameshwar Sahu wrote:
> Hi Tejun,
>
> On Wed, Nov 9, 2016 at 10:15 PM, Tejun Heo wrote:
> > Hello,
> >
> > On Wed, Sep 14, 2016 at 04:15:00PM +0530, Rameshwar Sahu wrote:
> >> > @@ -821,8 +823,6 @@ static int xgene_ahci_probe(struct pla
Hi all,
I am back to Synopsys, so please don't apply the patches I sent a few weeks ago
with the goal of changing the UFS drivers author e-mail.
I will be available to help in anything you need.
Thanks,
Joao
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a
On 2016-11-15 02:49, Kiwoong Kim wrote:
Some UFS host controllers may think
granularitys of PRDT length and offset as bytes, not double words.
Signed-off-by: Kiwoong Kim
---
drivers/scsi/ufs/ufshcd.c | 28 +---
drivers/scsi/ufs/ufshcd.h | 6 ++
2 files changed, 27
On 2016-11-15 02:52, Kiwoong Kim wrote:
Some UFS host controllers may clear a transfer request slot
by setting an associated bit in UTRLCLR/UTMRLCLR to 1, not 0.
That's opposite to what UFS spec describes.
v2: modify the commit message, remove unrelated changes
As Martin mentioned in other ema
On 2016-11-15 02:55, Kiwoong Kim wrote:
Some UFS host controllers might not be able to
reset UIC by setting HCE to 1.
Those controllers should invoke 'DME reset' and 'DME enable'
in order instead.
V2
As Martin mentioned in other email, please separate this version history
from commit text wit
On 2016-11-15 02:57, Kiwoong Kim wrote:
If UFS driver resets interrupt aggregation timer and counter
when there are some pended tasks, an IO competion interrupt
of any corresponing task may be issued.
That would casue a command timeout.
One thing you should mind to use interrupt aggreation
with
On 2016-11-15 03:24, Kiwoong Kim wrote:
These things are defined to be used by some UFS Host controllers.
And a new file for some declarations of mphy standard is added
V2
- modify the commit message
- add a new macro for UECDL
- add two definitions about UECDL
- change the names of two macros
(
On 2016-11-15 04:25, Zang Leigang wrote:
We set ufshcd_state to UFSHCD_STATE_ERROR when an err handler
fails. So I think UFSHCD_STATE_ERROR means host not works any more.
Set it before schedule eh_work is not correct.
Signed-off-by: Zang Leigang
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers
From: Omar Sandoval
Let's not depend on any of the BLK_MQ_RQ_QUEUE_* constants having
specific values. No functional change.
Signed-off-by: Omar Sandoval
---
drivers/nvme/host/core.c | 4 ++--
drivers/nvme/host/pci.c| 8
drivers/nvme/host/rdma.c | 2 +-
drivers/nvme/target/loo
From: Omar Sandoval
Let's not depend on any of the BLK_MQ_RQ_QUEUE_* constants having
specific values. No functional change.
Signed-off-by: Omar Sandoval
---
drivers/scsi/scsi_lib.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi
On Tue, Nov 15, 2016 at 11:11:58AM -0800, Omar Sandoval wrote:
> From: Omar Sandoval
>
> Let's not depend on any of the BLK_MQ_RQ_QUEUE_* constants having
> specific values. No functional change.
>
> Signed-off-by: Omar Sandoval
Yeah, we've been depending on the values of BLK_MQ_RQ_QUEUE_[ERROR
On 11/15/2016 12:11 PM, Omar Sandoval wrote:
From: Omar Sandoval
Let's not depend on any of the BLK_MQ_RQ_QUEUE_* constants having
specific values. No functional change.
Thanks Omar, applied both for 4.10.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi
Hi Hannes,
Thank you for the patch
> -Original Message-
> From: Hannes Reinecke [mailto:h...@suse.de]
> Sent: Monday, November 7, 2016 11:12 PM
> To: Martin K. Petersen
> Cc: Christoph Hellwig; James Bottomley; linux-scsi@vger.kernel.org; Hannes
> Reinecke; Hannes Reinecke; dl-esc-Aacraid
- driver was not calling done in some cases which causes
the volume to be offlined.
- avoid doing rescan during a reset.
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 23 ++-
1 file changed, 22 insertions(+), 1 del
Signed-off-by: Satish Kharat
Signed-off-by: Sesidhar Baddela
---
MAINTAINERS | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index b3a7774..11fdf45 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3149,15 +3149,15 @@ S: Supported
F: d
On 11/14/2016 11:24 AM, Gabriel Krisman Bertazi wrote:
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1597,7 +1597,7 @@ static struct blk_mq_tags *blk_mq_init_rq_map(struct
blk_mq_tag_set *set,
INIT_LIST_HEAD(&tags->page_list);
tags->rqs = kzalloc_node(set->queue_depth * sizeof(s
The first four patches in this patch series include fixes for command
room violation and lun table management.
The remaining patches remove the reliance upon an internally maintained
private command pool in favor of private commands being allocated
alongside the SCSI commands. Several cleanup oppo
During test, the following crash was observed:
[34538.981505] Faulting instruction address: 0xd7c9c870
cpu 0x9: Vector: 300 (Data Access) at [c007f1e8f590]
pc: d7c9c870: cxlflash_restore_luntable+0x70/0x1d0 [cxlflash]
lr: d7c9c84c: cxlflash_restore_luntable+0x4c
Currently, the context reset routine waits for command room to
be available before sending the reset request. Per review of the
SISLite specification and clarifications from the CXL Flash AFU
designers, this wait is unnecessary. The reset request can be
sent anytime regardless of command room, so l
The following Oops is encountered when blk_mq is enabled with the
cxlflash driver:
[ 2960.817172] Oops: Kernel access of bad area, sig: 11 [#5]
[ 2960.817309] NIP __blk_mq_run_hw_queue+0x278/0x4c0
[ 2960.817313] LR __blk_mq_run_hw_queue+0x2bc/0x4c0
[ 2960.817314] Call Trace:
[ 2960.817320] __blk_
From: "Matthew R. Ochs"
The cxlflash driver originally required a per-command 4K buffer that
hosted data passed to the AFU. When the routines that initiate AFU
and internal SCSI commands were refactored to use scsi_execute(), the
need for this buffer became obsolete. As it is no longer necessary,
During test, a command room violation interrupt is occasionally seen
for the master context when the CXL flash devices are stressed.
After studying the code, there could be gaps in the way command room
value is being cached in cxlflash. When the cached command room is zero
the thread attempting to
From: "Matthew R. Ochs"
Instead of using a private pool of AFU commands, use cmd_size to prime
the private pool of SCSI commands such that they are allocated with a
size large enough to contain an aligned AFU command. Use scsi_cmd_priv()
to derive the aligned/zeroed private command on queuecomman
From: "Matthew R. Ochs"
As staging for the removal of the AFU command pool, remove the reliance
upon the pool for the internal AFU sync command. Instead of obtaining an
AFU command from the pool, dynamically allocate memory with the appropriate
alignment requirements. Since the AFU sync service i
From: "Matthew R. Ochs"
Clean up and remove the remaining private command pool infrastructure
that is no longer required.
Signed-off-by: Matthew R. Ochs
---
drivers/scsi/cxlflash/common.h | 7 -
drivers/scsi/cxlflash/main.c | 68 --
2 files change
From: "Matthew R. Ochs"
With the removal of the static private command pool, the ability to
'complete' outstanding commands was lost. While not an issue for the
commands originating outside the driver, internal AFU commands are
synchronous and therefore have a timeout associated with them. To
avo
From: "Matthew R. Ochs"
The original design of the cxlflash driver required AFU commands
to convey state information across multiple threads. The IOASA
"host use" byte was used to track if a command was done, errored,
or timed out. A per-command spin lock was used to serialize access
to this byte
From: "Matthew R. Ochs"
The send_tmf() routine includes some copy/paste cruft that can be
removed as well as the setting of an AFU command-specific while
holding the tmf_slock. While not a bug, it is out of place and
should be shifted down alongside the other command initialization
statements for
From: "Matthew R. Ochs"
The queuecommand routine is disorganized where it populates the
private command and also contains some logic/statements that are
not needed given that cxlflash devices do not (and likely never
will) support scatter-gather.
Restructure the code to remove the unnecessary lo
From: "Matthew R. Ochs"
As staging for supporting hardware with a different queuing mechanism,
move the send_cmd() and context_reset() routines to function pointers
that are configured when the AFU is initialized. In addition, rename
the existing routines to better reflect the queue model they su
From: "Matthew R. Ochs"
Currently, when sending a SCSI command, the pointer is stored in a
reserved field of the AFU command descriptor for retrieval once the
SCSI command has completed. In order to support new descriptor formats
that make use of the reserved field, the pointer is migrated to out
On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote:
> From: Xiang Chen
>
> Currently slots are allocated from queues in a round-robin fashion.
> This causes a problem for internal commands in device mode. For this
> mode, we should ensure that the internal abort command is the last
> command seen i
On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote:
> From: Xiang Chen
>
> When we form a wideport, we should use hardware PHY port_id instead
> of sas_phy->id.
>
> Signed-off-by: Xiang Chen
> Signed-off-by: John Garry
Reviewed-by: Zhangfei Gao
--
To unsubscribe from this list: send the line "u
On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote:
> From: Xiang Chen
>
> Delete repeated configuration items for hisi_sas_device() when
> we free a device. These items are now only set in
> hisi_sas_dev_gone().
>
> Signed-off-by: Xiang Chen
> Signed-off-by: John Garry
Reviewed-by: Zhangfei Gao
On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote:
> Sometimes the value of hisi_sas_device.running_req
> would go negative unless we have the check for
> running_req >= 0 before trying to decrement.
>
> This is because using running_req is not thread-safe.
>
> As such, the value for running_req ma
On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote:
> From: Xiang Chen
>
> Modify and add some SATA commands according to SATA protocol.
>
> Signed-off-by: Xiang Chen
> Signed-off-by: John Garry
Reviewed-by: Zhangfei Gao
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" i
On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote:
> From: Xiang Chen
>
> For ECC 1bit error, logic can recover it, so we only print
> a warning.
> For ECC multi-bit and AXI bus fatal error, we panic.
Is it possible to recover via resetting phy and device etc instead of panic?
Thanks
--
To unsub
On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote:
> From: Xiang Chen
>
> There are many BROADCAST primitives generated by the host.
> We are only interested in BROADCAST (CHANGE) primitives currently,
> so only process this.
>
> Signed-off-by: Xiang Chen
> Signed-off-by: John Garry
Reviewed-by
On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote:
> From: Xiang Chen
>
> Add the function to set PHY min and max linkrate through
> sysfs interface.
>
> Signed-off-by: Xiang Chen
> Signed-off-by: John Garry
Reviewed-by: Zhangfei Gao
--
To unsubscribe from this list: send the line "unsubscribe
On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote:
> From: Xiang Chen
>
> Check ERR bit of status to decide whether there is something wrong with
> initial register-D2H FIS. If error exists, PHY reset the channel to
> restart OOB.
>
> Signed-off-by: Xiang Chen
> Signed-off-by: John Garry
Review
On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote:
> From: Xiang Chen
>
> sas_scsi_find_task() only deals with return value
> TMF_RESP_FUNC_FAILED/TMF_RESP_FUNC_SUCC/TMF_RESP_FUNC_COMPLETE of
> query task. So for LLDD errors just return TMF_RESP_FUNC_FAILED.
>
> Signed-off-by: Xiang Chen
> Signed
>> > Some UFS host controllers may clear a transfer request slot by setting
>> > an associated bit in UTRLCLR/UTMRLCLR to 1, not 0.
>> > That's opposite to what UFS spec describes.
>> >
>> > v2: modify the commit message, remove unrelated changes
>>
>> As Martin mentioned in other email, please se
Ok, got it.
I will resend a new patch.
On Tue, Nov 15, 2016 at 11:00:12AM -0800, Subhash Jadavani wrote:
> On 2016-11-15 04:25, Zang Leigang wrote:
> >We set ufshcd_state to UFSHCD_STATE_ERROR when an err handler
> >fails. So I think UFSHCD_STATE_ERROR means host not works any more.
> >Set it befo
Add a new ufshcd_state, indicats that an err handler may get to run
immediately. Use UFSHCD_STATE_ERROR here looks not literaly correct.
Signed-off-by: Zang Leigang
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 05c7456..59d4130 100644
--- a/drivers/scsi/ufs/ufshcd.c
++
Some UFS host controllers may clear a transfer request slot
by setting an associated bit in UTRLCLR/UTMRLCLR to 1, not 0.
That's opposite to what UFS spec describes.
Signed-off-by: Kiwoong Kim
---
drivers/scsi/ufs/ufshcd.c | 28 ++--
drivers/scsi/ufs/ufshcd.h | 7 +++
Some UFS host controllers might not be able to
reset UIC by setting HCE to 1.
Those controllers should invoke 'DME reset' and 'DME enable'
in order instead.
Signed-off-by: Kiwoong Kim
---
drivers/scsi/ufs/ufshcd.c | 44 +++-
drivers/scsi/ufs/ufshcd.h | 7
If UFS driver resets interrupt aggregation timer and counter
when there are some pended tasks, an IO competion interrupt
of any corresponing task may be issued.
That would casue a command timeout.
One thing you should mind to use interrupt aggreation
with this quirk is that the host controller sho
> On 2016-11-15 03:24, Kiwoong Kim wrote:
> > These things are defined to be used by some UFS Host controllers.
> > And a new file for some declarations of mphy standard is added
> >
> > V2
> > - modify the commit message
> > - add a new macro for UECDL
> > - add two definitions about UECDL
> > - c
These things are defined to be used by some UFS Host controllers.
And a new file for some declarations of mphy standard is added
Signed-off-by: Kiwoong Kim
---
V3: add new macros of all bits of UECDL
---
drivers/scsi/ufs/mphy.h | 38 ++
drivers/scsi/ufs/ufs
https://bugzilla.kernel.org/show_bug.cgi?id=187231
Patrick Schaaf changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugzilla.kernel.org/show_bug.cgi?id=187221
--- Comment #1 from Patrick Schaaf ---
Some more info on my problematic machine / further diagnosing is in
https://bugzilla.kernel.org/show_bug.cgi?id=187231
Summary: at least with the P440ar controllers, such 10-30 second "logical
reset" episod
On 11/15/2016 08:33 PM, Raghava Aditya Renukunta wrote:
> Hi Hannes,
> Thank you for the patch
>
>> -Original Message-
>> From: Hannes Reinecke [mailto:h...@suse.de]
>> Sent: Monday, November 7, 2016 11:12 PM
>> To: Martin K. Petersen
>> Cc: Christoph Hellwig; James Bottomley; linux-scsi@v
68 matches
Mail list logo
