Hi Tejun,
On Wed, Nov 9, 2016 at 10:15 PM, Tejun Heo wrote:
> Hello,
>
> On Wed, Sep 14, 2016 at 04:15:00PM +0530, Rameshwar Sahu wrote:
>> > @@ -821,8 +823,6 @@ static int xgene_ahci_probe(struct platform_device
>> > *pdev)
>> > dev_warn(&pdev->dev, "%s: Error rea
>
> They're not the same. I don't see how your solution properly deals with
> remote sas_port deletion.
>
> When we unplug a device connected to an expander, can't the sas_port be
> deleted twice, in sas_unregister_devs_sas_addr() from domain revalidation and
> also now in sas_destruct_devices
On 11/11/2016 08:12, wangyijing wrote:
They're not the same. I don't see how your solution properly deals with remote
sas_port deletion.
When we unplug a device connected to an expander, can't the sas_port be deleted
twice, in sas_unregister_devs_sas_addr() from domain revalidation and also n
Hi James, sorry to bother you, these two patches try to fix several issues
in libsas, Dan Williams and John Garry also found similar issue, and post
some patches before. Dan Williams's solution fix the sysfs warning calltrace,
but may introduce new flutter issue.
In these two patches, we introduce
> -Original Message-
> From: linux-block-ow...@vger.kernel.org [mailto:linux-block-
> ow...@vger.kernel.org] On Behalf Of Hannes Reinecke
> Sent: Thursday, November 10, 2016 10:05 AM
> To: Jens Axboe ; Christoph Hellwig
> Cc: SCSI Mailing List ; linux-
> bl...@vger.kernel.org
> Subject:
>>> I have not seen the flutter issue. I am just trying to solve the horrible
>>> WARN dump.
>>> However I do understand that there may be a issue related to how we queue
>>> the events; there was a recent attempt to fix this, but it came to nothing:
>>> https://www.spinics.net/lists/linux-scsi/m
The megaraid_sas HBA only has a single register for I/O submission,
which will be hit pretty hard with scsi-mq. To ensure that the
PCI writes have made it across we need to add a mmio barrier
after each write; otherwise I've been seeing spurious command
completions and I/O stalls.
Signed-off-by: H
Avoid a kernel oops when receiving an invalid command completion.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
b/drivers/scsi
Hi all,
here's the patcheset to enable scsi-mq support for megaraid_sas.
It's based on hch's irq rework currently pending in tip.
As the overall results have been less then stellar (see the thread
'reduced latency is killing performance') I've also added a module
parameter 'use_blk_mq' to allowing
This patch enables full scsi multiqueue support. But as I have
been seeing performance regressions I've also added a module
parameter 'use_blk_mq', allowing multiqueue to be switched
off if required.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/megaraid/megaraid_sas_base.c | 22
Cleanup the MSI-X handling allowing us to use
the PCI-layer provided vector allocation.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/megaraid/megaraid_sas.h | 1 -
drivers/scsi/megaraid/megaraid_sas_base.c | 63 ++-
2 files changed, 29 insertions(+), 35 delet
It's quite pointless to call megasas_lookup_instance() if we can
derive a pointer to the structure directly.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/megaraid/megaraid_sas.h| 3 ++-
drivers/scsi/megaraid/megaraid_sas_base.c | 24 +++-
drivers/scsi/megaraid/m
https://bugzilla.kernel.org/show_bug.cgi?id=187231
--- Comment #5 from Patrick Schaaf ---
After almost 4 days my problematic box downgraded to 3.14.79, finally made some
noise, like this:
2016-11-11T03:31:10.608539+01:00 kvm3f kernel: [320020.727691] hpsa
:03:00.0: Abort request on C0:B0:T0:
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
> ow...@vger.kernel.org] On Behalf Of Jens Axboe
> Sent: Thursday, November 10, 2016 10:18 PM
> To: Hannes Reinecke; Christoph Hellwig
> Cc: SCSI Mailing List; linux-bl...@vger.kernel.org
> Subject: Re: Reduce
>-Original Message-
>From: Hannes Reinecke [mailto:h...@suse.de]
>Sent: Friday, November 11, 2016 3:15 PM
>To: Martin K. Petersen
>Cc: Christoph Hellwig; James Bottomley; Sumit Saxena; linux-
>s...@vger.kernel.org; Hannes Reinecke; Hannes Reinecke
>Subject: [PATCH 2/5] megaraid_sas: avoid c
>-Original Message-
>From: Hannes Reinecke [mailto:h...@suse.de]
>Sent: Friday, November 11, 2016 3:15 PM
>To: Martin K. Petersen
>Cc: Christoph Hellwig; James Bottomley; Sumit Saxena; linux-
>s...@vger.kernel.org; Hannes Reinecke; Hannes Reinecke
>Subject: [PATCH 5/5] megaraid_sas: add mmi
Hi Hannes,
[auto build test ERROR on scsi/for-next]
[also build test ERROR on v4.9-rc4 next-2016]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Hannes-Reinecke/megaraid_sas-scsi-mq-support
>-Original Message-
>From: Hannes Reinecke [mailto:h...@suse.de]
>Sent: Friday, November 11, 2016 3:15 PM
>To: Martin K. Petersen
>Cc: Christoph Hellwig; James Bottomley; Sumit Saxena; linux-
>s...@vger.kernel.org; Hannes Reinecke; Hannes Reinecke
>Subject: [PATCH 1/5] megaraid_sas: switch
On 11/11/2016 08:02 AM, Elliott, Robert (Persistent Memory) wrote:
-Original Message-
From: linux-block-ow...@vger.kernel.org [mailto:linux-block-
ow...@vger.kernel.org] On Behalf Of Hannes Reinecke
Sent: Thursday, November 10, 2016 10:05 AM
To: Jens Axboe ; Christoph Hellwig
Cc: SCSI
>-Original Message-
>From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
>ow...@vger.kernel.org] On Behalf Of Hannes Reinecke
>Sent: Friday, November 11, 2016 3:15 PM
>To: Martin K. Petersen
>Cc: Christoph Hellwig; James Bottomley; Sumit Saxena; linux-
>s...@vger.kernel.org; Hannes R
>-Original Message-
>From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
>ow...@vger.kernel.org] On Behalf Of Hannes Reinecke
>Sent: Friday, November 11, 2016 3:15 PM
>To: Martin K. Petersen
>Cc: Christoph Hellwig; James Bottomley; Sumit Saxena; linux-
>s...@vger.kernel.org; Hannes R
Hi,
This patchset cleans up direct access to bvec table.
The 1st patch passes bvec table to bio_init(), so that
direct access to bvec table in bio initialization is avoided.
For other patches, most of them uses bio_add_page()
to replace hardcode style of adding page to bvec,
and others avoids to
When the bio is full, bio_add_pc_page() will return zero,
so use this way to handle full bio.
Also replace access to .bi_vcnt for pr_debug() with bio_segments().
Reviewed-by: Christoph Hellwig
Signed-off-by: Ming Lei
---
drivers/target/target_core_pscsi.c | 8 ++--
1 file changed, 2 insert
> -Original Message-
> From: James Bottomley [mailto:james.bottom...@hansenpartnership.com]
> Sent: Thursday, September 08, 2016 5:38 PM
> To: Scott Benesh; James Bottomley; Don Brace; Martin K. Petersen
> Cc: Viswas G; Mahesh Rajashekhara; h...@infradead.org; Scott Teel; Kevin
> Barnett; J
On 11/11/2016 12:32 PM, Sumit Saxena wrote:
>> -Original Message-
>> From: Hannes Reinecke [mailto:h...@suse.de]
>> Sent: Friday, November 11, 2016 3:15 PM
>> To: Martin K. Petersen
>> Cc: Christoph Hellwig; James Bottomley; Sumit Saxena; linux-
>> s...@vger.kernel.org; Hannes Reinecke; Han
On 11/11/2016 12:51 PM, Sumit Saxena wrote:
-Original Message-
From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
ow...@vger.kernel.org] On Behalf Of Hannes Reinecke
Sent: Friday, November 11, 2016 3:15 PM
To: Martin K. Petersen
Cc: Christoph Hellwig; James Bottomley; Sumit Saxena
This patch enables full scsi-mq support for the hpsa driver.
Due to some reports of performance regressions this patch
also adds a parameter 'use_blk_mq' which can be used to
disable multiqueue support if required.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/hpsa.c | 64 +
On 11/08/2016 07:56 AM, Manish Rangankar wrote:
From: Yuval Mintz
This adds the backbone required for the various HW initalizations
which are necessary for the iSCSI driver (qedi) for QLogic FastLinQ
4 line of adapters - FW notification, resource initializations, etc.
Signed-off-by: Arun E
On 11/08/2016 07:56 AM, Manish Rangankar wrote:
From: Yuval Mintz
This patch adds out of order packet handling for hardware offloaded
iSCSI. Out of order packet handling requires driver buffer allocation
and assistance.
Signed-off-by: Arun Easi
Signed-off-by: Yuval Mintz
---
drivers/net/eth
> -Original Message-
> From: Hannes Reinecke [mailto:h...@suse.de]
> Sent: Thursday, October 27, 2016 4:03 AM
> To: Don Brace; j...@linux.vnet.ibm.com; John Hall; Kevin Barnett; Mahesh
> Rajashekhara; h...@infradead.org; Scott Teel; Viswas G; Justin Lindley; Scott
> Benesh; elli...@hpe.com;
Hi Hannes,
[auto build test ERROR on scsi/for-next]
[also build test ERROR on v4.9-rc4 next-2016]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Hannes-Reinecke/hpsa-scsi-mq-support
On Fri, Nov 11, 2016 at 04:46:34PM +0100, Hannes Reinecke wrote:
> This patch enables full scsi-mq support for the hpsa driver.
> Due to some reports of performance regressions this patch
> also adds a parameter 'use_blk_mq' which can be used to
> disable multiqueue support if required.
This patch
On 11/08/2016 07:57 AM, Manish Rangankar wrote:
The QLogic FastLinQ Driver for iSCSI (qedi) is the iSCSI specific module
for 41000 Series Converged Network Adapters by QLogic.
This patch consists of following changes:
- MAINTAINERS Makefile and Kconfig changes for qedi,
- PCI driver registra
On 11/08/2016 07:57 AM, Manish Rangankar wrote:
This patch adds support for iscsiuio interface using Light L2 (LL2) qed
interface.
Signed-off-by: Nilesh Javali
Signed-off-by: Adheer Chandravanshi
Signed-off-by: Chad Dupuis
Signed-off-by: Saurav Kashyap
Signed-off-by: Arun Easi
Signed-off-by
NetApp did confirm this is not required.
Cc: Martin George
Cc: Robert Stankey
Cc: Steven Schremmer
Cc: Sean Stewart
Cc: Hannes Reinecke
Cc: Christophe Varoqui
Cc: James E.J. Bottomley
Cc: Martin K. Petersen
Cc: SCSI ML
Cc: device-mapper development
Signed-off-by: Xose Vazquez Perez
---
On 11/08/2016 07:57 AM, Manish Rangankar wrote:
This patch adds support for data path and TMF handling.
Signed-off-by: Nilesh Javali
Signed-off-by: Adheer Chandravanshi
Signed-off-by: Chad Dupuis
Signed-off-by: Saurav Kashyap
Signed-off-by: Arun Easi
Signed-off-by: Manish Rangankar
---
dr
Hi Hannes,
[auto build test WARNING on scsi/for-next]
[also build test WARNING on v4.9-rc4 next-2016]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Hannes-Reinecke/hpsa-scsi-mq-support
On 11/08/2016 07:57 AM, Manish Rangankar wrote:
This patch adds support for iscsi_transport LLD Login,
Logout, NOP-IN/NOP-OUT, Async, Reject PDU processing
and Firmware async event handling support.
Signed-off-by: Nilesh Javali
Signed-off-by: Adheer Chandravanshi
Signed-off-by: Chad Dupuis
Si
On 11/09/2016 08:38 AM, George, Martin wrote:
Drop this one.
> As discussed with Hannes, this is not required for ONTAP's LUN C-Mode
> as well. So the ALUA blacklisting may be removed here as well, and
> not just for NetApp RDAC.
OK, done in v2.
Thank you.
> -Original Message-
> From:
On 11/10/2016 08:04 AM, Hannes Reinecke wrote:
this really feels like a follow-up to the discussion we've had in Santa
Fe, but finally I'm able to substantiate it with some numbers.
Hello Hannes,
Since for the sequential read test the difference between the 50th
percentile sequential read com
On 11/11/2016 05:35 PM, Christoph Hellwig wrote:
On Fri, Nov 11, 2016 at 04:46:34PM +0100, Hannes Reinecke wrote:
This patch enables full scsi-mq support for the hpsa driver.
Due to some reports of performance regressions this patch
also adds a parameter 'use_blk_mq' which can be used to
disable
On Fri, 11 Nov 2016, 7:57am, Hannes Reinecke wrote:
> On 11/08/2016 07:56 AM, Manish Rangankar wrote:
> > From: Yuval Mintz
> >
> > This adds the backbone required for the various HW initalizations
> > which are necessary for the iSCSI driver (qedi) for QLogic FastLinQ
> > 4 line of adapters
Hello James and Martin,
This short patch series fixes a deadlock that I ran into for the first
time several months ago but for which I had not yet had the time to post
a fix. As usual, feedback is appreciated.
Thanks,
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-s
Let dm-mpath fail requests if queue_if_no_path is enabled and
request flag REQ_FAIL_IF_NO_PATH has been set. This facility will
be used in the next patch to fix a deadlock between SCSI device
removal and sd event checking.
Signed-off-by: Bart Van Assche
Cc: Mike Snitzer
Cc: Hannes Reinecke
---
If sd_check_events() is called for an sd device on top of a
multipath device without paths then the scsi_test_unit_ready()
call from that function will block until one or more paths
have been added to the multipath device. However, if
scsi_remove_host() is called before a path has been added then
a
It is required to hold the queue lock when calling blk_run_queue_async()
to avoid that a race between blk_run_queue_async() and
blk_cleanup_queue() is triggered. Additionally, remove the get_device()
and put_device() calls from fc_bsg_goose_queue. It is namely the
responsibility of the caller of fc
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
> ow...@vger.kernel.org] On Behalf Of Gabriel C
> Sent: Friday, November 11, 2016 9:40 AM
> To: James Bottomley; Andrew Morton; Linus Torvalds
> Cc: linux-scsi; linux-kernel; sta...@vger.kernel.org
> Subject:
The megaraid_sas patch in here fixes a major regression in the last fix
set that made all megaraid_sas cards unusable. It turns out no-one had
actually tested such an "obvious" fix, sigh. The fix for the fix has
been tested ...
The next most serious is the vmw_pvscsi abort problem which basical
On 11/09/2016 03:21 AM, Chris Leech wrote:
> On Mon, Nov 07, 2016 at 04:23:10PM -0200, Guilherme G. Piccoli wrote:
>>
>> Sure! Count on us to test any patches. I guess the first step is to
>> reproduce on upstream right? We haven't tested specifically this
>> scenario for long time. Will try to rep
On 12.11.2016 02:08, Kashyap Desai wrote:
>> -Original Message-
>> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
>> ow...@vger.kernel.org] On Behalf Of Gabriel C
>> Sent: Friday, November 11, 2016 9:40 AM
>> To: James Bottomley; Andrew Morton; Linus Torvalds
>> Cc: linux-scsi
50 matches
Mail list logo