Re: [PATCH 3/3] virtio_scsi: use complete() instead complete_all()

2016-09-14 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] sym53c8xx_2: use complete() instead complete_all()

2016-09-14 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] csiostor: fix completion usage

2016-09-14 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [vfio-users] aacraid / Adaptec 3805 - AAC: Host adapter dead -1

2016-09-14 Thread Matthias Huber
Hi, i am getting same Message with Adaptec 3405: using Linux 4.7.3 from kernel.org root@intel:~# lspci -nnvs 02:0e.0 02:0e.0 RAID bus controller [0104]: Adaptec AAC-RAID [9005:0285] Subsystem: Adaptec 3405 [9005:02bb] Flags: bus master, stepping, 66MHz, medium devsel, latency 32, IRQ 1

[Bug 151661] Adaptec 3405 3805 prints "AAC: Host adapter dead -1" every 10 seconds but works fine anyway

2016-09-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=151661 HarvestEnterpises changed: What|Removed |Added CC||he...@fitmsg.net --- Comment #13 fro

[Bug 151661] Adaptec 3405 3805 prints "AAC: Host adapter dead -1" every 10 seconds but works fine anyway

2016-09-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=151661 Matthias changed: What|Removed |Added CC||hm10...@gmail.com --- Comment #14 from Matthi

[Bug 151661] Adaptec 3405 3805 prints "AAC: Host adapter dead -1" every 10 seconds but works fine anyway

2016-09-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=151661 --- Comment #15 from HE - IT Services --- (In reply to HE - IT Services from comment #13) > I have the exact same problem on Proxmox which is using Debian Jesse Linux > Kernel 4.2.4, using Adaptec Raid 31605, it repeats every 10 seconds, "AAC: >

[Bug 151661] Adaptec 3405 3805 prints "AAC: Host adapter dead -1" every 10 seconds but works fine anyway

2016-09-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=151661 --- Comment #16 from HE - IT Services --- (In reply to Matthias from comment #14) > you can find it in: > drivers/scsi/aacraid/commsup.c > in my 4.7.3 it is in Line 1700 Thanks Matthias. -- You are receiving this mail because: You are watching

Re: [PATCH 01/15] hisi_sas: save completion queue read pointer

2016-09-14 Thread Hannes Reinecke
On 09/06/2016 05:36 PM, John Garry wrote: > Optimise by saving an avoidable read in the cq > interrupt. > The queue read pointer will only be updated > by software, so don't bother re-reading > what was already written in the previous interrupt. > > Signed-off-by: John Garry > --- > drivers/scsi

Re: [PATCH 02/15] hisi_sas: save delivery queue write pointer

2016-09-14 Thread Hannes Reinecke
On 09/06/2016 05:36 PM, John Garry wrote: > Optimise by saving an avoidable read in the > get_free_slot function. > The delivery queue write pointer will only be > updated by software, so don't bother re-reading > what was already written in the previous call > to start_delivery function. > > Sign

Re: [PATCH 03/15] hisi_sas: keep CHL_INT2 masked for v2 HW

2016-09-14 Thread Hannes Reinecke
On 09/06/2016 05:36 PM, John Garry wrote: > None of the CHL_INT2 interrupts are serviced > in the channel irq ISR, so leave the interrupt > source masked. > The interrupt mask is initially set in > init_reg_v2_hw(). > > Signed-off-by: John Garry > --- > drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 6

Re: [RFC][PATCH v1 1/2] libsas: Alloc dynamic work to avoid missing sas events

2016-09-14 Thread Hannes Reinecke
On 09/13/2016 04:30 AM, Yijing Wang wrote: > Now libsas hotplug work is static, LLDD driver queue > the hotplug work into shost->work_q. If LLDD driver > burst post lots hotplug event to libsas, the hotplug > events may pending in the workqueue like > > shost->workq > tail | PHYE_LOSS_OF_SIGNAL |

Re: [PATCH 04/15] hisi_sas: only zero slot memory when reused

2016-09-14 Thread Hannes Reinecke
On 09/06/2016 05:36 PM, John Garry wrote: > Currently the slot memory is zeroed when it is > freed and also when it is reused, like in > hisi_sas_task_prep(). Optimise by avoiding the > redundant zeroing in the free. > > Signed-off-by: John Garry > --- > drivers/scsi/hisi_sas/hisi_sas_main.c | 2

Re: [PATCH 05/15] hisi_sas: use safe BITS_PER_BYTE for slot tag size calculation

2016-09-14 Thread Hannes Reinecke
On 09/06/2016 05:36 PM, John Garry wrote: > The memory calculation for the tags bitmap should use BITS_PER_BYTE > macro instead of coincidental same value of sizeof(unsigned long). > > Signed-off-by: John Garry > --- > drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +- > 1 file changed, 1 insertion(+

Re: [PATCH 06/15] hisi_sas: disable dlvry queues once at reset for v2 hw

2016-09-14 Thread Hannes Reinecke
On 09/06/2016 05:36 PM, John Garry wrote: > The Delivery queue enable register should only be written > to once at reset for v2 hw. > > Signed-off-by: John Garry > --- > drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/sc

Re: [PATCH 07/15] hisi_sas: fix phy8 linkrate calculation in phy_up_v2_hw()

2016-09-14 Thread Hannes Reinecke
On 09/06/2016 05:36 PM, John Garry wrote: > In function phy_up_v2_hw(), we needlessly recalculate the > phy linkrate for all phys, and the calculation is incorrect > for phy8, so remove this code. > > Signed-off-by: John Garry > Signed-off-by: Xiang Chen > --- > drivers/scsi/hisi_sas/hisi_sas_v

Re: [PATCH 09/15] hisi_sas: set dma mask before allocate DMA memory

2016-09-14 Thread Hannes Reinecke
On 09/06/2016 05:36 PM, John Garry wrote: > The device DMA mask was being set after the bulk of the > DMA allocations in the driver init, so potentially > DMA allocates fail. > To resolve, relocate before allocating the DMA memory when > initialising the driver. > > Signed-off-by: Xiang Chen > Si

Re: [PATCH 08/15] hisi_sas: fix a potential warning for sata disk ejection

2016-09-14 Thread Hannes Reinecke
On 09/06/2016 05:36 PM, John Garry wrote: > If hisi_sas_task_prep() fails for a SATA device due to PHY > down, we return a failure to libata and also call task_done(), > which will cause ata_qc_complete() to be called twice: > - first call from hisi_sas_task_prep(), which will clear flag > ATA_QC

Re: [PATCH 10/15] hisi_sas: fix HBA SAS addr endianness for v2 hw

2016-09-14 Thread Hannes Reinecke
On 09/06/2016 05:36 PM, John Garry wrote: > The endianness for the SAS address in the TX_ID_DWORD > registers is set incorrectly. > We see errors like this in the boot log: > [7.583284] sas: target proto 0x0 at 5d1108e7923f:0x1f not handled > > This is due to the host SAS addr not matching

Re: [PATCH 12/15] hisi_sas: remove init_id_frame_v2_hw()

2016-09-14 Thread Hannes Reinecke
On 09/06/2016 05:36 PM, John Garry wrote: > Function config_id_frame_v2_hw() is called twice for > each PHY during initialisation, which is unneeded. > > So remove init_id_frame_v2_hw(), which only calls > config_id_frame_v2_hw(). > > We will keep the call to config_id_frame_v2_hw() > in start_ph

Re: [PATCH 11/15] hisi_sas: fix HBA SAS addr endianness for v1 hw

2016-09-14 Thread Hannes Reinecke
On 09/06/2016 05:36 PM, John Garry wrote: > The endianness for the SAS address in the TX_ID_DWORD > registers is set incorrectly. > We see errors like this in the boot log for v2 hw (which would > have the same issue as v1 hw): > [7.583284] sas: target proto 0x0 at 5d1108e7923f:0x1f not han

Re: [PATCH 14/15] hisi_sas: add missing SATA pending device type to v2 hw

2016-09-14 Thread Hannes Reinecke
On 09/06/2016 05:36 PM, John Garry wrote: > In setup_itct_v2_hw(), SATA device type SAS_SATA_PENDING > is missing, so add it. > > Note: The HiSi SAS controller does not support SATA PM, > so do not handle SAS_SATA_PM_PORT or SAS_SATA_PM. > > Signed-off-by: John Garry > Signed-off-by: Xiang

Re: [PATCH 13/15] hisi_sas: remove init_id_frame_v1_hw()

2016-09-14 Thread Hannes Reinecke
On 09/06/2016 05:36 PM, John Garry wrote: > Function config_id_frame_v1_hw() is called twice for > each PHY during initialisation, which is unneeded. > > So remove init_id_frame_v1_hw(), which only calls > config_id_frame_v1_hw(). > > We will keep the call to config_id_frame_v1_hw() > in start_ph

Re: [PATCH 15/15] hisi_sas: send three identify before phy up

2016-09-14 Thread Hannes Reinecke
On 09/06/2016 05:36 PM, John Garry wrote: > When the v2 hw is attached with many disks through > an expander, there may be OOB reset resulting in a PHY > going down after the speed is negotiated (very low > probability). > > This issue is resolved by modifying the link control > registers to send

Re: [PATCH] scsi: megaraid_sas: add in missing white space in error message text

2016-09-14 Thread Hannes Reinecke
On 09/12/2016 02:42 PM, Colin King wrote: > From: Colin Ian King > > A dev_printk message spans two lines and the literal string is missing > a white space between words. Add the white space. > > Signed-off-by: Colin Ian King > --- > drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- > 1 file c

Re: [PATCH v2 25/29] be2iscsi: Fix bad WRB index error

2016-09-14 Thread Hannes Reinecke
On 08/19/2016 11:50 AM, Jitendra Bhivare wrote: > In very rare scenario, connection gets killed after throwing this error: > scsi host0: BM_2312 : Event CXN_KILLED_BAD_WRB_INDEX_ERROR[15]... CID : 4 > connection1:0: detected conn error (1011) > > memset ISCSI_WRB descriptor to zero for all allocat

Re: [PATCH v2 26/29] be2iscsi: Fix queue and connection parameters

2016-09-14 Thread Hannes Reinecke
On 08/19/2016 11:50 AM, Jitendra Bhivare wrote: > Current EQ delay is set to 0 to receive very high max interrupt per sec. > Set EQ delay to 32 - reducing max interrupt rate from 65K to 20K per sec. > > Set TCP connection window size to 64K with scale shift count 2. > > Signed-off-by: Jitendra Bh

Re: [PATCH 3/6] cxlflash: Fix to avoid EEH and host reset collisions

2016-09-14 Thread Martin K. Petersen
> "Uma" == Uma Krishnan writes: Applied patches 3 through 6 to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vg

Re: [PATCH 00/15] hisi_sas misc fixes and minor optimisations

2016-09-14 Thread Martin K. Petersen
> "John" == John Garry writes: John> This patchset introdcues some minor bug fixes and optimisations John> for v1+v2 hw. John> No new functional features are introduced in this patchset. Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from

Re: [PATCH] scsi: replace broken specification URL

2016-09-14 Thread Martin K. Petersen
> "Michael" == Michael Opdenacker > writes: Michael> So, should we only that the cam-r12b document can be found from Michael> http://www.t10.org/t10docs.htm (registration required)?, and Michael> tell that a copy can be found on Michael> http://www.csit-sun.pub.ro/~cpop/Documentatie_SMP

[Bug 153171] scsi host6: runtime PM trying to activate child device host6 but parent (2-2:1.0) is not active

2016-09-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=153171 Martin K. Petersen changed: What|Removed |Added CC||m...@mkp.net --- Comment #5 from Ma

Re: [PATCH] scsi: megaraid_sas: add in missing white space in error message text

2016-09-14 Thread Martin K. Petersen
> "Colin" == Colin King writes: Colin> From: Colin Ian King A dev_printk Colin> message spans two lines and the literal string is missing a white Colin> space between words. Add the white space. Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscri

Re: [PATCH 0/3] wireless: Use complete() instead complete_all()

2016-09-14 Thread Martin K. Petersen
> "Daniel" == Daniel Wagner writes: Daniel> Using complete_all() is not wrong per se but it suggest that Daniel> there might be more than one waiter. For -rt I am reviewing all Daniel> complete_all() users and would like to leave only the real ones Daniel> in the tree. The main problem for -r

Re: [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

2016-09-14 Thread Martin K. Petersen
> "Chad" == Chad Dupuis writes: Johannes> Testing was conducted by booting from a QLogic BCM57840 CNA. Chad> We're regression testing the patches now. Please hold off on Chad> applying them. OK. I will wait. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this

Re: [PATCH v2 3/3] scsi/ncr5380: Improve interrupt latency during PIO tranfers

2016-09-14 Thread Martin K. Petersen
> "Finn" == Finn Thain writes: Finn> Large PIO transfers are broken up into chunks to try to avoid Finn> disabling local IRQs for long periods. But IRQs are still disabled Finn> for too long and this causes SCC FIFO overruns during serial port Finn> transfers. Finn> This patch reduces the PI

Re: [PATCH 0/5] hpsa updates

2016-09-14 Thread Martin K. Petersen
> "Don" == Don Brace writes: Don> The following changes are based on Linus's tree: Don> - correct minor bug created when adding hpsa_skip_device Don> - add check for null devices do to configuration changes Don> - add check for null devices in ioaccel path Don> - add check for vpd support

Re: [PATCH -next] [SCSI] mpt fusion: fix error return code in mptfc_probe()

2016-09-14 Thread Martin K. Petersen
> "Wei" == Wei Yongjun writes: Wei> Fix to return error code -ENOMEM from the workqueue alloc error Wei> handling case instead of 0, as done elsewhere in this function. Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the

Re: [PATCH 3/3] sd: move DIF protection types to t10-pi.h

2016-09-14 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> These should go together with the rest of the T10 protection Christoph> information defintions. Series looks good in general. However, now that you introduced t10-pi.h it seems a bit odd to perpetuate the obsolete "DIF" terminology. +enu

Re: TRIM/UNMAP/DISCARD via ATA Passthrough

2016-09-14 Thread Martin K. Petersen
> "Jason" == Jason A Donenfeld writes: Jason, Jason> These USB enclosures do not support SCSI UNMAP. However, they do Jason> support ATA-passthrough, and `hdparm -I` shows that TRIM is Jason> supported. How do they signal that they support the passthrough? -- Martin K. Petersen Oracl

[PATCH -next] scsi: ibmvscsis: Fix error return code in ibmvscsis_probe()

2016-09-14 Thread Wei Yongjun
From: Wei Yongjun Fix to return error code -ENOMEM from the dma mapping error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/ibmvscsi_tgt/ib

Re: [PATCH 3/3] sd: move DIF protection types to t10-pi.h

2016-09-14 Thread Christoph Hellwig
On Wed, Sep 14, 2016 at 02:34:35PM -0400, Martin K. Petersen wrote: > I don't mind fixing that up when I apply. Any objections? Sure, go ahead! -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at htt

Re: [PATCH -next] scsi: ibmvscsis: Fix error return code in ibmvscsis_probe()

2016-09-14 Thread Johannes Thumshirn
On Thu, Sep 15, 2016 at 03:25:23AM +, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return error code -ENOMEM from the dma mapping error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun > --- Reviewed-by: Johannes Thumshirn -- Johannes