Re: [PATCH] [SCSI] qla4xxx: mark symbols static where possible

2016-09-02 Thread Martin K. Petersen
> "Baoyou" == Baoyou Xie writes: Baoyou> We get 1 warning when build kernel with W=1: Baoyou> drivers/scsi/qla4xxx/ql4_nx.c:1846:10: warning: no previous Baoyou> prototype for 'ql4_84xx_ipmdio_rd_reg' [-Wmissing-prototypes] Baoyou> In fact, this function is only used in the file in which it

Re: [PATCH] bfa: do not dereference port before it is null checked

2016-09-02 Thread Martin K. Petersen
> "Colin" == Colin King writes: Colin> port is deferenced before it is null sanity checked, hence we Colin> potentially have a null pointer dereference bug. Instead, Colin> initialise trl_enabled from port->fcs->bfa after we are sure port Colin> is not null. Applied to 4.9/scsi-queue. -- M

Re: [PATCH 0/2] fusion: Remove deprecated create_singlethread_workqueue

2016-09-02 Thread Martin K. Petersen
> "Bhaktipriya" == Bhaktipriya Shridhar writes: Bhaktipriya> This patch set removes deprecated Bhaktipriya> create_singlethread_workqueue instances from Bhaktipriya> drivers/message Applied to 4.9/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe fr

Re: [PATCH V2 00/15] smartpqi update

2016-09-02 Thread Martin K. Petersen
> "Don" == Don Brace writes: Don, Don> These changes are based on Linus's tree The changes are: Please make sure you submit patches against my tree. Had to tweak a few things by hand. Applied series to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe

Re: [PATCH 1/2] wd719x: Remove last declaration using DEFINE_PCI_DEVICE_TABLE

2016-09-02 Thread Martin K. Petersen
> "Joe" == Joe Perches writes: Joe> Convert it to the preferred const struct pci_device_id instead. Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@

Re: [PATCH v1 0/3] Ibmvscsis fixes and code cleanup

2016-09-02 Thread Martin K. Petersen
> "Bryant" == Bryant G Ly writes: Bryant, Bryant> Here are some small fixes and cleanups for Ibmvscsis Target Bryant> Driver. The only one of significance is the first one where Bryant> there is a possibility of a kernel crash due to inproper Bryant> deregister of target session since we di

Re: [PATCH] fix:pmcraid: mark symbols static where possible

2016-09-02 Thread Martin K. Petersen
> "Baoyou" == Baoyou Xie writes: Baoyou> We get 4 warnings about global functions without a declaration Baoyou> in the scsi pmcraid driver when building with W=1: Baoyou> drivers/scsi/pmcraid.c:309:6: warning: no previous prototype for Baoyou> 'pmcraid_init_cmdblk' [-Wmissing-prototypes] Baoy

Re: [PATCH] scsi: ufs: add missing declaration in ufshcd.h

2016-09-02 Thread Martin K. Petersen
> "Baoyou" == Baoyou Xie writes: Baoyou> We get 1 warning about global functions without a declaration in Baoyou> the scsi ufshcd driver when building with W=1: Baoyou> drivers/scsi/ufs/ufshcd.c:1991:5: warning: no previous prototype Baoyou> for 'ufshcd_query_descriptor_retry' [-Wmissing-prot

Re: [PATCH] scsi: constify sr_pm_ops structure

2016-09-02 Thread Martin K. Petersen
> "Julia" == Julia Lawall writes: Julia> sr_pm_ops, of type struct dev_pm_ops, is never modified, so Julia> declare it as const. Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the bo

Re: [PATCH] scsi: ufs: add missing header dependencies for tc-dwc-g210

2016-09-02 Thread Martin K. Petersen
> "Baoyou" == Baoyou Xie writes: Baoyou> We get 2 warnings when build kernel with W=1: Baoyou> drivers/scsi/ufs/tc-dwc-g210.c:261:5: warning: no previous Baoyou> prototype for 'tc_dwc_g210_config_40_bit' [-Wmissing-prototypes] Baoyou> drivers/scsi/ufs/tc-dwc-g210.c:293:5: warning: no previous

Need some pointers to debug a target hang

2016-09-02 Thread Johannes Thumshirn
Hi Nick et al, I'm having a "interesting" problem with the kernel's iSCSI target and could use a debug hint. My target uses an iblock backstore on a dm-linear target. When I now get I/O form the initiator (I used a simple dd if=/dev/sda of=/dev/null) and call 'dmsetup suspend $backstore' it'll ta

Re: Block-level access

2016-09-02 Thread Alex Austin
My access is almost purely sequential and primarily writing, so read-ahead doesn't help me. What's problematic with pread/pwrite is the lack of error channel from media errors. BSG looks very interesting. I'll look further into that today. On Thu, Sep 1, 2016 at 5:16 PM, Bart Van Assche wrote: >

[PATCH] iscsi-target: fix spelling mistake "Unsolicitied" -> "Unsolicited"

2016-09-02 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistakes in pr_debug message and comments Signed-off-by: Colin Ian King --- drivers/target/iscsi/iscsi_target.c | 2 +- drivers/target/iscsi/iscsi_target_login.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/

RE: [PATCH V2 00/15] smartpqi update

2016-09-02 Thread Don Brace
Thank you for doing the tweaking. I notice that the MAINTAINERS file got updated with the Documentation/scsi/smartpqi.txt, but smartpqi.txt was not added. Wondering what I need to do to resolve this. Thanks, Don Brace ESC - Smart Storage Microsemi Corporation > -Original Message- >

Re: [PATCH] iscsi-target: fix spelling mistake "Unsolicitied" -> "Unsolicited"

2016-09-02 Thread Bart Van Assche
On 09/02/2016 07:32 AM, Colin King wrote: Trivial fix to spelling mistakes in pr_debug message and comments Reviewed-by: Bart Van Assche -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http:/

Re: linux-next: Tree for Jun 6 (scsi_debug.c)

2016-09-02 Thread Randy Dunlap
On 08/23/16 16:22, Masanari Iida wrote: > This one still exist on linus's tree (as of v4.8-rc3). > > CALLscripts/checksyscalls.sh > CHK kernel/config_data.h > Building modules, stage 2. > MODPOST 720 modules > ERROR: "ip_compute_csum" [drivers/scsi/scsi_debug.ko] undefined! > script

Re: [PATCH 1/2] wd719x: Remove last declaration using DEFINE_PCI_DEVICE_TABLE

2016-09-02 Thread Andrew Morton
On Fri, 02 Sep 2016 06:36:05 -0400 "Martin K. Petersen" wrote: > > "Joe" == Joe Perches writes: > > Joe> Convert it to the preferred const struct pci_device_id instead. > > Applied to 4.9/scsi-queue. That creates an ordering dependency between the scsi tree and -mm's "treewide: remove re

Re: [PATCH 1/2] wd719x: Remove last declaration using DEFINE_PCI_DEVICE_TABLE

2016-09-02 Thread Martin K. Petersen
> "Andrew" == Andrew Morton writes: Andrew> That creates an ordering dependency between the scsi tree and Andrew> -mm's "treewide: remove references to the now unnecessary Andrew> DEFINE_PCI_DEVICE_TABLE". Andrew> So an ack would be preferred, please. OK. I was assuming that a subsequent pa

Re: [PATCH V2 00/15] smartpqi update

2016-09-02 Thread Martin K. Petersen
> "Don" == Don Brace writes: Don, Don> Thank you for doing the tweaking. I notice that the MAINTAINERS Don> file got updated with the Documentation/scsi/smartpqi.txt, but Don> smartpqi.txt was not added. Peculiar. Will fix. -- Martin K. Petersen Oracle Linux Engineering -- To unsubs

[PATCH 3/6] cxlflash: Fix to avoid EEH and host reset collisions

2016-09-02 Thread Uma Krishnan
From: "Matthew R. Ochs" The EEH reset handler is ignorant to the current state of the driver when processing a frozen event and initiating a device reset. This can be an issue if an EEH event occurs while a user or stack initiated reset is executing. More specifically, if an EEH occurs while the

[PATCH 1/6] cxlflash: Scan host only after the port is ready for I/O

2016-09-02 Thread Uma Krishnan
When a port link is established, the AFU sends a 'link up' interrupt. After the link is up, corresponding initialization steps are performed on the card. Following that, when the card is ready for I/O, the AFU sends 'login succeeded' interrupt. Today, cxlflash invokes scsi_scan_host() upon receipt

[PATCH 2/6] cxlflash: Remove the device cleanly in the system shutdown path

2016-09-02 Thread Uma Krishnan
Commit 704c4b0ddc03 ("cxlflash: Shutdown notify support for CXL Flash cards") was recently introduced to notify the AFU when a system is going down. Due to the position of the cxlflash driver in the device stack, cxlflash devices are _always_ removed during a reboot/shutdown. This can lead to a cra

[PATCH 4/6] cxlflash: Improve EEH recovery time

2016-09-02 Thread Uma Krishnan
From: "Matthew R. Ochs" When an EEH occurs during device initialization, the port timeout logic can cause excessive delays as MMIO reads will fail. Depending on where they are experienced, these delays can lead to a prolonged reset, causing an unnecessary triggering of other timeout logic in the

[PATCH 5/6] cxlflash: Refactor WWPN setup

2016-09-02 Thread Uma Krishnan
From: "Matthew R. Ochs" Commit 964497b3bf3f ("cxlflash: Remove dual port online dependency") logically removed the ability for the WWPN setup routine afu_set_wwpn() to return a non-success value. This routine can safely be made a void to simplify the code as there is no longer a need to report a

[PATCH 6/6] cxlflash: Fix context reference tracking on detach

2016-09-02 Thread Uma Krishnan
From: "Matthew R. Ochs" Commit 888baf069f49 ("scsi: cxlflash: Add kref to context") introduced a kref to the context. In particular, the detach routine was updated to use the kref services for managing the removal and destruction of a context. As part of this change, the tracking mechanism inter

[PATCH 0/6] cxlflash: Miscellaneous fixes

2016-09-02 Thread Uma Krishnan
This patch set contains miscellaneous fixes in the device cleanup and EEH recovery paths. One of the patches simplifies the WWPN assignment routine. There are a couple of fixes that resolve regressions introduced by Commit 704c4b0ddc03 ("cxlflash: Shutdown notify support for CXL Flash cards") and