Re: [PATCH 01/17] smartpqi: change aio sg processing

2016-08-29 Thread Johannes Thumshirn
On Fri, Aug 26, 2016 at 11:44:11AM -0500, Don Brace wrote: > From: Kevin Barnett > > Take advantage of controller improvements. > > Reviewed-by: Scott Teel > Reviewed-by: Scott Benesh > Signed-off-by: Kevin Barnett > Signed-off-by: Don Brace > --- > drivers/scsi/smartpqi/smartpqi_init.c |

Re: [PATCH 02/17] smartpqi: change tmf macro names

2016-08-29 Thread Johannes Thumshirn
On Fri, Aug 26, 2016 at 11:44:17AM -0500, Don Brace wrote: > From: Kevin Barnett > > small change to make code look cleaner > > Reviewed-by: Scott Teel > Reviewed-by: Scott Benesh > Signed-off-by: Kevin Barnett > Signed-off-by: Don Brace > --- Reviewed-by: Johannes Thumshirn -- Johannes

Re: [PATCH 03/17] smartpqi: simplify spanning

2016-08-29 Thread Johannes Thumshirn
On Fri, Aug 26, 2016 at 11:44:24AM -0500, Don Brace wrote: > From: Kevin Barnett > > Removed the workaround for the transition to spanning. > > Reviewed-by: Scott Teel > Reviewed-by: Scott Benesh > Signed-off-by: Kevin Barnett > Signed-off-by: Don Brace > --- Reviewed-by: Johannes Thumshirn

Re: [PATCH 04/17] smartpqi: enhance drive offline informational message

2016-08-29 Thread Johannes Thumshirn
On Fri, Aug 26, 2016 at 11:44:30AM -0500, Don Brace wrote: > From: Kevin Barnett > > Made a couple of error messages more verbose. > > Reviewed-by: Scott Teel > Reviewed-by: Scott Benesh > Signed-off-by: Kevin Barnett > Signed-off-by: Don Brace > --- > drivers/scsi/smartpqi/smartpqi_init.c

Re: [PATCH 05/17] smartpqi: enhance reset logic

2016-08-29 Thread Johannes Thumshirn
On Fri, Aug 26, 2016 at 11:44:36AM -0500, Don Brace wrote: > From: Kevin Barnett > > Eliminated timeout from LUN reset logic. > > Reviewed-by: Scott Teel > Reviewed-by: Scott Benesh > Signed-off-by: Kevin Barnett > Signed-off-by: Don Brace > --- Reviewed-by: Johannes Thumshirn -- Johanne

Re: [PATCH 06/17] smartpqi: change commonly used function to inline

2016-08-29 Thread Johannes Thumshirn
On Fri, Aug 26, 2016 at 11:44:42AM -0500, Don Brace wrote: > From: Kevin Barnett > > A tiny tweak to convert a small, commonly used function to inline. > > Reviewed-by: Scott Teel > Reviewed-by: Scott Benesh > Signed-off-by: Kevin Barnett > Signed-off-by: Don Brace > --- > drivers/scsi/smar

Re: [PATCH 07/17] smartpqi: add kdump support

2016-08-29 Thread Johannes Thumshirn
On Fri, Aug 26, 2016 at 11:44:48AM -0500, Don Brace wrote: > From: Kevin Barnett > > Reviewed-by: Scott Teel > Reviewed-by: Scott Benesh > Signed-off-by: Kevin Barnett > Signed-off-by: Don Brace > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn

Re: [PATCH 08/17] smartpqi: correct controller offline issue

2016-08-29 Thread Johannes Thumshirn
On Fri, Aug 26, 2016 at 11:44:54AM -0500, Don Brace wrote: > From: Kevin Barnett > > Fixed a bug where the driver would not free all of the > controller resources if the controller ever went offline. > > Reviewed-by: Scott Teel > Reviewed-by: Scott Benesh > Signed-off-by: Kevin Barnett > Sign

Re: [PATCH 09/17] smartpqi: correct event acknowledgment timeout issue

2016-08-29 Thread Johannes Thumshirn
On Fri, Aug 26, 2016 at 11:45:00AM -0500, Don Brace wrote: > From: Kevin Barnett > > the driver no longer waits for the firmware to consume > the event ack IU. > > Reviewed-by: Scott Teel > Reviewed-by: Scott Benesh > Signed-off-by: Kevin Barnett > Signed-off-by: Don Brace > --- Reviewed-by

Re: [PATCH 11/17] smartpqi: minor tweaks to update time support

2016-08-29 Thread Johannes Thumshirn
On Fri, Aug 26, 2016 at 11:45:12AM -0500, Don Brace wrote: > From: Kevin Barnett > > minor tweaks to update time support > > Reviewed-by: Scott Teel > Reviewed-by: Scott Benesh > Signed-off-by: Kevin Barnett > Signed-off-by: Don Brace > --- > drivers/scsi/smartpqi/smartpqi_init.c |8 ++-

Re: [PATCH 12/17] smartpqi: scsi queuecommand cleanup

2016-08-29 Thread Johannes Thumshirn
On Fri, Aug 26, 2016 at 11:45:18AM -0500, Don Brace wrote: > From: Kevin Barnett > > minor cleanup of scsi queue command function > > Reviewed-by: Scott Teel > Reviewed-by: Scott Benesh > Signed-off-by: Kevin Barnett > Signed-off-by: Don Brace > --- Reviewed-by: Johannes Thumshirn -- Joh

Re: [PATCH 13/17] smartpqi: remove timeout for cache flush operations

2016-08-29 Thread Johannes Thumshirn
On Fri, Aug 26, 2016 at 11:45:24AM -0500, Don Brace wrote: > From: Kevin Barnett > > Some cache flush operations can take longer than the > timeout value. Best to not impose a time limit to > handle all cases. > > Reviewed-by: Scott Teel > Reviewed-by: Scott Benesh > Signed-off-by: Kevin Barne

Re: [PATCH 14/17] smartpqi: update Kconfig

2016-08-29 Thread Johannes Thumshirn
On Fri, Aug 26, 2016 at 11:45:30AM -0500, Don Brace wrote: > From: Kevin Barnett > > The aacraid driver will not managage Microsemi > smartpqi controllers, but will still manage > older aacraid devices. > > Updated help section. > > Reviewed-by: Scott Teel > Reviewed-by: Scott Benesh > Review

Re: [PATCH 15/17] smartpqi: update maintainers

2016-08-29 Thread Johannes Thumshirn
On Fri, Aug 26, 2016 at 11:45:36AM -0500, Don Brace wrote: > From: Kevin Barnett > > added Documentation/scsi/smartpqi.txt > > Reviewed-by: Kevin Barnett > Reviewed-by: Scott Benesh > Signed-off-by: Don Brace > --- > MAINTAINERS |1 + > 1 file changed, 1 insertion(+) > > diff --git a/MA

Re: [PATCH 16/17] smartpqi: add smartpqi.txt

2016-08-29 Thread Johannes Thumshirn
On Fri, Aug 26, 2016 at 11:45:43AM -0500, Don Brace wrote: > From: Kevin Barnett > > Reviewed-by: Kevin Barnett > Reviewed-by: Scott Benesh > Signed-off-by: Don Brace > --- With the MAINTAINERS update patch folded in Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn

Re: [PATCH 17/17] smartqi: bump driver version

2016-08-29 Thread Johannes Thumshirn
On Fri, Aug 26, 2016 at 11:45:49AM -0500, Don Brace wrote: > From: Kevin Barnett > > Reviewed-by: Scott Teel > Reviewed-by: Scott Benesh > Signed-off-by: Kevin Barnett > Signed-off-by: Don Brace > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn

[PATCH] scsi: ufs: add missing header dependencies for tc-dwc-g210

2016-08-29 Thread Baoyou Xie
We get 2 warnings when build kernel with W=1: drivers/scsi/ufs/tc-dwc-g210.c:261:5: warning: no previous prototype for 'tc_dwc_g210_config_40_bit' [-Wmissing-prototypes] drivers/scsi/ufs/tc-dwc-g210.c:293:5: warning: no previous prototype for 'tc_dwc_g210_config_20_bit' [-Wmissing-prototypes] In

[PATCH] [SCSI] qla4xxx: mark symbols static where possible

2016-08-29 Thread Baoyou Xie
We get 1 warning when build kernel with W=1: drivers/scsi/qla4xxx/ql4_nx.c:1846:10: warning: no previous prototype for 'ql4_84xx_ipmdio_rd_reg' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so t

Re: [PATCH] scsi: move function declarationes to scsi_priv.h

2016-08-29 Thread Bart Van Assche
On 08/27/2016 09:59 AM, Baoyou Xie wrote: We get 2 warnings about global functions without a declaration in the scsi driver when building with W=1: drivers/scsi/scsi_lib.c:467:6: warning: no previous prototype for 'scsi_requeue_run_queue' [-Wmissing-prototypes] drivers/scsi/scsi_lib.c:2609:6: wa

Re: Oops when completing request on the wrong queue

2016-08-29 Thread Gabriel Krisman Bertazi
Jens Axboe writes: >> Can you try this patch? It's not perfect, but I'll be interested if it >> makes a difference for you. > Hi Jens, Sorry for the delay. I just got back to this and have been running your patch on top of 4.8 without a crash for over 1 hour. I wanna give it more time to make

Re: Time to make dynamically allocated devt the default for scsi disks?

2016-08-29 Thread Bart Van Assche
On 08/14/2016 10:21 AM, James Bottomley wrote: > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > index d3e852a..222771d 100644 > --- a/drivers/scsi/sd.c > +++ b/drivers/scsi/sd.c > @@ -3000,7 +3000,13 @@ static void sd_probe_async(void *data, async_cookie_t > cookie) > } > > blk

Re: Oops when completing request on the wrong queue

2016-08-29 Thread Jens Axboe
On 08/29/2016 12:06 PM, Gabriel Krisman Bertazi wrote: Jens Axboe writes: Can you try this patch? It's not perfect, but I'll be interested if it makes a difference for you. Hi Jens, Sorry for the delay. I just got back to this and have been running your patch on top of 4.8 without a crash

Re: [PATCH -next] ibmvscsis: Use list_move_tail instead of list_del/list_add_tail

2016-08-29 Thread Tyrel Datwyler
On 07/22/2016 07:03 AM, Wei Yongjun wrote: > Using list_move_tail() instead of list_del() + list_add_tail(). > > Signed-off-by: Wei Yongjun Reviewed-by: Tyrel Datwyler -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org

RE: [PATCH 06/17] smartpqi: change commonly used function to inline

2016-08-29 Thread Don Brace
> -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Monday, August 29, 2016 4:07 AM > To: Don Brace > Cc: j...@linux.vnet.ibm.com; Viswas G; Mahesh Rajashekhara; > h...@infradead.org; Scott Teel; Kevin Barnett; Justin Lindley; Scott Benesh; > elli...@hpe.com;

RE: [PATCH 15/17] smartpqi: update maintainers

2016-08-29 Thread Don Brace
> -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Monday, August 29, 2016 4:42 AM > To: Don Brace > Cc: j...@linux.vnet.ibm.com; Viswas G; Mahesh Rajashekhara; > h...@infradead.org; Scott Teel; Kevin Barnett; Justin Lindley; Scott Benesh; > elli...@hpe.com;

RE: [PATCH 11/17] smartpqi: minor tweaks to update time support

2016-08-29 Thread Don Brace
> -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Monday, August 29, 2016 4:34 AM > To: Don Brace > Cc: j...@linux.vnet.ibm.com; Viswas G; Mahesh Rajashekhara; > h...@infradead.org; Scott Teel; Kevin Barnett; Justin Lindley; Scott Benesh; > elli...@hpe.com;

RE: [PATCH 13/17] smartpqi: remove timeout for cache flush operations

2016-08-29 Thread Don Brace
> -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Monday, August 29, 2016 4:40 AM > To: Don Brace > Cc: j...@linux.vnet.ibm.com; Viswas G; Mahesh Rajashekhara; > h...@infradead.org; Scott Teel; Kevin Barnett; Justin Lindley; Scott Benesh; > elli...@hpe.com;

RE: [PATCH 01/17] smartpqi: change aio sg processing

2016-08-29 Thread Don Brace
> -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Monday, August 29, 2016 3:54 AM > To: Don Brace > Cc: j...@linux.vnet.ibm.com; Viswas G; Mahesh Rajashekhara; > h...@infradead.org; Scott Teel; Kevin Barnett; Justin Lindley; Scott Benesh; > elli...@hpe.com;