RE: [PATCH 1/7] aacraid: Use memdup_user() rather than duplicating its implementation

2016-08-25 Thread David Carroll
> > > > Hi Markus, > > > > Patch 2/7 should precede Patch 1/7, as falling into kfree() would not look > pretty. > > Do you eventually prefer that this source code adjustment should be combined > with the update suggestion "[2/7] aacraid: One function call less in > aac_send_raw_srb() after error d

Re: [PATCH] ata: do not hard code limit in ata_set_lba_range_entries()

2016-08-25 Thread Shaun Tancheff
Tom, In my opinion this patch you submitted is simply making the code less safe against a buffer overflow without a sufficiently good reason. In future please comment on other patches as replies to those patches. Mixing them together is just confusing. --Shaun -- To unsubscribe from this list: s

[PATCH] UFS: Date Segment only need for WRITE DESCRIPTOR

2016-08-25 Thread Zang Leigang
Some device may cause a compatibility issue while receiving a Query UPIU with Data Segment which does not expected. Signed-off-by: Zang Leigang --- drivers/scsi/ufs/ufshcd.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/

Re: [PATCH] UFS: Date Segment only need for WRITE DESCRIPTOR

2016-08-25 Thread kbuild test robot
ord what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/Zang-Leigang/UFS-Date-Segment-only-need-for-WRITE-DESCRIPTOR/20160825-165332 base: https://git.kernel.org/pub/

[PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR

2016-08-25 Thread Zang Leigang
Some device may cause a compatibility issue while receiving a Query UPIU with Data Segment which does not expected. Signed-off-by: Zang Leigang --- drivers/scsi/ufs/ufshcd.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/

Re: [PATCHv2] ipr: Add asynchronous error notification

2016-08-25 Thread Gabriel Krisman Bertazi
Brian King writes: > Looks pretty good. I noticed one issue in an error path where you > weren't removing the new sysfs file. Here is a fixed version. > The modifications look good to me. -- Gabriel Krisman Bertazi -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in t

Re: [PATCH] scsi: don't reinitialize adapter's req_table

2016-08-25 Thread Bradley Grove
Acked-by: Bradley Grove On 08/20/2016 10:39 PM, Shawn Lin wrote: req_table is allocate by kzalloc, so we don't need to zero it again anyway. Signed-off-by: Shawn Lin --- drivers/scsi/esas2r/esas2r_init.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/scsi/esas2r/esas2r_init.

Re: [PATCH] scsi: not need to alloc zero buffer for local_atto_ioctl

2016-08-25 Thread Bradley Grove
Acked-by: Bradley Grove On 08/20/2016 10:33 PM, Shawn Lin wrote: We don't need to use kzalloc as we will always memset the local_atto_ioctl later. Signed-off-by: Shawn Lin --- drivers/scsi/esas2r/esas2r_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/

Re: [PATCH v8 1/2 RESEND] Add bio/request flags to issue ZBC/ZAC commands

2016-08-25 Thread Damien Le Moal
Shaun, On 8/25/16 05:24, Shaun Tancheff wrote: (RESENDING to include f2fs, fs-devel and dm-devel) Add op flags to access to zone information as well as open, close and reset zones: - REQ_OP_ZONE_REPORT - Query zone information (Report zones) - REQ_OP_ZONE_OPEN - Explicitly open a zone for

Re: [PATCH] megaraid_sas: Fix the search of first memory bar

2016-08-25 Thread Martin K. Petersen
> "Christophe" == Christophe JAILLET writes: Christophe> The 2nd parameter of 'find_first_bit' is the number of bits Christophe> to search. In this case, we are passing 'sizeof(unsigned Christophe> long)' which is likely to be 4. Kashyap? Sumit? -- Martin K. Petersen Oracle Linux Eng

Re: [PATCH v2 0/8] hisi_sas internal abort support

2016-08-25 Thread Martin K. Petersen
> "John" == John Garry writes: John> This patchset introduces support for the internal abort feature John> for the HiSilicon SAS controller. John> The internal abort feature allows commands which are active in the John> controller to be aborted before being sent to the slave device. John> O

Re: [PATCHv2] ipr: Add asynchronous error notification

2016-08-25 Thread Martin K. Petersen
> "Brian" == Brian King writes: Brian> Looks pretty good. I noticed one issue in an error path where you Brian> weren't removing the new sysfs file. Here is a fixed version. Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: sen

Re: [PATCH] scsi: core: configure runtime pm before calling device_add in scsi_add_host_with_dma

2016-08-25 Thread Martin K. Petersen
> "Heiner" == Heiner Kallweit writes: Heiner> Runtime PM should be configured already once we call Heiner> device_add. See also the description in this mail thread Heiner> https://lists.linuxfoundation.org/pipermail/linux-pm/2009-November/023198.html Heiner> or the order of calls e.g. in usb

Re: [PATCH] aic94xx: Add missing error code assignment before test

2016-08-25 Thread Martin K. Petersen
> "Christophe" == Christophe JAILLET writes: Christophe> It is likely that checking the result of Christophe> 'pci_write_config_dword' is expected here. Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH 0/2] ibmvfc: FC-TAPE Support

2016-08-25 Thread Martin K. Petersen
> "Tyrel" == Tyrel Datwyler writes: Tyrel> This patchset introduces optional FC-TAPE/FC Class 3 Error Tyrel> Recovery to the ibmvfc client driver. Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [PATCH 1/2] scsi: sg: Avoid overflow when USER_HZ > HZ

2016-08-25 Thread Martin K. Petersen
> "Paul" == Paul Burton writes: Paul> Calculating the maximum timeout that a user can set via the Paul> SG_SET_TIMEOUT ioctl involves multiplying INT_MAX by Paul> USER_HZ/HZ. If USER_HZ is larger than HZ then this results in an Paul> overflow when performed as a 32 bit integer calculation, re

Re: [PATCH] scsi: don't reinitialize adapter's req_table

2016-08-25 Thread Martin K. Petersen
> "Shawn" == Shawn Lin writes: Shawn> req_table is allocate by kzalloc, so we don't need to zero it Shawn> again anyway. Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a

RE: [PATCH] megaraid_sas: Fix the search of first memory bar

2016-08-25 Thread Sumit Saxena
>-Original Message- >From: Christophe JAILLET [mailto:christophe.jail...@wanadoo.fr] >Sent: Sunday, August 21, 2016 1:58 PM >To: kashyap.de...@avagotech.com; sumit.sax...@avagotech.com; >uday.ling...@avagotech.com; j...@linux.vnet.ibm.com; >martin.peter...@oracle.com >Cc: megaraidlinux@

Re: [PATCH] scsi: not need to alloc zero buffer for local_atto_ioctl

2016-08-25 Thread Martin K. Petersen
> "Shawn" == Shawn Lin writes: Shawn> We don't need to use kzalloc as we will always memset the Shawn> local_atto_ioctl later. Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body

Re: [PATCH v8 1/2 RESEND] Add bio/request flags to issue ZBC/ZAC commands

2016-08-25 Thread Shaun Tancheff
On Thu, Aug 25, 2016 at 9:31 PM, Damien Le Moal wrote: > > Shaun, > > On 8/25/16 05:24, Shaun Tancheff wrote: >> >> (RESENDING to include f2fs, fs-devel and dm-devel) >> >> Add op flags to access to zone information as well as open, close >> and reset zones: >> - REQ_OP_ZONE_REPORT - Query zone