Re: [PATCH v4 2/3] ses: use scsi_is_sas_rphy instead of is_sas_attached

2016-08-24 Thread Johannes Thumshirn
On Mon, Aug 22, 2016 at 04:57:39PM +0800, kbuild test robot wrote: > Hi Johannes, > > [auto build test ERROR on scsi/for-next] > [also build test ERROR on v4.8-rc3] > [cannot apply to next-20160822] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the sys

[PATCH 1/3] be2iscsi: Fix error return code

2016-08-24 Thread Jitendra Bhivare
From: Christophe JAILLET We know that 'ret' is not an error code because it has been tested a few lines above. So, if one of these function fails, 0 will be returned instead of an error code. Return -ENOMEM instead. Signed-off-by: Christophe JAILLET 'ret' needs to be set with error code if hba

[PATCH 2/3] be2iscsi: Remove redundant iscsi_wrb desc memset

2016-08-24 Thread Jitendra Bhivare
alloc_wrb_handle already does memset zero of iscsi_wrb descriptor so remove redundant memset in WRB submission paths. Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_main.c | 1 - drivers/scsi/be2iscsi/be_mgmt.c | 3 --- 2 files changed, 4 deletions(-) diff --git a/drivers/scsi/be2

[PATCH 0/3] be2iscsi: cleanup of 11.2 in 4.9/scsi-queue

2016-08-24 Thread Jitendra Bhivare
These patches address some auto built issues of 11.2.0.0 be2iscsi committed in 4.9/scsi-queue. Christophe JAILLET (1): be2iscsi: Fix error return code Jitendra Bhivare (2): be2iscsi: Remove redundant iscsi_wrb desc memset be2iscsi: Add missing unlock for mbox_lock drivers/scsi/be2iscsi/be

[PATCH 3/3] be2iscsi: Add missing unlock for mbox_lock

2016-08-24 Thread Jitendra Bhivare
Julia pointed out beiscsi_boot_get_sinfo does not unlock mbox_lock on nonemb_cmd memory allocation failure. Signed-off-by: Jitendra Bhivare --- drivers/scsi/be2iscsi/be_mgmt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be

[PATCH 0/3] be2iscsi: cleanup of 11.2 in 4.9/scsi-queue

2016-08-24 Thread Jitendra Bhivare
These patches address some auto built issues of 11.2.0.0 be2iscsi committed in 4.9/scsi-queue. Christophe JAILLET (1): be2iscsi: Fix error return code Jitendra Bhivare (2): be2iscsi: Remove redundant iscsi_wrb desc memset be2iscsi: Add missing unlock for mbox_lock drivers/scsi/be2iscsi/be

[PATCH v2 2/8] hisi_sas: add internal abort in hisi_sas_dev_gone()

2016-08-24 Thread John Garry
Execute an internal abort for that device when it is removed, so that commands for that device are not processed. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_

[PATCH v2 1/8] hisi_sas: add internal abort main code

2016-08-24 Thread John Garry
Add main code for internal abort functionality. The internal abort features allows the host controller to abort commands which are still active in the controller but have not yet been sent to the slave device. Typically a command only spends a relatively short time in the controller when compared

[PATCH v2 7/8] hisi_sas: add TMF success check

2016-08-24 Thread John Garry
When a tmf is issued, various response codes can be returned from the target. For a query tmf the response may be TMF_RESP_FUNC_COMPLETE or TMF_RESP_FUNC_SUCC. Add a condition for TMF_RESP_FUNC_SUCC to hisi_sas_exec_internal_tmf_task(). This affects query tmf, as the result is success the returned

[PATCH v2 0/8] hisi_sas internal abort support

2016-08-24 Thread John Garry
This patchset introduces support for the internal abort feature for the HiSilicon SAS controller. The internal abort feature allows commands which are active in the controller to be aborted before being sent to the slave device. Only support will be added for v2 HW since v1 HW has issues in suppo

[PATCH v2 4/8] hisi_sas: add prep_abort_v2_hw()

2016-08-24 Thread John Garry
Add function to prepare the an internal abort for v2 hw. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c in

[PATCH v2 3/8] hisi_sas: add internal abort to hisi_sas_abort_task()

2016-08-24 Thread John Garry
Execute an internal abort for executing a task abort. This is for case of the command still being present in host when abort is executed. For a SATA internal abort, we set abort for all tasks associated with the device. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 16 ++

[PATCH v2 8/8] hisi_sas: update version to 1.6

2016-08-24 Thread John Garry
Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hisi_sas/hisi_sas.h b/drivers/scsi/hisi_sas/hisi_sas.h index 8311360..ca55ec2 100644 --- a/drivers/scsi/hisi_sas/hisi_sas.h +++ b/drivers/scsi/hisi_sas/h

[PATCH v2 6/8] hisi_sas: fail tmf task prep when port detached

2016-08-24 Thread John Garry
When the port is detached we cannot execute a TMF, as there can be no device attached to the port. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sa

[PATCH v2 5/8] hisi_sas: add v2 hw slot complete internal abort support

2016-08-24 Thread John Garry
Add code in slot_complete_v2_hw() to deal with the slots which have completed due to internal abort. The status codes have the following meaning: - STAT_IO_ABORTED: the IO has been aborted due to internal abort, whether by device or individual abort command - STAT_IO_COMPLETE: internal abort comma

[Bug 153171] scsi host6: runtime PM trying to activate child device host6 but parent (2-2:1.0) is not active

2016-08-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=153171 Chris Bainbridge changed: What|Removed |Added CC||chris.bainbri...@gmail.com --- Commen

Re: [PATCH v2 2/8] hisi_sas: add internal abort in hisi_sas_dev_gone()

2016-08-24 Thread Hannes Reinecke
On 08/24/2016 01:05 PM, John Garry wrote: > Execute an internal abort for that device when it is removed, > so that commands for that device are not processed. > > Signed-off-by: John Garry > --- > drivers/scsi/hisi_sas/hisi_sas_main.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a

Re: [PATCH v2 1/8] hisi_sas: add internal abort main code

2016-08-24 Thread Hannes Reinecke
On 08/24/2016 01:05 PM, John Garry wrote: > Add main code for internal abort functionality. > > The internal abort features allows the host controller > to abort commands which are still active in the > controller but have not yet been sent to the slave > device. > > Typically a command only spen

Re: [PATCH v2 3/8] hisi_sas: add internal abort to hisi_sas_abort_task()

2016-08-24 Thread Hannes Reinecke
On 08/24/2016 01:05 PM, John Garry wrote: > Execute an internal abort for executing a task abort. > This is for case of the command still being present > in host when abort is executed. > > For a SATA internal abort, we set abort for all tasks > associated with the device. > > Signed-off-by: John

Re: [PATCH v2 4/8] hisi_sas: add prep_abort_v2_hw()

2016-08-24 Thread Hannes Reinecke
On 08/24/2016 01:05 PM, John Garry wrote: > Add function to prepare the an internal abort > for v2 hw. > > Signed-off-by: John Garry > --- > drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 33 + > 1 file changed, 33 insertions(+) > Reviewed-by: Hannes Reinecke Cheers,

Re: [PATCH v2 5/8] hisi_sas: add v2 hw slot complete internal abort support

2016-08-24 Thread Hannes Reinecke
On 08/24/2016 01:05 PM, John Garry wrote: > Add code in slot_complete_v2_hw() to deal with the > slots which have completed due to internal abort. > > The status codes have the following meaning: > - STAT_IO_ABORTED: the IO has been aborted due to > internal abort, whether by device or individual

Re: [PATCH v2 6/8] hisi_sas: fail tmf task prep when port detached

2016-08-24 Thread Hannes Reinecke
On 08/24/2016 01:05 PM, John Garry wrote: > When the port is detached we cannot execute a TMF, > as there can be no device attached to the port. > > Signed-off-by: John Garry > --- > drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/d

Re: [PATCH v2 7/8] hisi_sas: add TMF success check

2016-08-24 Thread Hannes Reinecke
On 08/24/2016 01:05 PM, John Garry wrote: > When a tmf is issued, various response codes can be > returned from the target. For a query tmf the > response may be TMF_RESP_FUNC_COMPLETE or > TMF_RESP_FUNC_SUCC. > Add a condition for TMF_RESP_FUNC_SUCC to > hisi_sas_exec_internal_tmf_task(). > This a

Re: [PATCH v2 8/8] hisi_sas: update version to 1.6

2016-08-24 Thread Hannes Reinecke
On 08/24/2016 01:05 PM, John Garry wrote: > Signed-off-by: John Garry > --- > drivers/scsi/hisi_sas/hisi_sas.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/hisi_sas/hisi_sas.h > b/drivers/scsi/hisi_sas/hisi_sas.h > index 8311360..ca55ec2 100644 > --- a/d

Re: [PATCH v2 5/8] hisi_sas: add v2 hw slot complete internal abort support

2016-08-24 Thread John Garry
On 24/08/2016 13:59, Hannes Reinecke wrote: On 08/24/2016 01:05 PM, John Garry wrote: Add code in slot_complete_v2_hw() to deal with the slots which have completed due to internal abort. The status codes have the following meaning: - STAT_IO_ABORTED: the IO has been aborted due to internal abor

Re: [PATCH v2 5/8] hisi_sas: add v2 hw slot complete internal abort support

2016-08-24 Thread Hannes Reinecke
On 08/24/2016 04:07 PM, John Garry wrote: > On 24/08/2016 13:59, Hannes Reinecke wrote: >> On 08/24/2016 01:05 PM, John Garry wrote: >>> Add code in slot_complete_v2_hw() to deal with the >>> slots which have completed due to internal abort. >>> >>> The status codes have the following meaning: >>>

[PATCHv2] ipr: Add asynchronous error notification

2016-08-24 Thread Brian King
Looks pretty good. I noticed one issue in an error path where you weren't removing the new sysfs file. Here is a fixed version. 8< This patch implements functions for pushing HCAM (host controlled asynchronous messages) error buffers to userspace through sysfs attributes. Reads to the "async_err_

Re: Oops when completing request on the wrong queue

2016-08-24 Thread Jens Axboe
On 08/23/2016 03:14 PM, Jens Axboe wrote: On 08/23/2016 03:11 PM, Jens Axboe wrote: On 08/23/2016 02:54 PM, Gabriel Krisman Bertazi wrote: Gabriel Krisman Bertazi writes: Can you share what you ran to online/offline CPUs? I can't reproduce this here. I was using the ppc64_cpu tool, which s

[PATCH v8 0/2 RESEND] Block layer support ZAC/ZBC commands

2016-08-24 Thread Shaun Tancheff
(RESENDING to include f2fs, fs-devel and dm-devel) Hi Jens, This series is based on linus' v4.8-rc2 branch. As Host Aware drives are becoming available we would like to be able to make use of such drives. This series is also intended to be suitable for use by Host Managed drives. ZBC [and ZAC]

[PATCH v8 1/2 RESEND] Add bio/request flags to issue ZBC/ZAC commands

2016-08-24 Thread Shaun Tancheff
(RESENDING to include f2fs, fs-devel and dm-devel) Add op flags to access to zone information as well as open, close and reset zones: - REQ_OP_ZONE_REPORT - Query zone information (Report zones) - REQ_OP_ZONE_OPEN - Explicitly open a zone for writing - REQ_OP_ZONE_CLOSE - Explicitly close a

[PATCH v8 2/2 RESEND] Add ioctl to issue ZBC/ZAC commands via block layer

2016-08-24 Thread Shaun Tancheff
(RESENDING to include f2fs, fs-devel and dm-devel) Add support for ZBC ioctl's BLKREPORT - Issue Report Zones to device. BLKZONEACTION - Issue a Zone Action (Close, Finish, Open, or Reset) Signed-off-by: Shaun Tancheff --- v8: - Changed ioctl for zone actions to a single ioctl that

Re: Oops when completing request on the wrong queue

2016-08-24 Thread Jens Axboe
On 08/24/2016 12:34 PM, Jens Axboe wrote: On 08/23/2016 03:14 PM, Jens Axboe wrote: On 08/23/2016 03:11 PM, Jens Axboe wrote: On 08/23/2016 02:54 PM, Gabriel Krisman Bertazi wrote: Gabriel Krisman Bertazi writes: Can you share what you ran to online/offline CPUs? I can't reproduce this here