Am 03.08.2016 um 23:25 schrieb Alan Stern:
> On Wed, 3 Aug 2016, Heiner Kallweit wrote:
>
>> Since commit 71723f95463d "PM / runtime: print error when activating a
>> child to unactive parent" I see the following error message:
>>
>> scsi host2: usb-storage 1-3:1.0
>> scsi host2: runtime PM trying
On Thu, Aug 04, 2016 at 08:27:56AM +0300, Dan Carpenter wrote:
> This should be doing kfree_skb() instead of kfree().
>
> Fixes: 9a6cf881df02 ('fcoe: implement FIP VLAN responder')
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c
> ind
In aacraid's ioctl_send_fib() we do two fetches from userspace, one the
get the fib header's size and one for the fib itself. Later we use the
size field from the second fetch to further process the fib. If for some
reason the size from the second fetch is different than from the first
fix, we may
Hi,
In iSER target during iwarp connection tear-down due to ping timeouts, the rdma
queues are set to error state and subsequent queued iscsi session commands
posted
shall fail with corresponding errno returned by ib_post_send/recv.
At this stage iser target handlers (Ex: isert_put_datain())
ret
On Wed, Aug 03, 2016 at 03:13:01PM +0200, Hannes Reinecke wrote:
> The kref handling in fc_rport is a mess. This patch updates
> the kref handling according to the following rules:
>
> - Take a reference whenever scheduling a workqueue
> - Take a reference whenever an ELS command is send
> - Drop
On Wed, Aug 03, 2016 at 03:13:02PM +0200, Hannes Reinecke wrote:
> Signed-off-by: Hannes Reinecke
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr.
On Wed, Aug 03, 2016 at 03:13:04PM +0200, Hannes Reinecke wrote:
> If a command times out libfc is sending an REC, which also
> might fail (due to frames being lost or something).
> If no data has been transferred we can simply retry
> the command, but the current code sets a state of FC_ERROR,
> w
On Wed, Aug 03, 2016 at 03:13:06PM +0200, Hannes Reinecke wrote:
> The initial PRLI is errored out with these messages:
> [ 5424.530686] host8: rport 001a1e: Received a PRLI accept
> [ 5424.530687] host8: rport 001a1e: PRLI spp_flags = 0x0
> [ 5424.530688] host8: rport 001a1e: Error -13193828960665
On Wed, Aug 03, 2016 at 03:13:07PM +0200, Hannes Reinecke wrote:
> ---
> drivers/scsi/fcoe/fcoe_ctlr.c | 12 +++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c
> index 1d0bec6..e7a14aa 100644
> --- a/driver
On Wed, Aug 03, 2016 at 03:13:03PM +0200, Hannes Reinecke wrote:
> Add additional statements for debugging FIP frames.
>
> Signed-off-by: Hannes Reinecke
With Bart's comment addressed:
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh.
On Wed, Aug 03, 2016 at 03:13:05PM +0200, Hannes Reinecke wrote:
> When the port is already started we don't need to login; that
> will only confuse the state machine.
>
> Signed-off-by: Hannes Reinecke
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn
On Wed, Aug 03, 2016 at 03:13:08PM +0200, Hannes Reinecke wrote:
> The user might want to modify the values for R_A_TOV and E_D_TOV,
> so add new module parameters 'e_d_tov' and 'r_a_tov' for the
> 'fcoe' modules and allow to modify them via sysfs attributes.
>
> Signed-off-by: Hannes Reinecke
A
On Wed, Aug 03, 2016 at 03:13:09PM +0200, Hannes Reinecke wrote:
> We should be using the configured R_A_TOV value when sending the
> exchange.
>
> Signed-off-by: Hannes Reinecke
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@sus
On Wed, Aug 03, 2016 at 03:13:10PM +0200, Hannes Reinecke wrote:
> If fc_rport_error_retry() is attempting to retry the remote
> port state we should be waiting for the configured e_d_tov
> value rather than the default.
>
> Signed-off-by: Hannes Reinecke
Acked-by: Johannes Thumshirn
--
Johan
On Wed, Aug 03, 2016 at 03:13:12PM +0200, Hannes Reinecke wrote:
> If a sequence should be aborted the exchange might already
> be completed (eg if the response is still queued in the rx
> queue), so this shouldn't considered as an error.
>
> Signed-off-by: Hannes Reinecke
Acked-by: Johannes Thu
On Wed, Aug 03, 2016 at 03:13:14PM +0200, Hannes Reinecke wrote:
> We only ever use the 'fp' argument for fc_rport_error() to
> encapsulate the error code, so we can as well do away with that
> and pass the error directly.
>
> Signed-off-by: Hannes Reinecke
Acked-by: Johannes Thumshirn
--
Joh
On Wed, Aug 03, 2016 at 03:13:13PM +0200, Hannes Reinecke wrote:
> When a command is aborted it might already have the DID_TIME_OUT
> status set, so we shouldn't be overwriting that.
>
> Signed-off-by: Hannes Reinecke
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn
On Wed, Aug 03, 2016 at 03:13:15PM +0200, Hannes Reinecke wrote:
> ---
> drivers/scsi/libfc/fc_exch.c | 41 +
> 1 file changed, 33 insertions(+), 8 deletions(-)
>
Missing Signed-off-by...
--
Johannes Thumshirn Sto
On Wed, Aug 03, 2016 at 03:13:17PM +0200, Hannes Reinecke wrote:
> When we fail to allocate a frame we should be sending an LS_RJT
> response and not just silently drop the frame altogether.
>
> Signed-off-by: Hannes Reinecke
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn
On Wed, Aug 03, 2016 at 03:13:18PM +0200, Hannes Reinecke wrote:
> When we receive an FLOGI but have already sent our own we should
> not advance the state machine but rather wait for our FLOGI to
> return before continuing with PLOGI.
>
> Signed-off-by: Hannes Reinecke
Acked-by: Johannes Thumsh
On Wed, Aug 03, 2016 at 03:13:20PM +0200, Hannes Reinecke wrote:
> When receiving packets from the network we cannot guarantee any
> frame ordering, so we should be receiving all valid frames and
> let the upper layers deal with it.
>
> Signed-off-by: Hannes Reinecke
Acked-by: Johannes Thumshirn
On Wed, Aug 03, 2016 at 03:13:19PM +0200, Hannes Reinecke wrote:
> The libfc stack generates an RTV request, so we should be implementing
> an RTV responder, too.
>
> Signed-off-by: Hannes Reinecke
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn Sto
On Wed, Aug 03, 2016 at 03:13:21PM +0200, Hannes Reinecke wrote:
> When we're receiving a timeout we should be checking for queue
> full status; if there are still some packets pending we should
> be resetting the counter to ensure we're not missing out any
> packets which are still queued.
>
> Si
On Wed, Aug 03, 2016 at 03:13:16PM +0200, Hannes Reinecke wrote:
> Add missing ELS RJT explanation values from FC-LS3.
>
> Signed-off-by: Hannes Reinecke
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de
On 08/03/16 06:13, Hannes Reinecke wrote:
As usual, comments and reviews are welcome.
Great work :-) Have you been testing these patches against the LIO FCoE
target driver? In that case you might need to port the following patch
to LIO, a patch that fixes a subtle data corruption issue:
http
On Mon, Aug 01, 2016 at 11:42:24AM +0200, Piotr Szymaniak wrote:
> Hi,
(Sorry, for almost-topposting. Leaving below for reference.)
As a followup to this thread - looking for answers here and there I've
added intel_iommu=igfx_off (found at some thread with some other
hardware mentioning Sandy Bri
On Wed, Aug 03, 2016 at 07:30:29PM -0500, Shaun Tancheff wrote:
> I think the translation in loop.c is suspicious here:
>
> "if use DIO && not (a flush_flag or discard_flag)"
> should translate to:
> "if use DIO && not ((a flush_flag) || op == discard)"
>
> But in the patch I read:
>
On Wed, Aug 03 2016 at 12:55pm -0400,
Bart Van Assche wrote:
> On 08/02/2016 05:40 PM, Mike Snitzer wrote:
> >But I asked you to run the v4.7 kernel patches I
> >pointed to _without_ any of your debug patches.
>
> I need several patches to fix bugs that are not related to the
> device mapper, e.
On Thu, Aug 4, 2016 at 10:46 AM, Christoph Hellwig wrote:
> On Wed, Aug 03, 2016 at 07:30:29PM -0500, Shaun Tancheff wrote:
>> I think the translation in loop.c is suspicious here:
>>
>> "if use DIO && not (a flush_flag or discard_flag)"
>> should translate to:
>> "if use DIO && not ((a fl
Am 03.08.2016 um 21:49 schrieb Heiner Kallweit:
> Runtime PM should be configured already once we call device_add. See also
> the description in this mail thread
> https://lists.linuxfoundation.org/pipermail/linux-pm/2009-November/023198.html
> or the order of calls e.g. in usb_new_device.
>
> The
On 08/04/2016 09:10 AM, Mike Snitzer wrote:
Anyway, at this point you're having us test too many changes that aren't
yet upstream:
$ git diff bart/srp-initiator-for-next dm/dm-4.7-mpath-fixes -- drivers block
include kernel | diffstat
block/bio-integrity.c |1
block/blk-c
On Mon, 1 Aug 2016 04:36:28 +0200 Tomas Vondra wrote:
> Hi,
>
> While investigating a strange OOM issue on the 3.18.x branch (which
> turned out to be already fixed by 52c84a95), I've noticed a strange
> difference in Dirty/Writeback fields in /proc/meminfo depending on
> kernel version. I'm
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
> ow...@vger.kernel.org] On Behalf Of Johannes Thumshirn
> Sent: Thursday, August 04, 2016 2:36 AM
> To: Martin K . Petersen; James Bottomley
> Cc: Linux SCSI Mailinglist; Pengfei Wang; Johannes Thumshirn;
> s
Commit 655ee63cf371 added a "Completed" sense string with key 0xF to
snstext[], but failed to updated the upper bounds check of the sense key in
scsi_sense_key_string().
Fixes: 655ee63cf371 ("[SCSI] scsi constants: command, sense key + additional
sense strings")
Signed-off-by: Tyrel Datwyler
---
On 8/3/16, 11:42 AM, "Dan Carpenter" wrote:
>The "if (test_bit(UNLOADING..." line was indented one tab more than it
>should have been. There was an extra parenthesis around the
>qla2x00_reset_active() function call. I lined up the conditions a bit
>so that it shows how they group together.
>
>
I've staged another fix, Laurence is seeing success with this added:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.8&id=d50a6450104c237db1dc75314d17b78c990a8c05
I'll be sending all the fixes I've queued to Linus tonight or early
tomorrow (since I'll then be
- Original Message -
> From: "Mike Snitzer"
> To: "Bart Van Assche"
> Cc: dm-de...@redhat.com, "Laurence Oberman" ,
> linux-scsi@vger.kernel.org
> Sent: Thursday, August 4, 2016 7:58:50 PM
> Subject: Re: dm-mq and end_clone_request()
>
> I've staged another fix, Laurence is seeing suc
> "Don" == Don Brace writes:
Don,
Don> This driver is based on Linus's tree This initial commit contains
Don> WIP of Microsemi's smartpqi module.
Is your interface related to T10 PQI?
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsu
> "Wei" == Wei Yongjun writes:
Wei> Use kfree_skb() instead of kfree() to free sk_buff.
Applied to 4.8/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.
> "Calvin" == Calvin Owens writes:
Calvin> We blindly trust the hardware to give us NUL-terminated strings,
Calvin> which is a bad idea because it doesn't always do that. For
Calvin> example:
Broadcom folks, please respond to this and other mpt3sas patches in the
queue:
https://patchwork.ke
> "Jitendra" == Jitendra Bhivare writes:
Somebody please review:
https://patchwork.kernel.org/project/linux-scsi/list/?q=be2iscsi
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord.
Hi,
Please consider this patch as Acked-by: Chaitra P B
Thanks,
Chaitra
-Original Message-
From: Calvin Owens [mailto:calvinow...@fb.com]
Sent: Friday, July 29, 2016 10:08 AM
To: Sathya Prakash; Chaitra P B; Suganath Prabu Subramani; James E.J.
Bottomley; Martin K. Petersen
Cc: mpt-fu
Hi,
Please consider this patch as Acked-by: Chaitra P B
Thanks,
Chaitra
-Original Message-
From: Calvin Owens [mailto:calvinow...@fb.com]
Sent: Friday, July 29, 2016 10:08 AM
To: Sathya Prakash; Chaitra P B; Suganath Prabu Subramani; James E.J.
Bottomley; Martin K. Petersen
Cc: mpt-fus
Hi,
Please consider this patch as Acked-by: Chaitra P B
Thanks,
Chaitra
-Original Message-
From: mpt-fusionlinux@broadcom.com
[mailto:mpt-fusionlinux@broadcom.com] On Behalf Of Calvin Owens
Sent: Friday, July 29, 2016 10:08 AM
To: Sathya Prakash; Chaitra P B; Suganath Prabu Su
Hi,
Please consider this patch as Acked-by: Chaitra P B
Thanks,
Chaitra
-Original Message-
From: Calvin Owens [mailto:calvinow...@fb.com]
Sent: Thursday, July 28, 2016 10:16 AM
To: Sathya Prakash; Chaitra P B; Suganath Prabu Subramani; James E.J.
Bottomley; Martin K. Petersen
Cc: mpt-
Hi,
Please consider this patch as Acked-by: Chaitra P B
Thanks,
Chaitra
-Original Message-
From: linux-scsi-ow...@vger.kernel.org
[mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Johannes Thumshirn
Sent: Wednesday, August 03, 2016 6:30 PM
To: Martin K . Petersen; James Bottomley
46 matches
Mail list logo
