Re: [PATCH 0/6] fcoe: VN2VN target mode fixes

2016-07-27 Thread Johannes Thumshirn
On Wed, Jul 27, 2016 at 12:26:38AM -0400, Martin K . Petersen wrote: > > "Johannes" == Johannes Thumshirn writes: > > Johannes> I've now Acked patches 5 and 6 as well, Hannes' answers > Johannes> clarified my concerns. Can you pick 'em up for 4.8 as well? > > Done! Thanks a lot. -- Johan

[GIT PULL] first round of SCSI updates for the 4.7+ merge window

2016-07-27 Thread James Bottomley
This update includes the usual round of driver updates (fcoe, lpfc, ufs, qla2xxx, hisi_sas). The most important other change is removing the flag to allow non-blk_mq on a per host basis (it's unused); there is still a global module parameter for all of SCSI just in case. The rest are an assortmen

Re: dm-mq and end_clone_request()

2016-07-27 Thread Mike Snitzer
On Tue, Jul 26 2016 at 6:51pm -0400, Bart Van Assche wrote: > On 07/25/2016 06:15 PM, Mike Snitzer wrote: > > Please try this patch to see if it fixes your issue, thanks. > > > > diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c > > index 52baf8a..287caa7 100644 > > --- a/drivers/md/dm

Re: [dm-devel] dm-mq and end_clone_request()

2016-07-27 Thread Benjamin Marzinski
On Wed, Jul 27, 2016 at 10:08:28AM -0400, Mike Snitzer wrote: > On Tue, Jul 26 2016 at 6:51pm -0400, > Bart Van Assche wrote: > > > On 07/25/2016 06:15 PM, Mike Snitzer wrote: > > > Please try this patch to see if it fixes your issue, thanks. > > > > > > diff --git a/drivers/md/dm-mpath.c b/dri

Re: [dm-devel] dm-mq and end_clone_request()

2016-07-27 Thread Bart Van Assche
On 07/27/2016 08:52 AM, Benjamin Marzinski wrote: if you look in drivers/md/dm-ioctl.c at do_resume(), device mapper internally does a suspend when you call resume with a new table loaded. That's when these suspends are happening. In the userspace tools, this happens in the DM_DEVICE_RESUME call

Re: dm-mq and end_clone_request()

2016-07-27 Thread Mike Snitzer
On Wed, Jul 27 2016 at 3:06pm -0400, Bart Van Assche wrote: > On 07/27/2016 08:52 AM, Benjamin Marzinski wrote: > >if you look in drivers/md/dm-ioctl.c at do_resume(), device mapper > >internally does a suspend when you call resume with a new table loaded. > >That's when these suspends are happe

Re: dm-mq and end_clone_request()

2016-07-27 Thread Mike Snitzer
On Mon, Jul 25 2016 at 9:16pm -0400, Mike Snitzer wrote: > Hi Bart, > > Please try this patch to see if it fixes your issue, thanks. > > diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c > index 52baf8a..287caa7 100644 > --- a/drivers/md/dm-mpath.c > +++ b/drivers/md/dm-mpath.c > @@

Re: [PATCH resend 5/5] libata-scsi: fix MODE SELECT translation for Control mode page

2016-07-27 Thread Tom Yan
Yes, because it touches an actual ATA drive setting, while D_SENSE is merely a "software setting" stored in dev->flags to make the kernel response differently when build sense data. On 26 July 2016 at 02:30, Tejun Heo wrote: > On Fri, Jul 22, 2016 at 05:50:18AM +0800, Tom Yan wrote: >> As I've me

Re: [dm-devel] dm-mq and end_clone_request()

2016-07-27 Thread Bart Van Assche
On 07/27/2016 01:09 PM, Mike Snitzer wrote: In addition to the above patch, please apply this patch and retest your 4.7 kernel: diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c index 287caa7..16583c1 100644 --- a/drivers/md/dm-mpath.c +++ b/drivers/md/dm-mpath.c @@ -1416,12 +1416,14 @

Re: [PATCH] ses: Fix racy cleanup of /sys in remove_dev()

2016-07-27 Thread Calvin Owens
On 06/15/2016 01:24 PM, Calvin Owens wrote: On Thursday 06/02 at 15:50 -0700, Calvin Owens wrote: On 05/13/2016 01:28 PM, Calvin Owens wrote: Currently we free the resources backing the enclosure device before we call device_unregister(). This is racy: during rmmod of low-level SCSI drivers tha

[PATCH] mpt3sas: Ensure the connector_name string is NUL-terminated

2016-07-27 Thread Calvin Owens
We blindly trust the hardware to give us NUL-terminated strings, which is a bad idea because it doesn't always do that. For example: [ 481.184784] mpt3sas_cm0: enclosure level(0x), connector name( \x3) In this case, connector_name is four spaces. We got lucky here because the 2nd by