[Bug 135031] New: error @ quickbooks call full quickbooks technical support phone numner (1844)-@414 4868

2016-07-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=135031 Bug ID: 135031 Summary: error @ quickbooks call full quickbooks technical support phone numner (1844)-@414 4868 Product: SCSI Drivers Version: 2.5 Kernel Version: error @ quickbo

[patch] ibmvfc: prevent a potential deadlock

2016-07-15 Thread Dan Carpenter
My static checker complains that we need to unlock on this path. Seems true. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c index fc523c3..ab67ec4 100644 --- a/drivers/scsi/ibmvscsi/ibmvfc.c +++ b/drivers/scsi/ibmvscsi/ibmvfc.c @@ -4722

Re: [PATCH 01/19] qla2xxx: Remove sysfs node fw_dump_template.

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_attr.c | 89 > - > drivers/scsi/qla2xxx/qla_dbg.c | 1 + > 2 files changed, 1 ins

Re: [PATCH 03/19] qla2xxx: Shutdown board on thermal shutdown aen.

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_dbg.c | 2 +- > drivers/scsi/qla2xxx/qla_def.h | 1 + > drivers/scsi/qla2xxx/qla_isr.c | 7 +++ > drivers/scsi/qla2xx

Re: [PATCH 02/19] qla2xxx: Add ram area DDR for fwdump template entry T262.

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_def.h | 2 ++ > drivers/scsi/qla2xxx/qla_mbx.c | 7 +-- > drivers/scsi/qla2xxx/qla_tmpl.c | 9 - > 3 files cha

Re: [PATCH 04/19] qla2xxx: Set FLOGI retry in additional firmware options for P2P (N2N) mode.

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Giridhar Malavali > > When VP decoupling enabled, there could be a window where, FLOGI from > initiators > can be dropped before VP0 is enabled, causing link level recovery. > Retry FLOGI to avoid link level recovery. > > Signed-off-by: Gi

Re: [PATCH 05/19] qla2xxx: Add module parameter alternate/short names.

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_os.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_o

Re: [PATCH 06/19] qla2xxx: Make debug buffer log easier to view.

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_dbg.c | 33 ++--- > 1 file changed, 14 insertions(+), 19 deletions(-) > Reviewed-by: Hannes Rei

Re: [PATCH 08/19] qla2xxx: Properly reset firmware statistics.

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_attr.c | 28 > drivers/scsi/qla2xxx/qla_bsg.c | 2 +- > drivers/scsi/qla2xxx/qla_dbg.c | 2

Re: [PATCH 07/19] qla2xxx: Properly initialize IO statistics.

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Properly initialize IO statistics to avoid initial 0xFFF (-1) values. > > Cleanup/simplify usage of pointer to statistics structure. > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > driver

Re: [PATCH 09/19] qla2xxx: Check for device state before unloading the driver.

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Sawan Chandak > > During hot swap of PCI device, there can be PCI error on device, > during normal driver unload. The race between normal driver unload and > driver unload due to PCI error, can lead to system crash.Fix is to check > if there

Re: [PATCH 10/19] qla2xxx: Add bsg interface to support D_Port Diagnostics.

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_bsg.c | 44 > drivers/scsi/qla2xxx/qla_bsg.h | 12 + > drivers/scsi/qla2xxx/qla_dbg

Re: [PATCH 11/19] qla2xxx: Add bsg interface to support statistics counter reset.

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Sawan Chandak > > Signed-off-by: Sawan Chandak > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_bsg.c | 48 > ++ > drivers/scsi/qla2xxx/qla_bsg.h | 1 + > 2 files changed, 26 ins

Re: [PATCH 12/19] qla2xxx: Let DPORT be enabled purely by nvram.

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_dbg.c | 2 +- > drivers/scsi/qla2xxx/qla_def.h | 1 + > drivers/scsi/qla2xxx/qla_init.c | 12 ++-- > 3 files cha

Re: [PATCH 13/19] qla2xxx: Add support to handle Loop Init error Asynchronus event.

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_dbg.c | 2 +- > drivers/scsi/qla2xxx/qla_isr.c | 11 +-- > 2 files changed, 10 insertions(+), 3 deletions(-) > Rev

Re: [PATCH 16/19] qla2xxx: Disable the adapter and skip error recovery in case of register disconnect.

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Sawan Chandak > > If there is error recovery going on due to command timeout and > there is register disconnect, then disable the adapter. > > Signed-off-by: Sawan Chandak > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/ql

Re: [PATCH 15/19] qla2xxx: Separate ISP type bits out from device type.

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_def.h | 6 -- > drivers/scsi/qla2xxx/qla_os.c | 44 > +- > 2 files changed, 2

Re: [PATCH 14/19] qla2xxx: Correction to function qla26xx_dport_diagnostics().

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Joe Carnuccio > > Signed-off-by: Joe Carnuccio > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_dbg.c | 2 +- > drivers/scsi/qla2xxx/qla_isr.c | 8 +++- > drivers/scsi/qla2xxx/qla_mbx.c | 5 - > 3 files changed,

Re: [PATCH 17/19] qla2xxx: Fix duplicate message id.

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Sawan Chandak > > Signed-off-by: Sawan Chandak > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_dbg.c | 7 +++ > drivers/scsi/qla2xxx/qla_isr.c | 2 +- > drivers/scsi/qla2xxx/qla_mbx.c | 4 ++-- > 3 files changed, 6

Re: [PATCH 01/21] lpfc: Fix Transgression Flag of Optical Element descriptor for RDP on Linux

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 09:35 PM, James Smart wrote: > > Fix Transgression Flag of Optical Element descriptor for RDP on Linux > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc.h | 12 + > drivers/scsi/lpfc/lpfc_els.c | 101 >

Re: [PATCH 18/19] qla2xxx: Fix BBCR offset

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > From: Sawan Chandak > > Fixes: 969a619 ("qla2xxx: Add support for buffer to buffer credit value for > ISP27XX.") > Signed-off-by: Sawan Chandak > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_fw.h | 2 +- > 1 file changed, 1

Re: [PATCH 19/19] qla2xxx: Update driver version to 8.07.00.38-k

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 05:14 PM, Himanshu Madhani wrote: > Signed-off-by: Himanshu Madhani > Signed-off-by: Giridhar Malavali > --- > drivers/scsi/qla2xxx/qla_version.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla2xxx/qla_version.h > b/drivers/scsi/qla2xxx/q

Re: [PATCH 02/21] lpfc: Correct RDP response sizing issue

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 09:35 PM, James Smart wrote: > > Correct RDP response sizing issue > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_els.c | 113 > --- > drivers/scsi/lpfc/lpfc_hw.h | 26 +++--- > 2 files ch

Re: [PATCH 03/21] lpfc: Add recovery from adapter parity errors on some SLI4 adapters

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 09:35 PM, James Smart wrote: > > Add recovery from adapter parity errors on some SLI4 adapters > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc.h | 2 + > drivers/scsi/lpfc/lpfc_hw4.h | 23 > drivers/scsi/lpfc/lpfc_init

Re: [PATCH 05/21] lpfc: Reject RDP ELS if port has no login

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 09:35 PM, James Smart wrote: > > Reject RDP ELS if port has no login > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_els.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/

Re: [PATCH 04/21] lpfc: Correct Buffer credit descriptor values in RDP response

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 09:35 PM, James Smart wrote: > > Correct Buffer credit descriptor values in RDP response > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_els.c | 74 > +++- > drivers/scsi/lpfc/lpfc_hw.h | 2 +-

Re: [PATCH 06/21] lpfc: Add sysfs proc_name support

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 09:35 PM, James Smart wrote: > > Add sysfs proc_name support > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_scsi.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi

Re: [PATCH 07/21] lpfc: Add MDS Diagnostics Support

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 09:36 PM, James Smart wrote: > > Add MDS Diagnostics Support > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc.h | 4 ++- > drivers/scsi/lpfc/lpfc_attr.c | 10 +++ > drivers/scsi/lpfc/lpfc_els.c | 7 + > drivers/scsi/lpfc/

Re: [PATCH 08/21] lpfc: Fix SLI mode 2 config failure

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 09:36 PM, James Smart wrote: > > Fix SLI mode 2 config failure > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_sli.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c

Re: [PATCH 09/21] lpfc: Correct FCOE discovery to avoid loss of storage devices after system reboot

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 09:36 PM, James Smart wrote: > > Correct FCOE discovery to avoid loss of storage devices after system reboot > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_init.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --gi

Re: [PATCH 10/21] lpfc: Re-organize source for easier device-id management

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 09:36 PM, James Smart wrote: > > Re-organize source for easier device-id management > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_ids.h | 122 > ++ > drivers/scsi/lpfc/lpfc_init.c | 101 +-

Re: [PATCH 11/21] lpfc: Correct RDP response Revision location

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 09:36 PM, James Smart wrote: > > Correct RDP response Revision location > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_hw.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/lpfc/lpfc_hw.h b/drivers

Re: [PATCH 12/21] lpfc: Add support for XLane LUN priority

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 09:36 PM, James Smart wrote: > > Add support for XLane LUN priority > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc.h | 1 + > drivers/scsi/lpfc/lpfc_attr.c | 89 > +-- > drivers/scsi/lpfc/

Re: [PATCH 13/21] lpfc: Correct Port reset resulting in FC port going offline

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 09:36 PM, James Smart wrote: > > Correct Port reset resulting in FC port going offline > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_init.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/lpfc/

Re: [PATCH 14/21] lpfc: Remove global lpfc_enable_npiv attribute in leiu of per-hba lpfc_enable_npiv

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 09:36 PM, James Smart wrote: > > Remove global lpfc_enable_npiv attribute in leiu of per-hba lpfc_enable_npiv lieu > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_attr.c | 8 ++-- > dri

Re: [PATCH 15/21] lpfc: Remove global lpfc_delay_discovery attribute in leiu of per-hba lpfc_delay_discovery

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 09:36 PM, James Smart wrote: > > Remove global lpfc_delay_discovery attribute in leiu of per-hba > lpfc_delay_discovery > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc.h | 1 + > drivers/scsi/lpfc/lpfc_attr.c | 8 +++- > driver

Re: [PATCH 16/21] lpfc: Remove global lpfc_sli_mode attribute in leiu of per-hba lpfc_sli_mode

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 09:36 PM, James Smart wrote: > > Remove global lpfc_sli_mode attribute in leiu of per-hba lpfc_sli_mode > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc.h | 1 + > drivers/scsi/lpfc/lpfc_attr.c | 12 ++-- > drivers/scsi/lpf

Re: [PATCH 17/21] lpfc: Re-organize source for easier driver attribute management

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 09:36 PM, James Smart wrote: > > Re-organize source for easier driver attribute management > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_attr.c | 97 +-- > drivers/scsi/lpfc/lpfc_attr.h | 116 > ++

Re: [PATCH 18/21] lpfc: Correct issue with ioremap() call on 32bit kernel

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 09:36 PM, James Smart wrote: > > Correct issue with ioremap() call on 32bit kernel > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/lpfc/lpfc.

Re: [PATCH 19/21] lpfc: Disable FDMI probing if not connected to a fabric

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 09:36 PM, James Smart wrote: > > Disable FDMI probing if not connected to a fabric > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_ct.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/

Re: [PATCH 20/21] lpfc: Copyright updates

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 09:36 PM, James Smart wrote: > > Copyright updates > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_crtn.h | 2 +- > drivers/scsi/lpfc/lpfc_scsi.c | 2 +- > drivers/scsi/lpfc/lpfc_scsi.h | 2 +- > drivers/scsi/lpfc/lpfc_sli.h | 2 +- >

Re: [PATCH 21/21] lpfc: Update lpfc version to 11.2.0.0

2016-07-15 Thread Hannes Reinecke
On 07/06/2016 09:36 PM, James Smart wrote: > > Update lpfc version to 11.2.0.0 > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_version.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/lpfc/lpfc_version.h > b/d

Re: [patch] ibmvfc: prevent a potential deadlock

2016-07-15 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [net-next 1/6] libcxgb: add library module for Chelsio drivers

2016-07-15 Thread Steve Wise
> Add common library module(libcxgb.ko) for > Chelsio drivers to remove duplicate code. > > Code for iSCSI DDP Page Pod Manager is moved > from cxgb4.ko to libcxgb.ko. Earlier only cxgbit.ko > was using this code, now cxgb3i and cxgb4i will > also use common Page Pod manager code. > > In future t

RE: [net-next 2/6] cxgb3i,cxgb4i,libcxgbi: remove iSCSI DDP support

2016-07-15 Thread Steve Wise
> Remove old ddp code from cxgb3i,cxgb4i,libcxgbi. > > Next two commits adds DDP support using > common iSCSI DDP Page Pod Manager. > > Signed-off-by: Varun Prakash > --- > drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 128 > drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 142 - > drivers/scsi/cx

RE: [net-next 3/6] cxgb4i,libcxgbi: add iSCSI DDP support

2016-07-15 Thread Steve Wise
> Add iSCSI DDP support in cxgb4i driver > using common iSCSI DDP Page Pod Manager. > > Signed-off-by: Varun Prakash > --- > drivers/scsi/cxgbi/Makefile| 2 + > drivers/scsi/cxgbi/cxgb3i/Kbuild | 1 + > drivers/scsi/cxgbi/cxgb3i/Kconfig | 1 + Should the cxgb3i changes be in pat

RE: [net-next 4/6] cxgb3i: add iSCSI DDP support

2016-07-15 Thread Steve Wise
> Add iSCSI DDP support in cxgb3i driver > using common iSCSI DDP Page Pod Manager. > > Signed-off-by: Varun Prakash Looks ok. Reviewed-by: Steve Wise -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo

RE: [net-next 5/6] libcxgb: export ppm release and tagmask set api

2016-07-15 Thread Steve Wise
> Export cxgbi_ppm_release() to release > ppod manager and cxgbi_tagmask_set() to > set tag mask, they are used by cxgb3i, cxgb4i > and cxgbit. > > Signed-off-by: Varun Prakash Looks good. Reviewd-by: Steve Wise -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the

RE: [net-next 6/6] cxgb3i,cxgb4i: fix symbol not declared sparse warning

2016-07-15 Thread Steve Wise
> > Fix following sparse warnings > warning: symbol 'cxgb3i_ofld_init' was not declared. Should it be static? > warning: symbol 'cxgb4i_cplhandlers' was not declared. Should it be static? > warning: symbol 'cxgb4i_ofld_init' was not declared. Should it be static? > > Signed-off-by: Varun Prakash

Re: [patch] ibmvfc: prevent a potential deadlock

2016-07-15 Thread Ewan D. Milne
On Fri, 2016-07-15 at 14:18 +0300, Dan Carpenter wrote: > My static checker complains that we need to unlock on this path. Seems > true. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c > index fc523c3..ab67ec4 100644 > --- a/driv

Re: [PATCH] qla2xxx: setup data needed in ISR before setting up the ISR

2016-07-15 Thread Martin K. Petersen
> "Johannes" == Johannes Thumshirn writes: Johannes> qla2xxx first calls request_irq() and then does the setup of Johannes> the queue entry data needed in the interrupt handlers in when Johannes> using MSI-X. Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering --

Re: PR API fixes for multipathing

2016-07-15 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> I was a bit overeager to thing ALL_TG_PT would solve all our Christoph> multipathing woes in respect to persistent reservation. Christoph> Turns out that there are lots of possible setups where it Christoph> doesn't work, and we'll have to

Re: [PATCH] mpt3sas: Fix panic when aer correct error occured

2016-07-15 Thread Martin K. Petersen
> "Kefeng" == Kefeng Wang writes: Kefeng> The _scsih_pci_mmio_enabled called if scsih_pci_error_detected Kefeng> returns PCI_ERS_RESULT_CAN_RECOVER, at this point, read/write to Kefeng> the device still works, no need to reset slot. Applied to 4.8/scsi-queue. -- Martin K. Petersen Ora

Re: [PATCH 1/1] scsi: ufs: tc-dwc-g210 driver fix for 20-bit RMMI

2016-07-15 Thread Martin K. Petersen
> "Manjunath" == Manjunath M B writes: Manjunath> The code was checking on PA_CONNECTEDRXLANES and Manjunath> PA_CONNECTEDTXLANES attributes to program the Lane#1 Manjunath> attributes. The correct attributes are PA_AVAILRXDATALANES Manjunath> and PA_AVAILTXDATALANES respectively. Applied to

Re: [PATCH] scsi: remove the disable_blk_mq host flag

2016-07-15 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> We've had scsi-mq for 2.5 years now, so we can remove the Christoph> unused flag to disable the code on a per-host basis that was Christoph> put in for unexpected emergencies during bringup. Applied to 4.8/scsi-queue. -- Martin K. Peter

Re: [PATCH] usb: MAINTAINERS: Oliver Neukum is the new uas maintainer

2016-07-15 Thread Martin K. Petersen
> "Hans" == Hans de Goede writes: Hans> Oliver Neukum is taking over uas maintainership from me and Gerd Hans> Hoffmann. Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a

Re: [PATCH 1/2] scsi: lpfc: avoid harmless comparison warning

2016-07-15 Thread James Smart
Patch is good. Thanks -- james Signed-off-by: James Smart On 6/15/2016 1:42 PM, Arnd Bergmann wrote: When building with -Wextra, we get a lot of warnings for the lpfc driver concerning expressions that are always true, starting with: drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_enable_

Re: [patch] ibmvfc: prevent a potential deadlock

2016-07-15 Thread Martin K. Petersen
> "Dan" == Dan Carpenter writes: Dan> My static checker complains that we need to unlock on this path. Dan> Seems true. Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a m

Re: [PATCH 00/21] lpfc: Update to revision 11.2.0.0

2016-07-15 Thread Martin K. Petersen
> "James" == James Smart writes: James> This patch set updates the lpfc driver to revision 11.2.0.00 Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...

Re: [PATCH 00/19] qla2xxx: Patches for scsi "misc" branch.

2016-07-15 Thread Martin K. Petersen
> "Himanshu" == Himanshu Madhani writes: Himanshu> Please apply the following patches to the scsi tree, misc Himanshu> branch at your earliest convenience. Applied to 4.8/scsi-queue. I folded the compiler fix into the offending commit. -- Martin K. Petersen Oracle Linux Engineering --

Re: [PATCH 0/2] hpsa update

2016-07-15 Thread Martin K. Petersen
> "Don" == Don Brace writes: Don> These patches are based on Linus's tree The changes are: - enhanced Don> check for skipping masked devices - corrected hpsa_passthru_ioctl Don> timeouts for fw flash Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsub

Re: [PATCH] scsi: ufs: remove unnecessary goto label

2016-07-15 Thread Martin K. Petersen
> "Tiezhu" == Tiezhu Yang writes: Tiezhu> When buff_ascii kmalloc failed, there is no need to call kfree, Tiezhu> it should return -ENOMEM directly, this patch fixes it. Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send th

[PATCH 1/1] ipr: Wait to do async scan until scsi host is initialized

2016-07-15 Thread Brian King
When performing an async scan, make sure the kthread doing scanning doesn't start before the scsi host is fully initialized. Signed-off-by: Brian King --- drivers/scsi/ipr.c |9 + drivers/scsi/ipr.h |1 + 2 files changed, 10 insertions(+) diff -puN drivers/scsi/ipr.c~ipr_async

[BUG] Slab corruption during XFS writeback under memory pressure

2016-07-15 Thread Calvin Owens
Hello all, I've found a nasty source of slab corruption. Based on seeing similar symptoms on boxes at Facebook, I suspect it's been around since at least 3.10. It only reproduces under memory pressure so far as I can tell: the issue seems to be that XFS reclaims pages from buffers that are still

Re: PR API fixes for multipathing

2016-07-15 Thread Christoph Hellwig
On Fri, Jul 15, 2016 at 03:03:54PM -0400, Martin K. Petersen wrote: > > "Christoph" == Christoph Hellwig writes: > > Christoph> I was a bit overeager to thing ALL_TG_PT would solve all our > Christoph> multipathing woes in respect to persistent reservation. > Christoph> Turns out that there a