[PATCH] cxl: remove dead Kconfig options

2016-07-04 Thread Andrew Donnellan
Remove the CXL_KERNEL_API and CXL_EEH Kconfig options, as they were only needed to coordinate the merging of the cxlflash driver. Also remove the stub implementation of cxl_perst_reloads_same_image() in cxlflash which is only used if CXL_EEH isn't defined (i.e. never). Suggested-by: Ian Munsie Si

how to test pscsi with vhost

2016-07-04 Thread Zhangfei Gao
I am testing with pscsi, but fail to find any block device under /dev to mount. The scsi_probe_lun seems can not return correctly, scsi scan: INQUIRY failes. Is this usage correct? /backstores/pscsi> create name=pscsi_backend dev=/dev/sdb Note: block backstore recommended for SCSI block devices C

Re: [PATCH v2] scsi/fcoe: convert to kworker

2016-07-04 Thread Sebastian Andrzej Siewior
On 06/10/2016 12:38 PM, Johannes Thumshirn wrote: … > > Tested in a Boot from FCoE scenario using a BCM57840. This got merged over the weekend. Thanks for that. I will try to look into the other two (bnx2i, bnx2fc) and convert them as well within this week. Sebastian -- To unsubscribe from this

[PATCH 0/6] fcoe: VN2VN target mode fixes

2016-07-04 Thread Hannes Reinecke
Hi all, When setting up a VN2VN FCoE target there is no real need to run fcoeadm, especially if DCB is disabled. So this patchset implements a VIP VLAN responder which can be enabled by writing to the sysfs attribute 'fip_vlan_responder'. Additionally there are some fixes for VN2VN mode, most nota

[PATCH 6/6] fcoe: Use default VLAN for FIP VLAN discovery

2016-07-04 Thread Hannes Reinecke
FC-BB-6 states: FIP protocols shall be performed on a per-VLAN basis. It is recommended to use the FIP VLAN discovery protocol on the default VLAN. Signed-off-by: Hannes Reinecke --- drivers/scsi/fcoe/fcoe.c | 49 +++- drivers/scsi/fcoe/fcoe.h | 1 +

[PATCH 2/6] fcoe: use enum for fip_mode

2016-07-04 Thread Hannes Reinecke
The FIP mode is independent on the FIP state machine, so use a separate enum for that instead of overloading it with state machine values. Signed-off-by: Hannes Reinecke --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 6 +++--- drivers/scsi/fcoe/fcoe.c | 6 +++--- drivers/scsi/fcoe/fcoe_ctlr.

[PATCH 1/6] fc_fip: Update to latest FC-BB-6 draft

2016-07-04 Thread Hannes Reinecke
Update to latest FC-BB-6 draft to include FIP VN2VN VLAN notifications and additional flags. Signed-off-by: Hannes Reinecke --- drivers/scsi/fcoe/fcoe_ctlr.c | 8 drivers/scsi/fnic/fnic_fcs.c | 4 ++-- drivers/scsi/fnic/fnic_fip.h | 8 include/scsi/fc/fc_fip.h | 21 ++

[PATCH 3/6] fcoe: fcoe->realdev is always set

2016-07-04 Thread Hannes Reinecke
'->realdev' is always set, so this check is pointless. Signed-off-by: Hannes Reinecke --- drivers/scsi/fcoe/fcoe.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c index 9c3742d..41c67e5 100644 --- a/drivers/scsi/fcoe/fcoe.c +++ b/drivers/

[PATCH 5/6] fcoe: implement FIP VLAN responder

2016-07-04 Thread Hannes Reinecke
When running in VN2VN mode there is no central instance which would send out any FIP VLAN discovery notifications. So this patch adds a new sysfs attribute 'fip_vlan_responder' which will activate a FIP VLAN discovery responder. Signed-off-by: Hannes Reinecke --- drivers/scsi/fcoe/fcoe.c |

[PATCH 4/6] fcoe: Update multicast addresses on FIP mode change

2016-07-04 Thread Hannes Reinecke
When the FIP mode is changed we need to update the multicast addresses to ensure we get the correct frames. Signed-off-by: Hannes Reinecke --- drivers/scsi/fcoe/fcoe.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe.c b/

Re: [PATCH 5/6] fcoe: implement FIP VLAN responder

2016-07-04 Thread Johannes Thumshirn
On Mon, Jul 04, 2016 at 10:29:22AM +0200, Hannes Reinecke wrote: > When running in VN2VN mode there is no central instance which > would send out any FIP VLAN discovery notifications. So this > patch adds a new sysfs attribute 'fip_vlan_responder' which > will activate a FIP VLAN discovery responde

Re: [PATCH 1/6] fc_fip: Update to latest FC-BB-6 draft

2016-07-04 Thread Johannes Thumshirn
On Mon, Jul 04, 2016 at 10:29:18AM +0200, Hannes Reinecke wrote: > Update to latest FC-BB-6 draft to include FIP VN2VN VLAN notifications > and additional flags. > > Signed-off-by: Hannes Reinecke Acked-by: Johannes Thumshirn -- Johannes Thumshirn Stor

Re: [PATCH 2/6] fcoe: use enum for fip_mode

2016-07-04 Thread Johannes Thumshirn
On Mon, Jul 04, 2016 at 10:29:19AM +0200, Hannes Reinecke wrote: > The FIP mode is independent on the FIP state machine, so use a > separate enum for that instead of overloading it with state > machine values. > > Signed-off-by: Hannes Reinecke Acked-by: Johannes Thumshirn -- Johannes Thumshi

Re: [PATCH 3/6] fcoe: fcoe->realdev is always set

2016-07-04 Thread Johannes Thumshirn
On Mon, Jul 04, 2016 at 10:29:20AM +0200, Hannes Reinecke wrote: > '->realdev' is always set, so this check is pointless. > > Signed-off-by: Hannes Reinecke Acked-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH 4/6] fcoe: Update multicast addresses on FIP mode change

2016-07-04 Thread Johannes Thumshirn
On Mon, Jul 04, 2016 at 10:29:21AM +0200, Hannes Reinecke wrote: > When the FIP mode is changed we need to update the multicast > addresses to ensure we get the correct frames. > > Signed-off-by: Hannes Reinecke Acked-by: Johannes Thumshirn -- Johannes Thumshirn

Re: [PATCH 6/6] fcoe: Use default VLAN for FIP VLAN discovery

2016-07-04 Thread Johannes Thumshirn
On Mon, Jul 04, 2016 at 10:29:23AM +0200, Hannes Reinecke wrote: > FC-BB-6 states: > FIP protocols shall be performed on a per-VLAN basis. It is > recommended to use the FIP VLAN discovery protocol on the > default VLAN. > > Signed-off-by: Hannes Reinecke Given the removal of the duplicate fip_f

Re: [PATCH 5/6] fcoe: implement FIP VLAN responder

2016-07-04 Thread Hannes Reinecke
On 07/04/2016 12:05 PM, Johannes Thumshirn wrote: > On Mon, Jul 04, 2016 at 10:29:22AM +0200, Hannes Reinecke wrote: >> When running in VN2VN mode there is no central instance which >> would send out any FIP VLAN discovery notifications. So this >> patch adds a new sysfs attribute 'fip_vlan_respond

Re: [PATCH] cxl: remove dead Kconfig options

2016-07-04 Thread Ian Munsie
Acked-by: Ian Munsie -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: how to test pscsi with vhost

2016-07-04 Thread Zhu Lingshan
Hi Zhangfei, I am also interested in pscsi, you can try kvm, seems you can create a virtualized pscsi device in kvm / virt-manager. I haven't tried that yet, hope this can help. Thanks, BR Zhu Lingshan 在 2016/7/4 15:32, Zhangfei Gao 写道: I am testing with pscsi, but fail to find any block dev

[PATCH] scsi: bnx2i: convert to kworker

2016-07-04 Thread Sebastian Andrzej Siewior
The driver creates its own per-CPU threads which are updated based on CPU hotplug events. It is also possible to use kworkers and remove some of the infrastructure get the same job done while saving a few lines of code. The DECLARE_PER_CPU() definition is moved into the header file where it belong

Re: [PATCH 1/6] lib: string: add function strtolower()

2016-07-04 Thread Markus Mayer
On 1 July 2016 at 14:08, Rasmus Villemoes wrote: > A few suggestions: > > - Make the function take separate src and dst parameters, making it explicitly > allowed to pass the same value (but not other kinds of overlap, of > course). That way one can avoid "strcpy(dst, src); strtolower(dst);".

[PATCH 2/2] libata-scsi: do not response with "invalid field" for FORMAT UNIT

2016-07-04 Thread tom . ty89
From: Tom Yan It does not make sense and is confusing to response with "Invalid field in cbd" while we have no support at all implemented for FORMAT UNIT. It is decent to let it go to the default, which will response with "Invalid command operation code" instead. Signed-off-by: Tom Yan diff --

[PATCH 1/2] libata-scsi: improve TRIM translation

2016-07-04 Thread tom . ty89
From: Tom Yan Define TRIM_RANGE_SIZE and TRIM_RANGE_NUM so that the corresponding functions can be more generalized. Also, conform SBC by rejecting WRITE SAME (16) commands with number of blocks that exceeds the limit that is defined in the SATL. Signed-off-by: Tom Yan diff --git a/drivers/ata

Re: [PATCH 1/2] libata-scsi: improve TRIM translation

2016-07-04 Thread Sergei Shtylyov
On 07/04/2016 11:53 PM, tom.t...@gmail.com wrote: From: Tom Yan Define TRIM_RANGE_SIZE and TRIM_RANGE_NUM so that the corresponding functions can be more generalized. Also, conform SBC by rejecting Conform to SBC, perhaps? WRITE SAME (16) commands with number of blocks that exceeds the

Re: [PATCH 2/2] libata-scsi: do not response with "invalid field" for FORMAT UNIT

2016-07-04 Thread Sergei Shtylyov
On 07/04/2016 11:53 PM, tom.t...@gmail.com wrote: From: Tom Yan It does not make sense and is confusing to response with "Invalid Respond here and in the subject. field in cbd" while we have no support at all implemented for FORMAT UNIT. It is decent to let it go to the default, which w

Re: [PATCH 2/2] libata-scsi: do not response with "invalid field" for FORMAT UNIT

2016-07-04 Thread Sergei Shtylyov
On 07/05/2016 12:27 AM, Sergei Shtylyov wrote: From: Tom Yan It does not make sense and is confusing to response with "Invalid Respond here and in the subject. field in cbd" while we have no support at all implemented for CDB. FORMAT UNIT. It is decent to let it go to the default

[PATCH v2 2/2] libata-scsi: do not respond with "invalid field" for FORMAT UNIT

2016-07-04 Thread tom . ty89
From: Tom Yan It does not make sense and is confusing to respond with "Invalid field in CDB" while we have no support at all implemented for FORMAT UNIT. It is decent to let it go to the default, which will respond with "Invalid command operation code" instead. Signed-off-by: Tom Yan diff --gi

[PATCH v2 1/2] libata-scsi: improve TRIM translation

2016-07-04 Thread tom . ty89
From: Tom Yan Define TRIM_RANGE_SIZE and TRIM_RANGE_NUM so that the corresponding functions can be more generalized. Also, conform to SBC by rejecting WRITE SAME (16) commands with number of blocks that exceeds the limit that is defined in the SATL. Signed-off-by: Tom Yan diff --git a/drivers/