Re: [PATCH 6/6] mpt3sas: Used "synchronize_irq()"API to synchronize timed-out IO & TMs

2016-05-10 Thread Tomas Henzl
On 6.5.2016 10:59, Chaitra P B wrote: > Replaced mpt3sas_base_flush_reply_queues()with > mpt3sas_base_sync_reply_irqs(),as mpt3sas_base_flush_reply_queues() > skips over reply queues that are currently busy (i.e. being handled > by interrupt processing in another core). If a reply queue is busy, >

Application error handling with write-back caching

2016-05-10 Thread Stefan Hajnoczi
SBC-3 4.15.3 Write caching says: "If processing a write command results in logical block data in cache that is different from the logical block data on the medium, then the device server shall retain that logical block data in cache until a write medium operation is performed using that logical bl

Re: Application error handling with write-back caching

2016-05-10 Thread James Bottomley
On Tue, 2016-05-10 at 14:47 +0100, Stefan Hajnoczi wrote: > SBC-3 4.15.3 Write caching says: > > "If processing a write command results in logical block data in cache > that is different from the logical block data on the medium, then the > device server shall retain that logical block data in cac

Re: [PATCHv2]sd: Don't treat succeeded SYNC as error

2016-05-10 Thread Jinpu Wang
On Mon, May 9, 2016 at 6:41 PM, Jinpu Wang wrote: > On Wed, May 4, 2016 at 7:02 PM, Jinpu Wang > wrote: >> On Mon, May 2, 2016 at 3:44 PM, James Bottomley >> wrote: >>> On Mon, 2016-05-02 at 12:05 +0200, Hannes Reinecke wrote: On 04/29/2016 02:49 PM, Jinpu Wang wrote: > Hi, all

Re: [PATCHv2]sd: Don't treat succeeded SYNC as error

2016-05-10 Thread James Bottomley
On Tue, 2016-05-10 at 16:48 +0200, Jinpu Wang wrote: > On Mon, May 9, 2016 at 6:41 PM, Jinpu Wang < > jinpu.w...@profitbricks.com> wrote: > > On Wed, May 4, 2016 at 7:02 PM, Jinpu Wang < > > jinpu.w...@profitbricks.com> wrote: > > > On Mon, May 2, 2016 at 3:44 PM, James Bottomley < > > > j...@linux

Re: [PATCHv2]sd: Don't treat succeeded SYNC as error

2016-05-10 Thread Jinpu Wang
On Tue, May 10, 2016 at 5:08 PM, James Bottomley wrote: > On Tue, 2016-05-10 at 16:48 +0200, Jinpu Wang wrote: >> On Mon, May 9, 2016 at 6:41 PM, Jinpu Wang < >> jinpu.w...@profitbricks.com> wrote: >> > On Wed, May 4, 2016 at 7:02 PM, Jinpu Wang < >> > jinpu.w...@profitbricks.com> wrote: >> > > On

Re: [PATCHv2]sd: Don't treat succeeded SYNC as error

2016-05-10 Thread James Bottomley
On Tue, 2016-05-10 at 17:46 +0200, Jinpu Wang wrote: > On Tue, May 10, 2016 at 5:08 PM, James Bottomley > wrote: [...] > > Actually, I think this is symptomatic of a much bigger problem. > > Now that the FS can send zero length non BLOCK_PC request, we're > > not treating failure correctly. bl

Re: Application error handling with write-back caching

2016-05-10 Thread Paolo Bonzini
On 10/05/2016 16:16, James Bottomley wrote: > > If "is performed" just means "completes", maybe with an error, the > > application would have to resubmit write requests and then try to > > flush the write cache again. > > > > I'm not aware of applications that keep acknowledged write data > >

Re: Application error handling with write-back caching

2016-05-10 Thread James Bottomley
On Tue, 2016-05-10 at 18:42 +0200, Paolo Bonzini wrote: > > On 10/05/2016 16:16, James Bottomley wrote: > > > If "is performed" just means "completes", maybe with an error, > > > the application would have to resubmit write requests and then > > > try to flush the write cache again. > > > > > >

Re: [PATCH] libfc: replace 'rp_mutex' with 'rp_lock'

2016-05-10 Thread Bart Van Assche
On 04/25/2016 01:01 AM, Hannes Reinecke wrote: We cannot use an embedded mutex in a structure with reference counting, as mutex unlock might be delayed, and the waiters might then access an already freed memory area. So convert it to a spinlock. > > For details cf https://lkml.org/lkml/2015/2/11

Re: [PATCHv2] scsi_lib: Decode T-10 vendor IDs

2016-05-10 Thread Bart Van Assche
On 05/09/2016 12:14 AM, Hannes Reinecke wrote: Some arrays / HBAs will only present T-10 vendor IDs, so we should be decoding them, too. Suggested-by: Paul Mackerras Tested-by: Paul Mackerras Signed-off-by: Hannes Reinecke Reviewed-by: Bart Van Assche -- To unsubscribe from this list: send

Re: Application error handling with write-back caching

2016-05-10 Thread Paolo Bonzini
On 10/05/2016 19:31, James Bottomley wrote: > > What about a SPACE ALLOCATION FAILED error or a similar error that > > can be fixed by administrator actions (or just by a concurrent > > process doing an UNMAP)? Would a subsequent cache flush cause data > > loss? > > You're now asking about how

Re: [PATCH] scsi_dh_alua: do not fail for unknown VPD identification

2016-05-10 Thread Bart Van Assche
On 05/06/2016 01:34 AM, Hannes Reinecke wrote: Not every device will return a useable VPD identification, but still might support ALUA. Rather then disable ALUA support we should be allowing the device identification to be empty and attach individual ALUA device handler to each devices. Reported

Re: [PATCH v3 0/6] scsi_debug: multiple queue support and cleanup

2016-05-10 Thread Martin K. Petersen
> "Douglas" == Douglas Gilbert writes: Douglas> Changes since v2.5 - rework the 'add multiple queue support' Douglas> patch based on reviewers' comments to more closely follow the Douglas> scsi/block mq template Applied the remaining patches in your series to 4.7/scsi-queue. Thanks! -- Ma

Re: [PATCH] scsi_dh_alua: do not fail for unknown VPD identification

2016-05-10 Thread Martin K. Petersen
> "Hannes" == Hannes Reinecke writes: Hannes> Not every device will return a useable VPD identification, but Hannes> still might support ALUA. Rather then disable ALUA support we Hannes> should be allowing the device identification to be empty and Hannes> attach individual ALUA device handler

Re: [PATCHv2] scsi_lib: Decode T-10 vendor IDs

2016-05-10 Thread Martin K. Petersen
> "Hannes" == Hannes Reinecke writes: Hannes> Some arrays / HBAs will only present T-10 vendor IDs, so we Hannes> should be decoding them, too. Applied to 4.7/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-

Re: [PATCH] libfc: replace 'rp_mutex' with 'rp_lock'

2016-05-10 Thread Martin K. Petersen
> "Bart" == Bart Van Assche writes: Bart> Is what you describe a theoretical concern or have you observed Bart> any issues that could have been caused by the rport mutex? I believe Ewan had some data. Ewan? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this lis

Re: [PATCH] hpsa: Fix type ZBC conditional checks

2016-05-10 Thread Martin K. Petersen
> "Petros" == Petros Koutoupis writes: Petros> The device ID obtained from the inquiry can only be of a single Petros> type. The original code places a check for TYPE_ZBC right after Petros> the check for TYPE_DISK. Logically, if the first if statement Petros> sees a device of a TYPE_DISK an

Re: [patch] [SCSI] eata_pio: missing break statement

2016-05-10 Thread Martin K. Petersen
> "Dan" == Dan Carpenter writes: Dan> This missing break statement bug predates git. It's a very minor Dan> thing, it means that we print a '?' instead of a 'z' in dmesg. Applied to 4.7/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send

Re: [PATCH 6/6] mpt3sas: Used "synchronize_irq()"API to synchronize timed-out IO & TMs

2016-05-10 Thread Sreekanth Reddy
On Tue, May 10, 2016 at 6:41 PM, Tomas Henzl wrote: > On 6.5.2016 10:59, Chaitra P B wrote: >> Replaced mpt3sas_base_flush_reply_queues()with >> mpt3sas_base_sync_reply_irqs(),as mpt3sas_base_flush_reply_queues() >> skips over reply queues that are currently busy (i.e. being handled >> by interrup

Re: [PATCH] libfc: replace 'rp_mutex' with 'rp_lock'

2016-05-10 Thread Hannes Reinecke
On 05/10/2016 08:33 PM, Bart Van Assche wrote: > On 04/25/2016 01:01 AM, Hannes Reinecke wrote: >> We cannot use an embedded mutex in a structure with reference >> counting, as mutex unlock might be delayed, and the waiters >> might then access an already freed memory area. >> So convert it to a sp

Re: [PATCH] libfc: replace 'rp_mutex' with 'rp_lock'

2016-05-10 Thread Hannes Reinecke
On 05/11/2016 07:49 AM, Hannes Reinecke wrote: > On 05/10/2016 08:33 PM, Bart Van Assche wrote: >> On 04/25/2016 01:01 AM, Hannes Reinecke wrote: >>> We cannot use an embedded mutex in a structure with reference >>> counting, as mutex unlock might be delayed, and the waiters >>> might then access a

Re: [PATCHv2]sd: Don't treat succeeded SYNC as error

2016-05-10 Thread Hannes Reinecke
On 05/10/2016 05:08 PM, James Bottomley wrote: > On Tue, 2016-05-10 at 16:48 +0200, Jinpu Wang wrote: >> On Mon, May 9, 2016 at 6:41 PM, Jinpu Wang < >> jinpu.w...@profitbricks.com> wrote: >>> On Wed, May 4, 2016 at 7:02 PM, Jinpu Wang < >>> jinpu.w...@profitbricks.com> wrote: On Mon, May 2, 2

Re: [PATCHv2]sd: Don't treat succeeded SYNC as error

2016-05-10 Thread James Bottomley
On Wed, 2016-05-11 at 08:21 +0200, Hannes Reinecke wrote: > On 05/10/2016 05:08 PM, James Bottomley wrote: > > On Tue, 2016-05-10 at 16:48 +0200, Jinpu Wang wrote: > > > On Mon, May 9, 2016 at 6:41 PM, Jinpu Wang < > > > jinpu.w...@profitbricks.com> wrote: > > > > On Wed, May 4, 2016 at 7:02 PM, Ji