On 05/03/2016 04:33 PM, Florian Westphal wrote:
> Replace all trans_start updates with netif_trans_update helper.
> change was done via spatch:
>
> struct net_device *d;
> @@
> - d->trans_start = jiffies
> + netif_trans_update(d)
>
> Compile tested only.
>
> Cc: user-mode-linux-de...@lists.sourc
Some arrays / HBAs will only present T-10 vendor IDs, so we
should be decoding them, too.
Suggested-by: Paul Mackerras
Tested-by: Paul Mackerras
Signed-off-by: Hannes Reinecke
---
drivers/scsi/scsi_lib.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/scsi/scsi_li
Smatch doesn't quite catch it because we check "cmd_fusion->scmd" for
NULL then assign "scmd_local = cmd_fusion->scmd;" and dereference
scmd_local unconditionally...
It does catch part of the bug if you have cross function analysis:
drivers/scsi/megaraid/megaraid_sas_fusion.c:2318 complete_cmd_
I've updated Smatch to catch these and I'm testing it now. We'll see
how it goes. If my quick and dirty method doesn't has too many false
positives then it's will take some months before I get around to doing
it properly...
Thanks for notifying me on this.
regards,
dan carpenter
--
To unsubscr
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Monday, May 09, 2016 1:36 PM
> To: Finn Thain
> Cc: Petros Koutoupis; kashyap.de...@avagotech.com;
> sumit.sax...@avagotech.com; uday.ling...@avagotech.com;
> megaraidlinux@avagotech.com; linux-scsi@vge
On Mon, Apr 25, 2016 at 10:01:33AM +0200, Hannes Reinecke wrote:
> We cannot use an embedded mutex in a structure with reference
> counting, as mutex unlock might be delayed, and the waiters
> might then access an already freed memory area.
> So convert it to a spinlock.
>
> For details cf https:/
On 05/05/2016 04:40 PM, Joe Lawrence wrote:
> On 05/05/2016 03:58 PM, Bart Van Assche wrote:
>> On 03/28/2016 02:29 PM, Bart Van Assche wrote:
>>> Avoid that the sd driver registers a BDI device with a name that
>>> is still in use. This patch avoids that the following warning gets
>>> triggered:
>
- Original Message -
> From: "Laurence Oberman"
> To: "Nicholas A. Bellinger"
> Cc: "Himanshu Madhani" , "Bart Van Assche"
> , "linux-scsi"
> , "target-devel" ,
> "Quinn Tran"
> Sent: Monday, April 4, 2016 6:50:03 PM
> Subject: Re: [PATCH] tcm_qla2xxx Add SCSI command jammer/discard
On 05/05/2016 09:40 PM, Douglas Gilbert wrote:
static bool stop_queued_cmnd(struct scsi_cmnd *cmnd)
{
unsigned long iflags;
- int k, qmax, r_qmax;
+ int j, k, qmax, r_qmax;
+ struct sdebug_queue *sqp;
struct sdebug_queued_cmd *sqcp;
struct sdebug_dev_
Mike Snitzer redhat.com> writes:
> I developed these changes some weeks ago but have since focused on
> regression and performance testing on larger NUMA systems.
Hello Mike,
Sorry that I do yet have any performance numbers available for the SRP
protocol for this patch series. But I want to let
On Fri, May 06, 2016 at 01:05:36PM +0200, Hannes Reinecke wrote:
> On 04/25/2016 10:16 PM, Tejun Heo wrote:
> > Hello,
> >
> > On Mon, Apr 25, 2016 at 12:45:42PM +0200, Hannes Reinecke wrote:
> >> here's a patchset implementing ZAC support for libata.
> >>
> >> This is the second part of a larger
On Wed, May 4, 2016 at 7:02 PM, Jinpu Wang wrote:
> On Mon, May 2, 2016 at 3:44 PM, James Bottomley
> wrote:
>> On Mon, 2016-05-02 at 12:05 +0200, Hannes Reinecke wrote:
>>> On 04/29/2016 02:49 PM, Jinpu Wang wrote:
>>> > Hi, all
>>> >
>>> > We hit IO error on fsync, it turns out was because sd
On 5/9/16, 7:56 AM, "Laurence Oberman" wrote:
>
>
>- Original Message -
>> From: "Laurence Oberman"
>> To: "Nicholas A. Bellinger"
>> Cc: "Himanshu Madhani" , "Bart Van Assche"
>> , "linux-scsi"
>> , "target-devel" ,
>> "Quinn Tran"
>> Sent: Monday, April 4, 2016 6:50:03 PM
>> Subj
The device ID obtained from the inquiry can only be of a single type.
The original code places a check for TYPE_ZBC right after the check
for TYPE_DISK. Logically, if the first if statement sees a device of
a TYPE_DISK and moves on to the second statement checking if not
TYPE_ZBC, it will always hi
I'm confused what you are saying. According to Petros, these bugs are
causing failures in real life, I was only added to the CC list because
Smatch should have warned about them.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a mess
On Mon, 2016-05-09 at 15:18 +0530, Sumit Saxena wrote:
> >
> > -Original Message-
> > From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> > Sent: Monday, May 09, 2016 1:36 PM
> > To: Finn Thain
> > Cc: Petros Koutoupis; kashyap.de...@avagotech.com;
> > sumit.sax...@avagotech.com; uday.
On 2016-05-09 06:12 PM, Bart Van Assche wrote:
On 05/05/2016 09:40 PM, Douglas Gilbert wrote:
static bool stop_queued_cmnd(struct scsi_cmnd *cmnd)
{
unsigned long iflags;
-int k, qmax, r_qmax;
+int j, k, qmax, r_qmax;
+struct sdebug_queue *sqp;
struct sdebug_queued_cm
On 05/09/2016 03:30 PM, Douglas Gilbert wrote:> The maximum return value
from the first scnprintf(sdebug_info ...)
is (sizeof(sdebug_info) - 1)). So strictly speaking the early return
comparison should be "==" for scnprintf and ">=" for snprintf. Given
that snprintf is more dangerous then scnprin
> "Anil" == Anil Gurumurthy writes:
Anil> Apologies for the delay. Patch looks good. Acked by: Anil
Anil> Gurumurthy
Applied to 4.7/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a me
19 matches
Mail list logo
