UFS patchset

2016-04-29 Thread Joao Pinto
Hi Martin, Could you please give me feedback about the UFS patch-set? The patches have been acked by various developers, so maybe could it be possible to put it into the 4.7 queue? Patch-set Cover Letter: http://www.spinics.net/lists/linux-scsi/msg95664.html Thank you, Joao -- To unsubscribe fro

Re: UFS patchset

2016-04-29 Thread Martin K. Petersen
> "Joao" == Joao Pinto writes: Joao, Joao> Could you please give me feedback about the UFS patch-set? The Joao> patches have been acked by various developers, so maybe could it Joao> be possible to put it into the 4.7 queue? It is on my list. I think we are OK from a SCSI perspective but

Re: UFS patchset

2016-04-29 Thread Joao Pinto
On 4/29/2016 1:19 PM, Martin K. Petersen wrote: >> "Joao" == Joao Pinto writes: > > Joao, > > Joao> Could you please give me feedback about the UFS patch-set? The > Joao> patches have been acked by various developers, so maybe could it > Joao> be possible to put it into the 4.7 queue? > >

[PATCHv2]sd: Don't treat succeeded SYNC as error

2016-04-29 Thread Jinpu Wang
Hi, all We hit IO error on fsync, it turns out was because sd treat succeeded SYNC as error. From what I checked in SBC spec there is no indication we should fail IO in this case, so we create this patch. Best Regards, Jack Wang v2: No change on patch itself, only resend in body as suggested b

Re: [dm-devel] Notes from the four separate IO track sessions at LSF/MM

2016-04-29 Thread Benjamin Marzinski
On Wed, Apr 27, 2016 at 04:39:49PM -0700, James Bottomley wrote: > Multipath - Mike Snitzer > > > Mike began with a request for feedback, which quickly lead to the > complaint that recovery time (and how you recover) was one of the > biggest issues in device mapper multipa

RE: [PATCH] mptsas: fix checks for dma mapping errors

2016-04-29 Thread Sathya Prakash Veerichetty
Please consider this patch as Ack-by: Sathya Prakash Veerichetty PS: We don't have test environment to test this patch as this is for an old controller. So ACKing based on code review and similar mpt3sas driver code. -Original Message- From: Martin K. Petersen [mailto:martin.peter...@ora

Re: [dm-devel] [Lsf] Notes from the four separate IO track sessions at LSF/MM

2016-04-29 Thread Laurence Oberman
Hello Bart I will email the entire log just to you. This is a summary only below of pertinent log messages. I dont think the whole list will have an interest in all thge log messages. When I sent the dull log to you I will include SCSI debug for the error handler stuff. I ran the tests. This i

Re: [dm-devel] [Lsf] Notes from the four separate IO track sessions at LSF/MM

2016-04-29 Thread Laurence Oberman
One small correction In the cut and past the mpath timing was this. I had a cut and past error in my prior message. Fri Apr 29 17:16:14 EDT 2016 mpathe (360014052a6f5f9f256d4c1097eedfd95) dm-2 LIO-ORG ,block-13 size=20G features='1 queue_if_no_path' hwhandler='0' wp=rw `-+- policy='service-time

Re: [PATCH 0/7] hpsa driver updates

2016-04-29 Thread Martin K. Petersen
> "Don" == Don Brace writes: Don> These patches are based on Linus's tree The changes are: - move Don> call to scsi_scan_host below where interrupts are enabled - add in Don> timouts for driver initiated commands. - some faulty disks caused Don> initialization hangs. - correct ioaccel chang

Re: [PATCH 00/10] aacraid: Patchset for aacraid driver version 41066

2016-04-29 Thread Martin K. Petersen
> "Raghava" == Raghava Aditya Renukunta > writes: Raghava> This patchset contains the following changes(bug fixes, Raghava> features and code refactors) specific to the aacraid driver Applied to 4.7/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from

Re: [PATCH 00/12] scsi_debug: multiple queue support and cleanup

2016-04-29 Thread Martin K. Petersen
> "Doug" == Douglas Gilbert writes: Doug> Primary reason for this patch series is to add multi queue support Doug> modelled on the null_blk driver. Ignore host_lock option but keep Doug> parameter for backward compatibility. Use high resolution timers Doug> to implement both the jiffy and nan

Re: UFS patchset

2016-04-29 Thread Martin K. Petersen
> "Joao" == Joao Pinto writes: Joao, >> It is on my list. Joao> Ok, great! In a previous email you said you had sent v14 to linux-scsi. However, I don't see neither v14, nor v13 in patchworks. The latest I have is v12 and it does not apply to 4.7/scsi-queue. -- Martin K. Petersen Or

Re: UFS patchset

2016-04-29 Thread Martin K. Petersen
> "Martin" == Martin K Petersen writes: Joao, Martin> In a previous email you said you had sent v14 to Martin> linux-scsi. However, I don't see neither v14, nor v13 in Martin> patchworks. The latest I have is v12 and it does not apply to Martin> 4.7/scsi-queue. I found v14 in my mailbox. No

Re: [PATCH v5] qla1280: Don't allocate 512kb of host tags

2016-04-29 Thread Martin K. Petersen
> "Johannes" == Johannes Thumshirn writes: Johannes> The qla1280 driver sets the scsi_host_template's can_queue Johannes> field to 0xf which results in an allocation failure when Johannes> allocating the block layer tags for the driver's queues. This Johannes> was introduced with the chan

Re: [dm-devel] [Lsf] Notes from the four separate IO track sessions at LSF/MM

2016-04-29 Thread Bart Van Assche
On 04/29/2016 02:47 PM, Laurence Oberman wrote: Recovery with 21 LUNS is 300s that have in-flights to abort. [ ... ] eh_deadline is set to 10 on the 2 qlogic ports, eh_timeout is set > to 10 for all devices. In multipath fast_io_fail_tmo=5 I jam one of the target array ports and discard the co

Re: [dm-devel] [Lsf] Notes from the four separate IO track sessions at LSF/MM

2016-04-29 Thread Laurence Oberman
Hello Bart Around 300s before the paths were declared hard failed and the devices offlined. This is when I/O restarts. The remaining paths on the second Qlogic port (that are not jammed) will not be used until the error handler activity completes. Until we get these for example, and device-mappe

[PATCH v2 00/12] scsi_debug: multiple queue support and cleanup

2016-04-29 Thread Douglas Gilbert
Changes since original version: - reduce resp_report_luns to reporting 256 LUNs (0 to 255) using address_method=0 which is single level peripheral device addressing method. Reviewer would like further address_methods support which will be presented as a separate patch - various

[PATCH v2 03/12] scsi_debug: replace jiffy timers with hr timers

2016-04-29 Thread Douglas Gilbert
The driver supports two command delay interfaces, the original one whose unit is a jiffy, and a newer one whose unit is a nanosecond. Each had different implementations. Keep both interfaces but simplify the implemenation to use a single delay mechanism based on high resolution timers. Signed-off-

[PATCH v2 05/12] scsi_debug: replace tasklet with work queue

2016-04-29 Thread Douglas Gilbert
When a negative value was placed in the delay parameter, a tasklet was scheduled. Change the tasklet to a work queue. Previously a delay of -1 scheduled a high priority tasklet; since there are no high priority work queues, treat -1 like other negative values in delay and schedule a work item. Sig

[PATCH v2 02/12] scsi_debug: ignore host lock option

2016-04-29 Thread Douglas Gilbert
Remove logic to optionally hold host_lock while each command is queued. Keep module and sysfs host_lock parameters for backward compatibility. Note in module parameter description that host_lock is ignored. Signed-off-by: Douglas Gilbert --- drivers/scsi/scsi_debug.c | 44 +++

[PATCH v2 04/12] scsi_debug: make jiffy delay name clearer

2016-04-29 Thread Douglas Gilbert
Add 'j' to delay names to make it clearer that its unit is jiffies and to differentiate it from sdebug_ndelay whose unit is nanoseconds. Signed-off-by: Douglas Gilbert --- drivers/scsi/scsi_debug.c | 46 +++--- 1 file changed, 23 insertions(+), 23 deletion

[PATCH v2 06/12] scsi_debug: re-order file scope declarations

2016-04-29 Thread Douglas Gilbert
Group most defines together first; followed by struct definitions and then table and variable definitions. Normalize all function headers. Replace dummy DEV_READONLY(tgt) macro with comment. Signed-off-by: Douglas Gilbert --- drivers/scsi/scsi_debug.c | 316 ++

[PATCH v2 10/12] scsi_debug: vpd and mode page work

2016-04-29 Thread Douglas Gilbert
Cleanup some mode and vpd pages. Stop reporting SBC (disk) pages when peripheral type is something else (e.g. tape). Update version descriptors. Expand LBPRZ flag handling. Signed-off-by: Douglas Gilbert --- drivers/scsi/scsi_debug.c | 187 ++ 1 file c

[PATCH v2 01/12] scsi_debug: cleanup naming and bit crunching

2016-04-29 Thread Douglas Gilbert
Shorten file scope static and constant names. Use more get/put_unaligned calls to hide bit banging. Introduce sdebug_verbose boolean to replace frequent masking of option bit flags. Add GPL and bump version. Signed-off-by: Douglas Gilbert --- drivers/scsi/scsi_debug.c | 1187

[PATCH v2 09/12] scsi_debug: add multiple queue support

2016-04-29 Thread Douglas Gilbert
Add submit_queue parameter (minimum and default: 1; maximum: nr_cpu_ids) that controls how many queues are built, each with their own lock and in_use bit vector. Add statistics parameter which is default on. Signed-off-by: Douglas Gilbert --- drivers/scsi/scsi_debug.c | 680 +

[PATCH v2 11/12] scsi_debug: uuid for lu name

2016-04-29 Thread Douglas Gilbert
Permit changing of a LU name from a (fake) IEEE registered NAA (5) to a locally assigned UUID. Using a UUID (RFC 4122) for a SCSI designation descriptor (e.g. a LU name) was added in spc5r08.pdf (a draft INCITS standard) on 25 January 2016. Add parameter uuid_ctl to use a separate UUID for each LU

[PATCH v2 12/12] scsi_debug: use locally assigned naa

2016-04-29 Thread Douglas Gilbert
For reported SAS addresses replace fake IEEE registered NAAs (5) with locally assigned NAAs (3). Signed-off-by: Douglas Gilbert --- drivers/scsi/scsi_debug.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/drivers/scsi/scsi_debug.c b/driv

[PATCH v2 07/12] scsi_debug: use likely hints on fast path

2016-04-29 Thread Douglas Gilbert
The most common commands in normal use are the READ and WRITE SCSI commands. Use likely and unlikely hints along the path taken by these commands. Rename check_readiness() to make_ua() and remove associated dead code. Rework devInfoReg() to find_build_dev_info() and resolve the trivial case at poin

[PATCH v2 08/12] scsi_debug: rework resp_report_luns

2016-04-29 Thread Douglas Gilbert
Based on "[PATH V2] scsi_debug: rework resp_report_luns" patch sent by Tomas Winkler on Thursday, 26 Feb 2015. His notes: 1. Remove duplicated boundary checks which simplify the fill-in loop 2. Use more of scsi generic API Replace fixed length response array a with heap allocation allowing

Re: [PATCH 00/12] scsi_debug: multiple queue support and cleanup

2016-04-29 Thread Douglas Gilbert
On 2016-04-29 07:53 PM, Martin K. Petersen wrote: "Doug" == Douglas Gilbert writes: Doug> Primary reason for this patch series is to add multi queue support Doug> modelled on the null_blk driver. Ignore host_lock option but keep Doug> parameter for backward compatibility. Use high resolution t