Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id

2016-03-09 Thread Johannes Thumshirn
On Fri, Feb 12, 2016 at 09:38:53AM -0800, Lee Duncan wrote: > The scsi_transport_iscsi module already uses the ida_simple > routines for managing the target ID, if requested to do > so. This change replaces an ever-increasing atomic integer > that tracks the session ID itself with the ida_simple >

Re: [BUG] "block: make generic_make_request handle arbitrarily sized bios" breaks boot on parisc-linux

2016-03-09 Thread James Bottomley
On Thu, 2016-02-25 at 11:38 +0800, Ming Lei wrote: > On Thu, Feb 25, 2016 at 7:28 AM, John David Anglin < > dave.ang...@bell.net> wrote: > > On 2016-02-24, at 4:36 PM, Helge Deller wrote: > > > > > Maybe Dave has more luck, otherwise I'll continue to try to get > > > some info. > > > > I tried yo

[PATCH 4/4] brd: thin provisioning support

2016-03-09 Thread Hannes Reinecke
Implement module parameter 'rd_mem_size' to restrict the overall allocated memory size and 'rd_lowat_thresh' to add a low water mark signalling. Signed-off-by: Hannes Reinecke --- drivers/block/brd.c | 53 + 1 file changed, 53 insertions(+) di

[PATCH 3/4] dm-thin: enable low water mark disk event

2016-03-09 Thread Hannes Reinecke
Enable sending of a 'low water mark' disk event and add supporting infrastructure to the DM core. Signed-off-by: Hannes Reinecke --- drivers/md/dm-thin.c | 2 ++ drivers/md/dm.c | 27 +++ drivers/md/dm.h | 3 ++- 3 files changed, 31 insertions(+), 1 deletion(-

[PATCH 1/4] scsi,block: enable disk event forwarding

2016-03-09 Thread Hannes Reinecke
Some SCSI events relate to block events (eg media change), so this patch implements a forwarding mechanism for SCSI events to the corresponding block event. It redefines the currently unused 'supported_events' bitmap to signal which SCSI events should be forwarded to block events. Signed-off-by: H

[RFC PATCH 0/4] Low water mark disk events

2016-03-09 Thread Hannes Reinecke
Hi all, here is a patchset to implement 'low water mark' disk events. This event corresponds to a TP Soft Threshold Reached UA for SCSI or a 'low watermark' event for dm-thin. It utilises the existing 'disk event' infrastructure from the blocklayer to send out the events via udev. And it also clea

[PATCH 2/4] block,scsi: Low water mark disk event

2016-03-09 Thread Hannes Reinecke
Add a disk event for a 'low water mark' condition, signalling when a device is about to run out of space. This event is mapped to a Thin Provisioning Soft Threshold Reached UA. Signed-off-by: Hannes Reinecke --- block/genhd.c | 2 ++ drivers/scsi/scsi_lib.c | 10 +- drivers/sc

PROBLEM: cdrom.c : cdrom_get_last_written() yields up to 3 different values

2016-03-09 Thread Thomas Schmitt
cdrom.c : cdrom_get_last_written() yields up to 3 different values -- Full description of the problem: Depending on the capabilities of the optical drive involved, the function cdrom_get_last_written() can yield up to 3 different

Re: [PATCH resend 2/2] mpt3sas: Remove unnecessary synchronize_irq() before free_irq()

2016-03-09 Thread Sreekanth Reddy
On Wed, Mar 9, 2016 at 7:22 AM, Martin K. Petersen wrote: >> "Lars-Peter" == Lars-Peter Clausen writes: > > Lars-Peter> Calling synchronize_irq() right before free_irq() is quite > Lars-Peter> useless. On one hand the IRQ can easily fire again before > Lars-Peter> free_irq() is entered, on th

[PATCH v5] scsi: ufs: add ioctl interface for query request

2016-03-09 Thread Yaniv Gardi
This patch exposes the ioctl interface for UFS driver via SCSI device ioctl interface. As of now UFS driver would provide the ioctl for query interface to connected UFS device. Reviewed-by: Subhash Jadavani Signed-off-by: Dolev Raviv Signed-off-by: Gilad Broner Signed-off-by: Yaniv Gardi ---

[PATCH v6] scsi: ufs: add ioctl interface for query request

2016-03-09 Thread Yaniv Gardi
This patch exposes the ioctl interface for UFS driver via SCSI device ioctl interface. As of now UFS driver would provide the ioctl for query interface to connected UFS device. Reviewed-by: Arnd Bergmann Reviewed-by: Subhash Jadavani Signed-off-by: Dolev Raviv Signed-off-by: Noa Rubens Signed-

[PATCH v7] scsi: ufs: add ioctl interface for query request

2016-03-09 Thread Yaniv Gardi
This patch exposes the ioctl interface for UFS driver via SCSI device ioctl interface. As of now UFS driver would provide the ioctl for query interface to connected UFS device. Reviewed-by: Subhash Jadavani Signed-off-by: Dolev Raviv Signed-off-by: Gilad Broner Signed-off-by: Yaniv Gardi ---

Re: [BUG] "block: make generic_make_request handle arbitrarily sized bios" breaks boot on parisc-linux

2016-03-09 Thread Ming Lei
On Wed, Mar 9, 2016 at 8:55 PM, James Bottomley wrote: > On Thu, 2016-02-25 at 11:38 +0800, Ming Lei wrote: >> On Thu, Feb 25, 2016 at 7:28 AM, John David Anglin < >> dave.ang...@bell.net> wrote: >> > On 2016-02-24, at 4:36 PM, Helge Deller wrote: >> > >> > > Maybe Dave has more luck, otherwise I'

我的个人主页是

2016-03-09 Thread 我的个人主页是
你的老朋友邀你来Q群:343257759

Re: [BUG] "block: make generic_make_request handle arbitrarily sized bios" breaks boot on parisc-linux

2016-03-09 Thread John David Anglin
On 2016-03-09 9:43 AM, Ming Lei wrote: We've provided all the information you asked for, what's the next step >on this, or do we have to unwind the bio splitting code with reverts >until it starts working? John, Helge, and I did discuss the problem for a while privately, and looks it is related

Re: [BUG] "block: make generic_make_request handle arbitrarily sized bios" breaks boot on parisc-linux

2016-03-09 Thread Ming Lei
On Wed, Mar 9, 2016 at 11:15 PM, John David Anglin wrote: > On 2016-03-09 9:43 AM, Ming Lei wrote: >>> >>> We've provided all the information you asked for, what's the next step >>> >on this, or do we have to unwind the bio splitting code with reverts >>> >until it starts working? >> >> John, Helg

Re: [PATCH] sg: fix dxferp in from_to case

2016-03-09 Thread Ewan Milne
On Thu, 2016-03-03 at 00:31 -0500, Douglas Gilbert wrote: > This patch is in response to this report: > http://www.spinics.net/lists/linux-scsi/msg93456.html > > One of the strange things that the original sg driver did was let > the user provide both a data-out buffer (it followed the > sg_he

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

2016-03-09 Thread Greg KH
On Wed, Mar 09, 2016 at 04:11:33PM +0200, Yaniv Gardi wrote: > This patch exposes the ioctl interface for UFS driver via SCSI device > ioctl interface. As of now UFS driver would provide the ioctl for query > interface to connected UFS device. > > Reviewed-by: Subhash Jadavani > Signed-off-by: Do

"scsi: use host wide tags by default" causes uas regression

2016-03-09 Thread Hans de Goede
Hi Christoph, I've received a bug report that uas is causing a 2-disk enclosure to lookup with 4.4 and later: https://bugzilla.redhat.com/show_bug.cgi?id=1315013 Looking at the dmesg this stands out: Mar 09 01:55:21 larry kernel: sd 2:0:0:1: [sdc] tag#31 uas_eh_abort_handler 0 uas-tag 32 infl

Re: "scsi: use host wide tags by default" causes uas regression

2016-03-09 Thread Christoph Hellwig
On Wed, Mar 09, 2016 at 06:58:48PM +0100, Hans de Goede wrote: > So my question is how do I tell the scsi layer to not submit more then X > commands with > scsi_init_shared_tag_map() gone ? By setting ->can_queue in the Scsi_Host structure to the maximum number of command you want outstanding for

Re: "scsi: use host wide tags by default" causes uas regression

2016-03-09 Thread Hans de Goede
Hi, On 09-03-16 19:26, Christoph Hellwig wrote: On Wed, Mar 09, 2016 at 06:58:48PM +0100, Hans de Goede wrote: So my question is how do I tell the scsi layer to not submit more then X commands with scsi_init_shared_tag_map() gone ? By setting ->can_queue in the Scsi_Host structure to the max

Re: "scsi: use host wide tags by default" causes uas regression

2016-03-09 Thread Christoph Hellwig
On Wed, Mar 09, 2016 at 07:28:06PM +0100, Hans de Goede wrote: > >By setting ->can_queue in the Scsi_Host structure to the maximum number > >of command you want outstanding for this host. > > Can I lower this after calling scsi_host_alloc(), or do I need to make > my template "dynamic" ? You don'

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

2016-03-09 Thread ygardi
> On Wed, Mar 09, 2016 at 04:11:33PM +0200, Yaniv Gardi wrote: >> This patch exposes the ioctl interface for UFS driver via SCSI device >> ioctl interface. As of now UFS driver would provide the ioctl for query >> interface to connected UFS device. >> >> Reviewed-by: Subhash Jadavani >> Signed-off

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

2016-03-09 Thread ygardi
> On Wed, Mar 09, 2016 at 04:11:33PM +0200, Yaniv Gardi wrote: >> This patch exposes the ioctl interface for UFS driver via SCSI device >> ioctl interface. As of now UFS driver would provide the ioctl for query >> interface to connected UFS device. >> >> Reviewed-by: Subhash Jadavani >> Signed-off

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

2016-03-09 Thread Greg KH
On Wed, Mar 09, 2016 at 07:09:49PM -, yga...@codeaurora.org wrote: > > On Wed, Mar 09, 2016 at 04:11:33PM +0200, Yaniv Gardi wrote: > >> This patch exposes the ioctl interface for UFS driver via SCSI device > >> ioctl interface. As of now UFS driver would provide the ioctl for query > >> interf

Re: [PATCH] mvsas:Fix possible NULL pointer deference in mvs_dev_found_notify

2016-03-09 Thread Dāvis Mosāns
2016-03-09 15:58 GMT+02:00 Nicholas Krause : > This adds properly checking after the call to mvs_find_dev_mvi > due to this function being able to return a NULL pointer and if > this does arise we will deference it in mvs_alloc_dev due to > this function never checking if a NULL pointer is given as

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

2016-03-09 Thread ygardi
> On Wed, Mar 09, 2016 at 07:09:49PM -, yga...@codeaurora.org wrote: >> > On Wed, Mar 09, 2016 at 04:11:33PM +0200, Yaniv Gardi wrote: >> >> This patch exposes the ioctl interface for UFS driver via SCSI device >> >> ioctl interface. As of now UFS driver would provide the ioctl for >> query >>

Re: [BUG] "block: make generic_make_request handle arbitrarily sized bios" breaks boot on parisc-linux

2016-03-09 Thread Helge Deller
On 09.03.2016 16:15, John David Anglin wrote: > On 2016-03-09 9:43 AM, Ming Lei wrote: >>> We've provided all the information you asked for, what's the next step >>> >on this, or do we have to unwind the bio splitting code with reverts >>> >until it starts working? >> John, Helge, and I did discuss

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

2016-03-09 Thread Greg KH
On Wed, Mar 09, 2016 at 08:52:59PM -, yga...@codeaurora.org wrote: > > On Wed, Mar 09, 2016 at 07:09:49PM -, yga...@codeaurora.org wrote: > >> > On Wed, Mar 09, 2016 at 04:11:33PM +0200, Yaniv Gardi wrote: > >> >> This patch exposes the ioctl interface for UFS driver via SCSI device > >> >>

Re: [BUG] "block: make generic_make_request handle arbitrarily sized bios" breaks boot on parisc-linux

2016-03-09 Thread James Bottomley
On Wed, 2016-03-09 at 22:20 +0100, Helge Deller wrote: > On 09.03.2016 16:15, John David Anglin wrote: > > On 2016-03-09 9:43 AM, Ming Lei wrote: > > > > We've provided all the information you asked for, what's the > > > > next step > > > > > on this, or do we have to unwind the bio splitting code

Re: [PATCH] mvsas:Fix possible NULL pointer deference in mvs_dev_found_notify

2016-03-09 Thread Valdis . Kletnieks
On Wed, 09 Mar 2016 22:33:47 +0200, Dāvis Mosāns said: > About whether mvs_find_dev_mvi can return NULL it looks like it's possible, > but I'm not sure if it practically happens. I guess it did hence patch. Or the "bug" was found by incorrect code inspection. Nick has a history of submitting p

Re: [PATCH] sg: fix dxferp in from_to case

2016-03-09 Thread Martin K. Petersen
> "Doug" == Douglas Gilbert writes: Doug> Make sure that a user space pointer is passed through when data Doug> follows the sg_header structure and command. Fix the abnormal Doug> case when a non-zero reply_len is also given. Applied to 4.5/scsi-fixes. -- Martin K. Petersen Oracle Li

Re: [PATCH resend 2/2] mpt3sas: Remove unnecessary synchronize_irq() before free_irq()

2016-03-09 Thread Martin K. Petersen
> "Lars-Peter" == Lars-Peter Clausen writes: Lars-Peter> Calling synchronize_irq() right before free_irq() is quite Lars-Peter> useless. On one hand the IRQ can easily fire again before Lars-Peter> free_irq() is entered, on the other hand free_irq() itself Lars-Peter> calls synchronize_irq()

Re: [PATCH v7 06/17] scsi: ufs: separate device and host quirks

2016-03-09 Thread Martin K. Petersen
> "Yaniv" == Yaniv Gardi writes: Yaniv> Currently we use the host quirks mechanism in order to handle Yaniv> both device and host controller quirks. In order to support Yaniv> various of UFS devices we should separate handling the device Yaniv> quirks from the host controller's. This patch

Re: [PATCH 1/1] sd: do not let LBPME bit stop the VPDs speak

2016-03-09 Thread Martin K. Petersen
> "Tom" == tom ty89 writes: Tom, Tom> Some devices have details of their support on unmapping on the Tom> Block Limits and/or Logical Block Provisioning VPDs while they do Tom> not set the LBPME bit to 1. Though this is required by the SCSI Tom> standards, the VPDs are giving even more concr

Re: [PATCH 1/1] sd: do not let LBPME bit stop the VPDs speak

2016-03-09 Thread Martin K. Petersen
> "Tom" == Tom Yan writes: Tom> Btw, why SD_MAX_WS16_BLOCKS (which is used for both SD_LBP_WS16 and Tom> SD_LBP_UNMAP) is set to 0x7f (23-bit) instead of 0x Tom> (32-bit, 4-byte)? This limit represents the largest block range we can describe using a single bio. -- Martin K. Pet

Re: [BUG] "block: make generic_make_request handle arbitrarily sized bios" breaks boot on parisc-linux

2016-03-09 Thread Rolf Eike Beer
> Right. > I just succeeded in reproducing the bug with moving blk_bio_segment_split() > into an own file (and with "extern" instead of "static" in blk-merge.c). > When compiled with -O2 it still crashes. So, next step is to analyze what > gcc does wrong when compiling this function. It should get