Re: [PATCH 08/14] scsi: mvumi: use __maybe_unused to hide pm functions

2016-03-03 Thread Johannes Thumshirn
On Wed, Mar 02, 2016 at 04:59:00PM +0100, Arnd Bergmann wrote: > The mvumi scsi hides the references to its suspend/resume functions > in an #ifdef but does not hide the implementation the same way: > > drivers/scsi/mvumi.c:2632:12: error: 'mvumi_suspend' defined but not used > [-Werror=unused-fu

Re: [PATCHv2] scsi_sysfs: add 'is_bin_visible' callback

2016-03-03 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv2 1/6] scsi: Add 'access_state' and 'preferred_path' attribute

2016-03-03 Thread Johannes Thumshirn
On Thu, Mar 03, 2016 at 07:54:07AM +0100, Hannes Reinecke wrote: > Add an 'access_state' field to struct scsi_device > and display them in sysfs as 'access_state' and > 'preferred_path' attribute. > > Reviewed-by: Christoph Hellwig > Signed-off-by: Hannes Reinecke Reviewed-by: Johannes Thumshir

Re: [PATCHv2 2/6] scsi_dh_alua: use common definitions for ALUA state

2016-03-03 Thread Johannes Thumshirn
On Thu, Mar 03, 2016 at 07:54:08AM +0100, Hannes Reinecke wrote: > scsi_proto.h now contains definitions for the ALUA state, > so we don't have to carry them in the device handler. > > Reviewed-by: Bart van Assche > Reviewed-by: Christoph Hellwig > Signed-off-by: Hannes Reinecke Reviewed-by: J

Re: [PATCHv2 3/6] scsi_dh_alua: update 'access_state' field

2016-03-03 Thread Johannes Thumshirn
On Thu, Mar 03, 2016 at 07:54:09AM +0100, Hannes Reinecke wrote: > Track attached SCSI devices and update the 'access_state' field > whenever an ALUA state change has been detected. > > Reviewed-by: Bart Van Assche > Reviewed-by: Ewan Milne > Reviewed-by: Christoph Hellwig > Signed-off-by: Hann

Re: [PATCHv2 4/6] scsi_dh_rdac: update 'access_state' field

2016-03-03 Thread Johannes Thumshirn
On Thu, Mar 03, 2016 at 07:54:10AM +0100, Hannes Reinecke wrote: > Track attached SCSI devices and update the 'access_state' > whenever the path state of the device changes. > > Reviewed-by: Christoph Hellwig > Signed-off-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn -- Johannes Thumsh

Re: [PATCHv2 6/6] scsi_sysfs: call 'device_add' after attaching device handler

2016-03-03 Thread Johannes Thumshirn
On Thu, Mar 03, 2016 at 07:54:12AM +0100, Hannes Reinecke wrote: > 'device_add' will be evaluating the 'is_visible' callback > when creating the sysfs attributes. As by this time the > device handler has not been attached the 'access_state' > attribute will never be visible. > > This patch moves t

Re: [PATCHv2 5/6] scsi_dh_emc: update 'access_state' field

2016-03-03 Thread Johannes Thumshirn
On Thu, Mar 03, 2016 at 07:54:11AM +0100, Hannes Reinecke wrote: > Update the 'access_state' field of the SCSI device whenever > the path state changes. > > Reviewed-by: Christoph Hellwig > Signed-off-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn

Re: [PATCH v5 03/15] scsi: ufs: implement scsi host timeout handler

2016-03-03 Thread ygardi
> On 03/01/2016 09:25 PM, yga...@codeaurora.org wrote: >>> On 02/28/2016 09:32 PM, Yaniv Gardi wrote: A race condition exists between request requeueing and scsi layer error handling: When UFS driver queuecommand returns a busy status for a request, it will be requeued and its t

Re: [PATCH v9 3/3] add support for DWC UFS Host Controller

2016-03-03 Thread Joao Pinto
Hi Arnd, On 3/2/2016 7:55 PM, Arnd Bergmann wrote: > On Wednesday 02 March 2016 16:46:47 Joao Pinto wrote: >> On 2/19/2016 3:03 PM, Arnd Bergmann wrote: >>> On Thursday 18 February 2016 17:20:27 Joao Pinto wrote: Facts: - Test Chip type are currently not detectable in runtime through the control

Re: [PATCH v9 3/3] add support for DWC UFS Host Controller

2016-03-03 Thread Arnd Bergmann
On Thursday 03 March 2016 11:39:05 Joao Pinto wrote: > Hi Arnd, > > On 3/2/2016 7:55 PM, Arnd Bergmann wrote: > > On Wednesday 02 March 2016 16:46:47 Joao Pinto wrote: > >> On 2/19/2016 3:03 PM, Arnd Bergmann wrote: > >>> On Thursday 18 February 2016 17:20:27 Joao Pinto wrote: > > Facts: > > - T

Re: [PATCH v5 03/15] scsi: ufs: implement scsi host timeout handler

2016-03-03 Thread Hannes Reinecke
On 03/03/2016 05:10 PM, yga...@codeaurora.org wrote: >> On 03/01/2016 09:25 PM, yga...@codeaurora.org wrote: On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > A race condition exists between request requeueing and scsi layer > error handling: > When UFS driver queuecommand returns a bus

[PATCH] mvumi: fix build warning

2016-03-03 Thread Sudip Mukherjee
While building tilepro allmodconfig we were getting build warning: drivers/scsi/mvumi.c:2632:12: warning: 'mvumi_suspend' defined but not used drivers/scsi/mvumi.c:2651:12: warning: 'mvumi_resume' defined but not used mvumi_suspend() and mvumi_resume() are only used when CONFIG_PM is defined as me

Re: [PATCH] mvumi: fix build warning

2016-03-03 Thread Johannes Thumshirn
On Thu, Mar 03, 2016 at 06:36:53PM +0530, Sudip Mukherjee wrote: > While building tilepro allmodconfig we were getting build warning: > drivers/scsi/mvumi.c:2632:12: warning: 'mvumi_suspend' defined but not used > drivers/scsi/mvumi.c:2651:12: warning: 'mvumi_resume' defined but not used > > mvumi

Re: [patch] tcm_loop: use after free on error

2016-03-03 Thread Tomas Henzl
On 2.3.2016 11:09, Dan Carpenter wrote: > We dereference "tl_nexus" to get the error code. > > Fixes: 1b418a8fcbc0 ('target: Convert demo-mode only drivers to > target_alloc_session') > Signed-off-by: Dan Carpenter Reviewed-by: Tomas Henzl -- To unsubscribe from this list: send the line "unsub

Re: [PATCH v9 3/3] add support for DWC UFS Host Controller

2016-03-03 Thread Joao Pinto
Hi, On 3/3/2016 12:04 PM, Arnd Bergmann wrote: > On Thursday 03 March 2016 11:39:05 Joao Pinto wrote: >> Hi Arnd, >> >> On 3/2/2016 7:55 PM, Arnd Bergmann wrote: >>> On Wednesday 02 March 2016 16:46:47 Joao Pinto wrote: On 2/19/2016 3:03 PM, Arnd Bergmann wrote: > On Thursday 18 February

Re: [PATCH v9 3/3] add support for DWC UFS Host Controller

2016-03-03 Thread Arnd Bergmann
On Thursday 03 March 2016 13:52:39 Joao Pinto wrote: > > config SCSI_UFS_DWC > bool > > config SCSI_UFS_DWC_TC_PLATFORM > tristate "DesignWare platform support using a G210 Test Chip" > depends on SCSI_UFSHCD_PLATFORM > select SCSI_UFS_DWC > ---help--- >

Re: [PATCH v9 3/3] add support for DWC UFS Host Controller

2016-03-03 Thread Joao Pinto
On 3/3/2016 2:12 PM, Arnd Bergmann wrote: > On Thursday 03 March 2016 13:52:39 Joao Pinto wrote: >> >> config SCSI_UFS_DWC >> bool >> >> config SCSI_UFS_DWC_TC_PLATFORM >> tristate "DesignWare platform support using a G210 Test Chip" >> depends on SCSI_UFSHCD_PLATFORM >>

Re: [PATCH v5 01/15] scsi: ufs-qcom: add number of lanes per direction

2016-03-03 Thread Rob Herring
On Sun, Feb 28, 2016 at 03:32:33PM +0200, Yaniv Gardi wrote: > Different platform may have different number of lanes > for the UFS link. > Add parameter to device tree specifying how many lanes > should be configured for the UFS link. > > Signed-off-by: Gilad Broner > Signed-off-by: Yaniv Gardi

Re: [PATCHv2 1/6] scsi: Add 'access_state' and 'preferred_path' attribute

2016-03-03 Thread Bart Van Assche
On 03/02/2016 10:54 PM, Hannes Reinecke wrote: Add an 'access_state' field to struct scsi_device and display them in sysfs as 'access_state' and 'preferred_path' attribute. Reviewed-by: Bart van Assche -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a me

Re: Page allocation failure (order 7) in UAS code

2016-03-03 Thread Yves-Alexis Perez
On mar., 2016-03-01 at 11:49 +0100, Hans de Goede wrote: > Hi, > > On 01-03-16 10:42, Yves-Alexis Perez wrote: > > > > Hi, > > > > [sorry if this is not the right point for reporting bugs, I took the email > > addresses from MAINTAINERS but please point me to the correct place if > > needed] > >

Re: Page allocation failure (order 7) in UAS code

2016-03-03 Thread Hans de Goede
Hi, On 04-03-16 08:13, Yves-Alexis Perez wrote: On mar., 2016-03-01 at 11:49 +0100, Hans de Goede wrote: Hi, On 01-03-16 10:42, Yves-Alexis Perez wrote: Hi, [sorry if this is not the right point for reporting bugs, I took the email addresses from MAINTAINERS but please point me to the corre