Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete

2016-02-29 Thread Mika Westerberg
On Sat, Feb 27, 2016 at 01:07:06AM -0800, dbasehore . wrote: > That's an interesting question. Part of direct complete is to leave > the device runtime suspended even after the system resumes if > possible. The comments in pm_complete_with_resume_check indicate that > the firmware may resume a devi

[PATCH] target/cxgbit: add INET dependency

2016-02-29 Thread Arnd Bergmann
The newly added cxgbit driver directly calls functions of the IPv4 network stack, which fails if that is disabled: ERROR: "ip_route_output_flow" [drivers/target/iscsi/cxgbit/cxgbit.ko] undefined! ERROR: "__ip_dev_find" [drivers/target/iscsi/cxgbit/cxgbit.ko] undefined! This adds a Kconfig depende

small diff in reported GiB size of an SSD

2016-02-29 Thread Toralf Förster
I'm just curious about this diff in dmesg output between 4.3.2 and 4.3.3 at a 64 bit Gentoo hardened system: $ diff dmesg-4.4.[23]-hardened | grep logical < sd 0:0:0:0: [sda] 468862128 512-byte logical blocks: (240 GB/223 GiB) > sd 0:0:0:0: [sda] 468862128 512-byte logical blocks: (240 GB/224 GiB

Re: [Lsf-pc] [LSF/MM ATTEND] Online Logical Head Depop and SMR disks chunked writepages

2016-02-29 Thread Jan Kara
On Mon 29-02-16 02:02:16, Damien Le Moal wrote: > > >On Wed 24-02-16 01:53:24, Damien Le Moal wrote: > >> > >> >On Tue 23-02-16 05:31:13, Damien Le Moal wrote: > >> >> > >> >> >On 02/22/16 18:56, Damien Le Moal wrote: > >> >> >> 2) Write back of dirty pages to SMR block devices: > >> >> >> > >>

Re: small diff in reported GiB size of an SSD

2016-02-29 Thread James Bottomley
On Mon, 2016-02-29 at 13:31 +, Toralf Förster wrote: > I'm just curious about this diff in dmesg output between 4.3.2 and > 4.3.3 at a 64 bit Gentoo hardened system: > > $ diff dmesg-4.4.[23]-hardened | grep logical > < sd 0:0:0:0: [sda] 468862128 512-byte logical blocks: (240 GB/223 > GiB) >

Re: small diff in reported GiB size of an SSD

2016-02-29 Thread Toralf Förster
James Bottomley: > On Mon, 2016-02-29 at 13:31 +, Toralf Förster wrote: > commit 564b026fbd0d28e9f70fb3831293d2922bb7855b > Author: James Bottomley > Date: Wed Jan 20 14:58:29 2016 -0800 > > string_helpers: fix precision loss for some inputs > > James > > cool - thx -- Toralf PGP

Re: [PATCH 00/35 v4] separate operations from flags in the bio/request structs

2016-02-29 Thread Christoph Hellwig
Any reason you've dropped my ACK for the previous version? Jens, is this something you're fine with? Would be great to figure out a way to get this into 4.6. There's probably going to be plenty of conflicts, so having some sort of stable base tree would be nice.. (Talking about conflicts, seems

Re: [PATCH 00/35 v4] separate operations from flags in the bio/request structs

2016-02-29 Thread Mike Christie
On 02/29/2016 11:13 AM, Christoph Hellwig wrote: > Any reason you've dropped my ACK for the previous version? Sorry. I think I accidentally dropped it when I rebased back over to linux-next. It looks like it only got stuck on the first patch. I will fix that up on the resend for those kbuild error

[PATCH] fcoe: fix reset of fip selection time.

2016-02-29 Thread Usha Ketineni
Do not reset fip selection time for every advertisement in fcoe_ctlr_recv_adv() but set it only once for the first validated FCF. Otherwise FCF selection won't happen when the advertisements consistently arrive with sub FCOE_CTLR_START_DELAY periodicity. Tested-by: Narendra K Acked-by: Neil Horma

Re: [PATCHv2] iscsi_ibft: Add prefix-len attr and display netmask

2016-02-29 Thread Mike Christie
On 02/25/2016 12:15 PM, Lee Duncan wrote: > From: Hannes Reinecke > > The iBFT table only specifies a prefix length, not a netmask. > And the netmask is pretty much pointless for IPv6. > So introduce a new attribute 'prefix-len' and display the > netmask attribute only for IPv4 addresses. The co

Re: [Open-FCoE] [PATCH] fcoe: fix reset of fip selection time.

2016-02-29 Thread Neil Horman
On Mon, Feb 29, 2016 at 03:36:52AM -0800, Usha Ketineni wrote: > Do not reset fip selection time for every advertisement > in fcoe_ctlr_recv_adv() but set it only once for the first > validated FCF. Otherwise FCF selection won't happen when the > advertisements consistently arrive with sub FCOE_CTL

Re: [PATCHv2] iscsi_ibft: Add prefix-len attr and display netmask

2016-02-29 Thread Konrad Rzeszutek Wilk
On Mon, Feb 29, 2016 at 1:45 PM, Mike Christie wrote: > On 02/25/2016 12:15 PM, Lee Duncan wrote: >> From: Hannes Reinecke >> >> The iBFT table only specifies a prefix length, not a netmask. >> And the netmask is pretty much pointless for IPv6. >> So introduce a new attribute 'prefix-len' and dis

Re: [LSF/MM TOPIC][LSF/MM ATTEND] LIO Target Synchronization with sysfs [resend]

2016-02-29 Thread Lee Duncan
On 02/27/2016 01:54 PM, Nicholas A. Bellinger wrote: > On Sat, 2016-02-27 at 08:19 -0800, Lee Duncan wrote: >> [Apologies for the resend.] >> >> I would like to attend LSF/MM this year. I would like to discuss >> problems I've had dealing with LIO targets and their inherent >> asynchronicity in sys

Re: [PATCHv2] iscsi_ibft: Add prefix-len attr and display netmask

2016-02-29 Thread Lee Duncan
On 02/29/2016 10:45 AM, Mike Christie wrote: > On 02/25/2016 12:15 PM, Lee Duncan wrote: >> From: Hannes Reinecke >> >> The iBFT table only specifies a prefix length, not a netmask. >> And the netmask is pretty much pointless for IPv6. >> So introduce a new attribute 'prefix-len' and display the >

Re: [PATCHv2] iscsi_ibft: Add prefix-len attr and display netmask

2016-02-29 Thread Lee Duncan
On 02/29/2016 01:04 PM, Konrad Rzeszutek Wilk wrote: > On Mon, Feb 29, 2016 at 1:45 PM, Mike Christie wrote: >> On 02/25/2016 12:15 PM, Lee Duncan wrote: >>> From: Hannes Reinecke >>> >>> The iBFT table only specifies a prefix length, not a netmask. >>> And the netmask is pretty much pointless fo

Re: [Lsf-pc] [LSF/MM ATTEND] Online Logical Head Depop and SMR disks chunked writepages

2016-02-29 Thread Damien Le Moal
From: Jan Kara Date: Monday, February 29, 2016 at 22:40 To: Damien Le Moal Cc: Jan Kara , "linux-bl...@vger.kernel.org" , Bart Van Assche , Matias Bjorling , "linux-scsi@vger.kernel.org" , "lsf...@lists.linuxfoundation.org" Subject: Re: [Lsf-pc] [LSF/MM ATTEND] Online Logical H

Re: [PATCH v2 1/1] sd: add missing scenario for sd_config_write_same

2016-02-29 Thread Martin K. Petersen
> "Tom" == Tom Yan writes: Tom> Since you've mentioned it, why do we disable write same for all Tom> devices with a ATA Information VPD? Generally speaking, SAS controllers that properly translate SCSI WRITE SAME to ATA ditto also support modern features such as the REPORT SUPPORTED OPERATIO

Re: [PATCH v2 0/6] hisi_sas: add abort and retry feature

2016-02-29 Thread Martin K. Petersen
> "John" == John Garry writes: John> This patchset introduces support to abort certain commands which John> have failed and retry. Certain errors require that the command be John> retried, like TRANS_TX_CREDIT_TIMEOUT_ERR in v1 hw. However, when John> these errors occur the IO may still be

Re: [PATCH] fcoe: fix reset of fip selection time.

2016-02-29 Thread Martin K. Petersen
> "Usha" == Usha Ketineni writes: Usha> Do not reset fip selection time for every advertisement in Usha> fcoe_ctlr_recv_adv() but set it only once for the first validated Usha> FCF. Otherwise FCF selection won't happen when the advertisements Usha> consistently arrive with sub FCOE_CTLR_START

Re: [PATCH] be2iscsi:Add missing error check in beiscsi_eeh_resume

2016-02-29 Thread Martin K. Petersen
> "Nicholas" == Nicholas Krause writes: Nicholas> This adds the missing error check and path for if the call to Nicholas> the function hwi_init_controller fails as this error path was Nicholas> clearly missed when writing beiscsi_eeh_resume and thus we Nicholas> must add it now in order to be

Re: [PATCH 0/6] ncr5380: Exception handling fixes for v4.5

2016-02-29 Thread Martin K. Petersen
> "Finn" == Finn Thain writes: Finn> These patches fix some exception handling and autosense bugs that Finn> I accidentally introduced in v4.5-rc1. Finn> drivers/scsi/NCR5380.c | 133 +++ Finn> drivers/scsi/atari_NCR5380.c | 133 ++

Reviews, please

2016-02-29 Thread Martin K. Petersen
Loose ends for 4.6: aicasm: fix kbuild for separated build directories https://patchwork.kernel.org/patch/8298331/ https://patchwork.kernel.org/patch/8343891/ qlogicpti: Return correct error code https://patchwork.kernel.org/patch/8338931/ scsi_transport_fc: Implement 'a

[PATCH] eata: Convert eata driver as normal PCI and platform device drivers

2016-02-29 Thread Jiang Liu
Previously the eata driver just grabs and accesses eata PCI devices without implementing a PCI device driver, that causes troubles with latest IRQ related Commit 991de2e59090 ("PCI, x86: Implement pcibios_alloc_irq() and pcibios_free_irq()") changes the way to allocate PCI legacy IRQ for PCI devic

Re: [PATCH] eata: Convert eata driver as normal PCI and platform device drivers

2016-02-29 Thread kbuild test robot
Hi Jiang, [auto build test ERROR on scsi/for-next] [also build test ERROR on v4.5-rc6 next-20160229] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Jiang-Liu/eata-Convert-eata-driver-as

Re: [PATCH] eata: Convert eata driver as normal PCI and platform device drivers

2016-02-29 Thread kbuild test robot
Hi Jiang, [auto build test ERROR on scsi/for-next] [also build test ERROR on v4.5-rc6 next-20160229] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Jiang-Liu/eata-Convert-eata-driver-as

Re: [PATCH 0/6] ncr5380: Exception handling fixes for v4.5

2016-02-29 Thread Finn Thain
On Mon, 29 Feb 2016, Martin K. Petersen wrote: > > "Finn" == Finn Thain writes: > > Finn> These patches fix some exception handling and autosense bugs that > Finn> I accidentally introduced in v4.5-rc1. > > Finn> drivers/scsi/NCR5380.c | 133 > +++---

[PATCH][RESEND] scsi_sysfs: add 'is_bin_visible' callback

2016-02-29 Thread Hannes Reinecke
Add 'is_bin_visible' callback to blank out unsupported vpd pages. Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_sysfs.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c index 00bc721..d8b275b 100644 --- a/dr

[PATCH 1/8] scsi_sysfs: add 'is_bin_visible' callback

2016-02-29 Thread Hannes Reinecke
Add 'is_bin_visible' callback to blank out unsupported vpd pages. Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_sysfs.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c index 00bc721..d8b275b 100644 --- a/dr

[PATCH 0/6] SCSI 'access_state' attribute

2016-02-29 Thread Hannes Reinecke
Hi all, here's the patchset to add an 'access_state' and 'preferred_path' attribute. It will display the access state of a path if a hardware handler is attached. The access_state is given in terms of SCSI ALUA, and the vendor-specific access state (eg for rdac or alua) are mapped onto the ALUA va

[PATCH 1/6] scsi: Add 'access_state' and 'preferred_path' attribute

2016-02-29 Thread Hannes Reinecke
Add an 'access_state' field to struct scsi_device and display them in sysfs as 'access_state' and 'preferred_path' attribute. Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_sysfs.c | 74 ++ include/scsi/scsi_device.h | 1 + include/scsi/scsi_pr

[PATCH 3/6] scsi_dh_alua: update 'access_state' field

2016-02-29 Thread Hannes Reinecke
Track attached SCSI devices and update the 'access_state' field whenever an ALUA state change has been detected. Reviewed-by: Bart Van Assche Reviewed-by: Ewan Milne Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 48 +

[PATCH 2/6] scsi_dh_alua: use common definitions for ALUA state

2016-02-29 Thread Hannes Reinecke
scsi_proto.h now contains definitions for the ALUA state, so we don't have to carry them in the device handler. Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 58 +- 1 file changed, 25 insertions(+), 33

[PATCH 6/6] scsi_sysfs: call 'device_add' after attaching device handler

2016-02-29 Thread Hannes Reinecke
'device_add' will be evaluating the 'is_visible' callback when creating the sysfs attributes. As by this time the device handler has not been attached the 'access_state' attribute will never be visible. This patch moves the code around so that the device handler is present by the time 'is_visible'

[PATCH 4/6] scsi_dh_rdac: update 'access_state' field

2016-02-29 Thread Hannes Reinecke
Track attached SCSI devices and update the 'access_state' whenever the path state of the device changes. Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_rdac.c | 38 -- 1 file changed, 31 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/

[PATCH 5/6] scsi_dh_emc: update 'access_state' field

2016-02-29 Thread Hannes Reinecke
Update the 'access_state' field of the SCSI device whenever the path state changes. Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_emc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/device_handler/scsi_dh_emc.c b/drivers/scsi/dev

Re: [PATCH 1/8] scsi_sysfs: add 'is_bin_visible' callback

2016-02-29 Thread Hannes Reinecke
On 03/01/2016 12:51 PM, Hannes Reinecke wrote: > Add 'is_bin_visible' callback to blank out unsupported vpd pages. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/scsi_sysfs.c | 23 +++ > 1 file changed, 23 insertions(+) > Sorry, this is actually a stand-alone patch.

Re: [PATCH v5 01/15] scsi: ufs-qcom: add number of lanes per direction

2016-02-29 Thread Hannes Reinecke
On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > Different platform may have different number of lanes > for the UFS link. > Add parameter to device tree specifying how many lanes > should be configured for the UFS link. > > Signed-off-by: Gilad Broner > Signed-off-by: Yaniv Gardi > > --- Reviewed-

Re: [PATCH v5 02/15] scsi: ufs: avoid spurious UFS host controller interrupts

2016-02-29 Thread Hannes Reinecke
On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > When control reaches to Linux UFS driver during UFS boot mode, UFS host > controller interrupt status/enable registers may have left over > settings. > In order to avoid any spurious interrupts due to these left overs, > it's important to clear these int

Re: [Bug 112241] Under heavy load FC TARGET going to Oops

2016-02-29 Thread Nicholas A. Bellinger
Hi Anthony, On Mon, 2016-02-29 at 02:26 +, bugzilla-dae...@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=112241 > > Anthony changed: > >What|Removed |Added > --

[Bug 112241] Under heavy load FC TARGET going to Oops

2016-02-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=112241 --- Comment #3 from nab --- Hi Anthony, On Mon, 2016-02-29 at 02:26 +, bugzilla-dae...@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=112241 > > Anthony changed: > >What|Removed

Re: [PATCH] target/cxgbit: add INET dependency

2016-02-29 Thread Nicholas A. Bellinger
Hi Arnd, On Mon, 2016-02-29 at 12:14 +0100, Arnd Bergmann wrote: > The newly added cxgbit driver directly calls functions of the > IPv4 network stack, which fails if that is disabled: > > ERROR: "ip_route_output_flow" [drivers/target/iscsi/cxgbit/cxgbit.ko] > undefined! > ERROR: "__ip_dev_find"

RE: [PATCH] snic: correctly check for array overrun on overly long version number

2016-02-29 Thread Seymour, Shane M
Reviewed-by: Shane Seymour -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH 2/2] scsi_transport_fc: Implement 'async_user_scan' module parameter

2016-02-29 Thread Seymour, Shane M
Reviewed-by: Shane Seymour -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/2] scsi_transport_fc: implement 'disable_target_scan' module parameter

2016-02-29 Thread Seymour, Shane M
Reviewed-by: Shane Seymour -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH] qlogicpti: Return correct error code

2016-02-29 Thread Seymour, Shane M
Reviewed-by: Shane Seymour -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH][RESEND] scsi_sysfs: add 'is_bin_visible' callback

2016-02-29 Thread Seymour, Shane M
Reviewed-by: Shane Seymour -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] eata: Convert eata driver as normal PCI and platform device drivers

2016-02-29 Thread Christoph Hellwig
Hi Jiang. I'd love to see this patch in and abuse of the old PCI API gone. Did you resolve the problems Arthur saw with the previous iteratons of the patch? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordom

RE: [PATCH 1/6] scsi: Add 'access_state' and 'preferred_path' attribute

2016-02-29 Thread Seymour, Shane M
in https://www.kernel.org/doc/Documentation/filesystems/sysfs.txt it says: - show() must not use snprintf() when formatting the value to be returned to user space. If you can guarantee that an overflow will never happen you can use sprintf() otherwise you must use scnprintf(). > -Origi

Re: [PATCH] target/cxgbit: add INET dependency

2016-02-29 Thread Varun Prakash
On Tue, Mar 01, 2016 at 10:58:28AM +0530, Nicholas A. Bellinger wrote: > Hi Arnd, > > On Mon, 2016-02-29 at 12:14 +0100, Arnd Bergmann wrote: > > The newly added cxgbit driver directly calls functions of the > > IPv4 network stack, which fails if that is disabled: > > > > ERROR: "ip_route_output_

Re: [PATCH v5 03/15] scsi: ufs: implement scsi host timeout handler

2016-02-29 Thread Hannes Reinecke
On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > A race condition exists between request requeueing and scsi layer > error handling: > When UFS driver queuecommand returns a busy status for a request, > it will be requeued and its tag will be freed and set to -1. > At the same time it is possible that

Re: [PATCH v5 04/15] scsi: ufs: verify hba controller hce reg value

2016-02-29 Thread Hannes Reinecke
On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > Sometimes due to hw issues it takes some time to the > host controller register to update. In order to verify the register > has updated, a polling is done until its value is set. > > In addition the functions ufshcd_hba_stop() and > ufshcd_wait_for_reg

Re: [PATCH v5 05/15] scsi: ufs: add support to read device and string descriptors

2016-02-29 Thread Hannes Reinecke
On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > This change adds support to read device descriptor and string descriptor > from a UFS device > > Reviewed-by: Gilad Broner > Signed-off-by: Raviv Shvili > Signed-off-by: Yaniv Gardi > > --- > drivers/scsi/ufs/ufs.h| 1 + > drivers/scsi/ufs/ufs

Re: [PATCH v5 07/15] scsi: ufs: disable vccq if it's not needed by UFS device

2016-02-29 Thread Hannes Reinecke
On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > Some UFS devices don't require VCCQ rail for device operations hence > this change adds support to recognize such devices and remove vote for > the unused VCCQ rail. > > Signed-off-by: Subhash Jadavani > Signed-off-by: Yaniv Gardi > > --- > drivers/

Re: [PATCH v5 06/15] scsi: ufs: separate device and host quirks

2016-02-29 Thread Hannes Reinecke
On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > Currently we use the host quirks mechanism in order to > handle both device and host controller quirks. > In order to support various of UFS devices we should separate > handling the device quirks from the host controller's. > > Reviewed-by: Gilad Brone

Re: [PATCH v5 08/15] scsi: ufs: make error handling bit faster

2016-02-29 Thread Hannes Reinecke
On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > UFS driver's error handler forcefully tries to clear all the pending > requests. For each pending request in the queue, it waits 1 sec for it > to get cleared. If we have multiple requests in the queue then it's > possible that we might end up waiting fo

Re: [PATCH v5 09/15] scsi: ufs: add error recovery after DL NAC error

2016-02-29 Thread Hannes Reinecke
On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > Some vendor's UFS device sends back to back NACs for the DL data frames > causing the host controller to raise the DFES error status. Sometimes > such UFS devices send back to back NAC without waiting for new > retransmitted DL frame from the host and in

Re: [PATCH v5 10/15] scsi: ufs: add retry for query descriptors

2016-02-29 Thread Hannes Reinecke
On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > Query commands have 100ms timeout and it may timeout if they are > issued in parallel to ongoing read/write SCSI commands, this change > adds the retry (max: 10) in case command timeouts. > > Signed-off-by: Subhash Jadavani > Signed-off-by: Yaniv Gardi

Re: [PATCH v5 11/15] scsi: ufs: handle non spec compliant bkops behaviour by device

2016-02-29 Thread Hannes Reinecke
On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > We are seeing that some devices are raising the urgent bkops exception > events even when BKOPS status doesn't indicate performace impacted or > critical. Handle these device by determining their urgent bkops status > at runtime. > > Signed-off-by: Subh

Re: [PATCH v5 12/15] scsi: ufs: tune UniPro parameters to optimize hibern8 exit time

2016-02-29 Thread Hannes Reinecke
On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > Optimal values of local UniPro parameters like PA_Hibern8Time & > PA_TActivate can help reduce the hibern8 exit latency. If both host and > device supports UniPro ver1.6 or later, these parameters will be > automatically tuned during link startup itself.

Re: [PATCH v5 13/15] scsi: ufs: fix leakage during link off state

2016-02-29 Thread Hannes Reinecke
On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > Currently when we try to put the link in off/disabled state during > suspend, it seems link is not being kept in low power mode. > This patch fixes the issue by putting the link in hibern8 first > (so device also puts the link in low power mode) and then

Re: [PATCH v5 14/15] scsi: ufs: add device quirk delay before putting UFS rails in LPM

2016-02-29 Thread Hannes Reinecke
On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > We put the UFS device in sleep state & UFS link in hibern8 state during > runtime suspaned. After this we put all the UFS rails in low power > modes immediately but it seems some devices may still draw more than > sleep current from UFS rails (especially

Re: [PATCH v5 15/15] scsi: ufs-qcom: set PA_Local_TX_LCC_Enable before link startup

2016-02-29 Thread Hannes Reinecke
On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > Some UFS devices (and may be host) have issues if LCC is > enabled. So we are setting PA_Local_TX_LCC_Enable to 0 > before link startup which will make sure that both host > and device TX LCC are disabled once link startup is > completed. > > This chang