[PATCH v5 00/15] add fixes, device quirks, error recovery,

2016-02-28 Thread Yaniv Gardi
V5: as per comment, patch 05/14 in V4, was divided into 2 patches in V5 V4: fixed DOS EOL symbols in 2 new files V3: Due to comments in V2 Removed change 02/17 of V2 Removed change 03/17 of V2 Removed change 17/17 of V2 V2: This series should be pushed on top of 15 patches series: "Big fixes, r

[PATCH v5 13/15] scsi: ufs: fix leakage during link off state

2016-02-28 Thread Yaniv Gardi
Currently when we try to put the link in off/disabled state during suspend, it seems link is not being kept in low power mode. This patch fixes the issue by putting the link in hibern8 first (so device also puts the link in low power mode) and then stop the host controller. Signed-off-by: Subhash

[PATCH v5 15/15] scsi: ufs-qcom: set PA_Local_TX_LCC_Enable before link startup

2016-02-28 Thread Yaniv Gardi
Some UFS devices (and may be host) have issues if LCC is enabled. So we are setting PA_Local_TX_LCC_Enable to 0 before link startup which will make sure that both host and device TX LCC are disabled once link startup is completed. This change also: - enables the device ref clock before changing to

[PATCH v5 14/15] scsi: ufs: add device quirk delay before putting UFS rails in LPM

2016-02-28 Thread Yaniv Gardi
We put the UFS device in sleep state & UFS link in hibern8 state during runtime suspaned. After this we put all the UFS rails in low power modes immediately but it seems some devices may still draw more than sleep current from UFS rails (especially from VCCQ rail) atleast for 500us. To avoid this s

[PATCH v5 12/15] scsi: ufs: tune UniPro parameters to optimize hibern8 exit time

2016-02-28 Thread Yaniv Gardi
Optimal values of local UniPro parameters like PA_Hibern8Time & PA_TActivate can help reduce the hibern8 exit latency. If both host and device supports UniPro ver1.6 or later, these parameters will be automatically tuned during link startup itself. But if either host or device doesn't support UniPr

[PATCH v5 08/15] scsi: ufs: make error handling bit faster

2016-02-28 Thread Yaniv Gardi
UFS driver's error handler forcefully tries to clear all the pending requests. For each pending request in the queue, it waits 1 sec for it to get cleared. If we have multiple requests in the queue then it's possible that we might end up waiting for those many seconds before resetting the host. But

[PATCH v5 09/15] scsi: ufs: add error recovery after DL NAC error

2016-02-28 Thread Yaniv Gardi
Some vendor's UFS device sends back to back NACs for the DL data frames causing the host controller to raise the DFES error status. Sometimes such UFS devices send back to back NAC without waiting for new retransmitted DL frame from the host and in such cases it might be possible the Host UniPro go

[PATCH v5 10/15] scsi: ufs: add retry for query descriptors

2016-02-28 Thread Yaniv Gardi
Query commands have 100ms timeout and it may timeout if they are issued in parallel to ongoing read/write SCSI commands, this change adds the retry (max: 10) in case command timeouts. Signed-off-by: Subhash Jadavani Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/ufshcd.c | 55

[PATCH v5 11/15] scsi: ufs: handle non spec compliant bkops behaviour by device

2016-02-28 Thread Yaniv Gardi
We are seeing that some devices are raising the urgent bkops exception events even when BKOPS status doesn't indicate performace impacted or critical. Handle these device by determining their urgent bkops status at runtime. Signed-off-by: Subhash Jadavani Signed-off-by: Yaniv Gardi --- drivers

[PATCH v5 06/15] scsi: ufs: separate device and host quirks

2016-02-28 Thread Yaniv Gardi
Currently we use the host quirks mechanism in order to handle both device and host controller quirks. In order to support various of UFS devices we should separate handling the device quirks from the host controller's. Reviewed-by: Gilad Broner Signed-off-by: Raviv Shvili Signed-off-by: Yaniv Ga

[PATCH v5 05/15] scsi: ufs: add support to read device and string descriptors

2016-02-28 Thread Yaniv Gardi
This change adds support to read device descriptor and string descriptor from a UFS device Reviewed-by: Gilad Broner Signed-off-by: Raviv Shvili Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/ufs.h| 1 + drivers/scsi/ufs/ufshcd.c | 88 ++- dri

[PATCH v5 04/15] scsi: ufs: verify hba controller hce reg value

2016-02-28 Thread Yaniv Gardi
Sometimes due to hw issues it takes some time to the host controller register to update. In order to verify the register has updated, a polling is done until its value is set. In addition the functions ufshcd_hba_stop() and ufshcd_wait_for_register() was updated with an additional input parameter,

[PATCH v5 07/15] scsi: ufs: disable vccq if it's not needed by UFS device

2016-02-28 Thread Yaniv Gardi
Some UFS devices don't require VCCQ rail for device operations hence this change adds support to recognize such devices and remove vote for the unused VCCQ rail. Signed-off-by: Subhash Jadavani Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/ufs.h| 1 + drivers/scsi/ufs/ufshcd.c | 60

[PATCH v5 03/15] scsi: ufs: implement scsi host timeout handler

2016-02-28 Thread Yaniv Gardi
A race condition exists between request requeueing and scsi layer error handling: When UFS driver queuecommand returns a busy status for a request, it will be requeued and its tag will be freed and set to -1. At the same time it is possible that the request will timeout and scsi layer will start er

[PATCH v5 02/15] scsi: ufs: avoid spurious UFS host controller interrupts

2016-02-28 Thread Yaniv Gardi
When control reaches to Linux UFS driver during UFS boot mode, UFS host controller interrupt status/enable registers may have left over settings. In order to avoid any spurious interrupts due to these left overs, it's important to clear these interrupt status/enable registers before enabling UFS in

RE: [v4 05/14] scsi: ufs: separate device and host quirks

2016-02-28 Thread ygardi
>> Currently we use the host quirks mechanism in order to >> handle both device and host controller quirks. >> In order to support various of UFS devices we should separate >> handling the device quirks from the host controller's. >> >> Reviewed-by: Gilad Broner >> Signed-off-by: Raviv Shvili >>

[PATCH v5 01/15] scsi: ufs-qcom: add number of lanes per direction

2016-02-28 Thread Yaniv Gardi
Different platform may have different number of lanes for the UFS link. Add parameter to device tree specifying how many lanes should be configured for the UFS link. Signed-off-by: Gilad Broner Signed-off-by: Yaniv Gardi --- .../devicetree/bindings/ufs/ufshcd-pltfrm.txt | 3 ++ drivers/s

sr: Failures to read TAO CD track ends

2016-02-28 Thread Thomas Schmitt
Hi, to solve the long standing problems when reading the end of TAO CD data tracks, i propose to perform a test READ(10) of the last 2 blocks on any data CD, before believing in the readable size as deduced from the reply of READ CAPACITY. Please instruct me if i have to re-submit this issue some

Re: [Lsf-pc] [LSF/MM TOPIC][LSF/MM ATTEND] blk-mq and I/O scheduling

2016-02-28 Thread Christoph Hellwig
I was still hoping we'd get your slicing patches in ASAP at least. But there are couple more topics here, so I think it would still be useful in that case. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [Lsf-pc] [LSF/MM TOPIC][LSF/MM ATTEND] blk-mq and I/O scheduling

2016-02-28 Thread Hannes Reinecke
On 02/29/2016 12:13 AM, Christoph Hellwig wrote: > I was still hoping we'd get your slicing patches in ASAP at least. > But there are couple more topics here, so I think it would > still be useful in that case. > Actually I have been pondering an alternative approach. In most cases submit_bio() /

Re: [Lsf-pc] [LSF/MM ATTEND] Online Logical Head Depop and SMR disks chunked writepages

2016-02-28 Thread Damien Le Moal
>On Wed 24-02-16 01:53:24, Damien Le Moal wrote: >> >> >On Tue 23-02-16 05:31:13, Damien Le Moal wrote: >> >> >> >> >On 02/22/16 18:56, Damien Le Moal wrote: >> >> >> 2) Write back of dirty pages to SMR block devices: >> >> >> >> >> >> Dirty pages of a block device inode are currently processed

[Bug 112241] Under heavy load FC TARGET going to Oops

2016-02-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=112241 --- Comment #1 from Anthony --- Created attachment 206351 --> https://bugzilla.kernel.org/attachment.cgi?id=206351&action=edit Screenshot with call trace for kernel 4.5.0 -- You are receiving this mail because: You are watching the assignee o

[Bug 112241] Under heavy load FC TARGET going to Oops

2016-02-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=112241 Anthony changed: What|Removed |Added Kernel Version|4.3.3 |4.5.0 --- Comment #2 from Anthony --- With ke

Re: [Lsf-pc] [LSF/MM ATTEND] Online Logical Head Depop and SMR disks chunked writepages

2016-02-28 Thread Hannes Reinecke
On 02/29/2016 10:02 AM, Damien Le Moal wrote: > >> On Wed 24-02-16 01:53:24, Damien Le Moal wrote: >>> On Tue 23-02-16 05:31:13, Damien Le Moal wrote: > >> On 02/22/16 18:56, Damien Le Moal wrote: >>> 2) Write back of dirty pages to SMR block devices: >>> >>> Dirty pages o

Re: [Lsf-pc] [LSF/MM ATTEND] Online Logical Head Depop and SMR disks chunked writepages

2016-02-28 Thread Damien Le Moal
>On 02/29/2016 10:02 AM, Damien Le Moal wrote: >> >>> On Wed 24-02-16 01:53:24, Damien Le Moal wrote: > On Tue 23-02-16 05:31:13, Damien Le Moal wrote: >> >>> On 02/22/16 18:56, Damien Le Moal wrote: 2) Write back of dirty pages to SMR block devices: Di