Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

2016-01-03 Thread Finn Thain
On Sat, 2 Jan 2016, Joe Perches wrote: > On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote: > > Hanging indentation was a poor choice for the text inside comments. It > > has been used in the wrong places and done badly elsewhere. There is > > little consistency within any file. One fork of the

Re: [PATCH 11/20] scsi_dh_alua: Use workqueue for RTPG

2016-01-03 Thread Christoph Hellwig
On Thu, Dec 31, 2015 at 02:01:43PM +0100, Hannes Reinecke wrote: >>> if (tmp_pg) { >>> spin_unlock(&port_group_lock); >>> - kfree(pg); >>> - return tmp_pg; >>> + kref_put(&pg->kref, release_port_group); >>> + pg = tmp_pg; >>> + tmp_p

Re: [PATCH 12/20] scsi_dh_alua: Allow workqueue to run synchronously

2016-01-03 Thread Christoph Hellwig
On Thu, Dec 31, 2015 at 02:54:18PM +0100, Hannes Reinecke wrote: > ATM the only ones I know of is NetApp (both FAS and E-series; E-series > requires it, and FAS benefits greatly). > But this is not to say that these are the only ones, _and_ the more obvious > approach would be to add the handling

Re: NMI watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [kworker/1:1:29]

2016-01-03 Thread Christoph Hellwig
On Thu, Dec 31, 2015 at 06:04:15PM +0100, Sebastian Herbszt wrote: > I still get this on 4.4.0-rc7-1.g276c9f4-default. Since this did not > happen on 4.3 I checked the scsi changes and found the following commit: > > scsi: restart list search after unlock in scsi_remove_target > > Christoph, can

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

2016-01-03 Thread One Thousand Gnomes
On Sat, 02 Jan 2016 23:54:28 -0800 Joe Perches wrote: > On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote: > > Hanging indentation was a poor choice for the text inside comments. It > > has been used in the wrong places and done badly elsewhere. There is > > little consistency within any file.

Re: NMI watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [kworker/1:1:29]

2016-01-03 Thread Sebastian Herbszt
Christoph Hellwig wrote: > On Thu, Dec 31, 2015 at 06:04:15PM +0100, Sebastian Herbszt wrote: > > I still get this on 4.4.0-rc7-1.g276c9f4-default. Since this did not > > happen on 4.3 I checked the scsi changes and found the following commit: > > > > scsi: restart list search after unlock in scsi

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

2016-01-03 Thread Joe Perches
On Sun, 2016-01-03 at 14:10 +, One Thousand Gnomes wrote: > On Sat, 02 Jan 2016 23:54:28 -0800 > Joe Perches wrote: > > > On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote: > > > Hanging indentation was a poor choice for the text inside comments. It > > > has been used in the wrong places a

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

2016-01-03 Thread One Thousand Gnomes
> > I would beg to differ. As a tool for understanding the differences as you > > step through the versions it's invaluable. > > This removes intentional formatting that > makes reading comments easier. And this matters at the end of the patch series because ? -- To unsubscribe from this list: s

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

2016-01-03 Thread Joe Perches
(using an email address for James that shouldn't bounce) On Sun, 2016-01-03 at 21:29 +, One Thousand Gnomes wrote: > > > I would beg to differ. As a tool for understanding the > > > differences as you > > > step through the versions it's invaluable. > > > > This removes intentional formatting

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

2016-01-03 Thread Joe Perches
On Sun, 2016-01-03 at 22:05 +, One Thousand Gnomes wrote: > On Sun, 03 Jan 2016 13:46:22 -0800 > Joe Perches wrote: > > > (using an email address for James that shouldn't bounce) > > > > On Sun, 2016-01-03 at 21:29 +, One Thousand Gnomes wrote: > > > > > I would beg to differ. As a tool

RE: [PATCH RESEND] megaraid:Fix for loop termination statment in the function process_fw_state_change_wq

2016-01-03 Thread Sumit Saxena
> -Original Message- > From: Nicholas Krause [mailto:xerofo...@gmail.com] > Sent: Friday, January 01, 2016 12:06 PM > To: kashyap.de...@avagotech.com > Cc: sumit.sax...@avagotech.com; uday.ling...@avagotech.com; > jbottom...@odin.com; martin.peter...@oracle.com; > megaraidlinux@avagotec

Re: [PATCH 12/20] target/tmr: LUN reset cause cmd premature free.

2016-01-03 Thread Bart Van Assche
On 12/08/2015 03:48 AM, Christoph Hellwig wrote: On Mon, Dec 07, 2015 at 07:48:59PM -0500, Himanshu Madhani wrote: From: Quinn Tran During LUN/Target reset, the TMR code attempt to intercept cmds and try to aborted them. Current code assume cmds are always intercepted at the back end device.