Re: [PATCH 03/15] be2iscsi: Fix to use atomic operations for tag_state

2015-12-20 Thread Mike Christie
On 12/20/2015 01:44 AM, Mike Christie wrote: >> diff --git a/drivers/scsi/be2iscsi/be_cmds.c >> b/drivers/scsi/be2iscsi/be_cmds.c >> index 6fabded..21c806f 100644 >> --- a/drivers/scsi/be2iscsi/be_cmds.c >> +++ b/drivers/scsi/be2iscsi/be_cmds.c >> @@ -164,9 +164,8 @@ int beiscsi_mccq_compl(struct

Re: [PATCH 03/15] be2iscsi: Fix to use atomic operations for tag_state

2015-12-20 Thread Mike Christie
On 12/20/15 3:01 AM, Mike Christie wrote: On 12/20/2015 01:44 AM, Mike Christie wrote: diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c index 6fabded..21c806f 100644 --- a/drivers/scsi/be2iscsi/be_cmds.c +++ b/drivers/scsi/be2iscsi/be_cmds.c @@ -164,9 +164,8 @@ int

RE: [PATCH 10/15] be2iscsi: Add FW config validation

2015-12-20 Thread Jitendra Bhivare
It stands for Dual ULP Aware. Will add a comment explaining that. Thanks, JB -Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Friday, December 18, 2015 2:34 PM To: Jitendra Bhivare; linux-scsi@vger.kernel.org; micha...@cs.wisc.edu Subject: Re: [PATCH 10/15] be2iscsi:

RE: [PATCH 10/15] be2iscsi: Add FW config validation

2015-12-20 Thread Jitendra Bhivare
Yes, the faults are not being used, it just adds to the confusion, we just intend to get the link state change - UP or DOWN. -Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Friday, December 18, 2015 2:34 PM To: Jitendra Bhivare; linux-scsi@vger.kernel.org; micha...@cs.

RE: [PATCH 03/15] be2iscsi: Fix to use atomic operations for tag_state

2015-12-20 Thread Jitendra Bhivare
Yep, there is a need for barrier when setting MCC_TAG_STATE_TIMEOUT. I am sorry, was under the assumption that lock prefix would be used for that atomic operation as well. Thanks, JB -Original Message- From: Mike Christie [mailto:micha...@cs.wisc.edu] Sent: Sunday, December 20, 2015 3:44

Re: [PATCH v2 00/16] qla2xxx: Patches for target-pending branch

2015-12-20 Thread Nicholas A. Bellinger
Hi Himanshu & Co, On Thu, 2015-12-17 at 14:56 -0500, Himanshu Madhani wrote: > Hi Nic, > > Please apply this series to target-pending at your earliest convenience. > > changes from v1 -> v2 > > o Added Reviewed-by tag for reviewed patches. > > o Dropped following patches for rework. > - qla2

Re: [PATCH 13/15] be2iscsi: Fix to process 25G link speed info from FW

2015-12-20 Thread Hannes Reinecke
On 12/21/2015 04:00 AM, Jitendra Bhivare wrote: Yes, the faults are not being used, it just adds to the confusion, where we just want to get the link state change up or down. So make it a separate patch explaining this. Cheers, Hannes -- Dr. Hannes ReineckezSeries

Re: [PATCH v2 15/16] qla2xxx: Add bulk send for atio & ctio completion paths.

2015-12-20 Thread Nicholas A. Bellinger
On Thu, 2015-12-17 at 14:57 -0500, Himanshu Madhani wrote: > From: Quinn Tran > > At high traffic, the work queue can become a bottle neck. > Instead of putting each command on the work queue as 1 work > element, the fix would daisy chain a list of commands that came > from FW/interrupt under 1 w

Re: [PATCH 0/2] target: kthread login failure hung task + CAW use-after-free

2015-12-20 Thread Nicholas A. Bellinger
On Fri, 2015-12-18 at 14:05 +0100, Martin Svec wrote: > Hello Nick, > > should these patches be included in 4.1.x LTS series too?: > > Nicholas Bellinger (2): > iscsi-target: Fix rx_login_comp hang after login failure > target: Fix race for SCF_COMPARE_AND_WRITE_POST checking > > They are ma

Re: [PATCH V3 4/4] scsi: storvsc: Tighten up the interrupt path

2015-12-20 Thread Hannes Reinecke
On 12/19/2015 03:28 AM, KY Srinivasan wrote: [ .. ] Could you? You're making what you describe as an optimisation but there are two reasons why this might not be so. The first is that the compiler is entitled to inline static functions. If it did, likely it picked up the optmisation anyway