Re: [PATCH 04/25] scsi: hisi_sas: add scsi host registration

2015-10-13 Thread John Garry
On 12/10/2015 16:21, Arnd Bergmann wrote: On Monday 12 October 2015 23:20:16 John Garry wrote: + + shost = scsi_host_alloc(&hisi_sas_sht, sizeof(void *)); + if (!shost) + return -ENOMEM; + + hisi_hba = hisi_sas_hba_alloc(pdev, shost, np); + if (!hisi_hba) {

Re: [PATCH 05/25] scsi: hisi_sas: allocate memories and create pools

2015-10-13 Thread zhangfei
Hi, Arnd On 10/12/2015 11:15 PM, Arnd Bergmann wrote: On Monday 12 October 2015 23:20:17 John Garry wrote: + interrupt_count = of_property_count_u32_elems(np, "interrupts"); + if (interrupt_count < 0) + goto err_out; + + if (of_property_read_u32(np, "#interrupt-c

Re: [PATCHv5 00/36] asynchronous ALUA device handler

2015-10-13 Thread Hannes Reinecke
On 09/30/2015 11:32 PM, Bart Van Assche wrote: > On 09/30/2015 06:21 AM, Hannes Reinecke wrote: >> On 09/29/2015 08:29 PM, Bart Van Assche wrote: >>> On 09/29/2015 03:47 AM, Hannes Reinecke wrote: here the next round of my update to the ALUA device handler. >>> >>> Sorry but this with this ver

Re: [PATCH 07/25] scsi: hisi_sas: add ioremap for device HW

2015-10-13 Thread zhangfei
On 10/12/2015 11:21 PM, Arnd Bergmann wrote: On Monday 12 October 2015 23:20:19 John Garry wrote: +int hisi_sas_ioremap(struct hisi_hba *hisi_hba) +{ + struct platform_device *pdev = hisi_hba->pdev; + struct device *dev = &pdev->dev; + struct resource *res; + + res = pl

Re: [PATCH v3] scsi: report 'INQUIRY result too short' once per host

2015-10-13 Thread Vitaly Kuznetsov
Hannes Reinecke writes: > On 10/12/2015 05:16 PM, Vitaly Kuznetsov wrote: >> Hannes Reinecke writes: >> >>> On 10/08/2015 06:54 PM, Vitaly Kuznetsov wrote: Some host adapters (e.g. Hyper-V storvsc) are known for not respecting the SPC-2/3/4 requirement for 'INQUIRY data (see table ...

Re: [PATCH v3 12/13] scsi: ufs-exynos: add UFS host support for Exynos SoCs

2015-10-13 Thread Alim Akhtar
Hi Arnd, On 10/01/2015 05:42 PM, Arnd Bergmann wrote: On Thursday 01 October 2015 13:39:29 Alim Akhtar wrote: +static int exynos7_ufs_drv_init(struct device *dev, struct exynos_ufs *ufs) +{ + int ret; + const char *const clks[] = { + "mout_sclk_combo_phy_embedded", +

Re: [PATCH v3 12/13] scsi: ufs-exynos: add UFS host support for Exynos SoCs

2015-10-13 Thread Arnd Bergmann
On Tuesday 13 October 2015 16:49:39 Alim Akhtar wrote: > >> diff --git a/drivers/scsi/ufs/ufs-exynos.h b/drivers/scsi/ufs/ufs-exynos.h > >> new file mode 100644 > >> index 000..58aa714 > >> --- /dev/null > >> +++ b/drivers/scsi/ufs/ufs-exynos.h > >> @@ -0,0 +1,463 @@ > >> +/* > >> + * UFS Host

Re: [PATCH v3 11/13] Documentation: devicetree: ufs: Add DT bindings for exynos UFS host controller

2015-10-13 Thread Alim Akhtar
Hi Arnd, On 10/01/2015 05:07 PM, Arnd Bergmann wrote: On Thursday 01 October 2015 13:39:28 Alim Akhtar wrote: From: Seungwon Jeon This adds Exynos Universal Flash Storage (UFS) Host Controller DT bindings. Signed-off-by: Seungwon Jeon Signed-off-by: Alim Akhtar --- .../devicetree/binding

Re: [RFC PATCH] phy: exynos-ufs: exynos_ufs_phy_calibrate() can be static

2015-10-13 Thread Alim Akhtar
HI How I am support to handle this patch? Should I just fix these warnings in my patch or I just add this as a separate patch on the top of the series? On 10/01/2015 04:34 PM, kbuild test robot wrote: Signed-off-by: Fengguang Wu --- phy-exynos-ufs.c |6 +++--- 1 file changed, 3 inser

Re: Bugs in multipath scsi in 4.3-rc2

2015-10-13 Thread Christoph Hellwig
On Tue, Oct 13, 2015 at 08:00:43AM +0200, Hannes Reinecke wrote: > In the light of the discussion I think it would be better to > upgrade the device handler to become their own transport class, > to be hooked in between scsi_target and scsi_device. > That way we would have a way of exposing the top

Re: [PATCH v3 12/13] scsi: ufs-exynos: add UFS host support for Exynos SoCs

2015-10-13 Thread Alim Akhtar
On 10/13/2015 05:08 PM, Arnd Bergmann wrote: On Tuesday 13 October 2015 16:49:39 Alim Akhtar wrote: diff --git a/drivers/scsi/ufs/ufs-exynos.h b/drivers/scsi/ufs/ufs-exynos.h new file mode 100644 index 000..58aa714 --- /dev/null +++ b/drivers/scsi/ufs/ufs-exynos.h @@ -0,0 +1,463 @@ +/* + *

Re: [PATCH v3 11/13] Documentation: devicetree: ufs: Add DT bindings for exynos UFS host controller

2015-10-13 Thread Arnd Bergmann
On Tuesday 13 October 2015 17:06:18 Alim Akhtar wrote: > > Better rename them to "core", "ref" and "iface", no point requiring to > > spell out "clk" here. > > > >> +ufs,pwr-attr-mode = "FAST"; > > > > A string is rather unusual here, what are the allowed values? Could you > > use a boo

Re: [PATCH 04/25] scsi: hisi_sas: add scsi host registration

2015-10-13 Thread Arnd Bergmann
On Tuesday 13 October 2015 10:16:55 John Garry wrote: > > > > >> + sha = SHOST_TO_SAS_HA(shost) = &hisi_hba->sha; > >> + platform_set_drvdata(pdev, sha); > >> + > >> + phy_nr = port_nr = HISI_SAS_MAX_PHYS; > >> + > >> + arr_phy = devm_kcalloc(dev, phy_nr, sizeof(void *), GF

Re: [PATCH 07/25] scsi: hisi_sas: add ioremap for device HW

2015-10-13 Thread Arnd Bergmann
On Tuesday 13 October 2015 17:47:02 zhangfei wrote: > On 10/12/2015 11:21 PM, Arnd Bergmann wrote: > > On Monday 12 October 2015 23:20:19 John Garry wrote: > >> +int hisi_sas_ioremap(struct hisi_hba *hisi_hba) > >> +{ > >> + struct platform_device *pdev = hisi_hba->pdev; > >> + struct d

Re: [PATCH 12/25] scsi: hisi_sas: add v1 HW initialisation code

2015-10-13 Thread John Garry
On 12/10/2015 19:46, Arnd Bergmann wrote: On Monday 12 October 2015 23:20:24 John Garry wrote: @@ -387,6 +392,21 @@ static int hisi_sas_probe(struct platform_device *pdev) } hisi_sas_init_add(hisi_hba); + + rc = hw_init_v1_hw(hisi_hba); + if (rc) + go

Re: [PATCH 12/25] scsi: hisi_sas: add v1 HW initialisation code

2015-10-13 Thread Arnd Bergmann
On Tuesday 13 October 2015 13:44:26 John Garry wrote: > Hello, > > Just to be clear, are you saying that you would prefer hisi_sas_probe() > and struct hisi_sas_driver to be relocated to hisi_sas_v1_hw.c? Correct. > I wanted to keep hisi_sas_v1_hw.c containing only code which accesses HW. > >

Re: [RFC PATCH] phy: exynos-ufs: exynos_ufs_phy_calibrate() can be static

2015-10-13 Thread Kishon Vijay Abraham I
Hi, On Tuesday 13 October 2015 05:08 PM, Alim Akhtar wrote: > HI > How I am support to handle this patch? Should I just fix these warnings > in my patch or I just add this as a separate patch on the top of the > series? This series has not been merged yet. So you can fix this patch. Thanks Kisho

Re: [kbuild-all] [RFC PATCH] phy: exynos-ufs: exynos_ufs_phy_calibrate() can be static

2015-10-13 Thread Fengguang Wu
On Tue, Oct 13, 2015 at 05:08:58PM +0530, Alim Akhtar wrote: > HI > How I am support to handle this patch? Should I just fix these warnings in > my patch or I just add this as a separate patch on the top of the series? Alim, you can simply fold it into your patch. Thanks, Fengguang > On 10/01/20

Re: [PATCHv5 00/36] asynchronous ALUA device handler

2015-10-13 Thread Bart Van Assche
On 10/13/2015 02:44 AM, Hannes Reinecke wrote: I have rebased my patches to 4.3.0-rc5 and didn't see any lockups; tested with hpsa and lpfc, both mq enabled and disabled. Can you check if it's specific to ib_srp? Is there a way to simulate an ib_srp setup? Hello Hannes, This infinite loop was

Re: [PATCH 07/25] scsi: hisi_sas: add ioremap for device HW

2015-10-13 Thread zhangfei
On 10/13/2015 08:20 PM, Arnd Bergmann wrote: On Tuesday 13 October 2015 17:47:02 zhangfei wrote: On 10/12/2015 11:21 PM, Arnd Bergmann wrote: On Monday 12 October 2015 23:20:19 John Garry wrote: +int hisi_sas_ioremap(struct hisi_hba *hisi_hba) +{ + struct platform_device *pdev = hisi_h

Re: [PATCHv5 00/36] asynchronous ALUA device handler

2015-10-13 Thread Hannes Reinecke
On 10/13/2015 05:07 PM, Bart Van Assche wrote: > On 10/13/2015 02:44 AM, Hannes Reinecke wrote: >> I have rebased my patches to 4.3.0-rc5 and didn't see any lockups; >> tested with hpsa and lpfc, both mq enabled and disabled. >> >> Can you check if it's specific to ib_srp? Is there a way to simulat

Re: [PATCHv5 00/36] asynchronous ALUA device handler

2015-10-13 Thread Bart Van Assche
On 10/13/2015 08:13 AM, Hannes Reinecke wrote: On 10/13/2015 05:07 PM, Bart Van Assche wrote: On 10/13/2015 02:44 AM, Hannes Reinecke wrote: I have rebased my patches to 4.3.0-rc5 and didn't see any lockups; tested with hpsa and lpfc, both mq enabled and disabled. Can you check if it's specifi

Re: [PATCH 09/25] scsi: hisi_sas: add phy SAS ADDR initialization

2015-10-13 Thread John Garry
On 13/10/2015 07:12, Hannes Reinecke wrote: On 10/12/2015 05:20 PM, John Garry wrote: This SAS ID is chosen as Huawei IEEE id: 001882 Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_init.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/scsi/hisi_sa

Re: SSP frame iu defines

2015-10-13 Thread John Garry
OK, can I put this together. I feel that the code may get messy due to byte-ordering difference in isci versions. That's why we develop with the show me the code model. Rather than arguing theoretically about whether something should or should not be done, you propose the actual change. If i

Re: [PATCH] scsi: advansys needs ISA dma api for ISA support

2015-10-13 Thread James Bottomley
On Mon, 2015-10-12 at 17:44 +0200, Arnd Bergmann wrote: > On Monday 12 October 2015 08:28:01 James Bottomley wrote: > > > > > > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig > > > index d2f480b04a52..d4aa6a1a806c 100644 > > > --- a/drivers/scsi/Kconfig > > > +++ b/drivers/scsi/Kconfig >

Re: [PATCH] st: allow debug output to be enabled or disabled via sysfs

2015-10-13 Thread Kai Mäkisara (Kolumbus)
> On 12.10.2015, at 7.31, Seymour, Shane M wrote: > > > Change st driver to allow enabling or disabling debug output > via sysfs file /sys/bus/scsi/drivers/st/debug_flag. > > Previously the only way to enable debug output was: > > 1. loading the driver with the module parameter debug_flag=1 >

Re: [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only

2015-10-13 Thread Laurent Vivier
James, this series has been reviewed and ack'ed, as SCSI maintainer, could you take it ? Laurent On 10/09/2015 11:23, Laurent Vivier wrote: > The value of the parameter is never re-read by the driver, > so a new value is ignored. Let know the user he > can't modify it by removing writable attrib

[PATCH net-next] cxgb4i: Increased the value of MAX_IMM_TX_PKT_LEN from 128 to 256 bytes

2015-10-13 Thread Karen Xie
This helps improving the latency of small packets. Signed-off-by: Rakesh Ranjan Signed-off-by: Karen Xie --- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c ind