RE: [PATCH v2 0/10] megaraid_sas : Updates for scsi for-next

2015-09-18 Thread Sumit Saxena
> -Original Message- > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: Saturday, August 29, 2015 1:03 AM > To: sumit.sax...@avagotech.com > Cc: linux-scsi@vger.kernel.org; the...@redhat.com; > martin.peter...@oracle.com; h...@infradead.org; jbottom...@parallels.

Re: [PATCH v2 09/30] cxlflash: Fix to stop interrupt processing on remove

2015-09-18 Thread Tomas Henzl
On 17.9.2015 19:16, Matthew R. Ochs wrote: >> On Sep 17, 2015, at 7:38 AM, Tomas Henzl wrote: >> >> On 16.9.2015 18:53, Matthew R. Ochs wrote: >>> Interrupt processing can run in parallel to a remove operation. This >>> can lead to a condition where the interrupt handler is processing with >>> mem

Re: [PATCH v2 08/30] cxlflash: Fix to avoid CXL services during EEH

2015-09-18 Thread Brian King
On 09/16/2015 04:27 PM, Matthew R. Ochs wrote: > --- a/drivers/scsi/cxlflash/main.c > +++ b/drivers/scsi/cxlflash/main.c > @@ -2311,6 +2311,7 @@ static int cxlflash_probe(struct pci_dev *pdev, > cfg->lr_port = -1; > mutex_init(&cfg->ctx_tbl_list_mutex); > mutex_init(&cfg->ctx_reco

Re: [Bugfix 3/3] eata: Enhance eata driver to support PCI device hot-removal

2015-09-18 Thread Arthur Marsh
Christoph Hellwig wrote on 16/09/15 23:12: Jiang, you also need to convert the driver to scsi_add_host/scsi_remove_host from the legacy scsi_register interface, otherwise the SCSI layer will be very unhappy. Take a look at commit 0d31f8759109cbc1e6fc196d08e6b0e8a9e93b3f for example, the chang

Re: [PATCH v2 10/30] cxlflash: Correct naming of limbo state and waitq

2015-09-18 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 11/30] cxlflash: Make functions static

2015-09-18 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 01/17] Add ida and idr helper routines.

2015-09-18 Thread Lee Duncan
On 09/15/2015 11:41 AM, Tejun Heo wrote: > Hello, > > On Tue, Sep 15, 2015 at 11:38:42AM -0700, James Bottomley wrote: >> For most of the SCSI stuff, yes. I'm less sure about the sd numbers. >> They go up very high and get hammered a lot during system bring up and >> hot plug. I think having the

Re: [PATCH 01/17] Add ida and idr helper routines.

2015-09-18 Thread Tejun Heo
Hello, On Fri, Sep 18, 2015 at 08:42:26AM -0700, Lee Duncan wrote: > To be clear: you would like a patch series that converts the users of > the ida_* routines in my patches to instead use the ida_simple_* > routines, correct? And of course the ida_* helper routines I was adding > in idr.h would n

[PATCH] sci: ufs: Fix module autoload for OF platform driver

2015-09-18 Thread Luis de Bethencourt
This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- Hello, This patch adds the missing MODULE_DEVICE_TABLE() for OF to export that information so modules have the correct aliase

Re: [PATCH v2 12/30] cxlflash: Refine host/device attributes

2015-09-18 Thread Brian King
On 09/16/2015 04:29 PM, Matthew R. Ochs wrote: > Implement the following suggestions and add two new attributes > to allow for debugging the port LUN table. > > - use scnprintf() instead of snprintf() > - use DEVICE_ATTR_RO and DEVICE_ATTR_RW > > Signed-off-by: Matthew R. Ochs > Signed-off-by:

Re: [PATCH v2 13/30] cxlflash: Fix to avoid spamming the kernel log

2015-09-18 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 04/30] cxlflash: Fix potential oops following LUN removal

2015-09-18 Thread Matthew R. Ochs
> On Sep 17, 2015, at 8:26 PM, Brian King wrote: > > On 09/16/2015 04:27 PM, Matthew R. Ochs wrote: >> >> lun_access = kzalloc(sizeof(*lun_access), GFP_KERNEL); >> if (unlikely(!lun_access)) { >> dev_err(dev, "%s: Unable to allocate lun_access!\n", __func__); >> +

Re: [PATCH v2 09/30] cxlflash: Fix to stop interrupt processing on remove

2015-09-18 Thread Matthew R. Ochs
> On Sep 18, 2015, at 6:59 AM, Tomas Henzl wrote: > On 17.9.2015 19:16, Matthew R. Ochs wrote: >>> On Sep 17, 2015, at 7:38 AM, Tomas Henzl wrote: >>> >>> On 16.9.2015 18:53, Matthew R. Ochs wrote: Interrupt processing can run in parallel to a remove operation. This can lead to a condi

Re: [PATCH v2 08/30] cxlflash: Fix to avoid CXL services during EEH

2015-09-18 Thread Matthew R. Ochs
> On Sep 18, 2015, at 8:37 AM, Brian King wrote: > On 09/16/2015 04:27 PM, Matthew R. Ochs wrote: >> >> /** >> + * drain_ioctls() - wait until all currently executing ioctls have completed >> + * @cfg:Internal structure associated with the host. >> + * >> + * Obtain write access to read/write

Re: [PATCH v2 12/30] cxlflash: Refine host/device attributes

2015-09-18 Thread Matthew R. Ochs
> On Sep 18, 2015, at 4:34 PM, Brian King wrote: > On 09/16/2015 04:29 PM, Matthew R. Ochs wrote: >> >> +ssize_t bytes = 0; >> +__be64 __iomem *fc_port; >> + >> +if (port >= NUM_FC_PORTS) >> +return 0; >> + >> +fc_port = &afu->afu_map->global.fc_port[port][0]; >> + >>

[PATCH] scsi: Fix a bdi reregistration race

2015-09-18 Thread Bart Van Assche
Unregister and reregister BDI devices in the proper order. This patch avoids that the following kernel warning can get triggered: WARNING: CPU: 7 PID: 203 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x68/0x80() sysfs: cannot create duplicate filename '/devices/virtual/bdi/8:32' Workqueue: events_unbound a