On 09/04/2015 09:47 PM, Brian King wrote:
> On 09/04/2015 11:15 AM, James Bottomley wrote:
>> On Fri, 2015-09-04 at 10:47 -0500, Brian King wrote:
>>> On 09/04/2015 10:36 AM, James Bottomley wrote:
On Wed, 2015-09-02 at 09:31 -0500, Brian King wrote:
> This patch fixes an issue seen with a
On 09/08/2015 08:30 PM, Mike Snitzer wrote:
> On Tue, Sep 08 2015 at 1:34pm -0400,
> James Bottomley wrote:
>
>> On Tue, 2015-09-08 at 13:23 -0400, Mike Snitzer wrote:
>>> On Tue, Sep 08 2015 at 1:10pm -0400,
>>> Jim Davis wrote:
>>>
Building with the attached random configuration file,
>
V1:
This series should be pushed on top of 15 patches series:
"Big fixes, retries, handle a race condition"
Yaniv Gardi (17):
scsi: ufs-qcom: add number of lanes per direction
scsi: ufs: add option to change default UFS power management level
scsi: ufs: optimize system suspend handling
scs
Currently when we try to put the link in off/disabled state during
suspend, it seems link is not being kept in low power mode.
This patch fixes the issue by putting the link in hibern8 first
(so device also puts the link in low power mode) and then stop the
host controller.
Signed-off-by: Subhash
Optimal values of local UniPro parameters like PA_Hibern8Time &
PA_TActivate can help reduce the hibern8 exit latency. If both host and
device supports UniPro ver1.6 or later, these parameters will be
automatically tuned during link startup itself. But if either host or
device doesn't support UniPr
Some UFS devices (and may be host) have issues if LCC is
enabled. So we are setting PA_Local_TX_LCC_Enable to 0
before link startup which will make sure that both host
and device TX LCC are disabled once link startup is
completed.
This change also:
- enables the device ref clock before changing to
We put the UFS device in sleep state & UFS link in hibern8 state during
runtime suspaned. After this we put all the UFS rails in low power
modes immediately but it seems some devices may still draw more than
sleep current from UFS rails (especially from VCCQ rail) atleast for
500us.
To avoid this s
We are seeing that some devices are raising the urgent bkops exception
events even when BKOPS status doesn't indicate performace impacted or
critical. Handle these device by determining their urgent bkops status
at runtime.
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
---
drivers
Query commands have 100ms timeout and it may timeout if they are
issued in parallel to ongoing read/write SCSI commands, this change
adds the retry (max: 10) in case command timeouts.
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 48
Currently we use the host quirks mechanism in order to
handle both device and host controller quirks.
In order to support various of UFS devices we should separate
handling the device quirks from the host controller's.
Signed-off-by: Raviv Shvili
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs
Sometimes due to hw issues it takes some time to the
host controller register to update. In order to verify the register
has updated, a polling is done until its value is set.
In addition the functions ufshcd_hba_stop() and
ufshcd_wait_for_register() was updated with an additional input
parameter,
UFS driver's error handler forcefully tries to clear all the pending
requests. For each pending request in the queue, it waits 1 sec for it
to get cleared. If we have multiple requests in the queue then it's
possible that we might end up waiting for those many seconds before
resetting the host. But
Currently when UFSHCD_BROKEN_LCC quirk is defined, LCC is getting
disabled on both host and device side but there could be a need
where we don't want to disable the LCC on both side hence this change
splits the quirk in 2 parts one for host and one for device.
Signed-off-by: Subhash Jadavani
Sign
Some UFS devices don't require VCCQ rail for device operations hence
this change adds support to recognize such devices and remove vote for
the unused VCCQ rail.
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufs.h| 1 +
drivers/scsi/ufs/ufshcd.c | 60
Some vendor's UFS device sends back to back NACs for the DL data frames
causing the host controller to raise the DFES error status. Sometimes
such UFS devices send back to back NAC without waiting for new
retransmitted DL frame from the host and in such cases it might be
possible the Host UniPro go
A race condition exists between request requeueing and scsi layer
error handling:
When UFS driver queuecommand returns a busy status for a request,
it will be requeued and its tag will be freed and set to -1.
At the same time it is possible that the request will timeout and
scsi layer will start er
UFS device and link can be put in multiple different low power modes
hence UFS driver supports multiple different low power modes.
By default UFS driver selects the default (optimal) low power mode
(which gives moderate power savings and have relatively less enter
and exit latencies) but we might h
Different platform may have different number of lanes
for the UFS link.
Add parameter to device tree specifying how many lanes
should be configured for the UFS link.
Signed-off-by: Gilad Broner
Signed-off-by: Yaniv Gardi
---
.../devicetree/bindings/ufs/ufshcd-pltfrm.txt | 3 ++
drivers/s
When control reaches to Linux UFS driver during UFS boot mode, UFS host
controller interrupt status/enable registers may have left over
settings.
In order to avoid any spurious interrupts due to these left overs,
it's important to clear these interrupt status/enable registers before
enabling UFS in
Consider following sequence of events:
1. UFS is runtime suspended, link_state = Hibern8, device_state = sleep
2. System goes into system suspend, ufshcd_system_suspend() brings both
link and device to active state and then puts the device in
Power_Down state and link in OFF state.
3. System
Ich bin Mr.Wenyao Zhou Independent Director der Bank of China, habe ich einen
Geschäftsvorgang von $ 23,5 Mio. und ich gebe Ihnen 30% Entschädigung für Ihre
Unterstützung in dieser Transaktion sollten Sie daran interessiert sein, bitte
senden Sie mir Ihre vollen Informationen, wie unten angegebe
Hi Matt & Manoj,
Just a general comment about this series - I'd like to see more detailed
commit messages for almost all these patches. Of course James is the
scsi maintainer and it's up to him whether to take these as is or not,
but generally when you write a commit message for a bug fix you want
Due to having no hardware for testing, this is just a sample code
to support PCI device hot-removal. It just passing compilation,
no any tests.
Signed-off-by: Jiang Liu
---
drivers/scsi/eata.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/drivers/scsi/eata.c b
Hi Authur,
As suggested by Bjorn, patch 1-2 set implement a PCI device
driver to manage eata PCI devices. And patch 3 tries to support PCI
device hot-removal for eata, but I have no change to test due to
limited knowledge about scsi subsystem and lacking of hardware for
tests.
So y
Use IDA to manage eata board IDs, so we could dynamically allocate
and free board IDs later.
Signed-off-by: Jiang Liu
---
drivers/scsi/eata.c | 46 ++
1 file changed, 30 insertions(+), 16 deletions(-)
diff --git a/drivers/scsi/eata.c b/drivers/scsi/
Previously the eata driver just grabs and accesses eata PCI devices
without implementing a PCI device driver, that causes troubles with
latest IRQ related
Commit 991de2e59090 ("PCI, x86: Implement pcibios_alloc_irq() and
pcibios_free_irq()") changes the way to allocate PCI legacy IRQ
for PCI devic
From: Nicholas Bellinger
This patch fixes a v4.2+ regression introduced by commit 79dc9c9e86
where lookup of t10_pr_registration->pr_reg_deve and associated
->pr_kref get was missing from __core_scsi3_do_alloc_registration(),
which is responsible for setting DEF_PR_REG_ACTIVE.
This would result
27 matches
Mail list logo
