Re: [PATCH] SCSI: Fix NULL pointer dereference in runtime PM

2015-08-18 Thread Johannes Thumshirn
Alan Stern writes: > The routines in scsi_rpm.c assume that if a runtime-PM callback is > invoked for a SCSI device, it can only mean that the device's driver > has asked the block layer to handle the runtime power management (by > calling blk_pm_runtime_init(), which among other things sets q->

[PATCH v4] mpt2sas: setpci reset kernel oops fix

2015-08-18 Thread Nagarajkumar Narayanan
mpt2sas: setpci reset on nytro warpdrive card along with sysfs access and cli ioctl access resulted in kernel oops 1. pci_access_mutex lock added to provide synchronization between IOCTL, sysfs, PCI resource handling path 2. gioc_lock spinlock to protect list operations over multiple controll

Re: [patch] qla4xxx: remove some bogus casts

2015-08-18 Thread Dan Carpenter
On Mon, Aug 17, 2015 at 09:45:45PM -0700, Bart Van Assche wrote: > On 08/17/2015 07:36 AM, Dan Carpenter wrote: > >These casts are wrong and unnecessary. They annoy static checkers > >because they imply we are planning to write sizeof(long) bytes to a > >sizeof(u32) buffer which would corrupt memo

[patch] cxlflash: shift wrapping bug in afu_link_reset()

2015-08-18 Thread Dan Carpenter
"port_sel" is a u64 so the shifting should also be a 64 bit shift. Fixes: c21e0bbfc485 ('cxlflash: Base support for IBM CXL Flash Adapter') Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c index 0720d2f..f97421d 100644 --- a/drivers/scsi/cxlfl

[patch] scsi: aic94xx: set an error code on failure

2015-08-18 Thread Dan Carpenter
We recently did some cleanup here and now the static checkers notice that there is a missing error code when ioremap() fails. Let's set it to -ENOMEM. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c index 140cb8e..f6c336b 1006

Re: [patch] scsi: aic94xx: set an error code on failure

2015-08-18 Thread Johannes Thumshirn
Dan Carpenter writes: > We recently did some cleanup here and now the static checkers notice > that there is a missing error code when ioremap() fails. Let's set it > to -ENOMEM. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/scsi/aic94xx/aic94xx_init.c > b/drivers/scsi/aic94xx/aic9

Re: [patch] cxlflash: shift wrapping bug in afu_link_reset()

2015-08-18 Thread Johannes Thumshirn
Dan Carpenter writes: > "port_sel" is a u64 so the shifting should also be a 64 bit shift. > > Fixes: c21e0bbfc485 ('cxlflash: Base support for IBM CXL Flash Adapter') > Signed-off-by: Dan Carpenter > > diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c > index 0720d2f..f97

[Bug 103061] New: kernel BUG at drivers/scsi/qla2xxx/qla_isr.c:2242

2015-08-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=103061 Bug ID: 103061 Summary: kernel BUG at drivers/scsi/qla2xxx/qla_isr.c:2242 Product: SCSI Drivers Version: 2.5 Kernel Version: 3.10.0 Hardware: All OS: Linux Tr

Re: [PATCH] SCSI: Fix NULL pointer dereference in runtime PM

2015-08-18 Thread Alan Stern
On Mon, 17 Aug 2015, Alan Stern wrote: > The routines in scsi_rpm.c assume that if a runtime-PM callback is > invoked for a SCSI device, it can only mean that the device's driver > has asked the block layer to handle the runtime power management (by > calling blk_pm_runtime_init(), which among ot

Re: [PATCH v1 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations

2015-08-18 Thread Akinobu Mita
Hi Yaniv, 2015-08-16 19:14 GMT+09:00 Yaniv Gardi : > @@ -708,17 +713,18 @@ static inline u32 > ufshcd_vops_get_ufs_hci_version(struct ufs_hba *hba) > return ufshcd_readl(hba, REG_UFS_VERSION); > } > > -static inline void ufshcd_vops_clk_scale_notify(struct ufs_hba *hba) > +static inline

Re: [PATCH v6 1/3] cxlflash: Base error recovery support

2015-08-18 Thread Brian King
On 08/17/2015 07:30 PM, Matthew R. Ochs wrote: > Hi Brian, > > Thanks for reviewing. > > All good suggestions that I am fine with implementing. As these are fairly > minor, > would you be okay with these being made in a separate ‘fix' patch series? That's fine with me. Thanks, Brian -- Bria

[Bug 101891] mvsas prep failed, NULL pointer dereference in mvs_slot_task_free+0x5/0x1f0 [mvsas]

2015-08-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=101891 --- Comment #4 from Dāvis --- (In reply to Dāvis from comment #3) > I narrowed it down to this section of mvs_abort_task function > (drivers/scsi/mvsas/mv_sas.c) > > } else if (task->task_proto & SAS_PROTOCOL_SATA || > task->

Re: [patch] cxlflash: shift wrapping bug in afu_link_reset()

2015-08-18 Thread Matthew R. Ochs
> On Aug 18, 2015, at 3:57 AM, Dan Carpenter wrote: > > "port_sel" is a u64 so the shifting should also be a 64 bit shift. > > Fixes: c21e0bbfc485 ('cxlflash: Base support for IBM CXL Flash Adapter') > Signed-off-by: Dan Carpenter > > diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cx

Re: Persistent Reservation API V2

2015-08-18 Thread Jens Axboe
On 08/17/2015 01:13 PM, Christoph Hellwig wrote: Does this look fine to you Jens? I'd love to get this API into 4.3 so I can submit the NFS SCSI layout patches that depend on it for 4.4. I'll take a look at this today. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2()

2015-08-18 Thread Sebastian Herbszt
Johannes Thumshirn wrote: > Sebastian Herbszt writes: > > > Johannes Thumshirn wrote: > >> If the bf_get() call in lpfc_mbx_cmpl_rdp_page_a2() does succeeds, > >> execution > >> continues normally and mp gets kfree()d. > >> > >> If the subsequent call to lpfc_sli_issue_mbox() fails execution ju

[GIT PULL] target fixes for v4.2-rc7

2015-08-18 Thread Nicholas A. Bellinger
Hi Linus, Here are the outstanding target-pending fixes for v4.2-rc7 code. Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master It contains a v4.2-rc specific RCU module unload regression bug-fix, a long-standing iscsi-target bug-fix for duplicate targ

[PATCH] scsi: fcoe: Convert use of __constant_htons to htons

2015-08-18 Thread Vaishali Thakkar
In little endian cases, the macro htons unfolds to __swab16 which provides special case for constants. In big endian cases, __constant_htons and htons expand directly to the same expression. So, replace __constant_htons with htons with the goal of getting rid of the definition of __constant_htons c

[PATCH] [SCSI] bnx2fc: Convert use of __constant_htons to htons

2015-08-18 Thread Vaishali Thakkar
In little endian cases, the macro htons unfolds to __swab16 which provides special case for constants. In big endian cases, __constant_htons and htons expand directly to the same expression. So, replace __constant_htons with htons with the goal of getting rid of the definition of __constant_htons c

[PATCH 2/2] be2iscsi: Bump the driver version

2015-08-18 Thread John Soni Jose
Bump the driver version Signed-off-by: John Soni Jose --- drivers/scsi/be2iscsi/be_main.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h index afcd55f..9ff4fd6 100644 --- a/drivers/scsi/be2iscsi/be_main

[PATCH 1/2] be2iscsi: Fix updating the next pointer during WRB posting

2015-08-18 Thread John Soni Jose
While posting WRB the next_pointer of the current WRB should point to itself and the previous WRB next_pointer should point to the current WRB. The next pointer value was retrieved during alloc_pdu and was updated in wrb before ringing the doorbell. The fix retrieves the next_pointer just be

[PATCH 0/2] be2iscsi driver update to 10.6.0.1

2015-08-18 Thread John Soni Jose
This patch is generated against the for-next branch. John Soni Jose (1): be2iscsi: Bump the driver version John Soni Jose (1): be2iscsi: Fix updating the next pointer during WRB posting drivers/scsi/be2iscsi/be_main.c | 62 +- drivers/scsi/be2iscsi/be_m