Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Stefano Stabellini
On Tue, 4 Aug 2015, Boris Ostrovsky wrote: > On 08/04/2015 02:12 PM, Julien Grall wrote: > > /* > >* We detect special mappings in one of two ways: > > @@ -217,9 +232,13 @@ static inline unsigned long bfn_to_local_pfn(unsigned > > long mfn) > > /* VIRT <-> MACHINE conversion */ > > #d

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Stefano Stabellini
On Tue, 4 Aug 2015, Julien Grall wrote: > Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN > is meant, I suspect this is because the first support for Xen was for > PV. This resulted in some misimplementation of helpers on ARM and > confused developers about the expected behavi

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Julien Grall
Hi Boris, On 05/08/15 00:16, Boris Ostrovsky wrote: > On 08/04/2015 02:12 PM, Julien Grall wrote: >> /* >>* We detect special mappings in one of two ways: >> @@ -217,9 +232,13 @@ static inline unsigned long >> bfn_to_local_pfn(unsigned long mfn) >> /* VIRT <-> MACHINE conversion */ >>

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Boris Ostrovsky
On 08/05/2015 06:51 AM, Julien Grall wrote: diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c index 09dc447..25e3cce 100644 --- a/drivers/video/fbdev/xen-fbfront.c +++ b/drivers/video/fbdev/xen-fbfront.c @@ -539,7 +539,7 @@ static int xenfb_remove(struct xenbus_

Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Julien Grall
On 05/08/15 13:19, Boris Ostrovsky wrote: > On 08/05/2015 06:51 AM, Julien Grall wrote: >> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c index 09dc447..25e3cce 100644 --- a/drivers/video/fbdev/xen-fbfront.c +++ b/drivers/video/fbdev/xen-

Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Boris Ostrovsky
On 08/05/2015 08:33 AM, Julien Grall wrote: On 05/08/15 13:19, Boris Ostrovsky wrote: On 08/05/2015 06:51 AM, Julien Grall wrote: diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c index 09dc447..25e3cce 100644 --- a/drivers/video/fbdev/xen-fbfront.c +++ b/driver

Re: [PATCH v3 1/4] cxlflash: Updates to legacy I/O

2015-08-05 Thread Brian King
Hi Matt, Can you break this up into separate patches for these separate logical bug fixes / changes? There is too much bundled all into a single patch here from my perspective. Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the

Re: [PATCH v3 2/4] cxlflash: Base error recovery support

2015-08-05 Thread Brian King
On 08/02/2015 11:33 PM, Matthew R. Ochs wrote: > diff --git a/drivers/scsi/cxlflash/common.h b/drivers/scsi/cxlflash/common.h > index ba070a5..3d6217a 100644 > --- a/drivers/scsi/cxlflash/common.h > +++ b/drivers/scsi/cxlflash/common.h > @@ -76,6 +76,12 @@ enum cxlflash_init_state { > INIT_S

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Dmitry Torokhov
On Wed, Aug 05, 2015 at 11:08:55AM +0100, Stefano Stabellini wrote: > On Tue, 4 Aug 2015, Julien Grall wrote: > > Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN > > is meant, I suspect this is because the first support for Xen was for > > PV. This resulted in some misimplemen

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Wei Liu
On Tue, Aug 04, 2015 at 07:12:48PM +0100, Julien Grall wrote: [...] > diff --git a/drivers/net/xen-netback/netback.c > b/drivers/net/xen-netback/netback.c > index 7d50711..3b7b7c3 100644 > --- a/drivers/net/xen-netback/netback.c > +++ b/drivers/net/xen-netback/netback.c > @@ -314,7 +314,7 @@ stati

Re: [Open-FCoE] [PATCH] libfc: correct function name in comment

2015-08-05 Thread Vasu Dev
On Wed, 2015-08-05 at 00:21 +0200, Sebastian Herbszt wrote: > Use the correct function name in kernel-doc comment. > > Signed-off-by: Sebastian Herbszt > --- > > diff -U 5 -rp a/drivers/scsi/libfc/fc_npiv.c b/drivers/scsi/libfc/fc_npiv.c > --- a/drivers/scsi/libfc/fc_npiv.c2014-09-03 19:30:1

Re: [PATCH v3 1/4] cxlflash: Updates to legacy I/O

2015-08-05 Thread Matthew R. Ochs
> On Aug 5, 2015, at 10:44 AM, Brian King wrote: > > Hi Matt, > > Can you break this up into separate patches for these separate logical bug > fixes / changes? > There is too much bundled all into a single patch here from my perspective. Sure, I can do that for v4. > > Thanks, > > Brian >

Re: [PATCH v3 2/4] cxlflash: Base error recovery support

2015-08-05 Thread Matthew R. Ochs
Hi Brian, Thanks for reviewing. Comments inline below. -matt > On Aug 5, 2015, at 11:04 AM, Brian King wrote: > > On 08/02/2015 11:33 PM, Matthew R. Ochs wrote: > >> diff --git a/drivers/scsi/cxlflash/common.h b/drivers/scsi/cxlflash/common.h >> index ba070a5..3d6217a 100644 >> --- a/drivers

Re: [PATCH v3 2/4] cxlflash: Base error recovery support

2015-08-05 Thread Daniel Axtens
On Wed, 2015-08-05 at 17:30 -0500, Matthew R. Ochs wrote: > Hi Brian, > > Thanks for reviewing. Comments inline below. > > > -matt > > > On Aug 5, 2015, at 11:04 AM, Brian King wrote: > > > > On 08/02/2015 11:33 PM, Matthew R. Ochs wrote: > > > >> diff --git a/drivers/scsi/cxlflash/common.h

Re: [dm-devel] kernel BUG at drivers/scsi/scsi_lib.c:1101! observed during md5sum for one file on (RAID4->RAID0) device

2015-08-05 Thread Yi Zhang
Hi Neil I test 10 times with below patch on Linux 4.2-rc5, didn't reproduce the issue, thanks. - Original Message - From: "NeilBrown" To: "yizhan" Sent: Thursday, August 6, 2015 1:21:29 PM Subject: Re: [dm-devel] kernel BUG at drivers/scsi/scsi_lib.c:1101! observed during md5sum for