Re: [PATCH v2 1/8] qla2xxx: kill sessions/log out initiator on RSCN and port down events

2015-07-27 Thread Hannes Reinecke
On 07/14/2015 10:00 PM, Himanshu Madhani wrote: > From: Roland Dreier > > To fix some issues talking to ESX, this patch modifies the qla2xxx driver > so that it never logs into remote ports. This has the side effect of > getting rid of the "rports" entirely, which means we never log out of > ini

Re: [PATCH v2 2/8] qla2xxx: cleanup cmd in qla workqueue before processing TMR

2015-07-27 Thread Hannes Reinecke
On 07/14/2015 10:00 PM, Himanshu Madhani wrote: > From: Swapnil Nagle > > Since cmds go into qla_tgt_wq and TMRs don't, it's possible that TMR > like TASK_ABORT can be queued over the cmd for which it was meant. > To avoid this race, use a per-port list to keep track of cmds that > are enqueued t

Re: [PATCH v2 4/8] qla2xxx: Abort stale cmds on qla_tgt_wq when plogi arrives

2015-07-27 Thread Hannes Reinecke
On 07/14/2015 10:00 PM, Himanshu Madhani wrote: > From: Alexei Potashnik > > cancel any commands from initiator's s_id that are still waiting > on qla_tgt_wq when PLOGI arrives. > > Cc: > Signed-off-by: Alexei Potashnik > Acked-by: Quinn Tran > Signed-off-by: Himanshu Madhani > --- Reviewed-

Re: [PATCH v2 3/8] qla2xxx: delay plogi/prli ack until existing sessions are deleted

2015-07-27 Thread Hannes Reinecke
On 07/14/2015 10:00 PM, Himanshu Madhani wrote: > From: Alexei Potashnik > > - keep qla_tgt_sess object on the session list until it's freed > > - modify use of sess->deleted flag to differentiate delayed > session deletion that can be cancelled from irreversible one: > QLA_SESS_DELETION_PEN

Re: [PATCH v2 5/8] qla2xxx: added sess generations to detect RSCN update races

2015-07-27 Thread Hannes Reinecke
On 07/14/2015 10:00 PM, Himanshu Madhani wrote: > From: Alexei Potashnik > > RSCN processing in qla2xxx driver can run in parallel with ELS/IO > processing. As such the decision to remove disappeared fc port's > session could be stale, because a new login sequence has occurred > since and created

Re: [PATCH v2 7/8] qla2xxx: drop cmds/tmrs arrived while session is being deleted

2015-07-27 Thread Hannes Reinecke
On 07/14/2015 10:00 PM, Himanshu Madhani wrote: > From: Alexei Potashnik > > If a new initiator (different WWN) shows up on the same fcport, old > initiator's session is scheduled for deletion. But there is a small > window between it being marked with QLA_SESS_DELETION_IN_PROGRESS > and qlt_unre

Re: [PATCH v2 6/8] qla2xxx: disable scsi_transport_fc registration in target mode

2015-07-27 Thread Hannes Reinecke
On 07/14/2015 10:00 PM, Himanshu Madhani wrote: > From: Alexei Potashnik > > There are multiple reasons for disabling this: > > 1. It provides no functional benefit. We pretty much only get a few more > sysfs entries for each port, but all that information is already > available from /sys/kernel

Re: [PATCH v2 8/8] qla2xxx: terminate exchange when command is aborted by LIO

2015-07-27 Thread Hannes Reinecke
On 07/14/2015 10:00 PM, Himanshu Madhani wrote: > From: Alexei Potashnik > > The newly introduced aborted_task TFO callback has to terminate > exchange with QLogic driver, since command is being deleted and > no status will be queued to the driver at a later point. > > This patch also moves the

Re: [PATCH v3] [SCSI] mpt2sas, mpt3sas: Abort initialization if no memory I/O resources detected

2015-07-27 Thread Hannes Reinecke
On 07/15/2015 06:49 AM, Sreekanth Reddy wrote: > Driver crashes if the BIOS do not set up at least one > memory I/O resource. This failure can happen if the device is too > slow to respond during POST and is missed by the BIOS, but Linux > then detects the device later in the boot process. > > Cha

Re: [PATCH] MAINTAINERS: Update LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI) maintainers list

2015-07-27 Thread Hannes Reinecke
On 07/15/2015 06:50 AM, Sreekanth Reddy wrote: > Updating maintainers list for the entry LSILOGIC MPT FUSION DRIVERS in > MAINTAINERS file > > Signed-off-by: Sreekanth Reddy > --- > MAINTAINERS | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINE

Re: [PATCH 00/52] atp870u: Major rework

2015-07-27 Thread Hannes Reinecke
On 07/26/2015 10:24 PM, Ondrej Zary wrote: > This patch series removes the first level of crap from atp870u - the worst > (in-tree) SCSI driver [1] and then cleans up the code a bit. > > First the driver is converted to C from something that looks like a (bad) > assembler code: use of tmport for a

Re: [PATCH] scsi: fix hang in scsi error handling

2015-07-27 Thread Hannes Reinecke
On 07/16/2015 08:55 PM, Kevin Groeneveld wrote: >> -Original Message- >> From: Hannes Reinecke [mailto:h...@suse.de] >> Sent: July-16-15 7:11 AM >>> When the hang occurs shost->host_busy == 2 and shost->host_failed == 1 >>> in the scsi_eh_wakeup function. However this function only wakes th

Re: [for 4.1 PATCH resend] libsas: fix "sysfs group not found" warnings at port teardown time

2015-07-27 Thread James Bottomley
On Wed, 2015-07-22 at 14:08 -0700, Dan Williams wrote: > On Wed, Jul 22, 2015 at 11:28 AM, James Bottomley > wrote: > > > >> } > >> > >> void sas_device_set_phy(struct domain_device *dev, struct sas_port *port) > >> diff --git a/drivers/scsi/libsas/sas_port.c > >> b/drivers/scsi/libsas/sas_port

RE: [PATCH] scsi: fix hang in scsi error handling

2015-07-27 Thread Kevin Groeneveld
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: July-27-15 6:39 AM > On 07/16/2015 08:55 PM, Kevin Groeneveld wrote: > >> -Original Message- > >> From: Hannes Reinecke [mailto:h...@suse.de] > >> Sent: July-16-15 7:11 AM > >>> When the hang occurs shost->ho

Re: [for 4.1 PATCH resend] libsas: fix "sysfs group not found" warnings at port teardown time

2015-07-27 Thread Dan Williams
On Mon, Jul 27, 2015 at 8:17 AM, James Bottomley wrote: > On Wed, 2015-07-22 at 14:08 -0700, Dan Williams wrote: >> On Wed, Jul 22, 2015 at 11:28 AM, James Bottomley >> wrote: >> > >> >> } >> >> >> >> void sas_device_set_phy(struct domain_device *dev, struct sas_port *port) >> >> diff --git a/d

Re: [for 4.1 PATCH resend] libsas: fix "sysfs group not found" warnings at port teardown time

2015-07-27 Thread James Bottomley
On Mon, 2015-07-27 at 08:48 -0700, Dan Williams wrote: > On Mon, Jul 27, 2015 at 8:17 AM, James Bottomley > wrote: > > On Wed, 2015-07-22 at 14:08 -0700, Dan Williams wrote: > >> On Wed, Jul 22, 2015 at 11:28 AM, James Bottomley > >> wrote: > >> > > >> >> } > >> >> > >> >> void sas_device_set_p

Re: [PATCH] scsi: fix memory leak with scsi-mq

2015-07-27 Thread Ewan Milne
On Thu, 2015-07-16 at 11:40 -0400, Tony Battersby wrote: > Fix a memory leak with scsi-mq triggered by commands with large data > transfer length. > > __sg_alloc_table() sets both table->nents and table->orig_nents to the > same value. When the scatterlist is DMA-mapped, table->nents is > overwri

Re: [for 4.1 PATCH resend] libsas: fix "sysfs group not found" warnings at port teardown time

2015-07-27 Thread Dan Williams
On Mon, Jul 27, 2015 at 10:11 AM, James Bottomley wrote: > On Mon, 2015-07-27 at 08:48 -0700, Dan Williams wrote: >> On Mon, Jul 27, 2015 at 8:17 AM, James Bottomley >> wrote: >> > On Wed, 2015-07-22 at 14:08 -0700, Dan Williams wrote: >> >> On Wed, Jul 22, 2015 at 11:28 AM, James Bottomley >> >>

Re: [for 4.1 PATCH resend] libsas: fix "sysfs group not found" warnings at port teardown time

2015-07-27 Thread James Bottomley
On Mon, 2015-07-27 at 08:48 -0700, Dan Williams wrote: > On Mon, Jul 27, 2015 at 8:17 AM, James Bottomley > wrote: > > On Wed, 2015-07-22 at 14:08 -0700, Dan Williams wrote: > >> I don't have a libsas environment handy, I worked with Praveen to > >> validate the version as submitted if you want

Re: [PATCH v2 1/8] qla2xxx: kill sessions/log out initiator on RSCN and port down events

2015-07-27 Thread Roland Dreier
On Mon, Jul 27, 2015 at 1:09 AM, Hannes Reinecke wrote: > Hmm? What happened to the original FIXME? > Is it not required anymore? Not sure I follow the question. The original FIXME was "/* FIXME: Re-enable Global event handling.. */" and this patch indeed re-enables global event handling. I don

Re: [for 4.1 PATCH resend] libsas: fix "sysfs group not found" warnings at port teardown time

2015-07-27 Thread Dan Williams
On Mon, Jul 27, 2015 at 11:07 AM, James Bottomley wrote: > On Mon, 2015-07-27 at 08:48 -0700, Dan Williams wrote: >> On Mon, Jul 27, 2015 at 8:17 AM, James Bottomley >> wrote: >> > On Wed, 2015-07-22 at 14:08 -0700, Dan Williams wrote: >> >> I don't have a libsas environment handy, I worked wit

Re: [for 4.1 PATCH resend] libsas: fix "sysfs group not found" warnings at port teardown time

2015-07-27 Thread James Bottomley
On Mon, 2015-07-27 at 10:55 -0700, Dan Williams wrote: > On Mon, Jul 27, 2015 at 10:11 AM, James Bottomley > wrote: > > On Mon, 2015-07-27 at 08:48 -0700, Dan Williams wrote: > >> On Mon, Jul 27, 2015 at 8:17 AM, James Bottomley > >> wrote: > >> > On Wed, 2015-07-22 at 14:08 -0700, Dan Williams w

Re: [PATCH 2/3] scsi: rescan device if an invalid capacity had been reported

2015-07-27 Thread Lee Duncan
On 07/08/2015 12:41 AM, Hannes Reinecke wrote: > Device paths in ALUA state 'standby' do not necessarily support > the READ_CAPACITY command. This patch adds a new flag 'invalid_capacity' > to the scsi device, and rescans the device if an ALUA state > change occurred. > > Signed-off-by: Hannes Rei

RE: [for 4.1 PATCH resend] libsas: fix "sysfs group not found" warnings at port teardown time

2015-07-27 Thread Praveen Murali
> -Original Message- > From: Dan Williams [mailto:dan.j.willi...@intel.com] > Sent: Monday, July 27, 2015 11:25 AM > To: James Bottomley > Cc: Christoph Hellwig; Praveen Murali; linux-scsi; sta...@vger.kernel.org > Subject: Re: [for 4.1 PATCH resend] libsas: fix "sysfs group not found" > w

Re: [for 4.1 PATCH resend] libsas: fix "sysfs group not found" warnings at port teardown time

2015-07-27 Thread Dan Williams
On Mon, Jul 27, 2015 at 11:38 AM, James Bottomley wrote: > No, that seems to be the intent of the prior code. The reason port > visibility goes immediately (along with all associated phys), is that > the port is ready for reuse as soon as sas_deform_port() returns. > Destroying the subtree is lef

Re: [PATCH] qla2xxx: Return the fabric command state for non-task management requests

2015-07-27 Thread Quinn Tran
Christoph, Currently, the command state within TCM (se_cmd.t_state) only track command states from the point of new to the Back End and from Back End up to QLA driver. From the debug perspective, that¹s only half the picture. The other half comes from qla2xxx¹s private command state provided by t

Re: [PATCH v2 1/8] qla2xxx: kill sessions/log out initiator on RSCN and port down events

2015-07-27 Thread Hannes Reinecke
On 07/27/2015 08:09 PM, Roland Dreier wrote: > On Mon, Jul 27, 2015 at 1:09 AM, Hannes Reinecke wrote: >> Hmm? What happened to the original FIXME? >> Is it not required anymore? > > Not sure I follow the question. The original FIXME was "/* FIXME: > Re-enable Global event handling.. */" and thi